@malloydata/malloy 0.0.433 → 0.0.435

package/dist/api/foundation/compile.d.ts

@@ -2,7 +2,7 @@ import type { LogMessage } from '../../lang';
 import type { Connection, InfoConnection, LookupConnection, FetchSchemaOptions } from '../../connection/types';
 import type { ConnectionTypeDef, ConnectionPropertyDefinition } from '../../connection/registry';
 import type { URLReader, EventStream } from '../../runtime_types';
-import type { SQLSourceDef, QueryRunStats } from '../../model';
+import type { SQLSourceDef, QueryRunStats, VirtualMap } from '../../model';
 import type { RunSQLOptions } from '../../run_sql_options';
 import type { CacheManager } from './cache';
 import { Parse } from './document';
@@ -35,7 +35,7 @@ export interface MalloyCompileOptions {
     noThrowOnError?: boolean;
     eventStream?: EventStream;
     importBaseURL?: URL;
-    testEnvironment?: boolean;
+    virtualMap?: VirtualMap;
 }
 export interface MalloyRunOptions {
     connection?: Connection;

package/dist/api/foundation/compile.js

@@ -88,9 +88,6 @@ class Malloy {
         const translator = new lang_1.MalloyTranslator(url.toString(), importBaseURL.toString(), {
             urls: { [url.toString()]: source },
         }, eventStream, (_a = options === null || options === void 0 ? void 0 : options.restrictedMode) !== null && _a !== void 0 ? _a : false);
-        if (options === null || options === void 0 ? void 0 : options.testEnvironment) {
-            translator.allDialectsEnabled = true;
-        }
         return new document_1.Parse(translator, invalidationKey);
     }
     static parse({ url, urlReader, source, eventStream, options, }) {
@@ -119,9 +116,10 @@ class Malloy {
      * @return A (promise of a) compiled `Model`.
      */
     static async compile(req) {
-        var _a, _b, _c, _d, _e;
+        var _a, _b, _c, _d, _e, _f;
         let { url, source, importBaseURL, cacheManager } = req;
         const { parse, urlReader, connections, model, refreshSchemaCache, noThrowOnError, eventStream, restrictedMode, method, } = req;
+        const virtualMap = (_a = req.virtualMap) !== null && _a !== void 0 ? _a : parse === null || parse === void 0 ? void 0 : parse._translator.virtualMap;
         if (restrictedMode) {
             // Restricted-mode compiles do not participate in the model-def
             // cache. The cache key is the URL, but restricted vs. unrestricted
@@ -172,7 +170,8 @@ class Malloy {
                 throw new Error(`Malloy.compile: restrictedMode (${restrictedMode}) does not match the pre-parsed translator's restrictedMode (${parse._translator.restrictedMode}). Set restrictedMode at parse time.`);
             }
             translator = parse._translator;
-            const invalidationKey = (_a = parse._invalidationKey) !== null && _a !== void 0 ? _a : (await (0, readers_1.getInvalidationKey)(urlReader, url));
+            translator.virtualMap = virtualMap;
+            const invalidationKey = (_b = parse._invalidationKey) !== null && _b !== void 0 ? _b : (await (0, readers_1.getInvalidationKey)(urlReader, url));
             invalidationKeys[_url] = invalidationKey;
         }
         else {
@@ -187,7 +186,7 @@ class Malloy {
             }
             translator = new lang_1.MalloyTranslator(_url, importBaseURL.toString(), {
                 urls: { [_url]: source },
-            }, eventStream, restrictedMode !== null && restrictedMode !== void 0 ? restrictedMode : false);
+            }, eventStream, restrictedMode !== null && restrictedMode !== void 0 ? restrictedMode : false, virtualMap);
         }
         for (;;) {
             const result = translator.translate(model === null || model === void 0 ? void 0 : model._modelDef);
@@ -208,14 +207,14 @@ class Malloy {
                     const existingQueryModel = !result.modelWasModified && model
                         ? model.getExistingQueryModel()
                         : undefined;
-                    return new core_1.Model(result.modelDef, result.problems || [], [...((_b = model === null || model === void 0 ? void 0 : model.fromSources) !== null && _b !== void 0 ? _b : []), ...((_c = result.fromSources) !== null && _c !== void 0 ? _c : [])], existingQueryModel);
+                    return new core_1.Model(result.modelDef, result.problems || [], [...((_c = model === null || model === void 0 ? void 0 : model.fromSources) !== null && _c !== void 0 ? _c : []), ...((_d = result.fromSources) !== null && _d !== void 0 ? _d : [])], existingQueryModel);
                 }
                 else if (noThrowOnError) {
                     const emptyModel = (0, model_1.mkModelDef)('modelDidNotCompile');
                     const modelFromCompile = (model === null || model === void 0 ? void 0 : model._modelDef) || emptyModel;
                     return new core_1.Model(modelFromCompile, result.problems || [], [
-                        ...((_d = model === null || model === void 0 ? void 0 : model.fromSources) !== null && _d !== void 0 ? _d : []),
-                        ...((_e = result.fromSources) !== null && _e !== void 0 ? _e : []),
+                        ...((_e = model === null || model === void 0 ? void 0 : model.fromSources) !== null && _e !== void 0 ? _e : []),
+                        ...((_f = result.fromSources) !== null && _f !== void 0 ? _f : []),
                     ]);
                 }
                 else {

package/dist/api/foundation/config.js

@@ -169,7 +169,7 @@ class MalloyConfig {
         this._managedLookup = (0, config_lookup_1.buildManagedLookup)(prepared.compiledConnections, rawConnectionEntries(pojo), mergedOverlays, log);
         this._connections = this._managedLookup;
         this._overlays = mergedOverlays;
-        this.virtualMap = toVirtualMap(prepared.virtualMap, log);
+        this.virtualMap = toVirtualMap(prepared.virtualMap);
         this.configURL = configURL;
         this.rootDirectory = rootDirectory;
         this.manifestPath = prepared.manifestPath;
@@ -444,10 +444,10 @@ function validateURLString(value, fieldName, log) {
 }
 /**
  * Convert the raw virtualMap POJO shape (a dict of dicts of strings) into
- * the runtime Map-of-Maps representation. Invalid entries are dropped and
- * logged — they'd be pasted into FROM clauses downstream otherwise.
+ * the runtime Map-of-Maps representation. Table paths are checked against
+ * the executing dialect when a virtual source is substituted into SQL.
  */
-function toVirtualMap(raw, log) {
+function toVirtualMap(raw) {
     if (!isRecord(raw))
         return undefined;
     const outer = new Map();
@@ -456,18 +456,9 @@ function toVirtualMap(raw, log) {
             continue;
         const innerMap = new Map();
         for (const [virtualName, tablePath] of Object.entries(inner)) {
-            if (typeof tablePath !== 'string')
-                continue;
-            const invalid = (0, validate_table_path_1.validateCanonicalTablePathAnyDialect)(tablePath);
-            if (invalid !== undefined) {
-                log.push({
-                    message: `virtualMap entry '${connName}.${virtualName}': ${invalid}`,
-                    severity: 'error',
-                    code: 'config-validation',
-                });
-                continue;
+            if (typeof tablePath === 'string') {
+                innerMap.set(virtualName, tablePath);
             }
-            innerMap.set(virtualName, tablePath);
         }
         if (innerMap.size > 0)
             outer.set(connName, innerMap);

package/dist/api/foundation/runtime.d.ts

@@ -42,7 +42,6 @@ declare class FluentState<T> {
  * An environment for compiling and running Malloy queries.
  */
 export declare class Runtime {
-    isTestRuntime: boolean;
     private _urlReader;
     private _connections;
     private _eventStream;
@@ -172,13 +171,8 @@ export declare class Runtime {
     /** @internal */
     _invalidateGivensCache(): void;
     /**
-     * The virtual map for virtual source resolution.
-     * When set, compiled queries automatically resolve virtual sources
-     * against this map. Can be overridden per-query via
-     * CompileQueryOptions.virtualMap.
-     *
-     * When constructed with a MalloyConfig, falls through to
-     * config.virtualMap.
+     * Default virtual-source bindings for translation and query SQL generation.
+     * Falls back to config.virtualMap when no runtime map is assigned.
      */
     get virtualMap(): VirtualMap | undefined;
     set virtualMap(map: VirtualMap | undefined);

package/dist/api/foundation/runtime.js

@@ -51,7 +51,6 @@ class FluentState {
 class Runtime {
     constructor({ urlReader, connections, connection, config, buildManifest, eventStream, cacheManager, givens, }) {
         var _a, _b;
-        this.isTestRuntime = false;
         if (config !== undefined) {
             this._config = config;
             connections = connections !== null && connections !== void 0 ? connections : config.connections;
@@ -302,13 +301,8 @@ class Runtime {
         this._resolvedGivensPromise = undefined;
     }
     /**
-     * The virtual map for virtual source resolution.
-     * When set, compiled queries automatically resolve virtual sources
-     * against this map. Can be overridden per-query via
-     * CompileQueryOptions.virtualMap.
-     *
-     * When constructed with a MalloyConfig, falls through to
-     * config.virtualMap.
+     * Default virtual-source bindings for translation and query SQL generation.
+     * Falls back to config.virtualMap when no runtime map is assigned.
      */
     get virtualMap() {
         var _a, _b;
@@ -355,16 +349,9 @@ class Runtime {
      */
     loadModel(source, options) {
         const { refreshSchemaCache, noThrowOnError } = options || {};
-        if (this.isTestRuntime) {
-            if (options === undefined) {
-                options = { testEnvironment: true };
-            }
-            else {
-                options = { ...options, testEnvironment: true };
-            }
-        }
         const compilable = source instanceof URL ? { url: source } : { source };
         return new ModelMaterializer(this, async () => {
+            var _a;
             const m = await compile_1.Malloy.compile({
                 ...compilable,
                 urlReader: this.urlReader,
@@ -373,8 +360,8 @@ class Runtime {
                 noThrowOnError,
                 eventStream: this.eventStream,
                 importBaseURL: options === null || options === void 0 ? void 0 : options.importBaseURL,
-                testEnvironment: options === null || options === void 0 ? void 0 : options.testEnvironment,
                 cacheManager: this.cacheManager,
+                virtualMap: (_a = options === null || options === void 0 ? void 0 : options.virtualMap) !== null && _a !== void 0 ? _a : this.virtualMap,
             });
             return this._withRuntimeContext(m);
         }, options);
@@ -634,12 +621,13 @@ class ModelMaterializer extends FluentState {
         // `restrictedMode` and `method` are named to hold them back: this entry
         // point has never honored them, and `loadRestrictedQuery` is how a caller
         // asks for restricted compilation.
-        const { importBaseURL, testEnvironment, refreshSchemaCache, noThrowOnError, restrictedMode: _restrictedMode, method: _method, ...callQueryOptions } = options !== null && options !== void 0 ? options : {};
+        const { importBaseURL, refreshSchemaCache, noThrowOnError, restrictedMode: _restrictedMode, method: _method, ...callQueryOptions } = options !== null && options !== void 0 ? options : {};
         const compileQueryOptions = {
             ...this.compileQueryOptions,
             ...callQueryOptions,
         };
         return this.makeQueryMaterializer(async () => {
+            var _a;
             const compilable = query instanceof URL ? { url: query } : { source: query };
             const queryModel = await compile_1.Malloy.compile({
                 ...compilable,
@@ -649,8 +637,8 @@ class ModelMaterializer extends FluentState {
                 refreshSchemaCache,
                 noThrowOnError,
                 importBaseURL,
-                testEnvironment: testEnvironment || this.runtime.isTestRuntime,
                 ...compileQueryOptions,
+                virtualMap: (_a = compileQueryOptions.virtualMap) !== null && _a !== void 0 ? _a : this.runtime.virtualMap,
             });
             return queryModel.preparedQuery;
         }, compileQueryOptions);
@@ -702,7 +690,6 @@ class ModelMaterializer extends FluentState {
         return this.makeQueryMaterializer(async () => {
             const urlReader = this.runtime.urlReader;
             const connections = this.runtime.connections;
-            const testEnvironment = this.runtime.isTestRuntime ? true : undefined;
             const model = await this.getModel();
             const queryModel = await compile_1.Malloy.compile({
                 source: text,
@@ -711,7 +698,6 @@ class ModelMaterializer extends FluentState {
                 urlReader,
                 connections,
                 model,
-                testEnvironment,
                 ...this.compileQueryOptions,
             });
             return queryModel.preparedQuery;
@@ -725,14 +711,8 @@ class ModelMaterializer extends FluentState {
      * or loading further related objects.
      */
     extendModel(query, options) {
-        if (this.runtime.isTestRuntime) {
-            if (options === undefined) {
-                options = { testEnvironment: true };
-            }
-            else {
-                options = { ...options, testEnvironment: true };
-            }
-        }
+        var _a, _b;
+        const virtualMap = (_a = options === null || options === void 0 ? void 0 : options.virtualMap) !== null && _a !== void 0 ? _a : (_b = this.compileQueryOptions) === null || _b === void 0 ? void 0 : _b.virtualMap;
         return new ModelMaterializer(this.runtime, async () => {
             const urlReader = this.runtime.urlReader;
             const connections = this.runtime.connections;
@@ -747,11 +727,11 @@ class ModelMaterializer extends FluentState {
                 refreshSchemaCache: options === null || options === void 0 ? void 0 : options.refreshSchemaCache,
                 noThrowOnError: options === null || options === void 0 ? void 0 : options.noThrowOnError,
                 importBaseURL: options === null || options === void 0 ? void 0 : options.importBaseURL,
-                testEnvironment: options === null || options === void 0 ? void 0 : options.testEnvironment,
                 ...this.compileQueryOptions,
+                virtualMap: virtualMap !== null && virtualMap !== void 0 ? virtualMap : this.runtime.virtualMap,
             });
             return this.runtime._withRuntimeContext(queryModel);
-        }, options);
+        }, { ...options, virtualMap });
     }
     async search(sourceName, searchTerm, limit = 1000, searchField = undefined) {
         const model = await this.materialize();
@@ -1064,15 +1044,7 @@ class QueryMaterializer extends FluentState {
                     connectionDigests[connName] = conn.getDigest();
                 }
             }
-            // Use virtualMap from options if provided, otherwise fall back to Runtime's.
             const virtualMap = (_b = mergedOptions.virtualMap) !== null && _b !== void 0 ? _b : this.runtime.virtualMap;
-            if (virtualMap) {
-                for (const [connName, inner] of virtualMap) {
-                    for (const [virtualName, tablePath] of inner) {
-                        (0, validate_table_path_1.requireCanonicalTablePathAnyDialect)(tablePath, `virtualMap entry '${connName}.${virtualName}'`);
-                    }
-                }
-            }
             // Per-query supply for a finalized given is rejected at API entry
             // — the finalized-givens set is the runtime's "this can't be
             // overridden by the caller" guarantee. Fail before any IO so misuse

package/dist/api/foundation/types.d.ts

@@ -20,7 +20,6 @@ export interface Loggable {
 }
 export interface ParseOptions {
     importBaseURL?: URL;
-    testEnvironment?: boolean;
     /** Reject language constructs that reach outside the trusted model. */
     restrictedMode?: boolean;
     /**
@@ -43,6 +42,7 @@ export type CompileMethod = 'loadModel' | 'extendModel' | 'query';
 export interface CompileOptions {
     refreshSchemaCache?: boolean | number;
     noThrowOnError?: boolean;
+    virtualMap?: VirtualMap;
 }
 /** Options given to the Malloy compiler (QueryModel) */
 export interface CompileQueryOptions {

package/dist/connection/validate_table_path.d.ts

@@ -2,8 +2,7 @@
 export declare function validateCanonicalTablePath(dialectName: string, tablePath: string): string | undefined;
 /**
  * Validate against any registered dialect. Used at boundaries where the
- * destination dialect isn't synchronously known (virtualMap, manifest
- * entries).
+ * destination dialect isn't synchronously known (manifest entries).
  */
 export declare function validateCanonicalTablePathAnyDialect(tablePath: string): string | undefined;
 /** Throw if `tablePath` isn't canonical SQL in any registered dialect. */

package/dist/connection/validate_table_path.js

@@ -28,8 +28,7 @@ function validateCanonicalTablePath(dialectName, tablePath) {
 }
 /**
  * Validate against any registered dialect. Used at boundaries where the
- * destination dialect isn't synchronously known (virtualMap, manifest
- * entries).
+ * destination dialect isn't synchronously known (manifest entries).
  */
 function validateCanonicalTablePathAnyDialect(tablePath) {
     let suggestion;

package/dist/dialect/databricks/databricks.js

@@ -304,13 +304,13 @@ class DatabricksDialect extends dialect_1.Dialect {
         // Databricks has no timestamptz type; timestamps are stored as UTC
         // Convert from UTC to local timezone for civil time operations
         return {
-            sql: `FROM_UTC_TIMESTAMP(${expr}, '${timezone}')`,
+            sql: `FROM_UTC_TIMESTAMP(${expr}, ${this.sqlTimezoneLiteral(timezone)})`,
             typeDef: { type: 'timestamp' },
         };
     }
     sqlConvertFromCivilTime(expr, timezone, _destTypeDef) {
         // Convert from local timezone back to UTC
-        return `TO_UTC_TIMESTAMP(${expr}, '${timezone}')`;
+        return `TO_UTC_TIMESTAMP(${expr}, ${this.sqlTimezoneLiteral(timezone)})`;
     }
     sqlTruncate(expr, unit, _typeDef, _inCivilTime, _timezone) {
         // Databricks DATE_TRUNC starts weeks on Monday; Malloy wants Sunday.
@@ -342,7 +342,7 @@ class DatabricksDialect extends dialect_1.Dialect {
         if (malloy_types_1.TD.isTimestamp(te.e.typeDef)) {
             const tz = (0, dialect_1.qtz)(qi);
             if (tz) {
-                extractFrom = `FROM_UTC_TIMESTAMP(${extractFrom}, '${tz}')`;
+                extractFrom = `FROM_UTC_TIMESTAMP(${extractFrom}, ${this.sqlTimezoneLiteral(tz)})`;
             }
         }
         if (extractionMap[te.units]) {
@@ -356,10 +356,10 @@ class DatabricksDialect extends dialect_1.Dialect {
         const { op, srcTypeDef, dstTypeDef, dstSQLType } = this.sqlCastPrep(cast);
         const tz = (0, dialect_1.qtz)(qi);
         if (op === 'timestamp::date' && tz) {
-            return `CAST(FROM_UTC_TIMESTAMP(${srcSQL}, '${tz}') AS DATE)`;
+            return `CAST(FROM_UTC_TIMESTAMP(${srcSQL}, ${this.sqlTimezoneLiteral(tz)}) AS DATE)`;
         }
         else if (op === 'date::timestamp' && tz) {
-            return `TO_UTC_TIMESTAMP(CAST(${srcSQL} AS TIMESTAMP_NTZ), '${tz}')`;
+            return `TO_UTC_TIMESTAMP(CAST(${srcSQL} AS TIMESTAMP_NTZ), ${this.sqlTimezoneLiteral(tz)})`;
         }
         if (!malloy_types_1.TD.eq(srcTypeDef, dstTypeDef)) {
             if (cast.safe) {
@@ -381,7 +381,7 @@ class DatabricksDialect extends dialect_1.Dialect {
     sqlTimestampLiteral(qi, literal, timezone) {
         const tz = timezone || (0, dialect_1.qtz)(qi);
         if (tz) {
-            return `TO_UTC_TIMESTAMP(TIMESTAMP_NTZ '${literal}', '${tz}')`;
+            return `TO_UTC_TIMESTAMP(TIMESTAMP_NTZ '${literal}', ${this.sqlTimezoneLiteral(tz)})`;
         }
         return `TIMESTAMP '${literal}'`;
     }

package/dist/dialect/dialect.d.ts

@@ -1,11 +1,20 @@
 import type { Expr, Sampling, AtomicTypeDef, MeasureTimeExpr, TimeExtractExpr, TypecastExpr, RegexMatchExpr, TimeLiteralExpr, RecordLiteralNode, ArrayLiteralNode, BasicAtomicTypeDef, OrderBy, TimestampUnit, ATimestampTypeDef, TimeExpr, TemporalFieldType } from '../model/malloy_types';
 import type { DialectFunctionOverloadDef } from './functions';
 import type { ValidateTablePathResult } from './table-path';
+/**
+ * One field of a struct, for the dialect methods which emit SQL over it.
+ *
+ * `typeDef` is the Malloy type, for the dialects which have to declare a SQL
+ * type for the field -- the ROW and STRUCT types they build.  `sqlExpression`
+ * is SQL producing the value, valid in the scope the consumer emits into.
+ * `rawName` is the field's name with no quoting: a consumer needing it as an
+ * identifier quotes it itself, because only the consumer knows whether it
+ * wants an identifier or a string literal holding the name.
+ */
 interface DialectField {
     typeDef: AtomicTypeDef;
     sqlExpression: string;
     rawName: string;
-    sqlOutputName: string;
 }
 export type DialectFieldList = DialectField[];
 /**
@@ -74,6 +83,7 @@ export declare function qtz(qi: QueryInfo): string | undefined;
  */
 export declare function turtleGroupSetCondition(groupSet: number | undefined, filterSQL: string | undefined): string | undefined;
 export type OrderByClauseType = 'output_name' | 'ordinal' | 'expression';
+export type GroupByClauseType = 'ordinal' | 'expression';
 export type OrderByRequest = 'query' | 'turtle' | 'analytical';
 export type BooleanTypeSupport = 'supported' | 'simulated' | 'none';
 /**
@@ -106,6 +116,14 @@ export declare abstract class Dialect {
     abstract supportsSafeCast: boolean;
     abstract supportsNesting: boolean;
     abstract experimental: boolean;
+    /**
+     * What the compiler consults, not `experimental` itself. The test harness
+     * calls `acceptExperimental()` on the dialect under test so the shared
+     * suites can run on an experimental dialect without every test enabling it.
+     */
+    private experimentalAccepted;
+    isExperimental(): boolean;
+    acceptExperimental(): void;
     cantPartitionWindowFunctionsOnExpressions: boolean;
     sqlLateralJoinBag(_expressions: LateralJoinExpression[]): string;
     supportsPipelinesInViews: boolean;
@@ -114,6 +132,9 @@ export declare abstract class Dialect {
     hasTimestamptz: boolean;
     readsNestedData: boolean;
     orderByClause: OrderByClauseType;
+    groupByClause: GroupByClauseType;
+    /** The ordering and row limit which end a SELECT stage */
+    sqlOrderByLimit(orderTerms: string[], limit: number | undefined): string;
     nullMatchesFunctionSignature: boolean;
     supportsSelectReplace: boolean;
     supportsBigIntPrecision: boolean;
@@ -131,6 +152,7 @@ export declare abstract class Dialect {
     compoundObjectInSchema: boolean;
     booleanType: BooleanTypeSupport;
     likeEscape: boolean;
+    likeExtraWildcards: string[];
     /**
      * Mappings from integer value ranges to Malloy number types.
      *
@@ -188,6 +210,7 @@ export declare abstract class Dialect {
     abstract sqlAnyValue(groupSet: number, fieldName: string): string;
     abstract sqlAggregateTurtle(groupSet: number | undefined, fieldList: DialectFieldList, orderBy: CompiledOrderBy[] | undefined, limit?: number, filterSQL?: string): string;
     sqlTurtleOrderByClause(orderBy: CompiledOrderBy[]): string;
+    sqlCombineLastStageOrderBy(orderBy: OrderBy[] | undefined, fieldList: DialectFieldList): string;
     abstract sqlAnyValueTurtle(groupSet: number, fieldList: DialectFieldList): string;
     abstract sqlAnyValueLastTurtle(name: string, groupSet: number, sqlName: string): string;
     abstract sqlCoaleseMeasuresInline(groupSet: number, fieldList: DialectFieldList): string;
@@ -457,6 +480,16 @@ export declare abstract class Dialect {
      *   the civil time in the specified timezone
      */
     abstract sqlTimestamptzLiteral(qi: QueryInfo, literal: string, timezone: string): string;
+    /**
+     * Reject characters that can break SQL literals or
+     * be changed by SQL formatting. Timezone-name validity belongs to the
+     * database, whose formats may include offsets and POSIX TZ strings.
+     * Static so the translator can apply the same rule before dialect resolution.
+     */
+    static isSafeTimezoneName(timezone: string): boolean;
+    /** Return an unquoted timezone for inclusion in a larger SQL literal. */
+    protected checkedTimezoneName(timezone: string): string;
+    sqlTimezoneLiteral(timezone: string): string;
     /**
      * Render a Malloy string as a SQL string literal. The escape style is
      * driven by `stringLiteralStyle`; dialects normally do not override
@@ -483,14 +516,13 @@ export declare abstract class Dialect {
     exprToSQL(qi: QueryInfo, df: Expr): string | undefined;
     sqlSumDistinct(_key: string, _value: string, _funcName: string): string;
     sqlAggDistinct(_key: string, _values: string[], _func: (valNames: string[]) => string): string;
-    sqlSampleTable(tableSQL: string, sample: Sampling | undefined): string;
+    sqlSampleTable(tableSQL: string, sample: Sampling | undefined, _onBaseTable?: boolean): string;
     /**
      * MySQL is NULLs first, all other dialects have a way to make NULLs last.
      * isBaseOrdering is a hack to allow the MySQL dialect to partially implement
      * NULLs last, but should go away once MySQL fully implements NULLs last.
      */
     sqlOrderBy(orderTerms: string[], _orderFor?: OrderByRequest): string;
-    sqlTzStr(qi: QueryInfo): string;
     sqlMakeUnnestKey(key: string, rowKey: string): string;
     sqlStringAggDistinct(distinctKey: string, valueSQL: string, separatorSQL: string): string;
     abstract sqlTypeToMalloyType(sqlType: string): BasicAtomicTypeDef;

package/dist/dialect/dialect.js

@@ -81,6 +81,12 @@ function turtleGroupSetCondition(groupSet, filterSQL) {
 }
 class Dialect {
     constructor() {
+        /**
+         * What the compiler consults, not `experimental` itself. The test harness
+         * calls `acceptExperimental()` on the dialect under test so the shared
+         * suites can run on an experimental dialect without every test enabling it.
+         */
+        this.experimentalAccepted = false;
         // -- we should add flags with default values from now on so as to not break
         // dialects outside our repository
         //
@@ -106,6 +112,9 @@ class Dialect {
         this.readsNestedData = true;
         // ORDER BY 1 DESC
         this.orderByClause = 'ordinal';
+        // GROUP BY 1, or GROUP BY the dimension expressions for an engine whose
+        // GROUP BY takes no ordinals
+        this.groupByClause = 'ordinal';
         // null will match in a function signature
         this.nullMatchesFunctionSignature = true;
         // support select * replace(...)
@@ -147,6 +156,8 @@ class Dialect {
         this.booleanType = 'supported';
         // Like characters are escaped with ESCAPE clause
         this.likeEscape = true;
+        // Characters LIKE reads as wildcards beyond % and _, escaped like them
+        this.likeExtraWildcards = [];
         /**
          * Mappings from integer value ranges to Malloy number types.
          *
@@ -209,6 +220,12 @@ class Dialect {
          */
         this.identifierEscapeStyle = exports.EscapeStyle.Unset;
     }
+    isExperimental() {
+        return this.experimental && !this.experimentalAccepted;
+    }
+    acceptExperimental() {
+        this.experimentalAccepted = true;
+    }
     // Generate the lateral join bag clause for window function partitioning.
     // The expressions are dimension fields that need to be referenced by name
     // in PARTITION BY clauses. Must be overridden by any dialect that sets
@@ -219,6 +236,14 @@ class Dialect {
         }
         throw new Error('Internal error: sqlLateralJoinBag called but cantPartitionWindowFunctionsOnExpressions is false');
     }
+    /** The ordering and row limit which end a SELECT stage */
+    sqlOrderByLimit(orderTerms, limit) {
+        let s = orderTerms.length > 0 ? this.sqlOrderBy(orderTerms, 'query') + '\n' : '';
+        if (limit !== undefined) {
+            s += `LIMIT ${limit}\n`;
+        }
+        return s;
+    }
     /**
      * Determine the Malloy number type for a numeric literal.
      */
@@ -323,6 +348,20 @@ class Dialect {
         const terms = orderBy.map(o => ` ${o.field} ${o.dir.toUpperCase()}`);
         return ' ' + this.sqlOrderBy(terms, 'turtle');
     }
+    // Format the ordering of the last stage of a nest's pipeline into an ORDER BY
+    // clause for the aggregate which packs that stage's rows into an array. An
+    // ordinal names an output field by number, counting from one; the field list
+    // is a zero-based array.
+    sqlCombineLastStageOrderBy(orderBy, fieldList) {
+        if (orderBy === undefined || orderBy.length === 0) {
+            return '';
+        }
+        const terms = orderBy.map(o => {
+            const name = typeof o.field === 'string' ? o.field : fieldList[o.field - 1].rawName;
+            return `${this.sqlQuoteIdentifier(name)} ${o.dir || 'asc'}`;
+        });
+        return ` ORDER BY ${terms.join(', ')}`;
+    }
     sqlFinalStage(_lastStageName, _fields) {
         throw new Error('Dialect has no final Stage but called Anyway');
     }
@@ -482,6 +521,25 @@ class Dialect {
         }
         return sql;
     }
+    /**
+     * Reject characters that can break SQL literals or
+     * be changed by SQL formatting. Timezone-name validity belongs to the
+     * database, whose formats may include offsets and POSIX TZ strings.
+     * Static so the translator can apply the same rule before dialect resolution.
+     */
+    static isSafeTimezoneName(timezone) {
+        return !/['"`\\\r\n]/.test(timezone);
+    }
+    /** Return an unquoted timezone for inclusion in a larger SQL literal. */
+    checkedTimezoneName(timezone) {
+        if (!Dialect.isSafeTimezoneName(timezone)) {
+            throw new Error(`Invalid timezone ${JSON.stringify(timezone)}: quotes, backslashes, and line breaks are not allowed`);
+        }
+        return timezone;
+    }
+    sqlTimezoneLiteral(timezone) {
+        return `'${this.checkedTimezoneName(timezone)}'`;
+    }
     /**
      * Render a Malloy string as a SQL string literal. The escape style is
      * driven by `stringLiteralStyle`; dialects normally do not override
@@ -590,7 +648,9 @@ class Dialect {
     _func) {
         return 'sqlAggDistinct called but not implemented';
     }
-    sqlSampleTable(tableSQL, sample) {
+    // onBaseTable: the source is a table the engine can sample in place; a
+    // dialect whose sampling reads the table itself ignores a sample elsewhere
+    sqlSampleTable(tableSQL, sample, _onBaseTable = true) {
         if (sample !== undefined) {
             throw new Error(`Sampling is not supported on dialect ${this.name}.`);
         }
@@ -604,9 +664,6 @@ class Dialect {
     sqlOrderBy(orderTerms, _orderFor) {
         return `ORDER BY ${orderTerms.join(',')}`;
     }
-    sqlTzStr(qi) {
-        return `"${qi.queryTimezone}"`;
-    }
     sqlMakeUnnestKey(key, rowKey) {
         return this.concat(key, "'x'", rowKey);
     }
@@ -664,6 +721,11 @@ class Dialect {
                 escapeActive = false;
                 escapeClause = true;
             }
+            else if (this.likeEscape && this.likeExtraWildcards.includes(c)) {
+                escaped += '^' + c;
+                escapeActive = false;
+                escapeClause = true;
+            }
             else {
                 if (escapeActive) {
                     if (this.likeEscape) {
@@ -690,7 +752,7 @@ class Dialect {
      */
     sqlBoolean(bv) {
         if (this.booleanType === 'none') {
-            return bv ? '(1=1)' : '(1-0)';
+            return bv ? '(1=1)' : '(1=0)';
         }
         return bv ? 'true' : 'false';
     }

package/dist/dialect/dialect_map.js

@@ -14,6 +14,7 @@ const standardsql_1 = require("./standardsql");
 const trino_1 = require("./trino");
 const mysql_1 = require("./mysql");
 const databricks_1 = require("./databricks");
+const sqlserver_1 = require("./sqlserver");
 const dialectMap = new Map();
 function getDialect(name) {
     const d = dialectMap.get(name);
@@ -36,4 +37,5 @@ registerDialect(new trino_1.TrinoDialect());
 registerDialect(new trino_1.PrestoDialect());
 registerDialect(new mysql_1.MySQLDialect());
 registerDialect(new databricks_1.DatabricksDialect());
+registerDialect(new sqlserver_1.SQLServerDialect());
 //# sourceMappingURL=dialect_map.js.map