@malloydata/malloy 0.0.394 → 0.0.395

package/dist/dialect/snowflake/snowflake.d.ts

@@ -6,6 +6,9 @@ export declare class SnowflakeDialect extends Dialect {
     name: string;
     experimental: boolean;
     hasTimestamptz: boolean;
+    stringLiteralStyle: "backslash";
+    identifierEscapeStyle: "doubled";
+    identifierQuoteChar: string;
     defaultNumberType: string;
     defaultDecimalType: string;
     udfPrefix: string;
@@ -26,8 +29,8 @@ export declare class SnowflakeDialect extends Dialect {
     supportsQualify: boolean;
     supportsPipelinesInViews: boolean;
     supportsComplexFilteredSources: boolean;
+    tablePathBareIdentRegex: RegExp;
     integerTypeMappings: IntegerTypeMapping[];
-    quoteTablePath(tablePath: string): string;
     sqlGroupSetTable(groupSetCount: number): string;
     sqlAnyValue(groupSet: number, fieldName: string): string;
     mapFields(fieldList: DialectFieldList): string;
@@ -45,7 +48,6 @@ export declare class SnowflakeDialect extends Dialect {
     sqlCreateFunction(_id: string, _funcText: string): string;
     sqlCreateFunctionCombineLastStage(_lastStageName: string): string;
     sqlSelectAliasAsStruct(alias: string): string;
-    sqlMaybeQuoteIdentifier(identifier: string): string;
     sqlCreateTableAsSelect(tableName: string, sql: string): string;
     sqlConvertToCivilTime(expr: string, timezone: string, typeDef: AtomicTypeDef): {
         sql: string;
@@ -65,8 +67,6 @@ export declare class SnowflakeDialect extends Dialect {
     sqlRegexpMatch(compare: RegexMatchExpr): string;
     sqlSampleTable(tableSQL: string, sample: Sampling | undefined): string;
     sqlOrderBy(orderTerms: string[]): string;
-    sqlLiteralString(literal: string): string;
-    sqlLiteralRegexp(literal: string): string;
     getDialectFunctionOverrides(): {
         [name: string]: DialectFunctionOverloadDef[];
     };

package/dist/dialect/snowflake/snowflake.js

@@ -78,6 +78,9 @@ class SnowflakeDialect extends dialect_1.Dialect {
         this.name = 'snowflake';
         this.experimental = false;
         this.hasTimestamptz = true;
+        this.stringLiteralStyle = dialect_1.EscapeStyle.Backslash;
+        this.identifierEscapeStyle = dialect_1.EscapeStyle.Doubled;
+        this.identifierQuoteChar = '"';
         this.defaultNumberType = 'NUMBER';
         this.defaultDecimalType = 'NUMBER';
         this.udfPrefix = '__udf';
@@ -98,21 +101,14 @@ class SnowflakeDialect extends dialect_1.Dialect {
         this.supportsQualify = false;
         this.supportsPipelinesInViews = false;
         this.supportsComplexFilteredSources = false;
+        // Snowflake bare-identifier continuation allows `$` (verified against
+        // the live engine).
+        this.tablePathBareIdentRegex = /^[A-Za-z_][A-Za-z0-9_$]*/;
         // Snowflake uses NUMBER(38,0) for all integers - can exceed JS Number precision
         this.integerTypeMappings = [
             { min: dialect_1.MIN_DECIMAL38, max: dialect_1.MAX_DECIMAL38, numberType: 'bigint' },
         ];
     }
-    quoteTablePath(tablePath) {
-        // Quote with double quotes if contains dangerous characters
-        if (tablePath.match(/[;-]/)) {
-            return tablePath
-                .split('.')
-                .map(part => `"${part}"`)
-                .join('.');
-        }
-        return tablePath;
-    }
     sqlGroupSetTable(groupSetCount) {
         return `CROSS JOIN (SELECT index as group_set FROM TABLE(FLATTEN(ARRAY_GENERATE_RANGE(0, ${groupSetCount + 1}))))`;
     }
@@ -126,7 +122,7 @@ class SnowflakeDialect extends dialect_1.Dialect {
     }
     mapFieldsForObjectConstruct(fieldList) {
         return fieldList
-            .map(f => `'${f.rawName}', (${f.sqlExpression})`)
+            .map(f => `${this.sqlLiteralString(f.rawName)}, (${f.sqlExpression})`)
             .join(', ');
     }
     sqlAggregateTurtle(groupSet, fieldList, orderBy) {
@@ -152,7 +148,7 @@ class SnowflakeDialect extends dialect_1.Dialect {
         return `COALESCE(ARRAY_AGG(CASE WHEN group_set=${groupSet} THEN OBJECT_CONSTRUCT_KEEP_NULL(${fields}) END)[0], OBJECT_CONSTRUCT_KEEP_NULL(${nullValues}))`;
     }
     sqlUnnestAlias(source, alias, _fieldList, _needDistinctKey, isArray, _isInNestedPipeline) {
-        const as = this.sqlMaybeQuoteIdentifier(alias);
+        const as = this.sqlQuoteIdentifier(alias);
         if (isArray) {
             return `LEFT JOIN lateral flatten(input => ${source}) as ${as}`;
         }
@@ -202,7 +198,7 @@ class SnowflakeDialect extends dialect_1.Dialect {
         return 'UUID_STRING()';
     }
     sqlFieldReference(parentAlias, parentType, childName, childType) {
-        const sqlName = this.sqlMaybeQuoteIdentifier(childName);
+        const sqlName = this.sqlQuoteIdentifier(childName);
         if (childName === '__row_id') {
             return `"${parentAlias}".INDEX::varchar`;
         }
@@ -250,9 +246,6 @@ class SnowflakeDialect extends dialect_1.Dialect {
     sqlSelectAliasAsStruct(alias) {
         return `OBJECT_CONSTRUCT_KEEP_NULL(${alias}.*)`;
     }
-    sqlMaybeQuoteIdentifier(identifier) {
-        return '"' + identifier.replace(/"/g, '""') + '"';
-    }
     sqlCreateTableAsSelect(tableName, sql) {
         return `
 CREATE TEMP TABLE IF NOT EXISTS \`${tableName}\`
@@ -425,14 +418,6 @@ ${(0, utils_1.indent)(sql)}
     sqlOrderBy(orderTerms) {
         return `ORDER BY ${orderTerms.map(t => `${t} NULLS LAST`).join(',')}`;
     }
-    sqlLiteralString(literal) {
-        const noVirgule = literal.replace(/\\/g, '\\\\');
-        return "'" + noVirgule.replace(/'/g, "\\'") + "'";
-    }
-    sqlLiteralRegexp(literal) {
-        const noVirgule = literal.replace(/\\/g, '\\\\');
-        return "'" + noVirgule.replace(/'/g, "\\'") + "'";
-    }
     getDialectFunctionOverrides() {
         return (0, functions_1.expandOverrideMap)(function_overrides_1.SNOWFLAKE_MALLOY_STANDARD_OVERLOADS);
     }
@@ -457,7 +442,7 @@ ${(0, utils_1.indent)(sql)}
                 var _a;
                 if ((0, malloy_types_1.isAtomic)(f)) {
                     const name = (_a = f.as) !== null && _a !== void 0 ? _a : f.name;
-                    const oneSchema = `${this.sqlMaybeQuoteIdentifier(name)} ${this.malloyTypeToSQLType(f)}`;
+                    const oneSchema = `${this.sqlQuoteIdentifier(name)} ${this.malloyTypeToSQLType(f)}`;
                     ret.push(oneSchema);
                 }
                 return ret;
@@ -521,9 +506,8 @@ ${(0, utils_1.indent)(sql)}
         const rowVals = [];
         for (const f of lit.typeDef.fields) {
             const name = (_a = f.as) !== null && _a !== void 0 ? _a : f.name;
-            const propName = `'${name}'`;
             const propVal = (_c = (_b = (0, malloy_types_1.safeRecordGet)(lit.kids, name)) === null || _b === void 0 ? void 0 : _b.sql) !== null && _c !== void 0 ? _c : 'internal-error-record-literal';
-            rowVals.push(`${propName},${propVal}`);
+            rowVals.push(`${this.sqlLiteralString(name)},${propVal}`);
         }
         return `OBJECT_CONSTRUCT_KEEP_NULL(${rowVals.join(',')})`;
     }

package/dist/dialect/standardsql/standardsql.d.ts

@@ -4,6 +4,9 @@ import type { CompiledOrderBy, DialectFieldList, IntegerTypeMapping, OrderByRequ
 import { Dialect, type LateralJoinExpression } from '../dialect';
 export declare class StandardSQLDialect extends Dialect {
     name: string;
+    stringLiteralStyle: "backslash";
+    identifierEscapeStyle: "backslash";
+    identifierQuoteChar: string;
     experimental: boolean;
     defaultNumberType: string;
     defaultDecimalType: string;
@@ -29,7 +32,9 @@ export declare class StandardSQLDialect extends Dialect {
     supportsHyperLogLog: boolean;
     likeEscape: boolean;
     integerTypeMappings: IntegerTypeMapping[];
-    quoteTablePath(tablePath: string): string;
+    private bqRejectBacktick;
+    sqlQuoteIdentifier(identifier: string): string;
+    tablePathBareIdentRegex: RegExp;
     needsCivilTimeComputation(typeDef: AtomicTypeDef, truncateTo: TimestampUnit | undefined, offsetUnit: TimestampUnit | undefined, qi: QueryInfo): {
         needed: boolean;
         tz: string | undefined;
@@ -50,7 +55,6 @@ export declare class StandardSQLDialect extends Dialect {
     sqlCreateTableAsSelect(tableName: string, sql: string): string;
     sqlCreateFunctionCombineLastStage(lastStageName: string): string;
     sqlSelectAliasAsStruct(alias: string): string;
-    sqlMaybeQuoteIdentifier(identifier: string): string;
     sqlNowExpr(): string;
     sqlTimeExtractExpr(qi: QueryInfo, te: TimeExtractExpr): string;
     sqlConvertToCivilTime(expr: string, timezone: string, _typeDef: AtomicTypeDef): {
@@ -68,8 +72,6 @@ export declare class StandardSQLDialect extends Dialect {
     sqlTimestamptzLiteral(_qi: QueryInfo, _literal: string, _timezone: string): string;
     sqlMeasureTimeExpr(measure: MeasureTimeExpr): string;
     sqlSampleTable(tableSQL: string, sample: Sampling | undefined): string;
-    sqlLiteralString(literal: string): string;
-    sqlLiteralRegexp(literal: string): string;
     getDialectFunctionOverrides(): {
         [name: string]: DialectFunctionOverloadDef[];
     };

package/dist/dialect/standardsql/standardsql.js

@@ -76,6 +76,9 @@ class StandardSQLDialect extends dialect_1.Dialect {
     constructor() {
         super(...arguments);
         this.name = 'standardsql';
+        this.stringLiteralStyle = dialect_1.EscapeStyle.Backslash;
+        this.identifierEscapeStyle = dialect_1.EscapeStyle.Backslash;
+        this.identifierQuoteChar = '`';
         this.experimental = false;
         this.defaultNumberType = 'FLOAT64';
         this.defaultDecimalType = 'NUMERIC';
@@ -101,13 +104,42 @@ class StandardSQLDialect extends dialect_1.Dialect {
         this.integerTypeMappings = [
             { min: dialect_1.MIN_INT64, max: dialect_1.MAX_INT64, numberType: 'bigint' },
         ];
+        // BigQuery bare-identifier continuation allows dashes (verified
+        // against the live engine: `proj-foo.dataset.table` resolves to a
+        // table reference, both bare and inside per-segment backticks). The
+        // base `sqlValidateTableName` handles every shape we accept —
+        // bare-dotted, whole-backticked, and per-segment-backticked — because
+        // its grammar is `Segment ('.' Segment)*` and a segment is either
+        // bare or quoted with this dialect's `identifierQuoteChar` /
+        // `identifierEscapeStyle` (`` ` `` / Backslash). The whole-path form
+        // (`` `proj.dataset.table` ``) is accepted naturally as a single
+        // quoted segment.
+        //
+        // `*` is intentionally NOT in this regex. BigQuery's parser only
+        // accepts `*` inside backticks (wildcard tables must be quoted, e.g.
+        // `` `dataset.events_*` ``). Bare wildcards would fail at the engine,
+        // so we reject them up front and require the user to type the
+        // backticks they'd need anyway.
+        this.tablePathBareIdentRegex = /^[A-Za-z_][A-Za-z0-9_-]*/;
     }
     sqlLateralJoinBag(expressions) {
         const fields = expressions.map(e => `${e.sql} as ${e.name}`);
         return `LEFT JOIN UNNEST([STRUCT(${fields.join(',\n')})]) as __lateral_join_bag\n`;
     }
-    quoteTablePath(tablePath) {
-        return `\`${tablePath}\``;
+    // BigQuery's parser accepts `\`` as a backtick escape inside quoted
+    // identifiers, but BigQuery's schema layer rejects field/table names
+    // containing a literal backtick. Refuse here so the error names the
+    // dialect; the rest of the escape (backslash-doubling) is handled by
+    // the base via identifierEscapeStyle.
+    // Reference: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical
+    bqRejectBacktick(name, kind) {
+        if (name.includes('`')) {
+            throw new Error(`BigQuery ${kind} cannot contain a backtick: ${JSON.stringify(name)}`);
+        }
+    }
+    sqlQuoteIdentifier(identifier) {
+        this.bqRejectBacktick(identifier, 'identifier');
+        return super.sqlQuoteIdentifier(identifier);
     }
     needsCivilTimeComputation(typeDef, truncateTo, offsetUnit, qi) {
         // In addition to using "civil" space for units where a query time zone is
@@ -193,7 +225,7 @@ class StandardSQLDialect extends dialect_1.Dialect {
         return 'GENERATE_UUID()';
     }
     sqlFieldReference(parentAlias, _parentType, childName, _childType) {
-        const child = this.sqlMaybeQuoteIdentifier(childName);
+        const child = this.sqlQuoteIdentifier(childName);
         return `${parentAlias}.${child}`;
     }
     sqlUnnestPipelineHead(isSingleton, sourceSQLExpression) {
@@ -223,9 +255,6 @@ ${(0, utils_1.indent)(sql)}
     sqlSelectAliasAsStruct(alias) {
         return `(SELECT AS STRUCT ${alias}.*)`;
     }
-    sqlMaybeQuoteIdentifier(identifier) {
-        return '`' + identifier + '`';
-    }
     sqlNowExpr() {
         return 'CURRENT_TIMESTAMP()';
     }
@@ -358,14 +387,6 @@ ${(0, utils_1.indent)(sql)}
         }
         return tableSQL;
     }
-    sqlLiteralString(literal) {
-        const noVirgule = literal.replace(/\\/g, '\\\\');
-        return "'" + noVirgule.replace(/'/g, "\\'") + "'";
-    }
-    sqlLiteralRegexp(literal) {
-        const noVirgule = literal.replace(/\\/g, '\\\\');
-        return "'" + noVirgule.replace(/'/g, "\\'") + "'";
-    }
     getDialectFunctionOverrides() {
         return (0, functions_1.expandOverrideMap)(function_overrides_1.STANDARDSQL_MALLOY_STANDARD_OVERLOADS);
     }
@@ -432,7 +453,7 @@ ${(0, utils_1.indent)(sql)}
         const ents = [];
         for (const [name, val] of Object.entries(lit.kids)) {
             const expr = val.sql || 'internal-error-literal-record';
-            ents.push(`${expr} AS ${this.sqlMaybeQuoteIdentifier(name)}`);
+            ents.push(`${expr} AS ${this.sqlQuoteIdentifier(name)}`);
         }
         return `STRUCT(${ents.join(',')})`;
     }

package/dist/dialect/table-path.d.ts

@@ -0,0 +1,54 @@
+export type ValidateTablePathResult = {
+    ok: true;
+    canonical: string;
+} | {
+    ok: false;
+    error: string;
+};
+export interface TablePathSegment {
+    /** Decoded segment value: delimiters stripped, escapes unescaped. */
+    value: string;
+    /** Whether the segment appeared in quoted form in the input. */
+    quoted: boolean;
+}
+export type DecodeDottedTablePathResult = {
+    ok: true;
+    segments: TablePathSegment[];
+} | {
+    ok: false;
+    error: string;
+};
+export type TablePathEscapeStyle = 'doubled' | 'backslash';
+export interface DottedTablePathOptions {
+    /** Delimiter for quoted segments (`"`, `` ` ``, …). */
+    quoteChar: string;
+    /**
+     * How a literal `quoteChar` is encoded inside a quoted body:
+     *   - 'doubled':   `qq` inside body escapes one literal `q`.
+     *   - 'backslash': `\X` is a two-character escape; unescaped `q` closes.
+     */
+    escapeStyle: TablePathEscapeStyle;
+    /**
+     * Regex matching one bare segment, anchored at the start of the input.
+     * Must NOT have global/sticky flags; the parser calls `.match()` on
+     * `input.slice(i)` and expects the match to start at position 0.
+     */
+    bareIdentRegex: RegExp;
+    /** Used in error messages only. */
+    dialectName: string;
+}
+/**
+ * Parse `input` as a dotted table path and require end-of-input. On
+ * success, returns the decoded segment values — delimiters stripped,
+ * escape sequences unescaped — so callers that need the segments
+ * (connection metadata lookups) and callers that only need
+ * accept/reject (`validateDottedTablePath`) share one parser.
+ */
+export declare function decodeDottedTablePath(input: string, opts: DottedTablePathOptions): DecodeDottedTablePathResult;
+/**
+ * Validate `input` as a dotted table path. On success the canonical
+ * form is the input verbatim. See `decodeDottedTablePath` for the
+ * underlying parser; this is the validate-only wrapper that doesn't
+ * expose segment internals.
+ */
+export declare function validateDottedTablePath(input: string, opts: DottedTablePathOptions): ValidateTablePathResult;

package/dist/dialect/table-path.js

@@ -0,0 +1,144 @@
+"use strict";
+/*
+ * Copyright Contributors to the Malloy project
+ * SPDX-License-Identifier: MIT
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.decodeDottedTablePath = decodeDottedTablePath;
+exports.validateDottedTablePath = validateDottedTablePath;
+/**
+ * Parse `input` as a dotted table path and require end-of-input. On
+ * success, returns the decoded segment values — delimiters stripped,
+ * escape sequences unescaped — so callers that need the segments
+ * (connection metadata lookups) and callers that only need
+ * accept/reject (`validateDottedTablePath`) share one parser.
+ */
+function decodeDottedTablePath(input, opts) {
+    const { quoteChar, escapeStyle, bareIdentRegex, dialectName } = opts;
+    if (input.length === 0) {
+        return { ok: false, error: `${dialectName} table path is empty` };
+    }
+    const segments = [];
+    let i = 0;
+    while (true) {
+        let segValue;
+        let segQuoted;
+        if (input[i] === quoteChar) {
+            const result = consumeQuotedSegment(input, i, quoteChar, escapeStyle);
+            if (result === null) {
+                return {
+                    ok: false,
+                    error: `Invalid ${dialectName} table path: ${JSON.stringify(input)} — ` +
+                        'unterminated quoted segment',
+                };
+            }
+            segValue = result.decoded;
+            segQuoted = true;
+            i = result.end;
+        }
+        else {
+            const m = input.slice(i).match(bareIdentRegex);
+            if (!m || m.index !== 0 || m[0].length === 0) {
+                return {
+                    ok: false,
+                    error: `Invalid ${dialectName} table path: ${JSON.stringify(input)} — ` +
+                        `invalid segment at position ${i}`,
+                };
+            }
+            segValue = m[0];
+            segQuoted = false;
+            i += m[0].length;
+        }
+        // Defense-in-depth: `;` and `--` are forbidden in any decoded segment,
+        // even a legally-quoted one. Real table names don't contain them.
+        if (segValue.includes(';') || segValue.includes('--')) {
+            return {
+                ok: false,
+                error: `Invalid ${dialectName} table path: segment ${JSON.stringify(segValue)} ` +
+                    'contains forbidden character; even when quoted, table-path ' +
+                    'segments may not contain `;` or `--`.',
+            };
+        }
+        segments.push({ value: segValue, quoted: segQuoted });
+        if (i === input.length)
+            return { ok: true, segments };
+        if (input[i] !== '.') {
+            return {
+                ok: false,
+                error: `Invalid ${dialectName} table path: ${JSON.stringify(input)} — ` +
+                    `expected '.' at position ${i}`,
+            };
+        }
+        i++;
+        if (i === input.length) {
+            return {
+                ok: false,
+                error: `Invalid ${dialectName} table path: ${JSON.stringify(input)} — ` +
+                    'trailing dot',
+            };
+        }
+    }
+}
+/**
+ * Validate `input` as a dotted table path. On success the canonical
+ * form is the input verbatim. See `decodeDottedTablePath` for the
+ * underlying parser; this is the validate-only wrapper that doesn't
+ * expose segment internals.
+ */
+function validateDottedTablePath(input, opts) {
+    const result = decodeDottedTablePath(input, opts);
+    if (!result.ok)
+        return result;
+    return { ok: true, canonical: input };
+}
+/**
+ * Read past a quoted segment starting at `input[i]` (must be `quoteChar`).
+ * Returns the segment body (delimiters stripped, escape sequences
+ * unescaped) and the index just after the closing quote, or `null` if
+ * the segment is unterminated.
+ */
+function consumeQuotedSegment(input, i, quoteChar, escapeStyle) {
+    // input[i] === quoteChar
+    let j = i + 1;
+    let decoded = '';
+    while (j < input.length) {
+        if (escapeStyle === 'backslash' && input[j] === '\\') {
+            if (j + 1 >= input.length)
+                return null;
+            decoded += decodeBackslashEscape(input[j + 1]);
+            j += 2;
+            continue;
+        }
+        if (input[j] === quoteChar) {
+            if (escapeStyle === 'doubled' && input[j + 1] === quoteChar) {
+                decoded += quoteChar;
+                j += 2;
+                continue;
+            }
+            return { decoded, end: j + 1 };
+        }
+        decoded += input[j];
+        j++;
+    }
+    return null;
+}
+/**
+ * Decode a single character after a backslash. We intentionally accept
+ * any character — we're a translator-time grammar check, not a strict
+ * lexical conformance test for any particular engine's quoted-identifier
+ * escape table. The engine will surface its own errors at bind time if
+ * it doesn't recognize a particular sequence.
+ */
+function decodeBackslashEscape(c) {
+    switch (c) {
+        case 'n':
+            return '\n';
+        case 't':
+            return '\t';
+        case 'r':
+            return '\r';
+        default:
+            return c;
+    }
+}
+//# sourceMappingURL=table-path.js.map

package/dist/dialect/trino/trino.d.ts

@@ -30,7 +30,6 @@ export declare class TrinoDialect extends PostgresBase {
     supportsTempTables: boolean;
     supportsCountApprox: boolean;
     supportsHyperLogLog: boolean;
-    quoteTablePath(tablePath: string): string;
     sqlGroupSetTable(groupSetCount: number): string;
     exprToSQL(qi: QueryInfo, df: Expr): string | undefined;
     sqlAnyValue(groupSet: number, fieldName: string): string;
@@ -62,8 +61,6 @@ export declare class TrinoDialect extends PostgresBase {
     sqlRegexpMatch(reCmp: RegexMatchExpr): string;
     sqlMeasureTimeExpr(mf: MeasureTimeExpr): string;
     sqlSampleTable(tableSQL: string, sample: Sampling | undefined): string;
-    sqlLiteralString(literal: string): string;
-    sqlLiteralRegexp(literal: string): string;
     getDialectFunctionOverrides(): {
         [name: string]: DialectFunctionOverloadDef[];
     };

package/dist/dialect/trino/trino.js

@@ -200,16 +200,9 @@ class TrinoDialect extends pg_impl_1.PostgresBase {
   WITH
   WITHIN`.split(/\s/);
     }
-    quoteTablePath(tablePath) {
-        // Quote with double quotes if contains dangerous characters
-        if (tablePath.match(/[;-]/)) {
-            return tablePath
-                .split('.')
-                .map(part => `"${part}"`)
-                .join('.');
-        }
-        return tablePath;
-    }
+    // Trino bare identifier is strict ANSI (`[A-Za-z_][A-Za-z0-9_]*`),
+    // which matches the Dialect default — no override needed. Verified
+    // against the live engine.
     sqlGroupSetTable(groupSetCount) {
         return `CROSS JOIN (SELECT row_number() OVER() -1  group_set FROM UNNEST(SEQUENCE(0,${groupSetCount})))`;
     }
@@ -300,7 +293,7 @@ class TrinoDialect extends pg_impl_1.PostgresBase {
         if (childName === '__row_id') {
             return `__row_id_from_${parentAlias}`;
         }
-        return `${parentAlias}.${this.sqlMaybeQuoteIdentifier(childName)}`;
+        return `${parentAlias}.${this.sqlQuoteIdentifier(childName)}`;
     }
     sqlUnnestPipelineHead(isSingleton, sourceSQLExpression) {
         let p = sourceSQLExpression;
@@ -471,12 +464,6 @@ ${(0, utils_1.indent)(sql)}
         }
         return tableSQL;
     }
-    sqlLiteralString(literal) {
-        return "'" + literal.replace(/'/g, "''") + "'";
-    }
-    sqlLiteralRegexp(literal) {
-        return "'" + literal.replace(/'/g, "''") + "'";
-    }
     getDialectFunctionOverrides() {
         return (0, functions_1.expandOverrideMap)(function_overrides_1.TRINO_MALLOY_STANDARD_OVERLOADS);
     }
@@ -503,7 +490,7 @@ ${(0, utils_1.indent)(sql)}
                 const typeSpec = [];
                 for (const f of malloyType.fields) {
                     if ((0, malloy_types_1.isAtomic)(f)) {
-                        typeSpec.push(`${this.sqlMaybeQuoteIdentifier(f.name)} ${this.malloyTypeToSQLType(f)}`);
+                        typeSpec.push(`${this.sqlQuoteIdentifier(f.name)} ${this.malloyTypeToSQLType(f)}`);
                     }
                 }
                 return `ROW(${typeSpec.join(',')})`;
@@ -515,7 +502,7 @@ ${(0, utils_1.indent)(sql)}
                     const typeSpec = [];
                     for (const f of malloyType.fields) {
                         if ((0, malloy_types_1.isAtomic)(f)) {
-                            typeSpec.push(`${this.sqlMaybeQuoteIdentifier(f.name)} ${this.malloyTypeToSQLType(f)}`);
+                            typeSpec.push(`${this.sqlQuoteIdentifier(f.name)} ${this.malloyTypeToSQLType(f)}`);
                         }
                     }
                     return `ARRAY<ROW(${typeSpec.join(',')})>`;
@@ -603,7 +590,7 @@ ${(0, utils_1.indent)(sql)}
                 const name = (_a = f.as) !== null && _a !== void 0 ? _a : f.name;
                 rowVals.push((_c = (_b = (0, malloy_types_1.safeRecordGet)(lit.kids, name)) === null || _b === void 0 ? void 0 : _b.sql) !== null && _c !== void 0 ? _c : 'internal-error-record-literal');
                 const elType = this.malloyTypeToSQLType(f);
-                rowTypes.push(`${this.sqlMaybeQuoteIdentifier(name)} ${elType}`);
+                rowTypes.push(`${this.sqlQuoteIdentifier(name)} ${elType}`);
             }
         }
         return `CAST(ROW(${rowVals.join(',')}) AS ROW(${rowTypes.join(',')}))`;

package/dist/index.d.ts

@@ -1,5 +1,5 @@
-export { DuckDBDialect, StandardSQLDialect, TrinoDialect, PostgresDialect, SnowflakeDialect, MySQLDialect, DatabricksDialect, registerDialect, arg, qtz, overload, minScalar, anyExprType, minAggregate, maxScalar, sql, makeParam, param, variadicParam, literal, spread, Dialect, } from './dialect';
-export type { DialectFieldList, DialectFunctionOverloadDef, QueryInfo, MalloyStandardFunctionImplementations, DefinitionBlueprint, DefinitionBlueprintMap, OverloadedDefinitionBlueprint, } from './dialect';
+export { DuckDBDialect, StandardSQLDialect, TrinoDialect, PostgresDialect, SnowflakeDialect, MySQLDialect, DatabricksDialect, registerDialect, arg, qtz, overload, minScalar, anyExprType, minAggregate, maxScalar, sql, makeParam, param, variadicParam, literal, spread, Dialect, decodeDottedTablePath, validateDottedTablePath, } from './dialect';
+export type { DialectFieldList, DialectFunctionOverloadDef, QueryInfo, MalloyStandardFunctionImplementations, DefinitionBlueprint, DefinitionBlueprintMap, OverloadedDefinitionBlueprint, DecodeDottedTablePathResult, DottedTablePathOptions, TablePathEscapeStyle, TablePathSegment, ValidateTablePathResult, } from './dialect';
 export type { QueryRecord, StructDef, TableSourceDef, SQLSourceDef, SourceDef, JoinFieldDef, NamedSourceDefs, MalloyQueryData, DateUnit, ExtractUnit, TimestampUnit, TemporalFieldType, QueryData, QueryValue, Expr, FilterCondition, Argument, Parameter, FieldDef, PipeSegment, QueryFieldDef, IndexFieldDef, TurtleDef, SearchValueMapResult, SearchIndexResult, ModelDef, Query, QueryResult, QueryResultDef, QueryRunStats, QueryScalar, NamedQueryDef, NamedModelObject, ExpressionType, FunctionDef, FunctionOverloadDef, FunctionParameterDef, ExpressionValueType, TypeDesc, FunctionParamTypeDesc, DocumentLocation, DocumentRange, DocumentPosition, Sampling, Annotation, BasicAtomicTypeDef, BasicAtomicDef, AtomicTypeDef, AtomicFieldDef, ArrayDef, ArrayTypeDef, RecordTypeDef, RepeatedRecordTypeDef, RecordDef, RepeatedRecordDef, RecordLiteralNode, StringLiteralNode, ArrayLiteralNode, SourceComponentInfo, DateLiteralNode, TimestampLiteralNode, TimestamptzLiteralNode, TimeLiteralExpr, TypecastExpr, BuildID, BuildManifest, BuildManifestEntry, GivenValue, VirtualMap, } from './model';
 export { isSourceDef, isAtomic, isBasicAtomic, isCompoundArrayData, isJoined, isJoinedSource, isSamplingEnable, isSamplingPercent, isSamplingRows, isRepeatedRecord, isBasicArray, mkArrayDef, mkFieldDef, expressionIsAggregate, expressionIsAnalytic, expressionIsCalculation, expressionIsScalar, expressionIsUngroupedAggregate, indent, composeSQLExpr, isTimestampUnit, isDateUnit, constantExprToSQL, } from './model';
 export { malloyToQuery, MalloyTranslator, } from './lang';

package/dist/index.js

@@ -33,8 +33,8 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Runtime = exports.Malloy = exports.Model = exports.MalloyTranslator = exports.malloyToQuery = exports.constantExprToSQL = exports.isDateUnit = exports.isTimestampUnit = exports.composeSQLExpr = exports.indent = exports.expressionIsUngroupedAggregate = exports.expressionIsScalar = exports.expressionIsCalculation = exports.expressionIsAnalytic = exports.expressionIsAggregate = exports.mkFieldDef = exports.mkArrayDef = exports.isBasicArray = exports.isRepeatedRecord = exports.isSamplingRows = exports.isSamplingPercent = exports.isSamplingEnable = exports.isJoinedSource = exports.isJoined = exports.isCompoundArrayData = exports.isBasicAtomic = exports.isAtomic = exports.isSourceDef = exports.Dialect = exports.spread = exports.literal = exports.variadicParam = exports.param = exports.makeParam = exports.sql = exports.maxScalar = exports.minAggregate = exports.anyExprType = exports.minScalar = exports.overload = exports.qtz = exports.arg = exports.registerDialect = exports.DatabricksDialect = exports.MySQLDialect = exports.SnowflakeDialect = exports.PostgresDialect = exports.TrinoDialect = exports.StandardSQLDialect = exports.DuckDBDialect = void 0;
-exports.makeDigest = exports.EMPTY_BUILD_MANIFEST = exports.PersistSource = exports.annotationToTaglines = exports.annotationToTag = exports.sqlKey = exports.API = exports.sourceDefToSourceInfo = exports.modelDefToModelInfo = exports.toAsyncGenerator = exports.createConnectionsFromConfig = exports.getRegisteredConnectionTypes = exports.getConnectionTypeDisplayName = exports.getConnectionProperties = exports.registerConnectionType = exports.discoverConfig = exports.defaultConfigOverlays = exports.contextOverlay = exports.envOverlay = exports.MalloyConfig = exports.Manifest = exports.CacheManager = exports.InMemoryModelCache = exports.Explore = exports.DataWriter = exports.Parse = exports.JSONWriter = exports.CSVWriter = exports.QueryMaterializer = exports.Result = exports.PreparedResult = exports.TimestampTimeframe = exports.DateTimeframe = exports.SourceRelationship = exports.JoinRelationship = exports.MalloyError = exports.FixedConnectionMap = exports.InMemoryURLReader = exports.EmptyURLReader = exports.SingleConnectionRuntime = exports.ConnectionRuntime = exports.AtomicFieldType = void 0;
+exports.Model = exports.MalloyTranslator = exports.malloyToQuery = exports.constantExprToSQL = exports.isDateUnit = exports.isTimestampUnit = exports.composeSQLExpr = exports.indent = exports.expressionIsUngroupedAggregate = exports.expressionIsScalar = exports.expressionIsCalculation = exports.expressionIsAnalytic = exports.expressionIsAggregate = exports.mkFieldDef = exports.mkArrayDef = exports.isBasicArray = exports.isRepeatedRecord = exports.isSamplingRows = exports.isSamplingPercent = exports.isSamplingEnable = exports.isJoinedSource = exports.isJoined = exports.isCompoundArrayData = exports.isBasicAtomic = exports.isAtomic = exports.isSourceDef = exports.validateDottedTablePath = exports.decodeDottedTablePath = exports.Dialect = exports.spread = exports.literal = exports.variadicParam = exports.param = exports.makeParam = exports.sql = exports.maxScalar = exports.minAggregate = exports.anyExprType = exports.minScalar = exports.overload = exports.qtz = exports.arg = exports.registerDialect = exports.DatabricksDialect = exports.MySQLDialect = exports.SnowflakeDialect = exports.PostgresDialect = exports.TrinoDialect = exports.StandardSQLDialect = exports.DuckDBDialect = void 0;
+exports.makeDigest = exports.EMPTY_BUILD_MANIFEST = exports.PersistSource = exports.annotationToTaglines = exports.annotationToTag = exports.sqlKey = exports.API = exports.sourceDefToSourceInfo = exports.modelDefToModelInfo = exports.toAsyncGenerator = exports.createConnectionsFromConfig = exports.getRegisteredConnectionTypes = exports.getConnectionTypeDisplayName = exports.getConnectionProperties = exports.registerConnectionType = exports.discoverConfig = exports.defaultConfigOverlays = exports.contextOverlay = exports.envOverlay = exports.MalloyConfig = exports.Manifest = exports.CacheManager = exports.InMemoryModelCache = exports.Explore = exports.DataWriter = exports.Parse = exports.JSONWriter = exports.CSVWriter = exports.QueryMaterializer = exports.Result = exports.PreparedResult = exports.TimestampTimeframe = exports.DateTimeframe = exports.SourceRelationship = exports.JoinRelationship = exports.MalloyError = exports.FixedConnectionMap = exports.InMemoryURLReader = exports.EmptyURLReader = exports.SingleConnectionRuntime = exports.ConnectionRuntime = exports.AtomicFieldType = exports.Runtime = exports.Malloy = void 0;
 /*
  * Copyright 2023 Google LLC
  *
@@ -80,6 +80,8 @@ Object.defineProperty(exports, "variadicParam", { enumerable: true, get: functio
 Object.defineProperty(exports, "literal", { enumerable: true, get: function () { return dialect_1.literal; } });
 Object.defineProperty(exports, "spread", { enumerable: true, get: function () { return dialect_1.spread; } });
 Object.defineProperty(exports, "Dialect", { enumerable: true, get: function () { return dialect_1.Dialect; } });
+Object.defineProperty(exports, "decodeDottedTablePath", { enumerable: true, get: function () { return dialect_1.decodeDottedTablePath; } });
+Object.defineProperty(exports, "validateDottedTablePath", { enumerable: true, get: function () { return dialect_1.validateDottedTablePath; } });
 var model_1 = require("./model");
 Object.defineProperty(exports, "isSourceDef", { enumerable: true, get: function () { return model_1.isSourceDef; } });
 // Used in Composer Demo

package/dist/lang/ast/source-elements/table-source.d.ts

@@ -3,7 +3,7 @@ import { Source } from './source';
 import type { ModelEntryReference } from '../types/malloy-element';
 type TableInfo = {
     tablePath: string;
-    connectionName?: string | undefined;
+    connectionName: string;
 };
 export declare abstract class TableSource extends Source {
     abstract getTableInfo(): TableInfo | undefined;
@@ -16,10 +16,4 @@ export declare class TableMethodSource extends TableSource {
     constructor(connectionName: ModelEntryReference, tablePath: string);
     getTableInfo(): TableInfo | undefined;
 }
-export declare class TableFunctionSource extends TableSource {
-    readonly tableURI: string;
-    elementType: string;
-    constructor(tableURI: string);
-    getTableInfo(): TableInfo | undefined;
-}
 export {};