@malloydata/malloy 0.0.343 → 0.0.344

package/dist/api/core.js

@@ -500,7 +500,8 @@ function statedCompileQuery(state) {
                     source = query.structRef;
                 }
                 else {
-                    source = result.modelDef.contents[query.structRef];
+                    // TODO: `as StructDef` cast is pre-existing type-safety issue — contents holds NamedModelObject
+                    source = (0, model_1.safeRecordGet)(result.modelDef.contents, query.structRef);
                 }
             }
             const sourceAnnotations = (0, annotation_1.annotationToTaglines)(source.annotation).map(l => ({

package/dist/api/foundation/core.d.ts

@@ -1,5 +1,5 @@
 import type { LogMessage } from '../../lang';
-import type { BuildID, CompiledQuery, DocumentLocation, BooleanFieldDef, JSONFieldDef, NumberFieldDef, StringFieldDef, FilterCondition, Query as InternalQuery, ModelDef, DocumentPosition as ModelDocumentPosition, NamedQueryDef, StructDef, TurtleDef, NativeUnsupportedFieldDef, ImportLocation, Annotation, AtomicFieldDef, DateFieldDef, ATimestampFieldDef, SourceDef, Argument, SourceComponentInfo, DocumentReference, PersistableSourceDef } from '../../model';
+import type { BuildID, CompiledQuery, DocumentLocation, BooleanFieldDef, JSONFieldDef, NumberFieldDef, StringFieldDef, FilterCondition, Query as InternalQuery, ModelDef, DocumentPosition as ModelDocumentPosition, NamedQueryDef, StructDef, TurtleDef, NativeUnsupportedFieldDef, ImportLocation, Annotation, NamedModelObject, AtomicFieldDef, DateFieldDef, ATimestampFieldDef, SourceDef, Argument, SourceComponentInfo, DocumentReference, PersistableSourceDef } from '../../model';
 import { QueryModel } from '../../model';
 import type { Dialect } from '../../dialect';
 import type { BuildGraph, CompileQueryOptions } from './types';
@@ -235,7 +235,10 @@ export declare class Model implements Taggable {
     readonly fromSources: string[];
     private readonly references;
     private _queryModel?;
+    private readonly contentsMap;
     constructor(modelDef: ModelDef, problems: LogMessage[], fromSources: string[], existingQueryModel?: QueryModel);
+    /** Safe lookup in model contents by name. */
+    getContent(name: string): NamedModelObject | undefined;
     get queryModel(): QueryModel;
     /**
      * Returns the cached QueryModel if it exists, without creating one.

package/dist/api/foundation/core.js

@@ -750,6 +750,11 @@ class Model {
         this.fromSources = fromSources;
         this.references = new reference_list_1.ReferenceList((_a = fromSources[0]) !== null && _a !== void 0 ? _a : '', (_b = modelDef.references) !== null && _b !== void 0 ? _b : []);
         this._queryModel = existingQueryModel;
+        this.contentsMap = new Map(Object.entries(modelDef.contents));
+    }
+    /** Safe lookup in model contents by name. */
+    getContent(name) {
+        return this.contentsMap.get(name);
     }
     get queryModel() {
         if (!this._queryModel) {
@@ -799,7 +804,7 @@ class Model {
      * @return A prepared query.
      */
     getPreparedQueryByName(queryName) {
-        const query = this.modelDef.contents[queryName];
+        const query = this.getContent(queryName);
         if ((query === null || query === void 0 ? void 0 : query.type) === 'query') {
             return new PreparedQuery(query, this, this.problems, queryName);
         }
@@ -846,7 +851,7 @@ class Model {
      * @return An `Explore`.
      */
     getExploreByName(name) {
-        const struct = this.modelDef.contents[name];
+        const struct = this.getContent(name);
         if (struct && (0, model_1.isSourceDef)(struct)) {
             return new Explore(struct);
         }
@@ -1129,9 +1134,9 @@ class PreparedQuery {
     get dialect() {
         const sourceRef = this._query.structRef;
         const source = typeof sourceRef === 'string'
-            ? this._modelDef.contents[sourceRef]
+            ? this._model.getContent(sourceRef)
             : sourceRef;
-        if (!(0, model_1.isSourceDef)(source)) {
+        if (source === undefined || !(0, model_1.isSourceDef)(source)) {
             throw new Error('Invalid source for query');
         }
         return source.dialect;
@@ -1221,7 +1226,7 @@ class PreparedResult {
     }
     get sourceExplore() {
         const name = this.inner.sourceExplore;
-        const explore = this.modelDef.contents[name];
+        const explore = (0, model_1.safeRecordGet)(this.modelDef.contents, name);
         if (explore && (0, model_1.isSourceDef)(explore)) {
             return new Explore(explore);
         }

package/dist/api/foundation/runtime.js

@@ -572,7 +572,7 @@ class QueryMaterializer extends FluentState {
                 }
                 const plan = preparedQuery.model.getBuildPlan();
                 const connectionNames = new Set(Object.values(plan.sources).map(s => s.connectionName));
-                connectionDigests = {};
+                connectionDigests = (0, model_1.mkSafeRecord)();
                 for (const connName of connectionNames) {
                     const conn = await this.runtime.connections.lookupConnection(connName);
                     connectionDigests[connName] = conn.getDigest();

package/dist/dialect/snowflake/snowflake.js

@@ -515,12 +515,12 @@ ${(0, utils_1.indent)(sql)}
         return sqlType.match(/^[A-Za-z\s(),[\]0-9]*$/) !== null;
     }
     sqlLiteralRecord(lit) {
-        var _a, _b;
+        var _a, _b, _c;
         const rowVals = [];
         for (const f of lit.typeDef.fields) {
             const name = (_a = f.as) !== null && _a !== void 0 ? _a : f.name;
             const propName = `'${name}'`;
-            const propVal = (_b = lit.kids[name].sql) !== null && _b !== void 0 ? _b : 'internal-error-record-literal';
+            const propVal = (_c = (_b = (0, malloy_types_1.safeRecordGet)(lit.kids, name)) === null || _b === void 0 ? void 0 : _b.sql) !== null && _c !== void 0 ? _c : 'internal-error-record-literal';
             rowVals.push(`${propName},${propVal}`);
         }
         return `OBJECT_CONSTRUCT_KEEP_NULL(${rowVals.join(',')})`;

package/dist/dialect/trino/trino.js

@@ -594,13 +594,13 @@ ${(0, utils_1.indent)(sql)}
         return from.units === 'day_of_week' ? `mod(${extracted}+1,7)` : extracted;
     }
     sqlLiteralRecord(lit) {
-        var _a, _b;
+        var _a, _b, _c;
         const rowVals = [];
         const rowTypes = [];
         for (const f of lit.typeDef.fields) {
             if ((0, malloy_types_1.isAtomic)(f)) {
                 const name = (_a = f.as) !== null && _a !== void 0 ? _a : f.name;
-                rowVals.push((_b = lit.kids[name].sql) !== null && _b !== void 0 ? _b : 'internal-error-record-literal');
+                rowVals.push((_c = (_b = (0, malloy_types_1.safeRecordGet)(lit.kids, name)) === null || _b === void 0 ? void 0 : _b.sql) !== null && _c !== void 0 ? _c : 'internal-error-record-literal');
                 const elType = this.malloyTypeToSQLType(f);
                 rowTypes.push(`${this.sqlMaybeQuoteIdentifier(name)} ${elType}`);
             }

package/dist/lang/ast/field-space/dynamic-space.js

@@ -57,6 +57,7 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DynamicSpace = void 0;
 const model = __importStar(require("../../../model/malloy_types"));
+const malloy_types_1 = require("../../../model/malloy_types");
 const field_utils_1 = require("../../field-utils");
 const error_factory_1 = require("../error-factory");
 const space_field_1 = require("../types/space-field");
@@ -116,7 +117,7 @@ class DynamicSpace extends static_space_1.StaticSpace {
         if (this.sourceDef === undefined) {
             // Grab all the parameters so that we can populate the "final" structDef
             // with parameters immediately so that views can see them when they are translating
-            const parameters = {};
+            const parameters = (0, malloy_types_1.mkSafeRecord)();
             for (const [name, entry] of this.entries()) {
                 if (entry instanceof space_param_1.SpaceParam) {
                     parameters[name] = entry.parameter();

package/dist/lang/ast/field-space/index-field-space.js

@@ -76,7 +76,7 @@ class IndexFieldSpace extends query_spaces_1.QueryOperationSpace {
         for (const [name, field] of this.entries()) {
             if (field instanceof space_field_1.SpaceField) {
                 let nextFieldUsage = undefined;
-                const wild = this.expandedWild[name];
+                const wild = this.expandedWild.get(name);
                 if (wild) {
                     indexFields.push({ type: 'fieldref', path: wild.path, at: wild.at });
                     fieldUsage.push({ path: wild.path });
@@ -104,7 +104,7 @@ class IndexFieldSpace extends query_spaces_1.QueryOperationSpace {
     }
     addRefineFromFields(_refineThis) { }
     addWild(wild) {
-        var _a;
+        var _a, _b;
         let current = this.exprSpace;
         const joinPath = [];
         if (wild.joinPath) {
@@ -142,7 +142,7 @@ class IndexFieldSpace extends query_spaces_1.QueryOperationSpace {
                 name,
             ]);
             if (this.entry(indexName)) {
-                const conflict = (_a = this.expandedWild[indexName].path) === null || _a === void 0 ? void 0 : _a.join('.');
+                const conflict = (_b = (_a = this.expandedWild.get(indexName)) === null || _a === void 0 ? void 0 : _a.path) === null || _b === void 0 ? void 0 : _b.join('.');
                 wild.logError('name-conflict-in-wildcard-expansion', `Cannot expand '${name}' in '${wild.refString}' because a field with that name already exists${conflict ? ` (conflicts with ${conflict})` : ''}`);
             }
             else {
@@ -152,11 +152,11 @@ class IndexFieldSpace extends query_spaces_1.QueryOperationSpace {
                     (0, malloy_types_1.expressionIsScalar)(eTypeDesc.expressionType) &&
                     (dialect === undefined || !dialect.ignoreInProject(name))) {
                     expandEntries.push({ name: indexName, entry });
-                    this.expandedWild[indexName] = {
+                    this.expandedWild.set(indexName, {
                         path: joinPath.concat(name),
                         entry,
                         at: wild.location,
-                    };
+                    });
                 }
             }
         }

package/dist/lang/ast/field-space/parameter-space.js

@@ -11,9 +11,9 @@ const space_param_1 = require("../types/space-param");
 class ParameterSpace {
     constructor(parameters) {
         this.type = 'fieldSpace';
-        this._map = {};
+        this._map = new Map();
         for (const parameter of parameters) {
-            this._map[parameter.name] = new space_param_1.AbstractParameter(parameter);
+            this._map.set(parameter.name, new space_param_1.AbstractParameter(parameter));
         }
     }
     structDef() {
@@ -23,7 +23,7 @@ class ParameterSpace {
         throw new Error('Parameter space does not have an emptyStructDef');
     }
     entry(name) {
-        return this._map[name];
+        return this._map.get(name);
     }
     lookup(symbol) {
         const name = symbol[0];
@@ -65,7 +65,7 @@ class ParameterSpace {
         };
     }
     entries() {
-        return Object.entries(this._map);
+        return [...this._map.entries()];
     }
     dialectName() {
         return '~parameter-space-unknown-dialect~';

package/dist/lang/ast/field-space/query-spaces.d.ts

@@ -24,7 +24,7 @@ export declare abstract class QueryOperationSpace extends RefinedSpace implement
     readonly astEl: MalloyElement;
     protected exprSpace: QueryInputSpace;
     abstract readonly segmentType: 'reduce' | 'project' | 'index';
-    expandedWild: Record<string, {
+    expandedWild: Map<string, {
         path: string[];
         entry: SpaceEntry;
         at: model.DocumentLocation;

package/dist/lang/ast/field-space/query-spaces.js

@@ -85,7 +85,7 @@ class QueryOperationSpace extends refined_space_1.RefinedSpace {
         super(queryInputSpace.emptyStructDef());
         this.nestParent = nestParent;
         this.astEl = astEl;
-        this.expandedWild = {};
+        this.expandedWild = new Map();
         this.drillDimensions = [];
         this.compositeFieldUsers = [];
         // Composite field usage is not computed until `queryFieldDefs` is called
@@ -149,7 +149,7 @@ class QueryOperationSpace extends refined_space_1.RefinedSpace {
                 continue;
             }
             if (this.entry(name)) {
-                const conflict = (_a = this.expandedWild[name]) === null || _a === void 0 ? void 0 : _a.path.join('.');
+                const conflict = (_a = this.expandedWild.get(name)) === null || _a === void 0 ? void 0 : _a.path.join('.');
                 wild.logError('name-conflict-in-wildcard-expansion', `Cannot expand '${name}' in '${wild.refString}' because a field with that name already exists${conflict ? ` (conflicts with ${conflict})` : ''}`);
             }
             else {
@@ -158,11 +158,11 @@ class QueryOperationSpace extends refined_space_1.RefinedSpace {
                     model.expressionIsScalar(eType.expressionType) &&
                     (dialect === undefined || !dialect.ignoreInProject(name))) {
                     expandEntries.push({ name, entry });
-                    this.expandedWild[name] = {
+                    this.expandedWild.set(name, {
                         path: joinPath.concat(name),
                         entry,
                         at: wild.location,
-                    };
+                    });
                 }
             }
         }
@@ -348,7 +348,7 @@ class QuerySpace extends QueryOperationSpace {
             }
             else {
                 const { name, field } = user;
-                const wildPath = this.expandedWild[name];
+                const wildPath = this.expandedWild.get(name);
                 if (wildPath) {
                     const typeDesc = wildPath.entry.typeDesc();
                     fields.push({

package/dist/lang/ast/field-space/static-space.js

@@ -62,16 +62,16 @@ class StaticSpace {
     }
     get map() {
         if (this.memoMap === undefined) {
-            this.memoMap = {};
+            this.memoMap = new Map();
             for (const f of this.fromStruct.fields) {
                 const name = f.as || f.name;
-                this.memoMap[name] = this.defToSpaceField(f);
+                this.memoMap.set(name, this.defToSpaceField(f));
             }
             if ((0, malloy_types_1.isSourceDef)(this.fromStruct)) {
                 if (this.fromStruct.parameters) {
                     for (const [paramName, paramDef] of Object.entries(this.fromStruct.parameters)) {
-                        if (!(paramName in this.memoMap)) {
-                            this.memoMap[paramName] = new space_param_1.DefinedParameter(paramDef);
+                        if (!this.memoMap.has(paramName)) {
+                            this.memoMap.set(paramName, new space_param_1.DefinedParameter(paramDef));
                         }
                     }
                 }
@@ -83,20 +83,20 @@ class StaticSpace {
         return 'internal';
     }
     dropEntries() {
-        this.memoMap = {};
+        this.memoMap = new Map();
     }
     dropEntry(name) {
-        delete this.map[name];
+        this.map.delete(name);
     }
     // TODO this was protected
     entry(name) {
-        return this.map[name];
+        return this.map.get(name);
     }
     setEntry(name, value) {
-        this.map[name] = value;
+        this.map.set(name, value);
     }
     entries() {
-        return Object.entries(this.map);
+        return [...this.map.entries()];
     }
     structDef() {
         return this.fromStruct;
@@ -104,7 +104,7 @@ class StaticSpace {
     emptyStructDef() {
         const ret = { ...this.fromStruct };
         if ((0, malloy_types_1.isSourceDef)(ret)) {
-            ret.parameters = {};
+            ret.parameters = (0, malloy_types_1.mkSafeRecord)();
         }
         ret.fields = [];
         return ret;

package/dist/lang/ast/source-elements/named-source.js

@@ -117,7 +117,7 @@ class NamedSource extends source_1.Source {
     }
     evaluateArguments(parameterSpace, parametersIn, parametersOut) {
         var _a, _b, _c;
-        const outArguments = { ...this.sourceArguments };
+        const outArguments = Object.assign((0, malloy_types_1.mkSafeRecord)(), this.sourceArguments);
         const passedNames = new Set();
         for (const argument of (_a = this.args) !== null && _a !== void 0 ? _a : []) {
             const id = (_b = argument.id) !== null && _b !== void 0 ? _b : (argument.value instanceof expr_id_reference_1.ExprIdReference
@@ -133,7 +133,9 @@ class NamedSource extends source_1.Source {
                 continue;
             }
             passedNames.add(name);
-            const parameter = (parametersIn !== null && parametersIn !== void 0 ? parametersIn : {})[name];
+            const parameter = parametersIn
+                ? (0, malloy_types_1.safeRecordGet)(parametersIn, name)
+                : undefined;
             if (!parameter) {
                 id.logError('source-parameter-not-found', `\`${this.refName}\` has no declared parameter named \`${id.refString}\``);
             }
@@ -200,7 +202,7 @@ class NamedSource extends source_1.Source {
             notFound.dialect = notFound.dialect + err;
             return notFound;
         }
-        const outParameters = {};
+        const outParameters = (0, malloy_types_1.mkSafeRecord)();
         for (const parameter of pList !== null && pList !== void 0 ? pList : []) {
             const compiled = parameter.parameter();
             outParameters[compiled.name] = compiled;
@@ -208,8 +210,10 @@ class NamedSource extends source_1.Source {
         const outArguments = this.evaluateArguments(parameterSpace, base.parameters, pList);
         for (const paramName in base.parameters) {
             if (!(paramName in outArguments) &&
-                (0, malloy_types_1.paramHasValue)(base.parameters[paramName])) {
-                outArguments[paramName] = { ...base.parameters[paramName] };
+                (0, malloy_types_1.paramHasValue)((0, malloy_types_1.safeRecordGet)(base.parameters, paramName))) {
+                outArguments[paramName] = {
+                    ...(0, malloy_types_1.safeRecordGet)(base.parameters, paramName),
+                };
             }
         }
         const ret = { ...base, parameters: outParameters, arguments: outArguments };

package/dist/lang/ast/source-elements/source.js

@@ -23,6 +23,7 @@
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Source = void 0;
+const malloy_types_1 = require("../../../model/malloy_types");
 const malloy_element_1 = require("../types/malloy-element");
 /**
  * A "Source" is a thing which you can run queries against. The main
@@ -37,7 +38,7 @@ class Source extends malloy_element_1.MalloyElement {
     packParameters(pList) {
         if (pList === undefined)
             return undefined;
-        const parameters = {};
+        const parameters = (0, malloy_types_1.mkSafeRecord)();
         for (const hasP of pList) {
             const pVal = hasP.parameter();
             parameters[pVal.name] = pVal;

package/dist/lang/ast/statements/import-statement.js

@@ -102,7 +102,7 @@ class ImportStatement extends malloy_element_1.ListOf {
                     for (const importOne of this.list) {
                         const dstName = importOne.text;
                         const srcName = importOne.from ? importOne.from.text : dstName;
-                        if (importedModel.contents[srcName] === undefined) {
+                        if ((0, malloy_types_1.safeRecordGet)(importedModel.contents, srcName) === undefined) {
                             importOne.logError('selective-import-not-found', `Cannot find '${srcName}', not imported`);
                         }
                         else if (doc.getEntry(dstName)) {
@@ -117,7 +117,9 @@ class ImportStatement extends malloy_element_1.ListOf {
                         const picked = explicitImport[srcName];
                         const dstName = picked || srcName;
                         if (importAll || picked) {
-                            const importMe = { ...importedModel.contents[srcName] };
+                            const importMe = {
+                                ...(0, malloy_types_1.safeRecordGet)(importedModel.contents, srcName),
+                            };
                             importMe.as = dstName;
                             doc.setEntry(dstName, { entry: importMe, exported: false });
                             // Collect dependencies for persistable sources
@@ -136,7 +138,7 @@ class ImportStatement extends malloy_element_1.ListOf {
                                 // (parent can't resolve by name since it's not in namespace)
                                 let entry = value.entry;
                                 if ((0, malloy_types_1.isSourceRegistryReference)(entry)) {
-                                    const resolved = importedModel.contents[entry.name];
+                                    const resolved = (0, malloy_types_1.safeRecordGet)(importedModel.contents, entry.name);
                                     if (resolved &&
                                         (0, malloy_types_1.isSourceDef)(resolved) &&
                                         (0, malloy_types_1.isPersistableSourceDef)(resolved)) {

package/dist/lang/ast/types/malloy-element.d.ts

@@ -120,7 +120,7 @@ export declare class DocStatementList extends ListOf<DocStatement | DocStatement
 export declare class Document extends MalloyElement implements NameSpace {
     elementType: string;
     globalNameSpace: NameSpace;
-    documentModel: Record<string, ModelEntry>;
+    documentModel: Map<string, ModelEntry>;
     documentSrcRegistry: Record<SourceID, SourceRegistryValue>;
     queryList: Query[];
     statements: DocStatementList;
@@ -136,7 +136,7 @@ export declare class Document extends MalloyElement implements NameSpace {
     hasAnnotation(): boolean;
     currentModelAnnotation(): ModelAnnotation | undefined;
     modelDef(): ModelDef;
-    getEntry(str: string): ModelEntry;
+    getEntry(str: string): ModelEntry | undefined;
     setEntry(str: string, ent: ModelEntry): void;
     /**
      * Return an error message if this dialect is the first reference to this particular

package/dist/lang/ast/types/malloy-element.js

@@ -437,7 +437,7 @@ class Document extends MalloyElement {
         super();
         this.elementType = 'document';
         this.globalNameSpace = new global_name_space_1.GlobalNameSpace();
-        this.documentModel = {};
+        this.documentModel = new Map();
         this.documentSrcRegistry = {};
         this.queryList = [];
         this.didInitModel = false;
@@ -453,7 +453,7 @@ class Document extends MalloyElement {
         if (this.didInitModel) {
             return;
         }
-        this.documentModel = {};
+        this.documentModel = new Map();
         this.documentSrcRegistry = {};
         this.queryList = [];
         if (extendingModelDef) {
@@ -516,17 +516,17 @@ class Document extends MalloyElement {
         if (this.hasAnnotation()) {
             def.annotation = this.currentModelAnnotation();
         }
-        for (const entry in this.documentModel) {
-            const entryDef = this.documentModel[entry].entry;
+        for (const [name, modelEntry] of this.documentModel) {
+            const entryDef = modelEntry.entry;
             if ((0, malloy_types_1.isSourceDef)(entryDef) || entryDef.type === 'query') {
-                if (this.documentModel[entry].exported) {
-                    def.exports.push(entry);
+                if (modelEntry.exported) {
+                    def.exports.push(name);
                 }
                 const newEntry = { ...entryDef };
                 if (newEntry.modelAnnotation === undefined && def.annotation) {
                     newEntry.modelAnnotation = def.annotation;
                 }
-                def.contents[entry] = newEntry;
+                def.contents[name] = newEntry;
             }
         }
         // Copy the accumulated sourceRegistry
@@ -535,7 +535,7 @@ class Document extends MalloyElement {
     }
     getEntry(str) {
         var _a;
-        return (_a = this.globalNameSpace.getEntry(str)) !== null && _a !== void 0 ? _a : this.documentModel[str];
+        return (_a = this.globalNameSpace.getEntry(str)) !== null && _a !== void 0 ? _a : this.documentModel.get(str);
     }
     setEntry(str, ent) {
         // TODO this error message is going to be in the wrong place everywhere...
@@ -549,7 +549,7 @@ class Document extends MalloyElement {
         if (this.didInitModel) {
             this.modelWasModified = true;
         }
-        this.documentModel[str] = ent;
+        this.documentModel.set(str, ent);
         // Maintain sourceRegistry for persistable sources with sourceID
         if ((0, malloy_types_1.isSourceDef)(ent.entry) &&
             (0, malloy_types_1.isPersistableSourceDef)(ent.entry) &&

package/dist/model/expression_compiler.js

@@ -255,8 +255,8 @@ function generateAppliedFilter(context, filterMatchExpr, qi) {
     if (filterExpr.node === 'parameter') {
         const name = filterExpr.path[0];
         (_a = context.eventStream) === null || _a === void 0 ? void 0 : _a.emit('source-argument-compiled', { name });
-        const argument = context.arguments()[name];
-        if (argument.value) {
+        const argument = (0, malloy_types_1.safeRecordGet)(context.arguments(), name);
+        if (argument === null || argument === void 0 ? void 0 : argument.value) {
             filterExpr = argument.value;
         }
         else {
@@ -574,8 +574,8 @@ function generateParameterFragment(resultSet, context, expr, state) {
     var _a;
     const name = expr.path[0];
     (_a = context.eventStream) === null || _a === void 0 ? void 0 : _a.emit('source-argument-compiled', { name });
-    const argument = context.arguments()[name];
-    if (argument.value) {
+    const argument = (0, malloy_types_1.safeRecordGet)(context.arguments(), name);
+    if (argument === null || argument === void 0 ? void 0 : argument.value) {
         return exprToSQL(resultSet, context, argument.value, state);
     }
     throw new Error(`Can't generate SQL, no value for ${expr.path}`);

package/dist/model/malloy_types.d.ts

@@ -1,5 +1,16 @@
 import type * as Malloy from '@malloydata/malloy-interfaces';
 import type { EventStream } from '../runtime_types';
+/**
+ * A Record<string, V> used as a string-keyed map in serializable IR types.
+ * Direct bracket access (record[key]) is UNSAFE because Object.prototype
+ * property names like 'constructor', 'toString', 'valueOf' return inherited
+ * functions instead of undefined. Use safeRecordGet() to read entries.
+ */
+export type SafeRecord<V> = Record<string, V>;
+/** Safely read from a SafeRecord. Returns undefined for non-own properties. */
+export declare function safeRecordGet<V>(record: SafeRecord<V>, key: string): V | undefined;
+/** Create an empty null-prototype SafeRecord (immune to prototype pollution). */
+export declare function mkSafeRecord<V>(): SafeRecord<V>;
 /**
  * Field computations are compiled into an expression tree of "Expr"
  * type nodes. Each node is one of these three interfaces. The
@@ -229,7 +240,7 @@ export interface BooleanLiteralNode extends ExprLeaf {
 }
 export interface RecordLiteralNode extends ExprWithKids {
     node: 'recordLiteral';
-    kids: Record<string, Expr>;
+    kids: SafeRecord<Expr>;
     typeDef: RecordTypeDef;
 }
 export interface ArrayLiteralNode extends ExprWithKids {
@@ -561,7 +572,7 @@ export type StructRef = string | SourceDef;
 export declare function refIsStructDef(ref: StructRef): ref is SourceDef;
 export type InvokedStructRef = {
     structRef: StructRef;
-    sourceArguments?: Record<string, Argument>;
+    sourceArguments?: SafeRecord<Argument>;
 };
 export interface Filtered {
     filterList?: FilterCondition[];
@@ -579,7 +590,7 @@ export interface Query extends Pipeline, Filtered, HasLocation {
     type?: 'query';
     name?: string;
     structRef: StructRef;
-    sourceArguments?: Record<string, Argument>;
+    sourceArguments?: SafeRecord<Argument>;
     annotation?: Annotation;
     modelAnnotation?: Annotation;
     compositeResolvedSourceDef?: SourceDef;
@@ -699,8 +710,8 @@ export interface PartitionCompositeDesc {
     compositeFields: string[];
 }
 interface SourceDefBase extends StructDefBase, Filtered, ResultStructMetadata {
-    arguments?: Record<string, Argument>;
-    parameters?: Record<string, Parameter>;
+    arguments?: SafeRecord<Argument>;
+    parameters?: SafeRecord<Parameter>;
     queryTimezone?: string;
     connection: string;
     primaryKey?: PrimaryKeyRef;
@@ -950,7 +961,7 @@ export interface DependencyTree {
 export interface ModelDef {
     name: string;
     exports: string[];
-    contents: Record<string, NamedModelObject>;
+    contents: SafeRecord<NamedModelObject>;
     /**
      * Registry mapping sourceID to source definitions for build graph construction.
      * For sources in namespace: maps to SourceRegistryReference (look up in contents)
@@ -965,8 +976,8 @@ export interface ModelDef {
     imports?: ImportLocation[];
 }
 /** Very common record type */
-export type NamedSourceDefs = Record<string, SourceDef>;
-export type NamedModelObjects = Record<string, NamedModelObject>;
+export type NamedSourceDefs = SafeRecord<SourceDef>;
+export type NamedModelObjects = SafeRecord<NamedModelObject>;
 /** Malloy source annotations attached to objects */
 export interface Annotation {
     inherits?: Annotation;
@@ -1006,7 +1017,7 @@ export type MalloyQueryData = {
 export interface DrillSource {
     sourceExplore: string;
     sourceFilters?: FilterCondition[];
-    sourceArguments?: Record<string, Argument>;
+    sourceArguments?: SafeRecord<Argument>;
 }
 export interface CompiledQuery extends DrillSource {
     structs: SourceDef[];
@@ -1065,7 +1076,7 @@ export interface PrepareResultOptions {
     /** Manifest of built tables (BuildID → entry), the build cache */
     buildManifest?: BuildManifest;
     /** Map from connectionName to connectionDigest (from Connection.getDigest()) */
-    connectionDigests?: Record<string, string>;
+    connectionDigests?: SafeRecord<string>;
     /** If true, throw when a persist query's digest is not in the manifest */
     strictPersist?: boolean;
 }

package/dist/model/malloy_types.js

@@ -24,6 +24,8 @@
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.TD = exports.ValueType = void 0;
+exports.safeRecordGet = safeRecordGet;
+exports.mkSafeRecord = mkSafeRecord;
 exports.exprHasKids = exprHasKids;
 exports.exprHasE = exprHasE;
 exports.exprIsLeaf = exprIsLeaf;
@@ -96,6 +98,15 @@ exports.isValueBoolean = isValueBoolean;
 exports.isValueTimestamp = isValueTimestamp;
 exports.isValueDate = isValueDate;
 exports.mergeUniqueKeyRequirement = mergeUniqueKeyRequirement;
+const hasOwn = Object.prototype.hasOwnProperty;
+/** Safely read from a SafeRecord. Returns undefined for non-own properties. */
+function safeRecordGet(record, key) {
+    return hasOwn.call(record, key) ? record[key] : undefined;
+}
+/** Create an empty null-prototype SafeRecord (immune to prototype pollution). */
+function mkSafeRecord() {
+    return Object.create(null);
+}
 function exprHasKids(e) {
     return 'kids' in e;
 }

package/dist/model/persist_utils.js

@@ -13,7 +13,7 @@ const annotation_1 = require("../annotation");
  * Resolve a source name to its definition from model contents.
  */
 function resolveSource(modelDef, name) {
-    const obj = modelDef.contents[name];
+    const obj = (0, malloy_types_1.safeRecordGet)(modelDef.contents, name);
     return obj && (0, malloy_types_1.isSourceDef)(obj) ? obj : undefined;
 }
 /**

package/dist/model/query_query.js

@@ -537,7 +537,7 @@ class QueryQuery extends query_node_1.QueryField {
                 const { buildManifest, connectionDigests, strictPersist } = (_b = qs.prepareResultOptions) !== null && _b !== void 0 ? _b : {};
                 // Check manifest for this source
                 if (buildManifest && connectionDigests) {
-                    const connDigest = connectionDigests[qs.structDef.connection];
+                    const connDigest = (0, malloy_types_1.safeRecordGet)(connectionDigests, qs.structDef.connection);
                     if (connDigest) {
                         // Compile with empty opts to get manifest-ignorant SQL for BuildID
                         const fullRet = this.compileQueryToStages(qs.structDef.query, {}, undefined, false);

package/dist/model/source_def_utils.js

@@ -127,7 +127,7 @@ function resolveSourceID(modelDef, sourceID) {
     if (!value)
         return undefined;
     if ((0, malloy_types_1.isSourceRegistryReference)(value.entry)) {
-        const obj = modelDef.contents[value.entry.name];
+        const obj = (0, malloy_types_1.safeRecordGet)(modelDef.contents, value.entry.name);
         return obj && (0, malloy_types_1.isSourceDef)(obj) && (0, malloy_types_1.isPersistableSourceDef)(obj)
             ? obj
             : undefined;

package/dist/model/sql_compiled.js

@@ -54,7 +54,7 @@ function expandPersistableSource(source, opts, quoteTablePath, compileQuery) {
     const { buildManifest, connectionDigests, strictPersist } = opts;
     // Try manifest lookup if we have the required info
     if (buildManifest && connectionDigests) {
-        const connDigest = connectionDigests[source.connection];
+        const connDigest = (0, malloy_types_1.safeRecordGet)(connectionDigests, source.connection);
         if (connDigest) {
             // Get the SQL for this source to compute BuildID (no opts = full SQL)
             const sql = getSourceSQL(source, quoteTablePath, compileQuery);

package/dist/model/utils.js

@@ -293,7 +293,7 @@ function mkModelDef(name) {
     return {
         name,
         exports: [],
-        contents: {},
+        contents: (0, malloy_types_1.mkSafeRecord)(),
         sourceRegistry: {},
         queryList: [],
         dependencies: {},

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const MALLOY_VERSION = "0.0.343";
+export declare const MALLOY_VERSION = "0.0.344";

package/dist/version.js

@@ -2,5 +2,5 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.MALLOY_VERSION = void 0;
 // generated with 'generate-version-file' script; do not edit manually
-exports.MALLOY_VERSION = '0.0.343';
+exports.MALLOY_VERSION = '0.0.344';
 //# sourceMappingURL=version.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@malloydata/malloy",
-  "version": "0.0.343",
+  "version": "0.0.344",
   "license": "MIT",
   "exports": {
     ".": "./dist/index.js",
@@ -45,9 +45,9 @@
     "generate-version-file": "VERSION=$(npm pkg get version --workspaces=false | tr -d \\\")\necho \"// generated with 'generate-version-file' script; do not edit manually\\nexport const MALLOY_VERSION = '$VERSION';\" > src/version.ts"
   },
   "dependencies": {
-    "@malloydata/malloy-filter": "0.0.343",
-    "@malloydata/malloy-interfaces": "0.0.343",
-    "@malloydata/malloy-tag": "0.0.343",
+    "@malloydata/malloy-filter": "0.0.344",
+    "@malloydata/malloy-interfaces": "0.0.344",
+    "@malloydata/malloy-tag": "0.0.344",
     "@noble/hashes": "^1.8.0",
     "antlr4ts": "^0.5.0-alpha.4",
     "assert": "^2.0.0",

package/CONTEXT.md

@@ -1,58 +0,0 @@
-# Malloy Core Package
-
-The `malloy` package is the heart of the Malloy language implementation. It contains the compiler, translator, and runtime system that powers Malloy's semantic modeling and query capabilities.
-
-## Package Structure
-
-```
-packages/malloy/
-├── src/
-│   ├── lang/              # Translator: Parse tree → AST → IR (see src/lang/CONTEXT.md)
-│   ├── model/             # Compiler: IR → SQL (see src/model/CONTEXT.md)
-│   ├── dialect/           # Database-specific SQL generation
-│   ├── api/               # API layers (see src/api/CONTEXT.md)
-│   │   └── foundation/    # Public API classes (see MALLOY_API.md)
-│   └── connection/        # Database connection abstractions
-```
-
-## Two-Phase Architecture
-
-The Malloy compilation process is split into two distinct phases:
-
-### Phase 1: Translation (src/lang/)
-The translator takes Malloy source code and transforms it into an Intermediate Representation (IR).
-
-**Process:**
-1. ANTLR parser generates parse tree from source code
-2. Parse tree is transformed into Abstract Syntax Tree (AST)
-3. AST is analyzed and transformed into IR
-
-**Key characteristics:**
-- IR is a **serializable data format** (plain objects, not class instances)
-- IR fully describes the semantic model independent of SQL
-- IR can be cached, transmitted, and reused across compilations
-
-For detailed information about the translator, see [src/lang/CONTEXT.md](src/lang/CONTEXT.md).
-
-### Phase 2: Compilation (src/model/)
-The compiler takes IR and generates SQL queries for specific database dialects.
-
-**Process:**
-1. IR is read and analyzed
-2. Query operations are transformed into SQL expressions
-3. Dialect-specific SQL is generated
-4. Metadata is generated for result processing
-
-**Key characteristics:**
-- Produces SQL that can be executed on target database
-- Includes metadata to interpret and render results
-- Dialect-agnostic until final SQL generation step
-
-For detailed information about the compiler, see [src/model/CONTEXT.md](src/model/CONTEXT.md).
-
-## Subsystem Context
-
-For deeper details on specific subsystems:
-- [MALLOY_API.md](MALLOY_API.md) - Public API classes (Model, PreparedQuery, Runtime, Materializers)
-- [src/lang/CONTEXT.md](src/lang/CONTEXT.md) - Translator architecture (grammar, AST, IR generation)
-- [src/model/CONTEXT.md](src/model/CONTEXT.md) - Compiler architecture (SQL generation, expression compilation)

package/MALLOY_API.md

@@ -1,129 +0,0 @@
-# Foundation API - Public API Classes
-
-The directory `src/api/foundation/` is the main public API surface for the Malloy package. It exports classes that wrap internal IR types and provide user-facing functionality. See `src/api/CONTEXT.md` for a complete overview of all API layers.
-
-## Core Data Classes
-
-### `Model`
-Wraps `ModelDef` (internal IR). Represents a compiled Malloy model.
-
-- `explores: Explore[]` - All sources in the model (wrapped)
-- `getPreparedQueryByName(name): PreparedQuery`
-- `getPreparedQueryByIndex(index): PreparedQuery`
-- `getExploreByName(name): Explore`
-- `_modelDef` - Escape hatch to raw IR
-
-### `PreparedQuery`
-Wraps `Query` (internal IR) + `ModelDef`. A query that can be compiled to SQL.
-
-- `getPreparedResult(options?): PreparedResult` - Compile to SQL
-- `dialect: string`
-- `name?: string`
-- `_query`, `_modelDef` - Escape hatches
-
-**Issue:** Each `getPreparedResult()` call creates a new `QueryModel`, reprocessing the ModelDef.
-
-### `PreparedResult`
-Wraps `CompiledQuery` (internal). The compiled SQL and metadata.
-
-- `sql: string` - The generated SQL
-- `connectionName: string` - Which connection to run against
-- `resultExplore: Explore` - Schema of the result
-
-### `Result`
-Extends `PreparedResult`. Adds actual query result data.
-
-- `data: DataArray` - The result rows
-- `totalRows: number`
-- `runStats: QueryRunStats`
-
-### `Explore`
-Wraps `StructDef` (internal). Represents a source (historical name was "explore").
-
-- `name: string`
-- `allFields: Field[]`
-- `getFieldByName(name): Field`
-- `getQueryByName(name): PreparedQuery` - Get a view as a query
-
-### `ExploreField`
-Extends `Explore`. A joined source (appears as a field in parent).
-
-### `Query`
-Wraps `TurtleDef`. Represents a view definition. **Different from `PreparedQuery`.**
-
-### `QueryField`
-Extends `Query`. A view that appears as a field in an explore.
-
-### `AtomicField` and subclasses
-Field wrappers: `StringField`, `NumberField`, `DateField`, `TimestampField`, `BooleanField`, `JSONField`, `UnsupportedField`
-
-## Runtime & Materializer Classes
-
-### `Runtime`
-Entry point for loading and running Malloy. Holds URLReader, connections, event stream.
-
-- `loadModel(source): ModelMaterializer`
-- `loadQuery(query): QueryMaterializer`
-- `getModel(source): Promise<Model>`
-- `getQuery(query): Promise<PreparedQuery>`
-
-### `SingleConnectionRuntime`
-Extends `Runtime`. For single-connection use cases.
-
-### `ConnectionRuntime`
-Extends `Runtime`. Holds array of connections.
-
-### `ModelMaterializer`
-Fluent builder for loading models. Returned by `runtime.loadModel()`.
-
-- `getModel(): Promise<Model>`
-- `loadQueryByName(name): QueryMaterializer`
-- `loadExploreByName(name): ExploreMaterializer`
-- `extendModel(source): ModelMaterializer`
-
-### `QueryMaterializer`
-Fluent builder for queries. Returned by `modelMaterializer.loadQueryByName()`.
-
-- `getPreparedQuery(): Promise<PreparedQuery>`
-- `getPreparedResult(): Promise<PreparedResult>`
-- `getSQL(): Promise<string>`
-- `run(options?): Promise<Result>`
-
-### `PreparedResultMaterializer`
-Fluent builder for prepared results.
-
-### `ExploreMaterializer`
-Fluent builder for explores/sources.
-
-## Result Data Classes
-
-### `DataArray`
-Iterable array of `DataRecord`. Query result rows.
-
-### `DataRecord`
-Single result row. Field values accessed by name.
-
-## Utility Classes
-
-- `Parse` - Parsed (not compiled) Malloy document
-- `Malloy` - Static methods: `parse()`, `compile()`, `run()`
-- `MalloyError` - Error with structured problems
-- `EmptyURLReader`, `InMemoryURLReader` - URLReader implementations
-- `FixedConnectionMap` - LookupConnection implementation
-- `CacheManager`, `InMemoryModelCache` - Caching
-- `JSONWriter`, `CSVWriter` - Result writers
-- `DocumentSymbol`, `DocumentPosition`, `DocumentRange`, etc. - IDE support
-
-## Naming Issues
-
-| Current Name | What It Actually Is |
-|--------------|---------------------|
-| `Explore` | A source (historical name) |
-| `PreparedQuery` | Uncompiled query holding IR |
-| `PreparedResult` | Compiled query with SQL (not a "result") |
-| `Query` | A view/turtle definition |
-
-## Known Architectural Issues
-
-1. **Transient QueryModel**: `PreparedQuery.getPreparedResult()` creates new `QueryModel` each call - expensive.
-3. **Name collision**: `Query` class (view wrapper) vs internal `Query` type vs `PreparedQuery`