@malloydata/malloy 0.0.182-dev240911142514 → 0.0.182-dev240911163224

package/dist/dialect/snowflake/snowflake.js

@@ -25,9 +25,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SnowflakeDialect = void 0;
 const utils_1 = require("../../model/utils");
 const malloy_types_1 = require("../../model/malloy_types");
-const functions_1 = require("./functions");
+const functions_1 = require("../functions");
 const dialect_1 = require("../dialect");
-const dialect_functions_1 = require("./functions/dialect_functions");
+const dialect_functions_1 = require("./dialect_functions");
+const function_overrides_1 = require("./function_overrides");
 const extractionMap = {
     'day_of_week': 'dayofweek',
     'day_of_year': 'dayofyear',
@@ -86,7 +87,6 @@ class SnowflakeDialect extends dialect_1.Dialect {
         this.supportsSafeCast = true;
         this.supportsNesting = true;
         this.defaultSampling = { rows: 50000 };
-        this.globalFunctions = functions_1.SNOWFLAKE_FUNCTIONS;
         // NOTE: safely setting all these to false for now
         // more many be implemented in future
         this.unnestWithNumbers = false;
@@ -366,11 +366,11 @@ ${(0, utils_1.indent)(sql)}
         const noVirgule = literal.replace(/\\/g, '\\\\');
         return "'" + noVirgule.replace(/'/g, "\\'") + "'";
     }
-    getGlobalFunctionDef(name) {
-        return functions_1.SNOWFLAKE_FUNCTIONS.get(name);
+    getDialectFunctionOverrides() {
+        return (0, functions_1.expandOverrideMap)(function_overrides_1.SNOWFLAKE_MALLOY_STANDARD_OVERLOADS);
     }
     getDialectFunctions() {
-        return dialect_functions_1.SNOWFLAKE_DIALECT_FUNCTIONS;
+        return (0, functions_1.expandBlueprintMap)(dialect_functions_1.SNOWFLAKE_DIALECT_FUNCTIONS);
     }
     malloyTypeToSQLType(malloyType) {
         if (malloyType.type === 'number') {

package/dist/dialect/standardsql/dialect_functions.d.ts

@@ -0,0 +1,2 @@
+import { DefinitionBlueprintMap } from '../functions/util';
+export declare const STANDARDSQL_DIALECT_FUNCTIONS: DefinitionBlueprintMap;

package/dist/dialect/standardsql/dialect_functions.js

@@ -0,0 +1,65 @@
+"use strict";
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.STANDARDSQL_DIALECT_FUNCTIONS = void 0;
+const date_from_unix_date = {
+    takes: { 'unix_date': 'number' },
+    returns: 'date',
+    impl: { function: 'DATE_FROM_UNIX_DATE' },
+};
+const string_agg = {
+    'default_separator': {
+        takes: { 'value': { dimension: 'string' } },
+        returns: { measure: 'string' },
+        supportsOrderBy: true,
+        supportsLimit: true,
+        impl: {
+            sql: 'STRING_AGG(${value}${order_by:}${limit:})',
+            defaultOrderByArgIndex: 0,
+        },
+    },
+    'with_separator': {
+        takes: {
+            'value': { dimension: 'string' },
+            'separator': { literal: 'string' },
+        },
+        returns: { measure: 'string' },
+        supportsOrderBy: true,
+        supportsLimit: true,
+        impl: {
+            sql: 'STRING_AGG(${value}, ${separator}${order_by:}${limit:})',
+            defaultOrderByArgIndex: 0,
+        },
+    },
+};
+const string_agg_distinct = {
+    'default_separator': {
+        ...string_agg['default_separator'],
+        isSymmetric: true,
+        supportsOrderBy: 'only_default',
+        impl: {
+            sql: 'STRING_AGG(DISTINCT ${value}${order_by:}${limit:})',
+            defaultOrderByArgIndex: 0,
+        },
+    },
+    'with_separator': {
+        ...string_agg['with_separator'],
+        isSymmetric: true,
+        supportsOrderBy: 'only_default',
+        impl: {
+            sql: 'STRING_AGG(DISTINCT ${value}, ${separator}${order_by:}${limit:})',
+            defaultOrderByArgIndex: 0,
+        },
+    },
+};
+exports.STANDARDSQL_DIALECT_FUNCTIONS = {
+    date_from_unix_date,
+    string_agg,
+    string_agg_distinct,
+};
+//# sourceMappingURL=dialect_functions.js.map

package/dist/dialect/standardsql/function_overrides.d.ts

@@ -0,0 +1,2 @@
+import { MalloyStandardFunctionImplementations as OverrideMap } from '../functions/malloy_standard_functions';
+export declare const STANDARDSQL_MALLOY_STANDARD_OVERLOADS: OverrideMap;

package/dist/dialect/standardsql/function_overrides.js

@@ -0,0 +1,17 @@
+"use strict";
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.STANDARDSQL_MALLOY_STANDARD_OVERLOADS = void 0;
+exports.STANDARDSQL_MALLOY_STANDARD_OVERLOADS = {
+    chr: {
+        sql: "CASE WHEN IFNULL(${value}, 1) = 0 THEN '' ELSE CHR(${value}) END",
+    },
+    // There's no built-in PI function, but we can compute it easily.
+    pi: { sql: 'ACOS(-1)' },
+};
+//# sourceMappingURL=function_overrides.js.map

package/dist/dialect/standardsql/standardsql.d.ts

@@ -53,7 +53,9 @@ export declare class StandardSQLDialect extends Dialect {
     sqlSampleTable(tableSQL: string, sample: Sampling | undefined): string;
     sqlLiteralString(literal: string): string;
     sqlLiteralRegexp(literal: string): string;
-    getGlobalFunctionDef(name: string): DialectFunctionOverloadDef[] | undefined;
+    getDialectFunctionOverrides(): {
+        [name: string]: DialectFunctionOverloadDef[];
+    };
     getDialectFunctions(): {
         [name: string]: DialectFunctionOverloadDef[];
     };

package/dist/dialect/standardsql/standardsql.js

@@ -25,9 +25,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.StandardSQLDialect = void 0;
 const utils_1 = require("../../model/utils");
 const malloy_types_1 = require("../../model/malloy_types");
-const functions_1 = require("./functions");
+const functions_1 = require("../functions");
 const dialect_1 = require("../dialect");
-const dialect_functions_1 = require("./functions/dialect_functions");
+const dialect_functions_1 = require("./dialect_functions");
+const function_overrides_1 = require("./function_overrides");
 // These are the units that "TIMESTAMP_ADD" "TIMESTAMP_DIFF" accept
 function timestampMeasureable(units) {
     return [
@@ -441,11 +442,11 @@ ${(0, utils_1.indent)(sql)}
         const noVirgule = literal.replace(/\\/g, '\\\\');
         return "'" + noVirgule.replace(/'/g, "\\'") + "'";
     }
-    getGlobalFunctionDef(name) {
-        return functions_1.STANDARDSQL_FUNCTIONS.get(name);
+    getDialectFunctionOverrides() {
+        return (0, functions_1.expandOverrideMap)(function_overrides_1.STANDARDSQL_MALLOY_STANDARD_OVERLOADS);
     }
     getDialectFunctions() {
-        return dialect_functions_1.STANDARDSQL_DIALECT_FUNCTIONS;
+        return (0, functions_1.expandBlueprintMap)(dialect_functions_1.STANDARDSQL_DIALECT_FUNCTIONS);
     }
     malloyTypeToSQLType(malloyType) {
         if (malloyType.type === 'number') {

package/dist/dialect/trino/dialect_functions.d.ts

@@ -0,0 +1,2 @@
+import { DefinitionBlueprintMap } from '../functions/util';
+export declare const TRINO_DIALECT_FUNCTIONS: DefinitionBlueprintMap;

package/dist/dialect/trino/dialect_functions.js

@@ -0,0 +1,63 @@
+"use strict";
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.TRINO_DIALECT_FUNCTIONS = void 0;
+const from_unixtime = {
+    takes: { 'unixtime': 'number' },
+    returns: 'timestamp',
+    impl: { function: 'FROM_UNIXTIME' },
+};
+const count_approx = {
+    takes: { 'value': { dimension: 'any' } },
+    returns: { measure: 'number' },
+    impl: { function: 'APPROX_DISTINCT' },
+};
+const string_agg = {
+    default_separator: {
+        takes: { 'value': { dimension: 'string' } },
+        returns: { measure: 'string' },
+        supportsOrderBy: true,
+        impl: {
+            sql: "ARRAY_JOIN(ARRAY_AGG(${value} ${order_by:}), ',')",
+        },
+    },
+    with_separator: {
+        takes: {
+            'value': { dimension: 'string' },
+            'separator': { literal: 'string' },
+        },
+        returns: { measure: 'string' },
+        supportsOrderBy: true,
+        impl: {
+            sql: 'ARRAY_JOIN(ARRAY_AGG(${value} ${order_by:}), ${separator})',
+        },
+    },
+};
+const string_agg_distinct = {
+    default_separator: {
+        ...string_agg['default_separator'],
+        isSymmetric: true,
+        impl: {
+            sql: "ARRAY_JOIN(ARRAY_AGG(DISTINCT ${value} ${order_by:}), ',')",
+        },
+    },
+    with_separator: {
+        ...string_agg['with_separator'],
+        isSymmetric: true,
+        impl: {
+            sql: 'ARRAY_JOIN(ARRAY_AGG(DISTINCT ${value} ${order_by:}), ${separator})',
+        },
+    },
+};
+exports.TRINO_DIALECT_FUNCTIONS = {
+    count_approx,
+    from_unixtime,
+    string_agg,
+    string_agg_distinct,
+};
+//# sourceMappingURL=dialect_functions.js.map

package/dist/dialect/trino/function_overrides.d.ts

@@ -0,0 +1,2 @@
+import { MalloyStandardFunctionImplementations as OverrideMap } from '../functions/malloy_standard_functions';
+export declare const TRINO_MALLOY_STANDARD_OVERLOADS: OverrideMap;

package/dist/dialect/trino/function_overrides.js

@@ -0,0 +1,50 @@
+"use strict";
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.TRINO_MALLOY_STANDARD_OVERLOADS = void 0;
+const util_1 = require("../functions/util");
+exports.TRINO_MALLOY_STANDARD_OVERLOADS = {
+    byte_length: { sql: '(LENGTH(CAST(${value} AS VARBINARY)))' },
+    chr: { sql: "CASE WHEN ${value} = 0 THEN '' ELSE CHR(${value}) END" },
+    ascii: { sql: "CODEPOINT(NULLIF(CAST(${value} as VARCHAR(1)),''))" },
+    unicode: { sql: "CODEPOINT(NULLIF(CAST(${value} as VARCHAR(1)),''))" },
+    concat: {
+        variadic: {
+            // Using `expr` definition because each spread argument needs to be cast
+            expr: (0, util_1.sql) `CONCAT(${(0, util_1.spread)((0, util_1.arg)('values'), 'CAST(', 'AS VARCHAR)')})`,
+        },
+    },
+    div: { sql: 'FLOOR(${dividend} / ${divisor})' },
+    ifnull: { sql: 'COALESCE(${value}, ${default})' },
+    is_inf: { sql: 'COALESCE(IS_INFINITE(${value}), false)' },
+    // Trino has it but Presto doesn't
+    // TODO only apply this override for Presto, not Trino
+    log: { sql: '(LN(${value}) / LN(${base}))' },
+    repeat: {
+        sql: "ARRAY_JOIN(REPEAT(${value}, CASE WHEN ${value} IS NOT NULL THEN ${count} END),'')",
+    },
+    reverse: {
+        sql: 'REVERSE(CAST(${value} AS VARCHAR))',
+    },
+    starts_with: { sql: 'COALESCE(STARTS_WITH(${value}, ${prefix}), false)' },
+    ends_with: {
+        sql: 'COALESCE(STARTS_WITH(REVERSE(CAST(${value} AS VARCHAR)), REVERSE(CAST(${suffix} AS VARCHAR))), false)',
+    },
+    // Trunc function doesn't exist in Trino, so we emulate it.
+    // For both overloads, we switch between CEIL and FLOOR based on the sign of the arugment
+    // For the overload with precision, we multiply by a power of 10 before rounding, then divide.
+    trunc: {
+        to_integer: {
+            sql: 'CASE WHEN ${value} < 0 THEN CEIL(${value}) ELSE FLOOR(${value}) END',
+        },
+        to_precision: {
+            sql: 'CASE WHEN ${value} < 0 THEN CEIL(${value} * POW(10, ${precision})) / POW(10, ${precision}) ELSE FLOOR(${value} * POW(10, ${precision})) / POW(10, ${precision}) END',
+        },
+    },
+};
+//# sourceMappingURL=function_overrides.js.map

package/dist/dialect/trino/trino.d.ts

@@ -58,7 +58,9 @@ export declare class TrinoDialect extends PostgresBase {
     sqlSampleTable(tableSQL: string, sample: Sampling | undefined): string;
     sqlLiteralString(literal: string): string;
     sqlLiteralRegexp(literal: string): string;
-    getGlobalFunctionDef(name: string): DialectFunctionOverloadDef[] | undefined;
+    getDialectFunctionOverrides(): {
+        [name: string]: DialectFunctionOverloadDef[];
+    };
     getDialectFunctions(): {
         [name: string]: DialectFunctionOverloadDef[];
     };

package/dist/dialect/trino/trino.js

@@ -25,10 +25,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.PrestoDialect = exports.TrinoDialect = void 0;
 const utils_1 = require("../../model/utils");
 const malloy_types_1 = require("../../model/malloy_types");
-const functions_1 = require("./functions");
+const functions_1 = require("../functions");
 const dialect_1 = require("../dialect");
 const pg_impl_1 = require("../pg_impl");
-const dialect_functions_1 = require("./functions/dialect_functions");
+const dialect_functions_1 = require("./dialect_functions");
+const function_overrides_1 = require("./function_overrides");
 // These are the units that "TIMESTAMP_ADD" "TIMESTAMP_DIFF" accept
 function timestampMeasureable(units) {
     return [
@@ -417,12 +418,11 @@ ${(0, utils_1.indent)(sql)}
     sqlLiteralRegexp(literal) {
         return "'" + literal.replace(/'/g, "''") + "'";
     }
-    getGlobalFunctionDef(name) {
-        // TODO: implement
-        return functions_1.TRINO_FUNCTIONS.get(name);
+    getDialectFunctionOverrides() {
+        return (0, functions_1.expandOverrideMap)(function_overrides_1.TRINO_MALLOY_STANDARD_OVERLOADS);
     }
     getDialectFunctions() {
-        return dialect_functions_1.TRINO_DIALECT_FUNCTIONS;
+        return (0, functions_1.expandBlueprintMap)(dialect_functions_1.TRINO_DIALECT_FUNCTIONS);
     }
     malloyTypeToSQLType(malloyType) {
         if (malloyType.type === 'number') {

package/dist/index.d.ts

@@ -1,5 +1,5 @@
-export { DuckDBDialect, StandardSQLDialect, PostgresDialect, SnowflakeDialect, registerDialect, arg, qtz, overload, minScalar, anyExprType, minAggregate, maxScalar, sql, makeParam, param, params, literal, spread, Dialect, FUNCTIONS, } from './dialect';
-export type { DialectFieldList, DialectFunctionOverloadDef, QueryInfo, } from './dialect';
+export { DuckDBDialect, StandardSQLDialect, PostgresDialect, SnowflakeDialect, registerDialect, arg, qtz, overload, minScalar, anyExprType, minAggregate, maxScalar, sql, makeParam, param, variadicParam, literal, spread, Dialect, } from './dialect';
+export type { DialectFieldList, DialectFunctionOverloadDef, QueryInfo, MalloyStandardFunctionImplementations, DefinitionBlueprint, DefinitionBlueprintMap, OverloadedDefinitionBlueprint, } from './dialect';
 export type { QueryDataRow, StructDef, StructRelationship, NamedStructDefs, MalloyQueryData, AtomicFieldType as AtomicFieldTypeInner, DateUnit, ExtractUnit, TimestampUnit, TimeFieldType, QueryData, QueryValue, FieldTypeDef, Expr, FilterCondition, SQLBlock, FieldAtomicDef, FieldDef, PipeSegment, QueryFieldDef, IndexFieldDef, TurtleDef, SearchValueMapResult, SearchIndexResult, ModelDef, Query, QueryResult, QueryRunStats, NamedQuery, NamedModelObject, ExpressionType, FunctionDef, FunctionOverloadDef, FunctionParameterDef, ExpressionValueType, TypeDesc, FieldValueType, ExpressionTypeDesc, FunctionParamTypeDesc, DocumentLocation, DocumentRange, DocumentPosition, Sampling, Annotation, FieldAtomicTypeDef, SQLBlockStructDef, } from './model';
 export { Segment, isSamplingEnable, isSamplingPercent, isSamplingRows, expressionIsCalculation, indent, composeSQLExpr, } from './model';
 export { MalloyTranslator, } from './lang';

package/dist/index.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Explore = exports.DataWriter = exports.Parse = exports.JSONWriter = exports.CSVWriter = exports.QueryMaterializer = exports.Result = exports.PreparedResult = exports.TimestampTimeframe = exports.DateTimeframe = exports.SourceRelationship = exports.JoinRelationship = exports.MalloyError = exports.FixedConnectionMap = exports.InMemoryURLReader = exports.EmptyURLReader = exports.SingleConnectionRuntime = exports.ConnectionRuntime = exports.AtomicFieldType = exports.Runtime = exports.Malloy = exports.Model = exports.MalloyTranslator = exports.composeSQLExpr = exports.indent = exports.expressionIsCalculation = exports.isSamplingRows = exports.isSamplingPercent = exports.isSamplingEnable = exports.Segment = exports.FUNCTIONS = exports.Dialect = exports.spread = exports.literal = exports.params = exports.param = exports.makeParam = exports.sql = exports.maxScalar = exports.minAggregate = exports.anyExprType = exports.minScalar = exports.overload = exports.qtz = exports.arg = exports.registerDialect = exports.SnowflakeDialect = exports.PostgresDialect = exports.StandardSQLDialect = exports.DuckDBDialect = void 0;
-exports.Tag = exports.toAsyncGenerator = void 0;
+exports.toAsyncGenerator = exports.Explore = exports.DataWriter = exports.Parse = exports.JSONWriter = exports.CSVWriter = exports.QueryMaterializer = exports.Result = exports.PreparedResult = exports.TimestampTimeframe = exports.DateTimeframe = exports.SourceRelationship = exports.JoinRelationship = exports.MalloyError = exports.FixedConnectionMap = exports.InMemoryURLReader = exports.EmptyURLReader = exports.SingleConnectionRuntime = exports.ConnectionRuntime = exports.AtomicFieldType = exports.Runtime = exports.Malloy = exports.Model = exports.MalloyTranslator = exports.composeSQLExpr = exports.indent = exports.expressionIsCalculation = exports.isSamplingRows = exports.isSamplingPercent = exports.isSamplingEnable = exports.Segment = exports.Dialect = exports.spread = exports.literal = exports.variadicParam = exports.param = exports.makeParam = exports.sql = exports.maxScalar = exports.minAggregate = exports.anyExprType = exports.minScalar = exports.overload = exports.qtz = exports.arg = exports.registerDialect = exports.SnowflakeDialect = exports.PostgresDialect = exports.StandardSQLDialect = exports.DuckDBDialect = void 0;
+exports.Tag = void 0;
 /*
  * Copyright 2023 Google LLC
  *
@@ -40,11 +40,10 @@ Object.defineProperty(exports, "maxScalar", { enumerable: true, get: function ()
 Object.defineProperty(exports, "sql", { enumerable: true, get: function () { return dialect_1.sql; } });
 Object.defineProperty(exports, "makeParam", { enumerable: true, get: function () { return dialect_1.makeParam; } });
 Object.defineProperty(exports, "param", { enumerable: true, get: function () { return dialect_1.param; } });
-Object.defineProperty(exports, "params", { enumerable: true, get: function () { return dialect_1.params; } });
+Object.defineProperty(exports, "variadicParam", { enumerable: true, get: function () { return dialect_1.variadicParam; } });
 Object.defineProperty(exports, "literal", { enumerable: true, get: function () { return dialect_1.literal; } });
 Object.defineProperty(exports, "spread", { enumerable: true, get: function () { return dialect_1.spread; } });
 Object.defineProperty(exports, "Dialect", { enumerable: true, get: function () { return dialect_1.Dialect; } });
-Object.defineProperty(exports, "FUNCTIONS", { enumerable: true, get: function () { return dialect_1.FUNCTIONS; } });
 var model_1 = require("./model");
 // Used in Composer Demo
 Object.defineProperty(exports, "Segment", { enumerable: true, get: function () { return model_1.Segment; } });

package/dist/lang/ast/expressions/expr-func.js

@@ -196,39 +196,33 @@ class ExprFunc extends expression_def_1.ExpressionDef {
             structPath,
         };
         let funcCall = frag;
-        const dialectOverload = dialect ? overload.dialect[dialect] : undefined;
         // TODO add in an error if you use an asymmetric function in BQ
         // and the function uses joins
         // TODO add in an error if you use an illegal join pattern
-        if (dialectOverload === undefined) {
-            this.log(`Function ${this.name} is not defined in dialect ${dialect}`);
-        }
-        else {
-            if ((props === null || props === void 0 ? void 0 : props.orderBys) && props.orderBys.length > 0) {
-                const isAnalytic = (0, malloy_types_1.expressionIsAnalytic)(overload.returnType.expressionType);
-                if (!isAnalytic) {
-                    if (!this.inExperiment('aggregate_order_by', true)) {
-                        props.orderBys[0].log('Enable experiment `aggregate_order_by` to use `order_by` with an aggregate function');
-                    }
-                }
-                if (dialectOverload.supportsOrderBy || isAnalytic) {
-                    const allowExpression = dialectOverload.supportsOrderBy !== 'only_default';
-                    const allObs = props.orderBys.flatMap(orderBy => isAnalytic
-                        ? orderBy.getAnalyticOrderBy(fs)
-                        : orderBy.getAggregateOrderBy(fs, allowExpression));
-                    frag.kids.orderBy = allObs;
-                }
-                else {
-                    props.orderBys[0].log(`Function \`${this.name}\` does not support \`order_by\``);
+        if ((props === null || props === void 0 ? void 0 : props.orderBys) && props.orderBys.length > 0) {
+            const isAnalytic = (0, malloy_types_1.expressionIsAnalytic)(overload.returnType.expressionType);
+            if (!isAnalytic) {
+                if (!this.inExperiment('aggregate_order_by', true)) {
+                    props.orderBys[0].log('Enable experiment `aggregate_order_by` to use `order_by` with an aggregate function');
                 }
             }
-            if ((props === null || props === void 0 ? void 0 : props.limit) !== undefined) {
-                if (dialectOverload.supportsLimit) {
-                    frag.limit = props.limit.limit;
-                }
-                else {
-                    this.log(`Function ${this.name} does not support limit`);
-                }
+            if (overload.supportsOrderBy || isAnalytic) {
+                const allowExpression = overload.supportsOrderBy !== 'only_default';
+                const allObs = props.orderBys.flatMap(orderBy => isAnalytic
+                    ? orderBy.getAnalyticOrderBy(fs)
+                    : orderBy.getAggregateOrderBy(fs, allowExpression));
+                frag.kids.orderBy = allObs;
+            }
+            else {
+                props.orderBys[0].log(`Function \`${this.name}\` does not support \`order_by\``);
+            }
+        }
+        if ((props === null || props === void 0 ? void 0 : props.limit) !== undefined) {
+            if (overload.supportsLimit) {
+                frag.limit = props.limit.limit;
+            }
+            else {
+                this.log(`Function ${this.name} does not support limit`);
             }
         }
         if ((props === null || props === void 0 ? void 0 : props.partitionBys) && props.partitionBys.length > 0) {
@@ -377,7 +371,9 @@ function findOverload(func, args) {
                     (paramT.evalSpace === 'constant' &&
                         (arg.evalSpace === 'input' || arg.evalSpace === 'output')) ||
                     // Error if output is required but arg is input
-                    (paramT.evalSpace === 'output' && arg.evalSpace === 'input')) {
+                    // TODO: Assumption that calculations cannot take input things
+                    ((0, malloy_types_1.expressionIsAnalytic)(overload.returnType.expressionType) &&
+                        arg.evalSpace === 'input')) {
                     evalSpaceErrors.push({
                         argIndex,
                         param,

package/dist/lang/ast/types/dialect-name-space.js

@@ -23,17 +23,17 @@ class DialectNameSpace {
                     return {
                         returnType: overload.returnType,
                         params: overload.params,
+                        supportsOrderBy: overload.supportsOrderBy,
+                        supportsLimit: overload.supportsLimit,
+                        isSymmetric: overload.isSymmetric,
                         dialect: {
                             [dialect.name]: {
                                 e: overload.e,
-                                supportsOrderBy: overload.supportsOrderBy,
                                 defaultOrderByArgIndex: overload.defaultOrderByArgIndex,
-                                supportsLimit: overload.supportsLimit,
+                                between: overload.between,
+                                needsWindowOrderBy: overload.needsWindowOrderBy,
                             },
                         },
-                        needsWindowOrderBy: overload.needsWindowOrderBy,
-                        between: overload.between,
-                        isSymmetric: overload.isSymmetric,
                     };
                 }),
             });

package/dist/lang/ast/types/global-name-space.d.ts

@@ -1,12 +1,14 @@
+import { FunctionDef } from '../../../model';
 import { ModelEntry } from './model-entry';
 import { NameSpace } from './name-space';
 /**
- * We may want to remove this in the future...
- *
  * This is a global namespace which exists in the root of all Documents
  * and includes SQL function definitions.
  */
 export declare class GlobalNameSpace implements NameSpace {
+    entries: Map<string, FunctionDef>;
+    constructor();
     getEntry(name: string): ModelEntry | undefined;
     setEntry(_name: string, _value: ModelEntry, _exported: boolean): void;
 }
+export declare function getDialectFunctions(): Map<string, FunctionDef>;

package/dist/lang/ast/types/global-name-space.js

@@ -22,19 +22,19 @@
  * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.GlobalNameSpace = void 0;
+exports.getDialectFunctions = exports.GlobalNameSpace = void 0;
+const dialect_1 = require("../../../dialect");
 const dialect_map_1 = require("../../../dialect/dialect_map");
 /**
- * We may want to remove this in the future...
- *
  * This is a global namespace which exists in the root of all Documents
  * and includes SQL function definitions.
  */
 class GlobalNameSpace {
+    constructor() {
+        this.entries = getDialectFunctions();
+    }
     getEntry(name) {
-        // TODO cache this or precompute this so we're not comparing/merging dialect
-        // overloads on every usage
-        const func = (0, dialect_map_1.getDialectFunction)(name);
+        const func = this.entries.get(name);
         if (func === undefined) {
             return undefined;
         }
@@ -48,4 +48,57 @@ class GlobalNameSpace {
     }
 }
 exports.GlobalNameSpace = GlobalNameSpace;
+function paramsEqual(a, b) {
+    return (a.params.length === b.params.length &&
+        a.params.every((param, i) => {
+            const otherParam = b.params[i];
+            return (param.isVariadic === otherParam.isVariadic &&
+                param.name === otherParam.name &&
+                param.allowedTypes.length === otherParam.allowedTypes.length &&
+                param.allowedTypes.every(t => otherParam.allowedTypes.some(ot => t.dataType === ot.dataType &&
+                    t.expressionType === ot.expressionType)));
+        }));
+}
+function getDialectFunctions() {
+    var _a, _b;
+    const baseImplementations = (0, dialect_1.getMalloyStandardFunctions)();
+    const dialectOverrides = {};
+    const dialects = (0, dialect_map_1.getDialects)();
+    for (const dialect of dialects) {
+        dialectOverrides[dialect.name] = dialect.getDialectFunctionOverrides();
+    }
+    const functions = new Map();
+    for (const name in baseImplementations) {
+        const baseOverloads = baseImplementations[name];
+        const func = {
+            type: 'function',
+            name,
+            overloads: [],
+        };
+        for (const baseOverload of baseOverloads) {
+            const overload = {
+                returnType: baseOverload.returnType,
+                params: baseOverload.params,
+                dialect: {},
+                supportsOrderBy: baseOverload.supportsOrderBy,
+                supportsLimit: baseOverload.supportsLimit,
+                isSymmetric: baseOverload.isSymmetric,
+            };
+            for (const dialect of dialects) {
+                const overloads = (_a = dialectOverrides[dialect.name][name]) !== null && _a !== void 0 ? _a : [];
+                const dialectOverload = (_b = overloads.find(o => paramsEqual(o, overload))) !== null && _b !== void 0 ? _b : baseOverload;
+                overload.dialect[dialect.name] = {
+                    e: dialectOverload.e,
+                    needsWindowOrderBy: dialectOverload.needsWindowOrderBy,
+                    between: dialectOverload.between,
+                    defaultOrderByArgIndex: dialectOverload.defaultOrderByArgIndex,
+                };
+            }
+            func.overloads.push(overload);
+        }
+        functions.set(name, func);
+    }
+    return functions;
+}
+exports.getDialectFunctions = getDialectFunctions;
 //# sourceMappingURL=global-name-space.js.map

package/dist/model/malloy_query.d.ts

@@ -87,7 +87,7 @@ declare class QueryField extends QueryNode {
     generateCountFragment(resultSet: FieldInstanceResult, context: QueryStruct, expr: AggregateExpr, state: GenerateState): string;
     generateSourceReference(resultSet: FieldInstanceResult, context: QueryStruct, expr: SourceReferenceNode): string;
     getAnalyticPartitions(resultStruct: FieldInstanceResult, extraPartitionFields?: string[]): string[];
-    generateAnalyticFragment(resultStruct: FieldInstanceResult, context: QueryStruct, expr: Expr, overload: FunctionOverloadDef, state: GenerateState, args: Expr[], partitionByFields?: string[], funcOrdering?: string): string;
+    generateAnalyticFragment(dialect: string, resultStruct: FieldInstanceResult, context: QueryStruct, expr: Expr, overload: FunctionOverloadDef, state: GenerateState, args: Expr[], partitionByFields?: string[], funcOrdering?: string): string;
     generatePickSQL(pf: PickExpr): string;
     exprToSQL(resultSet: FieldInstanceResult, context: QueryStruct, exprToTranslate: Expr, state?: GenerateState): string;
     getExpr(): Expr;

package/dist/model/malloy_query.js

@@ -445,7 +445,7 @@ class QueryField extends QueryNode {
                 const extraPartitions = ((_c = frag.partitionBy) !== null && _c !== void 0 ? _c : []).map(outputName => {
                     return `(${resultSet.getField(outputName).getAnalyticalSQL(false)})`;
                 });
-                return this.generateAnalyticFragment(resultSet, context, funcCall, overload, state, args, extraPartitions, orderBySql);
+                return this.generateAnalyticFragment(context.dialect.name, resultSet, context, funcCall, overload, state, args, extraPartitions, orderBySql);
             }
             return this.exprToSQL(resultSet, context, funcCall, state);
         }
@@ -614,7 +614,7 @@ class QueryField extends QueryNode {
         }
         return ret;
     }
-    generateAnalyticFragment(resultStruct, context, expr, overload, state, args, partitionByFields, funcOrdering) {
+    generateAnalyticFragment(dialect, resultStruct, context, expr, overload, state, args, partitionByFields, funcOrdering) {
         const isComplex = resultStruct.root().isComplexQuery;
         const partitionFields = this.getAnalyticPartitions(resultStruct, partitionByFields);
         const allPartitions = [
@@ -625,7 +625,8 @@ class QueryField extends QueryNode {
             ? `PARTITION BY ${allPartitions.join(', ')}`
             : '';
         let orderBy = funcOrdering !== null && funcOrdering !== void 0 ? funcOrdering : '';
-        if (!funcOrdering && overload.needsWindowOrderBy) {
+        const dialectOverload = overload.dialect[dialect];
+        if (!funcOrdering && dialectOverload.needsWindowOrderBy) {
             // calculate the ordering.
             const obSQL = [];
             let orderingField;
@@ -662,10 +663,10 @@ class QueryField extends QueryNode {
             }
         }
         let between = '';
-        if (overload.between) {
+        if (dialectOverload.between) {
             const [preceding, following] = [
-                overload.between.preceding,
-                overload.between.following,
+                dialectOverload.between.preceding,
+                dialectOverload.between.following,
             ].map(value => {
                 if (value === -1) {
                     return 'UNBOUNDED';