@malloydata/malloy 0.0.138-dev240401005446 → 0.0.138-dev240401131656
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -77,7 +77,7 @@ class TrinoDialect extends dialect_1.Dialect {
|
|
|
77
77
|
this.supportsQualify = true;
|
|
78
78
|
this.supportsSafeCast = true;
|
|
79
79
|
this.supportsNesting = true;
|
|
80
|
-
this.cantPartitionWindowFunctionsOnExpressions =
|
|
80
|
+
this.cantPartitionWindowFunctionsOnExpressions = false;
|
|
81
81
|
this.orderByClause = 'output_name';
|
|
82
82
|
// TODO(figutierrez): update.
|
|
83
83
|
this.keywords = `
|
|
@@ -309,12 +309,7 @@ ${(0, utils_1.indent)(sql)}
|
|
|
309
309
|
return `(SELECT AS STRUCT ${alias}.*)`;
|
|
310
310
|
}
|
|
311
311
|
sqlMaybeQuoteIdentifier(identifier) {
|
|
312
|
-
|
|
313
|
-
// ? '`' + identifier + '`'
|
|
314
|
-
// : identifier;
|
|
315
|
-
return identifier;
|
|
316
|
-
// TODO: may need to escape;
|
|
317
|
-
//return `"${identifier}"`;
|
|
312
|
+
return '"' + identifier + '"';
|
|
318
313
|
}
|
|
319
314
|
sqlNow() {
|
|
320
315
|
return (0, malloy_types_1.mkExpr) `CURRENT_TIMESTAMP()`;
|
|
@@ -2105,7 +2105,7 @@ class QueryQuery extends QueryField {
|
|
|
2105
2105
|
o.push(`${fi.fieldUsage.resultIndex} ${f.dir || 'ASC'}`);
|
|
2106
2106
|
}
|
|
2107
2107
|
else if (this.parent.dialect.orderByClause === 'output_name') {
|
|
2108
|
-
o.push(`${f.field}${f.dir || 'ASC'}`);
|
|
2108
|
+
o.push(`${this.parent.dialect.sqlMaybeQuoteIdentifier(f.field)} ${f.dir || 'ASC'}`);
|
|
2109
2109
|
}
|
|
2110
2110
|
}
|
|
2111
2111
|
else {
|