@malloydata/malloy-tests 0.0.436 → 0.0.437

package/package.json

@@ -20,16 +20,16 @@
     "malloyc": "ts-node ../scripts/malloy-to-json"
   },
   "dependencies": {
-    "@malloydata/db-bigquery": "0.0.436",
-    "@malloydata/db-duckdb": "0.0.436",
-    "@malloydata/db-postgres": "0.0.436",
-    "@malloydata/db-snowflake": "0.0.436",
-    "@malloydata/db-sqlserver": "0.0.436",
-    "@malloydata/db-trino": "0.0.436",
-    "@malloydata/malloy": "0.0.436",
-    "@malloydata/malloy-tag": "0.0.436",
-    "@malloydata/render": "0.0.436",
-    "@malloydata/render-validator": "0.0.436",
+    "@malloydata/db-bigquery": "0.0.437",
+    "@malloydata/db-duckdb": "0.0.437",
+    "@malloydata/db-postgres": "0.0.437",
+    "@malloydata/db-snowflake": "0.0.437",
+    "@malloydata/db-sqlserver": "0.0.437",
+    "@malloydata/db-trino": "0.0.437",
+    "@malloydata/malloy": "0.0.437",
+    "@malloydata/malloy-tag": "0.0.437",
+    "@malloydata/render": "0.0.437",
+    "@malloydata/render-validator": "0.0.437",
     "events": "^3.3.0",
     "jsdom": "^22.1.0",
     "luxon": "^3.7.2",
@@ -43,5 +43,5 @@
   "overrides": {
     "typescript": "^6.0.3"
   },
-  "version": "0.0.436"
+  "version": "0.0.437"
 }

package/src/core/bugless.spec.ts

@@ -21,6 +21,26 @@ describe('misc tests for regressions that have no better home', () => {
     `).toMatchResult(testModel, {});
   });
 
+  test('rename a field in a join below a filtered join', async () => {
+    // A filtered join becomes a subquery, and the joins below it are packed
+    // into a struct under their column names, which a rename leaves different
+    // from the name the query uses.
+    await expect(`
+      source: two is duckdb.sql("""SELECT 1 as k, 'acme' as name""") extend {
+        rename: two_k is k
+        primary_key: two_k
+      }
+      source: one is duckdb.sql("""SELECT 1 as k, 2 as j""") extend {
+        where: j > 0
+        join_one: two with k
+      }
+      source: zero is duckdb.sql("""SELECT 1 as k""") extend {
+        join_one: one on one.k = k
+      }
+      run: zero -> { group_by: one.two.name, one.two.two_k }
+    `).toMatchResult(testModel, {name: 'acme', two_k: 1});
+  });
+
   test('ambiguous output names are auto-renamed and runnable', async () => {
     // `state` and `s2.state` both want the name `state`; the second is renamed
     // to `s2_state`. The query must compile to runnable SQL. (Small table with

package/src/databases/postgres/postgres.spec.ts

@@ -116,6 +116,28 @@ describe('Postgres tests', () => {
     }
     `).toMatchResult(testModel, {tenx: 10});
   });
+  it('keeps NUMERIC precision in symmetric aggregates', async () => {
+    // The join_many makes amt.sum() a symmetric aggregate. Its exact total,
+    // 1234567890123456.78, has more digits than a DOUBLE PRECISION holds; the
+    // second stage keeps only the cents, so the result fits in a JS number.
+    await expect(`
+      source: big is postgres.sql("""
+        SELECT 1 AS id, 1234567890123456.77::NUMERIC(18,2) AS amt
+        UNION ALL SELECT 2, 0.01
+      """) extend {
+        primary_key: id
+        join_many: dup is postgres.sql("""
+          SELECT 1 AS id UNION ALL SELECT 1 UNION ALL SELECT 2
+        """) on id = dup.id
+      }
+      run: big -> {
+        aggregate: total is amt.sum(), dup_rows is dup.count()
+      } -> {
+        select: cents is (total - 1234567890123456) * 100, dup_rows
+      }
+    `).toMatchResult(testModel, {cents: 78, dup_rows: 3});
+  });
+
   describe('all-aggregates query with joins and nested views', () => {
     // Reproduces a bug where an all-aggregates query on a source with
     // joins and nested views throws on Postgres. Postgres simulates