@malloydata/malloy-tests 0.0.279 → 0.0.281

package/package.json

@@ -21,14 +21,14 @@
   },
   "dependencies": {
     "@jest/globals": "^29.4.3",
-    "@malloydata/db-bigquery": "0.0.279",
-    "@malloydata/db-duckdb": "0.0.279",
-    "@malloydata/db-postgres": "0.0.279",
-    "@malloydata/db-snowflake": "0.0.279",
-    "@malloydata/db-trino": "0.0.279",
-    "@malloydata/malloy": "0.0.279",
-    "@malloydata/malloy-tag": "0.0.279",
-    "@malloydata/render": "0.0.279",
+    "@malloydata/db-bigquery": "0.0.281",
+    "@malloydata/db-duckdb": "0.0.281",
+    "@malloydata/db-postgres": "0.0.281",
+    "@malloydata/db-snowflake": "0.0.281",
+    "@malloydata/db-trino": "0.0.281",
+    "@malloydata/malloy": "0.0.281",
+    "@malloydata/malloy-tag": "0.0.281",
+    "@malloydata/render": "0.0.281",
     "events": "^3.3.0",
     "jsdom": "^22.1.0",
     "luxon": "^2.4.0",
@@ -38,5 +38,5 @@
     "@types/jsdom": "^21.1.1",
     "@types/luxon": "^2.4.0"
   },
-  "version": "0.0.279"
+  "version": "0.0.281"
 }

package/src/databases/all/expr.spec.ts

@@ -591,54 +591,60 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
       });
     });
 
-    describe('[not yet supported]', () => {
-      // See ${...} documentation for lookml here for guidance on remaining work:
-      // https://cloud.google.com/looker/docs/reference/param-field-sql#sql_for_dimensions
-      it('${view_name.dimension_name} - one path', async () => {
-        const query = await expressionModel.loadQuery(
-          `
-          ##! experimental { sql_functions }
-          source: a is ${databaseName}.table('malloytest.aircraft_models') extend { where: aircraft_model_code ? '0270202' }
+    it('${view_name.dimension_name} - one path', async () => {
+      await expect(`
+        ##! experimental { sql_functions }
+        source: a0 is ${databaseName}.table('malloytest.aircraft_models')
+        source: a is ${databaseName}.table('malloytest.aircraft_models') extend {
+          where: aircraft_model_code ? '0270202'
+          join_one: a0 on aircraft_model_code = a0.aircraft_model_code
+        }
 
-          run: a -> {
-              group_by: string_1 is sql_string("UPPER(\${a.manufacturer})")
-            }
-          `
-        );
-        await expect(query.run()).rejects.toThrow(
-          "'.' paths are not yet supported in sql interpolations, found ${a.manufacturer}"
-        );
+        run: a -> {
+          group_by: string_1 is sql_string("UPPER(\${a0.manufacturer})")
+        }
+      `).malloyResultMatches(expressionModel, {
+        string_1: 'AHRENS AIRCRAFT CORP.',
       });
+    });
 
-      it('${view_name.dimension_name} - multiple paths', async () => {
-        const query = await expressionModel.loadQuery(
-          `
-          ##! experimental { sql_functions }
-          source: a is ${databaseName}.table('malloytest.aircraft_models') extend { where: aircraft_model_code ? '0270202' }
+    it('${view_name.dimension_name} - multiple paths', async () => {
+      await expect(`
+        ##! experimental { sql_functions }
+        source: a0 is ${databaseName}.table('malloytest.aircraft_models')
+        source: a is ${databaseName}.table('malloytest.aircraft_models') extend {
+          where: aircraft_model_code ? '0270202'
+          join_one: a0 on aircraft_model_code = a0.aircraft_model_code
+        }
 
-          run: a -> {
-              group_by: number_1 is sql_number("\${a.seats} * \${a.seats} + \${a.total_seats}")
-            }
-          `
-        );
-        await expect(query.run()).rejects.toThrow(
-          "'.' paths are not yet supported in sql interpolations, found (${a.seats}, ${a.seats}, ${a.total_seats})"
-        );
+        run: a -> {
+          group_by: number_1 is sql_number("\${seats} + \${a0.seats}")
+        }
+      `).malloyResultMatches(expressionModel, {
+        number_1: 58,
       });
+    });
 
-      it('${view_name.SQL_TABLE_NAME}', async () => {
+    describe('[not yet supported]', () => {
+      // See ${...} documentation for lookml here for guidance on remaining work:
+      // https://cloud.google.com/looker/docs/reference/param-field-sql#sql_for_dimensions
+      it('${SQL_TABLE_NAME}', async () => {
         const query = await expressionModel.loadQuery(
           `
           ##! experimental { sql_functions }
-          source: a is ${databaseName}.table('malloytest.aircraft_models') extend { where: aircraft_model_code ? '0270202' }
+          source: a0 is ${databaseName}.table('malloytest.aircraft_models')
+          source: a is ${databaseName}.table('malloytest.aircraft_models') extend {
+            where: aircraft_model_code ? '0270202'
+            join_one: a0 on aircraft_model_code = a0.aircraft_model_code
+          }
 
           run: a -> {
-              group_by: number_1 is sql_number("\${a.SQL_TABLE_NAME}.seats")
-            }
+            group_by: number_1 is sql_number("\${a0.SQL_TABLE_NAME}.seats")
+          }
           `
         );
         await expect(query.run()).rejects.toThrow(
-          "'.' paths are not yet supported in sql interpolations, found ${a.SQL_TABLE_NAME}"
+          "Invalid interpolation: 'SQL_TABLE_NAME' is not defined"
         );
       });
     });

package/src/databases/all/functions.spec.ts

@@ -459,6 +459,25 @@ expressionModels.forEach((x, databaseName) => {
       expect(result.data.path(3, 'r').value).toBe(3);
     });
 
+    it(`dense_rank is supported - ${databaseName}`, async () => {
+      const result = await expressionModel
+        .loadQuery(
+          ` run: state_facts -> {
+            group_by:
+              first_letter is substr(state, 1, 1)
+            aggregate: state_count is count()
+            calculate: r is dense_rank() {order_by: state_count desc}
+          }`
+        )
+        .run();
+      // console.log(result.sql);
+      // console.log(result.data);
+      expect(result.data.path(0, 'r').value).toBe(1);
+      expect(result.data.path(1, 'r').value).toBe(1);
+      expect(result.data.path(2, 'r').value).toBe(2);
+      expect(result.data.path(3, 'r').value).toBe(2);
+    });
+
     it(`works using unary minus in calculate block - ${databaseName}`, async () => {
       const result = await expressionModel
         .loadQuery(
@@ -1777,6 +1796,42 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
         },
       ]);
     });
+    // TODO remove the need for the `##! unsafe_complex_select_query` compiler flag
+    it('can be used in a select in a composite source', async () => {
+      await expect(`
+        ##! experimental { function_order_by partition_by composite_sources }
+        ##! unsafe_complex_select_query
+        source: state_facts_composite is compose(state_facts, state_facts)
+        run: state_facts_composite -> {
+          select: state, births, popular_name
+          calculate: prev_births_by_name is lag(births) {
+            partition_by: popular_name
+            order_by: births desc
+          }
+          order_by: births desc
+          limit: 3
+        }
+      `).malloyResultMatches(expressionModel, [
+        {
+          state: 'CA',
+          births: 28810563,
+          popular_name: 'Isabella',
+          prev_births_by_name: null,
+        },
+        {
+          state: 'NY',
+          births: 23694136,
+          popular_name: 'Isabella',
+          prev_births_by_name: 28810563,
+        },
+        {
+          state: 'TX',
+          births: 21467359,
+          popular_name: 'Isabella',
+          prev_births_by_name: 23694136,
+        },
+      ]);
+    });
   });
 });
 

package/src/databases/presto-trino/presto-trino.spec.ts

@@ -345,6 +345,15 @@ describe.each(runtimes.runtimeList)(
           }
         `).malloyResultMatches(runtime, {some_words: ['hello', 'world']});
       });
+      it('runs array_agg', async () => {
+        const onetwo = `${databaseName}.sql('SELECT 1 as "n" UNION ALL SELECT 2 UNION ALL SELECT 1')`;
+        await expect(`##! experimental
+          run: ${onetwo}->{aggregate: alln is array_agg(n) {order_by: n desc }}
+        `).matchesRows(runtime, {alln: [2, 1, 1]});
+        await expect(`##! experimental
+          run: ${onetwo}->{aggregate: alln is array_agg_distinct(n) {order_by:n asc}}
+        `).matchesRows(runtime, {alln: [1, 2]});
+      });
       it.when(presto)('runs array_average', async () => {
         await expect(
           `run: ${nums}->{select: tavg is array_average(nums)}`