@malloydata/malloy-tests 0.0.225-dev250113200903 → 0.0.225

package/package.json

@@ -21,13 +21,13 @@
   },
   "dependencies": {
     "@jest/globals": "^29.4.3",
-    "@malloydata/db-bigquery": "^0.0.225-dev250113200903",
-    "@malloydata/db-duckdb": "^0.0.225-dev250113200903",
-    "@malloydata/db-postgres": "^0.0.225-dev250113200903",
-    "@malloydata/db-snowflake": "^0.0.225-dev250113200903",
-    "@malloydata/db-trino": "^0.0.225-dev250113200903",
-    "@malloydata/malloy": "^0.0.225-dev250113200903",
-    "@malloydata/render": "^0.0.225-dev250113200903",
+    "@malloydata/db-bigquery": "^0.0.225",
+    "@malloydata/db-duckdb": "^0.0.225",
+    "@malloydata/db-postgres": "^0.0.225",
+    "@malloydata/db-snowflake": "^0.0.225",
+    "@malloydata/db-trino": "^0.0.225",
+    "@malloydata/malloy": "^0.0.225",
+    "@malloydata/render": "^0.0.225",
     "events": "^3.3.0",
     "jsdom": "^22.1.0",
     "luxon": "^2.4.0",
@@ -37,5 +37,5 @@
     "@types/jsdom": "^21.1.1",
     "@types/luxon": "^2.4.0"
   },
-  "version": "0.0.225-dev250113200903"
+  "version": "0.0.225"
 }

package/src/databases/all/composite_sources.spec.ts

@@ -397,7 +397,7 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
         run: compose(
           state_facts extend { dimension: bar is 1 },
           state_facts
-        ) -> { index: bar } -> { group_by: fieldName; where: fieldName != null }
+        ) -> { index: bar } -> { group_by: fieldName; where: fieldName is not null }
       `).malloyResultMatches(runtime, {fieldName: 'bar'});
     });
   });

package/src/databases/all/expr.spec.ts

@@ -234,7 +234,7 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
       run: aircraft->{
         top: 10
         order_by: 1
-        where: region != NULL
+        where: region is not null
         group_by: region
         nest: by_state is {
           top: 10
@@ -823,7 +823,7 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
           SELECT '' as ${q`null_value`}, '' as ${q`string_value`}
           UNION ALL SELECT null, 'correct'
       """) -> {
-        where: null_value = null
+        where: null_value is null
         select:
           found_null is  null_value ?? 'correct',
           else_pass is string_value ?? 'incorrect'
@@ -836,6 +836,58 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
     });
   });
 
+  describe('null safe booleans', () => {
+    const nulls = `${databaseName}.sql("""
+      SELECT
+        0 as ${q`n`},
+        1 as ${q`x`}, 2 as ${q`y`},
+        'a' as ${q`a`}, 'b' as ${q`b`},
+        (1 = 1) as ${q`tf`}
+      UNION ALL SELECT
+        5,
+        null, null, null, null, null
+    """) extend { where: n > 0 }`;
+    const is_true = databaseName === 'mysql' ? 1 : true;
+
+    it('select boolean', async () => {
+      await expect(`run: ${nulls} -> {
+        select:
+          null_boolean is tf
+      }`).malloyResultMatches(runtime, {null_boolean: null});
+    });
+    it('not boolean', async () => {
+      await expect(`run: ${nulls} -> {
+        select:
+          not_null_boolean is not tf
+      }`).malloyResultMatches(runtime, {not_null_boolean: is_true});
+    });
+    it('numeric != non-null to null', async () => {
+      await expect(
+        `run: ${nulls} -> { select: val_ne_null is x != 9 }`
+      ).malloyResultMatches(runtime, {val_ne_null: is_true});
+    });
+    it('string !~ non-null to null', async () => {
+      await expect(
+        `run: ${nulls} -> { select: val_ne_null is a !~ 'z' }`
+      ).malloyResultMatches(runtime, {val_ne_null: is_true});
+    });
+    it('regex !~ non-null to null', async () => {
+      await expect(
+        `run: ${nulls} -> { select: val_ne_null is a !~ r'z' }`
+      ).malloyResultMatches(runtime, {val_ne_null: is_true});
+    });
+    it('numeric != null-to-null', async () => {
+      await expect(
+        `run: ${nulls} -> { select: null_ne_null is x != y }`
+      ).malloyResultMatches(runtime, {null_ne_null: is_true});
+    });
+    it('string !~ null-to-null', async () => {
+      await expect(
+        `run: ${nulls} -> { select: null_ne_null is a !~ b }`
+      ).malloyResultMatches(runtime, {null_ne_null: is_true});
+    });
+  });
+
   test('dimension expressions expanded with parens properly', async () => {
     await expect(
       `run: ${databaseName}.sql("SELECT 1 as one") extend {

package/src/databases/all/functions.spec.ts

@@ -642,7 +642,7 @@ expressionModels.forEach((x, databaseName) => {
           `
           run: aircraft -> {
             group_by: state
-            where: state != null
+            where: state is not null
             nest: by_county is {
               limit: 2
               group_by: county
@@ -680,7 +680,7 @@ expressionModels.forEach((x, databaseName) => {
           `
           run: airports extend { measure: airport_count is count() } -> {
             group_by: state
-            where: state != null
+            where: state is not null
             calculate: prev_airport_count is lag(airport_count)
           }`
         )

package/src/databases/all/nomodel.spec.ts

@@ -63,23 +63,6 @@ afterAll(async () => {
 
 runtimes.runtimeMap.forEach((runtime, databaseName) => {
   const q = runtime.getQuoter();
-  // Issue #1824
-  it.when(runtime.dialect.nativeBoolean)(
-    `not boolean field with null - ${databaseName}`,
-    async () => {
-      await expect(`
-      run: ${databaseName}.sql("""
-          SELECT
-            CASE WHEN 1=1 THEN NULL ELSE false END as ${q`n`}
-      """) -> {
-        select:
-          is_true is not n
-      }
-    `).malloyResultMatches(runtime, {
-        is_true: true,
-      });
-    }
-  );
 
   // Issue: #1284
   it(`parenthesize output field values - ${databaseName}`, async () => {
@@ -99,7 +82,7 @@ runtimes.runtimeMap.forEach((runtime, databaseName) => {
   it(`bug 151 which used to throw unknown dialect is still fixed- ${databaseName}`, async () => {
     await expect(`
       query: q is ${databaseName}.table('malloytest.aircraft')->{
-        where: state != null
+        where: state is not null
         group_by: state
       }
       run: q extend {
@@ -1052,7 +1035,7 @@ SELECT row_to_json(finalStage) as row FROM __stage0 AS finalStage`);
           ${splitFN!(q`city`, ' ')} as ${q`words`}
         FROM ${rootDbPath(databaseName)}malloytest.aircraft
       """) -> {
-        where: words.value != null
+        where: words.value is not null
         group_by: words.value
         aggregate: c is count()
       }
@@ -1106,7 +1089,7 @@ SELECT row_to_json(finalStage) as row FROM __stage0 AS finalStage`);
     await expect(`
         source: ga_sample is ${databaseName}.table('malloytest.ga_sample')
         run: ga_sample -> {
-          where: hits.product.productBrand != null
+          where: hits.product.productBrand is not null
           group_by:
             hits.product.productBrand
             hits.product.productSKU
@@ -1141,16 +1124,16 @@ SELECT row_to_json(finalStage) as row FROM __stage0 AS finalStage`);
         .loadQuery(
           `
         run: ${databaseName}.table('malloytest.airports') -> {
-          where: faa_region = null
+          where: faa_region is null
           group_by: faa_region
           aggregate: airport_count is count()
           nest: by_state is {
-            where: state != null
+            where: state is not null
             group_by: state
             aggregate: airport_count is count()
           }
           nest: by_state1 is {
-            where: state != null
+            where: state is not null
             group_by: state
             aggregate: airport_count is count()
             limit: 1

package/src/databases/all/parameters.spec.ts

@@ -320,7 +320,7 @@ runtimes.runtimeMap.forEach((runtime, databaseName) => {
         param::string is null,
         state_filter::string is "CA"
       ) is ${databaseName}.table('malloytest.state_facts') extend {
-        where: param = null and state = state_filter
+        where: param is null and state = state_filter
       }
       run: state_facts -> { group_by: state }
     `).malloyResultMatches(runtime, {state: 'CA'});

package/src/databases/bigquery/malloy_query.spec.ts

@@ -486,7 +486,7 @@ describe('BigQuery expression tests', () => {
         }
       }
       -> {
-        where: state.code.code != null
+        where: state.code.code is not null
         group_by: state.code.code
       }
     `
@@ -639,7 +639,7 @@ describe('airport_tests', () => {
       `
       run: airports-> {
         nest: zero is {
-          nest: by_faa_region_i is { where: county ~'I%' and  state != NULL
+          nest: by_faa_region_i is { where: county ~'I%' and  state is not null
             group_by: faa_region
             aggregate: airport_count
             nest: by_state is {

package/src/databases/bigquery/nested_source_table.spec.ts

@@ -154,7 +154,7 @@ describe.each(runtimes.runtimeList)(
     test(`search_index - ${databaseName}`, async () => {
       await expect(`
         run: ga_sessions->search_index -> {
-          where: fieldName != null
+          where: fieldName is not null
           select: *
           order_by: fieldName, weight desc
           limit: 10

package/src/databases/duckdb/nested_source_table.spec.ts

@@ -154,7 +154,7 @@ describe.each(runtimes.runtimeList)(
     test(`search_index - ${databaseName}`, async () => {
       await expect(`
         run: ga_sessions->search_index -> {
-          where: fieldName != null
+          where: fieldName is not null
           select: *
           order_by: fieldName, weight desc
           limit: 10

package/src/databases/duckdb/streaming.spec.ts

@@ -56,7 +56,7 @@ function modelText(databaseName: string) {
   }
 
   view: by_county is {
-    where: county != null
+    where: county is not null
     group_by: county
     aggregate: airport_count
     limit: 2
@@ -64,7 +64,7 @@ function modelText(databaseName: string) {
   }
 
   view: by_state is {
-    where: state != null
+    where: state is not null
     group_by: state
     aggregate: airport_count
     limit: 2