@malloydata/malloy-tests 0.0.142-dev240411154213 → 0.0.142-dev240413014741

package/package.json

@@ -21,13 +21,13 @@
   },
   "dependencies": {
     "@jest/globals": "^29.4.3",
-    "@malloydata/db-bigquery": "^0.0.142-dev240411154213",
-    "@malloydata/db-duckdb": "^0.0.142-dev240411154213",
-    "@malloydata/db-postgres": "^0.0.142-dev240411154213",
-    "@malloydata/db-snowflake": "^0.0.142-dev240411154213",
-    "@malloydata/db-trino": "^0.0.142-dev240411154213",
-    "@malloydata/malloy": "^0.0.142-dev240411154213",
-    "@malloydata/render": "^0.0.142-dev240411154213",
+    "@malloydata/db-bigquery": "^0.0.142-dev240413014741",
+    "@malloydata/db-duckdb": "^0.0.142-dev240413014741",
+    "@malloydata/db-postgres": "^0.0.142-dev240413014741",
+    "@malloydata/db-snowflake": "^0.0.142-dev240413014741",
+    "@malloydata/db-trino": "^0.0.142-dev240413014741",
+    "@malloydata/malloy": "^0.0.142-dev240413014741",
+    "@malloydata/render": "^0.0.142-dev240413014741",
     "jsdom": "^22.1.0",
     "luxon": "^2.4.0",
     "madge": "^6.0.0"
@@ -36,5 +36,5 @@
     "@types/jsdom": "^21.1.1",
     "@types/luxon": "^2.4.0"
   },
-  "version": "0.0.142-dev240411154213"
+  "version": "0.0.142-dev240413014741"
 }

package/src/databases/all/db_index.spec.ts

@@ -34,35 +34,38 @@ afterAll(async () => {
 });
 
 runtimes.runtimeMap.forEach((runtime, databaseName) => {
-  it(`basic index  - ${databaseName}`, async () => {
-    const model = await runtime.loadModel(
-      `
+  test.when(runtime.dialect.supportsTempTables)(
+    `basic index  - ${databaseName}`,
+    async () => {
+      const model = await runtime.loadModel(
+        `
         source: airports is ${databaseName}.table('malloytest.airports') extend {
         }
     `
-    );
-    let result = await model.search('airports', 'SANTA', 10);
+      );
+      let result = await model.search('airports', 'SANTA', 10);
 
-    // if (result !== undefined) {
-    //   console.log(result);
-    // } else {
-    //   console.log("no result");
-    // }
-    expect(result).toBeDefined();
-    if (result !== undefined) {
-      expect(result[0].fieldName).toBe('county');
-      expect(result[0].fieldValue).toBe('SANTA ROSA');
-      expect(result[0].weight).toBe(26);
-      expect(result.length).toBe(10);
-    }
+      // if (result !== undefined) {
+      //   console.log(result);
+      // } else {
+      //   console.log("no result");
+      // }
+      expect(result).toBeDefined();
+      if (result !== undefined) {
+        expect(result[0].fieldName).toBe('county');
+        expect(result[0].fieldValue).toBe('SANTA ROSA');
+        expect(result[0].weight).toBe(26);
+        expect(result.length).toBe(10);
+      }
 
-    result = await model.search('airports', 'SANTA A', 100, 'city');
-    if (result !== undefined) {
-      // console.log(result);
-      expect(result[0].fieldName).toBe('city');
-      expect(result[0].fieldValue).toBe('SANTA ANA');
+      result = await model.search('airports', 'SANTA A', 100, 'city');
+      if (result !== undefined) {
+        // console.log(result);
+        expect(result[0].fieldName).toBe('city');
+        expect(result[0].fieldValue).toBe('SANTA ANA');
+      }
     }
-  });
+  );
 
   it(`index value map  - ${databaseName}`, async () => {
     const model = await runtime.loadModel(
@@ -94,7 +97,7 @@ runtimes.runtimeMap.forEach((runtime, databaseName) => {
   });
 
   // bigquery doesn't support row count based sampling.
-  test.when(databaseName !== 'bigquery')(
+  test.when(databaseName !== 'bigquery' && databaseName !== 'trino')(
     `index rows count - ${databaseName}`,
     async () => {
       await expect(`

package/src/databases/all/expr.spec.ts

@@ -661,8 +661,10 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
     });
   });
 
-  it('joined filtered explores with dependencies', async () => {
-    await expect(`
+  test.when(runtime.dialect.supportsComplexFilteredSources)(
+    'joined filtered explores with dependencies',
+    async () => {
+      await expect(`
       source: bo_models is
         ${databaseName}.table('malloytest.aircraft_models') extend { where: manufacturer ? ~ 'BO%' }
         -> { select: aircraft_model_code, manufacturer, seats }
@@ -691,7 +693,8 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
         -- aggregate: b_models.bo_models.bo_count
       }
     `).malloyResultMatches(runtime, {model_count: 60461, b_count: 355});
-  });
+    }
+  );
 });
 
 describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {

package/src/databases/all/functions.spec.ts

@@ -756,9 +756,12 @@ expressionModels.forEach((expressionModel, databaseName) => {
     });
   });
   describe('is_inf', () => {
+    const inf = ['trino'].includes(databaseName)
+      ? 'infinity!()'
+      : "'+inf'::number";
     it(`works - ${databaseName}`, async () => {
       await funcTestMultiple(
-        ["is_inf('+inf'::number)", true],
+        [`is_inf(${inf})`, true],
         ['is_inf(100)', false],
         ['is_inf(null)', false]
       );
@@ -952,7 +955,7 @@ expressionModels.forEach((expressionModel, databaseName) => {
       await funcTestMultiple(
         ["ascii('A')", 65],
         ["ascii('ABC')", 65],
-        ["ascii('')", 0],
+        //["ascii('')", 0],   // I don't think we can guarentee this Trino returns null
         ['ascii(null)', null]
       );
     });
@@ -963,7 +966,7 @@ expressionModels.forEach((expressionModel, databaseName) => {
         ["unicode('A')", 65],
         ["unicode('â')", 226],
         ["unicode('âBC')", 226],
-        ["unicode('')", 0],
+        //["unicode('')", 0],   // I don't think we can guarentee this Trino returns null
         ['unicode(null)', null]
       );
     });
@@ -1294,7 +1297,7 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => {
 
     it(`works with fanout and order_by - ${databaseName}`, async () => {
       // TODO bigquery cannot handle both fanout and order_by today
-      if (['bigquery', 'snowflake'].includes(databaseName)) return;
+      if (['bigquery', 'snowflake', 'trino'].includes(databaseName)) return;
       await expect(`##! experimental.aggregate_order_by
       run: state_facts extend { join_many:
         state_facts2 is ${databaseName}.table('malloytest.state_facts')

package/src/databases/all/nomodel.spec.ts

@@ -905,8 +905,14 @@ SELECT row_to_json(finalStage) as row FROM __stage0 AS finalStage`);
     `).malloyResultMatches(runtime, {a: 1});
   });
 
+  // have to add an order_by: otherwise it isn't deterministic.
   it(`sql directly - ${databaseName}`, async () => {
-    await expect(`run: ${sql1234}`).malloyResultMatches(runtime, {a: 1});
+    await expect(
+      `run: ${sql1234}->{
+        select: *
+        order_by: a asc
+      }`
+    ).malloyResultMatches(runtime, {a: 1});
   });
 
   it(`sql with turducken- ${databaseName}`, async () => {
@@ -988,6 +994,7 @@ SELECT row_to_json(finalStage) as row FROM __stage0 AS finalStage`);
       """) -> {
         extend: {dimension:  c is b + 4}
         select: x is  a * c
+        order_by: x desc
       }
       `).malloyResultMatches(runtime, {x: 30});
   });
@@ -1053,6 +1060,20 @@ SELECT row_to_json(finalStage) as row FROM __stage0 AS finalStage`);
     }
   );
 
+  test.when(runtime.supportsNesting && runtime.dialect.readsNestedData)(
+    `can double unnest - ${databaseName}`,
+    async () => {
+      await expect(`
+        source: ga_sample is ${databaseName}.table('malloytest.ga_sample')
+
+        run: ga_sample -> {
+          aggregate:
+            p is floor(hits.product.productPrice.avg())
+        }
+      `).malloyResultMatches(runtime, {p: 23001594});
+    }
+  );
+
   test.when(runtime.supportsNesting)(
     'nest null - ${databaseName}',
     async () => {