@malloydata/db-mysql 0.0.431 → 0.0.433

package/dist/mysql_connection.js

@@ -62,6 +62,33 @@ class MySQLExecutor {
     }
 }
 exports.MySQLExecutor = MySQLExecutor;
+/**
+ * MySQL renders a DECIMAL at its declared scale, so trailing zeros after the
+ * point are formatting rather than data and stripping them is lossless.
+ *
+ * This matters because every aggregate of an integer column comes back as a
+ * DECIMAL: SUM() of a BIGINT arrives as `18014398509481986.0000000000`, and
+ * Malloy reads a bigint-typed cell with BigInt(), which rejects any fractional
+ * spelling. A value with a real fraction is left alone.
+ *
+ * mysql2 delivers DECIMAL as a string, which is what preserves digits above
+ * 2^53 -- its `decimalNumbers` option parses them into a double instead, and
+ * must stay off. This hook is the last point at which a cell's MySQL type is
+ * known; by the time a row reaches Malloy it is gone.
+ */
+function castMySQLValue(field, next) {
+    if (field.type === 'DECIMAL' || field.type === 'NEWDECIMAL') {
+        const digits = next();
+        if (typeof digits === 'string') {
+            const whole = digits.match(/^([+-]?\d+)\.0+$/);
+            if (whole) {
+                return whole[1];
+            }
+        }
+        return digits;
+    }
+    return next();
+}
 class MySQLConnection extends connection_1.BaseConnection {
     get dialectName() {
         return this.dialect.name;
@@ -84,9 +111,10 @@ class MySQLConnection extends connection_1.BaseConnection {
                 password: this.config.password,
                 database: this.config.database,
                 multipleStatements: true,
-                decimalNumbers: true,
+                // A BIGINT too wide for a double arrives as an exact string.
                 supportBigNumbers: true,
                 timezone: '+00:00',
+                typeCast: castMySQLValue,
             });
             await this.connection.query(
             // LTNOTE: Need to make the group_concat_max_len configurable.
@@ -246,9 +274,9 @@ class MySQLConnection extends connection_1.BaseConnection {
     }
     fillStructDefFromTypeMap(structDef, typeMap) {
         for (const fieldName in typeMap) {
-            let mySqlType = typeMap[fieldName].toLocaleLowerCase();
-            mySqlType = mySqlType.trim().split('(')[0];
-            const malloyType = this.dialect.sqlTypeToMalloyType(mySqlType);
+            // The dialect needs the full reported spelling: DECIMAL's parameters
+            // decide its Malloy type.
+            const malloyType = this.dialect.sqlTypeToMalloyType(typeMap[fieldName]);
             // no arrays or records exist in mysql
             structDef.fields.push({ ...malloyType, name: fieldName });
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@malloydata/db-mysql",
-  "version": "0.0.431",
+  "version": "0.0.433",
   "license": "MIT",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -23,7 +23,7 @@
     "prepublishOnly": "npm run build"
   },
   "dependencies": {
-    "@malloydata/malloy": "0.0.431",
+    "@malloydata/malloy": "0.0.433",
     "@types/node": "^22.20.0",
     "fastestsmallesttextencoderdecoder": "^1.0.22",
     "luxon": "^3.7.2",