@malloydata/db-duckdb 0.0.388 → 0.0.389

package/dist/duckdb_connection.d.ts

@@ -64,10 +64,19 @@ export declare class DuckDBConnection extends DuckDBCommon {
     close(): Promise<void>;
     idle(): Promise<void>;
     /**
-     * Remove this connection from the shared `activeDBs` entry. When the
-     * last connection sharing the entry is removed, close the underlying
-     * `DuckDBInstance` and drop the entry — releasing DuckDB's per-process
-     * file lock.
+     * Dispose this connection's stake in the underlying `DuckDBInstance`:
+     *   1. Disconnect the per-connection C++ `Connection` so its
+     *      `ClientContext` stops pinning the `DatabaseInstance`.
+     *   2. Drop our entry from the shared `activeDBs` bookkeeping.
+     *   3. If we were the last sharer, close the instance — which releases
+     *      DuckDB's per-process file lock.
+     *
+     * Step 1 is required even though step 3 calls `instance.closeSync()`.
+     * The C-API `duckdb_close` only decrements the `shared_ptr<DatabaseInstance>`
+     * refcount; live `Connection` objects keep that refcount above zero via
+     * their `ClientContext`, so the file handle (and `fcntl` lock) survive
+     * the `closeSync` call. Disconnecting first guarantees the `closeSync`
+     * is the last ref and the lock is actually released.
      */
     private detachInstance;
     /**

package/dist/duckdb_connection.js

@@ -295,12 +295,24 @@ class DuckDBConnection extends duckdb_common_1.DuckDBCommon {
         // re-acquire the lock immediately and defeat the point of idling.
     }
     /**
-     * Remove this connection from the shared `activeDBs` entry. When the
-     * last connection sharing the entry is removed, close the underlying
-     * `DuckDBInstance` and drop the entry — releasing DuckDB's per-process
-     * file lock.
+     * Dispose this connection's stake in the underlying `DuckDBInstance`:
+     *   1. Disconnect the per-connection C++ `Connection` so its
+     *      `ClientContext` stops pinning the `DatabaseInstance`.
+     *   2. Drop our entry from the shared `activeDBs` bookkeeping.
+     *   3. If we were the last sharer, close the instance — which releases
+     *      DuckDB's per-process file lock.
+     *
+     * Step 1 is required even though step 3 calls `instance.closeSync()`.
+     * The C-API `duckdb_close` only decrements the `shared_ptr<DatabaseInstance>`
+     * refcount; live `Connection` objects keep that refcount above zero via
+     * their `ClientContext`, so the file handle (and `fcntl` lock) survive
+     * the `closeSync` call. Disconnecting first guarantees the `closeSync`
+     * is the last ref and the lock is actually released.
      */
     detachInstance() {
+        if (this.connection) {
+            this.connection.disconnectSync();
+        }
         const activeDB = DuckDBConnection.activeDBs[this.shareKey];
         if (activeDB) {
             activeDB.connections = activeDB.connections.filter(connection => connection !== this.connection);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@malloydata/db-duckdb",
-  "version": "0.0.388",
+  "version": "0.0.389",
   "license": "MIT",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
@@ -60,7 +60,7 @@
   "dependencies": {
     "@duckdb/duckdb-wasm": "1.33.1-dev13.0",
     "@duckdb/node-api": "1.4.4-r.1",
-    "@malloydata/malloy": "0.0.388",
+    "@malloydata/malloy": "0.0.389",
     "@motherduck/wasm-client": "^0.6.6",
     "apache-arrow": "^17.0.0",
     "web-worker": "^1.3.0"