@malloy-publisher/server 0.9.10 → 0.9.12

package/dist/app/index.html

@@ -16,7 +16,7 @@ SPDX-License-Identifier: MIT
          href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&family=JetBrains+Mono:wght@400;500&display=swap"
       />
       <title>Malloy Publisher</title>
-     <script type="module" crossorigin src="/assets/index-BvSbJtsT.js"></script>
+     <script type="module" crossorigin src="/assets/index-5On9Gkpl.js"></script>
      <link rel="stylesheet" crossorigin href="/assets/index-DUqldpo0.css">
    </head>
    <body>

package/dist/package_load_worker.mjs

@@ -13053,15 +13053,36 @@ function filesystemAccessFailure(error) {
 function isMysqlConfigFault(code) {
   return typeof code === "string" && (MYSQL_CONFIG_CODES.has(code) || code.startsWith("HANDSHAKE_"));
 }
-function isConnectionFailure(error) {
-  let current = error;
+function isSqlserverConnectTimeout(error, code) {
+  return code === "ETIMEOUT" && error.name === "ConnectionError";
+}
+function wrappedError(error) {
+  if (error.cause instanceof Error)
+    return error.cause;
+  return error.originalError;
+}
+function causeChainHasTlsVerificationFailure(error) {
+  let current = wrappedError(error);
   for (let depth = 0;depth < 8 && current instanceof Error; depth++) {
+    const { code } = current;
+    if (typeof code === "string" && TLS_VERIFICATION_CODES.has(code)) {
+      return true;
+    }
+    current = wrappedError(current);
+  }
+  return false;
+}
+function isConnectionFailure(error) {
+  for (const current of causeChain(error)) {
     const { code, fatal } = current;
     if (typeof code === "string") {
       if (NODE_CONNECTION_CODES.has(code))
         return true;
       if (POSTGRES_CONNECTION_SQLSTATE.test(code))
         return true;
+      if (SQLSERVER_CONNECTION_CODES.has(code) || isSqlserverConnectTimeout(current, code)) {
+        return !causeChainHasTlsVerificationFailure(current);
+      }
     }
     if (fatal === true && !isMysqlConfigFault(code))
       return true;
@@ -13069,13 +13090,18 @@ function isConnectionFailure(error) {
     if (CODELESS_CONNECTION_MESSAGES.some((re) => re.test(message))) {
       return true;
     }
-    current = current.cause;
   }
   return false;
 }
-function isCredentialRejection(error) {
+function* causeChain(error) {
   let current = error;
   for (let depth = 0;depth < 8 && current instanceof Error; depth++) {
+    yield current;
+    current = wrappedError(current);
+  }
+}
+function isCredentialRejection(error) {
+  for (const current of causeChain(error)) {
     const { code } = current;
     if (typeof code === "string" || typeof code === "number") {
       const value = String(code);
@@ -13083,12 +13109,13 @@ function isCredentialRejection(error) {
         return true;
       if (MYSQL_AUTH_CODES.has(value))
         return true;
+      if (SQLSERVER_AUTH_CODES.has(value))
+        return true;
       if (SNOWFLAKE_AUTH_CODES.has(value))
         return true;
     }
     if (current.name === "BigQueryAuthenticationError")
       return true;
-    current = current.cause;
   }
   return false;
 }
@@ -13103,6 +13130,19 @@ function databaseAccessFailure(error) {
     return new ConnectionFailedError(message);
   return;
 }
+function statementRejection(error) {
+  for (const current of causeChain(error)) {
+    const { code, severity } = current;
+    if (severity === "FATAL" || severity === "PANIC")
+      return;
+    if (typeof code !== "string" || !POSTGRES_STATEMENT_SQLSTATES.has(code)) {
+      continue;
+    }
+    const message = current.message;
+    return code === POSTGRES_UNDEFINED_TABLE && POSTGRES_RELATION_MISSING.test(message) ? new TableNotFoundError(message) : new InvalidArgumentError(message);
+  }
+  return;
+}
 function describeFilesystemAccessFailure(errno) {
   const code = errno.code ?? "";
   const target = errno.path ? ` '${errno.path}'` : "";
@@ -13242,7 +13282,7 @@ function toQueryTextProblem(problem) {
     ...problem.at ? { at: { range: problem.at.range } } : {}
   };
 }
-var GENERIC_INTERNAL_MESSAGE = "Internal server error.", GENERIC_UPSTREAM_MESSAGE = "Upstream connection error.", GENERIC_UNREACHABLE_MESSAGE = "The database connection is down: the database could not be reached, so the query did not run.", GENERIC_AUTH_MESSAGE = "The database rejected the connection's credentials. Check the connection's user, password, key or token.", MAX_LOGGED_DETAIL_CHARS = 2000, FILESYSTEM_ACCESS_DESCRIPTIONS, NODE_CONNECTION_CODES, POSTGRES_CONNECTION_SQLSTATE, CODELESS_CONNECTION_MESSAGES, MYSQL_CONFIG_CODES, POSTGRES_AUTH_SQLSTATE, MYSQL_AUTH_CODES, SNOWFLAKE_AUTH_CODES, NotImplementedError, BadRequestError, InvalidArgumentError, CompileRefusedError, InvalidModelPathError, RenderTagRefusedError, UnparseableTextError, EnvironmentNotFoundError, PackageNotFoundError, ModelNotFoundError, DashboardNotFoundError, SkillNotFoundError, AgentNotFoundError, ConflictError, ConnectionNotFoundError, TableNotFoundError, ConnectionError, ConnectionFailedError, UnconfiguredConnectionError, ConnectionPoolExhaustedError, DestinationNotFoundError, ConnectionAuthError, UnsupportedCatalogFormatError, ModelCompilationError, PackageManifestError, MaterializationEligibilityError, ChainedUpstreamMissingError, ChainedShapeNotCarriedError, PublisherConfigError, ServerConfigurationError, FrozenConfigError, AccessDeniedError, QueryCompileError, NotQueryableError, OffSurfaceError, MaterializationNotFoundError, MaterializationConflictError, WriteConflictError, WriteRolledBackError, WriteRollbackFailedError, WriteVerifyError, InvalidStateTransitionError, ServiceUnavailableError, PackageAdmissionRefusedError, PayloadTooLargeError, ResponseUnserializableError, QueryTimeoutError;
+var GENERIC_INTERNAL_MESSAGE = "Internal server error.", GENERIC_UPSTREAM_MESSAGE = "Upstream connection error.", GENERIC_UNREACHABLE_MESSAGE = "The database connection is down: the database could not be reached, so the query did not run.", GENERIC_AUTH_MESSAGE = "The database rejected the connection's credentials. Check the connection's user, password, key or token.", MAX_LOGGED_DETAIL_CHARS = 2000, FILESYSTEM_ACCESS_DESCRIPTIONS, NODE_CONNECTION_CODES, POSTGRES_CONNECTION_SQLSTATE, CODELESS_CONNECTION_MESSAGES, MYSQL_CONFIG_CODES, SQLSERVER_CONNECTION_CODES, TLS_VERIFICATION_CODES, POSTGRES_AUTH_SQLSTATE, MYSQL_AUTH_CODES, SQLSERVER_AUTH_CODES, SNOWFLAKE_AUTH_CODES, POSTGRES_STATEMENT_SQLSTATES, POSTGRES_UNDEFINED_TABLE = "42P01", POSTGRES_RELATION_MISSING, NotImplementedError, BadRequestError, InvalidArgumentError, CompileRefusedError, InvalidModelPathError, RenderTagRefusedError, UnparseableTextError, EnvironmentNotFoundError, PackageNotFoundError, ModelNotFoundError, DashboardNotFoundError, SkillNotFoundError, AgentNotFoundError, ConflictError, ConnectionNotFoundError, TableNotFoundError, ConnectionError, ConnectionFailedError, UnconfiguredConnectionError, ConnectionPoolExhaustedError, DestinationNotFoundError, ConnectionAuthError, UnsupportedCatalogFormatError, ModelCompilationError, PackageManifestError, MaterializationEligibilityError, ChainedUpstreamMissingError, ChainedShapeNotCarriedError, PublisherConfigError, ServerConfigurationError, FrozenConfigError, AccessDeniedError, QueryCompileError, NotQueryableError, OffSurfaceError, MaterializationNotFoundError, MaterializationConflictError, WriteConflictError, WriteRolledBackError, WriteRollbackFailedError, WriteVerifyError, InvalidStateTransitionError, ServiceUnavailableError, PackageAdmissionRefusedError, PayloadTooLargeError, ResponseUnserializableError, QueryTimeoutError;
 var init_errors = __esm(() => {
   init_constants();
   init_logger();
@@ -13268,7 +13308,8 @@ var init_errors = __esm(() => {
     /^(Error: )?Connection lost: The server closed the connection\.$/,
     new RegExp(`^(Error: )?(connect|read|write|getaddrinfo) (${[
       ...NODE_CONNECTION_CODES
-    ].join("|")})\\b`)
+    ].join("|")})\\b`),
+    /^Failed to connect to \S+( \(redirected from \S+\))?( in \d+ms| - (?!.*certificate).+)$/i
   ];
   MYSQL_CONFIG_CODES = new Set([
     "ER_ACCESS_DENIED_ERROR",
@@ -13277,9 +13318,46 @@ var init_errors = __esm(() => {
     "AUTH_SWITCH_PLUGIN_ERROR",
     "MYSQL_CLEAR_PASSWORD_NOT_ENABLED"
   ]);
+  SQLSERVER_CONNECTION_CODES = new Set(["ESOCKET", "EINSTLOOKUP"]);
+  TLS_VERIFICATION_CODES = new Set([
+    "CERT_HAS_EXPIRED",
+    "DEPTH_ZERO_SELF_SIGNED_CERT",
+    "ERR_TLS_CERT_ALTNAME_INVALID",
+    "SELF_SIGNED_CERT_IN_CHAIN",
+    "UNABLE_TO_GET_ISSUER_CERT",
+    "UNABLE_TO_GET_ISSUER_CERT_LOCALLY",
+    "UNABLE_TO_VERIFY_LEAF_SIGNATURE"
+  ]);
   POSTGRES_AUTH_SQLSTATE = /^28[0-9A-Z]{3}$/;
   MYSQL_AUTH_CODES = new Set(["ER_ACCESS_DENIED_ERROR"]);
+  SQLSERVER_AUTH_CODES = new Set(["ELOGIN"]);
   SNOWFLAKE_AUTH_CODES = new Set(["390100", "390144", "390195", "390318"]);
+  POSTGRES_STATEMENT_SQLSTATES = new Set([
+    "42601",
+    "42703",
+    "42P01",
+    "42883",
+    "42704",
+    "42P02",
+    "42702",
+    "42725",
+    "42P09",
+    "42P10",
+    "42804",
+    "42846",
+    "42803",
+    "42P20",
+    "42P18",
+    "42P19",
+    "42712",
+    "42701",
+    "42602",
+    "42622",
+    "42809",
+    "42P21",
+    "42P22"
+  ]);
+  POSTGRES_RELATION_MISSING = /^relation ".*" does not exist$/;
   NotImplementedError = class NotImplementedError extends Error {
     constructor(message) {
       super(message);
@@ -21077,7 +21155,7 @@ ${body}`;
   if (artifactAt < 0) {
     return refuse({
       line: 1,
-      message: "Line 1: this notebook has no ## artifact note, so its header cannot be told from its cells. Fix: add `## artifact { layout=linear }` after the ##! line."
+      message: "Line 1: this notebook has no ## artifact note, so its header cannot be told from its cells. Fix: add `## artifact { layout=linear tiles=[…] }` after the ##! line."
     });
   }
   const runCount = items.filter((item) => item.kind === "statement" && item.run).length;
@@ -21277,12 +21355,14 @@ function readReportTag(modelNotes) {
   const kind = tagText(artifact, "kind");
   if (kind !== undefined)
     return { status: "kind-removed", kind };
-  const layout = parseLayoutValue(tagText(artifact, "layout"));
-  if (layout)
-    return { status: "report", layout, decidedBy: "layout" };
-  if (artifact.has("tiles") || tags?.tag("dashboard") !== undefined)
-    return { status: "report", layout: "grid", decidedBy: "tiles" };
-  return { status: "report", layout: "linear", decidedBy: "default" };
+  const hasTiles = artifact.has("tiles");
+  if (hasTiles && artifact.array("tiles") === undefined)
+    return { status: "unparsed" };
+  const declared = tagText(artifact, "layout");
+  const layout = parseLayoutValue(declared) ?? (hasTiles || tags?.tag("dashboard") !== undefined ? "grid" : "linear");
+  if (layout === "linear" && !hasTiles)
+    return declared !== undefined && parseLayoutValue(declared) === undefined ? { status: "cells-removed", unknownLayout: declared } : { status: "cells-removed" };
+  return { status: "report", layout };
 }
 function readReportTagOfText(text) {
   return readReportTag(modelNotesOfText(text));
@@ -23726,6 +23806,11 @@ function readGivenControlSpec(annotationTexts2) {
   }
   return spec;
 }
+function givenDeclaresNoDefault(given) {
+  const loose = given;
+  const parsed = "default" in loose ? loose.default : loose._internal?.default;
+  return parsed === undefined && loose._internal?.defaultText === undefined;
+}
 function malloyGivenToApi(given) {
   const type = given.type;
   const renderedType = type.type === "filter expression" ? `filter<${type.filterType}>` : type.type === "array" && type.elementTypeDef?.type ? `${type.elementTypeDef.type}[]` : type.type;
@@ -23736,7 +23821,8 @@ function malloyGivenToApi(given) {
     annotations: allNotes.filter((note) => !isReservedRoute(note.route) && note.route !== MARKDOWN_ROUTE).map((note) => note.text),
     ...readGivenControlSpec(allNotes.map((note) => note.text)),
     ...allNotes.some((note) => note.route === "secure") && { secure: true },
-    default: given._internal?.defaultText
+    default: given._internal?.defaultText,
+    ...givenDeclaresNoDefault(given) && { required: true }
   };
 }
 function collectGivenRefs(value, into) {
@@ -23900,6 +23986,15 @@ class RpcWaitAccountant {
   }
 }
 
+// src/service/experimental_dialects.ts
+import { getDialect } from "@malloydata/malloy";
+var BUNDLED_EXPERIMENTAL_DIALECTS = ["sqlserver"];
+function acceptBundledExperimentalDialects() {
+  for (const name of BUNDLED_EXPERIMENTAL_DIALECTS) {
+    getDialect(name).acceptExperimental();
+  }
+}
+
 // src/materialization_metrics.ts
 var resetHooks = [];
 function lazyCounter(name, description) {
@@ -23935,7 +24030,7 @@ var storageServeRoutingCounter = lazyCounter("publisher_storage_serve_routing_to
 var storageTableRetainedCounter = lazyCounter("publisher_storage_tables_retained_total", "Tables a FAILED run left in a storage= destination and deliberately did not " + "reclaim, because the source is refreshed incrementally and the name may be " + "the one it serves from. Label: destination. Not all of these are orphans — " + "a rebuild at a fresh generational name is, a seed on the live serving name " + "is not, and the manifest entry cannot separate them — so read this as an " + "upper bound on what is accumulating rather than a leak count. It is the " + "only accounting there is until reclaiming a destination exists, which is " + "why it is a counter and not just a log line: the question is a rate, not " + "whether it ever happened.");
 var storageBuildFailureCounter = lazyCounter("publisher_storage_build_failures_total", "storage= build failures (federation/passthrough/attach/CTAS), distinct from " + "in-warehouse build failures. Labels: destination (connection name), " + "reason ('build_failed'|'billed_read_not_captured'). The second is the " + "expensive one: the warehouse read ran and was charged, and the rows could " + "not be captured — so a re-drive pays for it again. Worth alerting on " + "separately from a failure that costs only a retry.");
 var attributionSkippedCounter = lazyCounter("publisher_storage_build_attribution_skipped_total", "storage= builds whose warehouse read went out UNATTRIBUTED while tagging was " + "on. Label: reason ('job_listing_unavailable'|'tag_failed'|" + "'read_row_not_found'|'read_row_ambiguous'|'cost_query_failed'). " + "The read still ran and the " + "build still succeeded — what was lost is the label in the customer's own " + "query history, and the cost on this side. Without this an operator who " + "turns tagging on and sees nothing has a single log line to go on.");
-var eligibilityRefusedCounter = lazyCounter("publisher_materialization_eligibility_refused_total", "materialization-eligibility refusals, both tiers. Label: reason " + "('free_parameter'|'given_in_persisted_query'|'dynamic_projection'|" + "'dynamic_join'|'dynamic_joined_where'|'partition_without_storage'|" + "'partition_column_unknown'|'partition_column_not_public'|" + "'merge_key_scope_unresolved'|'preaggregate_over_dynamic_source'|" + "'authorize'|'partition'|'not_duckdb_portable'|" + "'public_surface_unknown'). 'given' is retained on the enum for records " + "that carry it and is no longer produced: where a given sits decides the " + "outcome, so one reason covering every placement cannot be raised.");
+var eligibilityRefusedCounter = lazyCounter("publisher_materialization_eligibility_refused_total", "materialization-eligibility refusals, both tiers. Label: reason " + "('free_parameter'|'given_in_persisted_query'|'dynamic_projection'|" + "'dynamic_join'|'dynamic_joined_where'|'partition_without_storage'|" + "'partition_column_unknown'|'partition_column_not_public'|" + "'merge_key_scope_unresolved'|'preaggregate_over_dynamic_source'|" + "'authorize'|'partition'|'not_duckdb_portable'|" + "'public_surface_unknown'|'read_only_dialect'). 'given' is retained on the enum for records " + "that carry it and is no longer produced: where a given sits decides the " + "outcome, so one reason covering every placement cannot be raised.");
 var serveShapeTierDropCounter = lazyCounter("publisher_storage_serve_shape_tier_drop_total", "storage serve-shape compile escalations: a refinement tier failed to " + "compile and the riskiest category was dropped, or one or more lifted " + "entry points failed to compile and were dropped alone. Label: tier (the " + "failed tier index, 0=full; 'lifts' for dropped lifts).");
 var serveShapeTypeFallbackCounter = lazyCounter("publisher_storage_serve_shape_type_fallback_total", "Captured DuckDB column types mapped to json in the serve shape (type " + "fidelity loss). Label: kind ('array'|'unrecognized').");
 var chainedStorageBuildCounter = lazyCounter("publisher_storage_chained_build_total", "Chained storage= source builds (a source reading a storage-materialized " + "upstream). Label: outcome ('parent_reuse'|'inline_fallback'|" + "'strict_shape_fallback'|'strict_refused'|'infra_failure'). The " + "parent_reuse share is the headline signal for how far the " + "stack-on-the-parent path gets us vs recompute-from-raw.");
@@ -25124,7 +25219,16 @@ function assertMergeKeyScopeResolvable(persistSource, terms, annotationFields, w
     message: `${what} cannot be materialized: it declares 'merge_key=' and is ` + `scoped by a term this pass cannot express as a predicate over the ` + `stored table's own columns (${unscopable.map((term) => `'${term.code}'`).join(", ")}). An incremental refresh matches rows by the merge ` + `key, and the stored table holds every caller's rows, so the match ` + `must also carry the scoping columns or it would update rows ` + `belonging to other callers. Scope this source with a term over its ` + `own columns, or drop 'merge_key=' to refresh by watermark range.`
   });
 }
+var READ_ONLY_DIALECTS = new Set(["sqlserver"]);
 function assertColocatedPersistNotAuthorizeGated(persistSource, sourceName = persistSource.name, origin = "persist", gateOutcome, annotationFields = {}) {
+  if (!annotationFields.storage && READ_ONLY_DIALECTS.has(persistSource.dialectName)) {
+    recordEligibilityRefused("read_only_dialect");
+    const what2 = origin === "preaggregate" ? `Pre-aggregation rollup '${sourceName}'` : `Source '${sourceName}'`;
+    throw new MaterializationEligibilityError({
+      reason: "read_only_dialect",
+      message: `${what2} cannot be materialized (colocated '#@ persist'): its ` + `connection '${persistSource.connectionName}' is on the ` + `'${persistSource.dialectName}' dialect, whose connection is ` + `read-only and creates no tables, so there is nowhere in the ` + `source warehouse to write the result. The source serves live. ` + `Remove the annotation, or persist a source on a connection that ` + `can write.`
+    });
+  }
   const partition = resolvePartitionColumns(persistSource, annotationFields);
   if (!partition.ok) {
     recordEligibilityRefused(partition.reason);
@@ -25859,6 +25963,7 @@ function collectColocatedSourceEligibility(compiled) {
 if (!parentPort) {
   throw new Error("package_load_worker.ts must be loaded inside a worker_threads Worker");
 }
+acceptBundledExperimentalDialects();
 var port = parentPort;
 var nextRpcId = 0;
 var pendingRpc = new Map;
@@ -26381,7 +26486,13 @@ async function prepareForMainThread(job, malloyConfig, load, model) {
   const pastDeadline = () => performance.now() >= load.softDeadline;
   const { modelPath, materializer, importBaseURL } = model;
   const renderTagResults = [];
-  for (const target of renderTagTargets(model.queries, model.sources)) {
+  const targets = renderTagTargets(model.queries, model.sources);
+  if (targets.length > 0 && !load.failed && !pastDeadline()) {
+    try {
+      model.model.queryModel;
+    } catch {}
+  }
+  for (const target of targets) {
     if (load.failed || pastDeadline())
       break;
     try {