@malloy-publisher/server 0.8.5 → 0.9.1

package/dist/package_load_worker.mjs

@@ -13058,9 +13058,54 @@ function logInternalFailure(summary, error, level = "error") {
     }
   });
 }
-function internalErrorToHttpError(error) {
+function filesystemAccessFailure(error) {
+  let current = error;
+  for (let depth = 0;depth < 8 && current instanceof Error; depth++) {
+    const errno = current;
+    if (typeof errno.code === "string" && errno.code in FILESYSTEM_ACCESS_DESCRIPTIONS && typeof errno.syscall === "string") {
+      return errno;
+    }
+    current = errno.cause;
+  }
+  return;
+}
+function describeFilesystemAccessFailure(errno) {
+  const code = errno.code ?? "";
+  const target = errno.path ? ` '${errno.path}'` : "";
+  return `${code}: ${FILESYSTEM_ACCESS_DESCRIPTIONS[code] ?? code}, ${errno.syscall}${target}`;
+}
+function messageWithFilesystemCause(error) {
+  const message = error instanceof Error ? error.message : String(error);
+  const access = filesystemAccessFailure(error);
+  if (!access || message.includes(access.code ?? ""))
+    return message;
+  return `${message}: ${describeFilesystemAccessFailure(access)}`;
+}
+function errnoWireFields(error) {
+  const { code, syscall, path } = error;
+  if (typeof code !== "string")
+    return;
+  return {
+    code,
+    ...typeof syscall === "string" ? { syscall } : {},
+    ...typeof path === "string" ? { path } : {}
+  };
+}
+function internalErrorToHttpError(error, { log = true } = {}) {
+  const logInternal = (...args) => {
+    if (log)
+      logInternalFailure(...args);
+  };
+  const access = filesystemAccessFailure(error);
+  if (access) {
+    logInternal("Filesystem access refused", error, "warn");
+    return httpError(500, `The server cannot access a path it needs (${describeFilesystemAccessFailure(access)}). ` + `Give the user the server runs as access to it.`);
+  }
   if (error instanceof BadRequestError) {
     return httpError(400, error.message);
+  } else if (error instanceof ServerConfigurationError) {
+    logInternal("Server configuration error", error, "warn");
+    return httpError(500, error.message);
   } else if (error instanceof FrozenConfigError) {
     return httpError(403, error.message);
   } else if (error instanceof AccessDeniedError) {
@@ -13106,7 +13151,7 @@ function internalErrorToHttpError(error) {
     if (error.callerSafe) {
       return httpError(502, error.message);
     }
-    logInternalFailure("Upstream connection error", error, "warn");
+    logInternal("Upstream connection error", error, "warn");
     return httpError(502, GENERIC_UPSTREAM_MESSAGE);
   } else if (error instanceof MaterializationNotFoundError) {
     return httpError(404, error.message);
@@ -13117,7 +13162,7 @@ function internalErrorToHttpError(error) {
   } else if (error instanceof WriteConflictError) {
     return httpError(409, error.message);
   } else if (error instanceof WriteRolledBackError) {
-    logInternalFailure("Dashboard write rolled back", error, "warn");
+    logInternal("Dashboard write rolled back", error, "warn");
     return httpError(500, error.message);
   } else if (error instanceof ServiceUnavailableError) {
     return httpError(503, error.message);
@@ -13128,7 +13173,7 @@ function internalErrorToHttpError(error) {
   } else if (error instanceof NotImplementedError) {
     return httpError(501, error.message);
   } else {
-    logInternalFailure("Unhandled internal error", error);
+    logInternal("Unhandled internal error", error);
     return httpError(500, GENERIC_INTERNAL_MESSAGE);
   }
 }
@@ -13150,10 +13195,15 @@ function toQueryTextProblem(problem) {
     ...problem.at ? { at: { range: problem.at.range } } : {}
   };
 }
-var GENERIC_INTERNAL_MESSAGE = "Internal server error.", GENERIC_UPSTREAM_MESSAGE = "Upstream connection error.", MAX_LOGGED_DETAIL_CHARS = 2000, NotImplementedError, BadRequestError, InvalidArgumentError, CompileRefusedError, EnvironmentNotFoundError, PackageNotFoundError, ModelNotFoundError, DashboardNotFoundError, ConnectionNotFoundError, TableNotFoundError, ConnectionError, DestinationNotFoundError, ConnectionAuthError, UnsupportedCatalogFormatError, ModelCompilationError, PackageManifestError, MaterializationEligibilityError, PublisherConfigError, FrozenConfigError, AccessDeniedError, QueryCompileError, NotQueryableError, OffSurfaceError, MaterializationNotFoundError, MaterializationConflictError, WriteConflictError, WriteRolledBackError, InvalidStateTransitionError, ServiceUnavailableError, PayloadTooLargeError, ResponseUnserializableError, QueryTimeoutError;
+var GENERIC_INTERNAL_MESSAGE = "Internal server error.", GENERIC_UPSTREAM_MESSAGE = "Upstream connection error.", MAX_LOGGED_DETAIL_CHARS = 2000, FILESYSTEM_ACCESS_DESCRIPTIONS, NotImplementedError, BadRequestError, InvalidArgumentError, CompileRefusedError, EnvironmentNotFoundError, PackageNotFoundError, ModelNotFoundError, DashboardNotFoundError, ConnectionNotFoundError, TableNotFoundError, ConnectionError, DestinationNotFoundError, ConnectionAuthError, UnsupportedCatalogFormatError, ModelCompilationError, PackageManifestError, MaterializationEligibilityError, PublisherConfigError, ServerConfigurationError, FrozenConfigError, AccessDeniedError, QueryCompileError, NotQueryableError, OffSurfaceError, MaterializationNotFoundError, MaterializationConflictError, WriteConflictError, WriteRolledBackError, InvalidStateTransitionError, ServiceUnavailableError, PayloadTooLargeError, ResponseUnserializableError, QueryTimeoutError;
 var init_errors = __esm(() => {
   init_constants();
   init_logger();
+  FILESYSTEM_ACCESS_DESCRIPTIONS = {
+    EACCES: "permission denied",
+    EPERM: "operation not permitted",
+    EROFS: "read-only file system"
+  };
   NotImplementedError = class NotImplementedError extends Error {
     constructor(message) {
       super(message);
@@ -13174,8 +13224,8 @@ var init_errors = __esm(() => {
     }
   };
   PackageNotFoundError = class PackageNotFoundError extends Error {
-    constructor(message) {
-      super(message);
+    constructor(message, options) {
+      super(message, options);
     }
   };
   ModelNotFoundError = class ModelNotFoundError extends Error {
@@ -13246,6 +13296,12 @@ var init_errors = __esm(() => {
       this.cause = cause;
     }
   };
+  ServerConfigurationError = class ServerConfigurationError extends Error {
+    constructor(message) {
+      super(message);
+      this.name = "ServerConfigurationError";
+    }
+  };
   FrozenConfigError = class FrozenConfigError extends Error {
     constructor(message = `Publisher config can't be updated when ${PUBLISHER_CONFIG_NAME} has { "frozenConfig": true }`) {
       super(message);
@@ -13303,8 +13359,8 @@ var init_errors = __esm(() => {
     }
   };
   ServiceUnavailableError = class ServiceUnavailableError extends Error {
-    constructor(message) {
-      super(message);
+    constructor(message, options) {
+      super(message, options);
     }
   };
   PayloadTooLargeError = class PayloadTooLargeError extends Error {
@@ -13723,6 +13779,76 @@ var init_data_styles = __esm(() => {
   init_logger();
 });
 
+// src/package_load/error_wire.ts
+import { MalloyError as MalloyError2 } from "@malloydata/malloy";
+function serializeError(error) {
+  const serialized = serializeErrorShape(error);
+  const errno = error instanceof Error ? errnoWireFields(error) : undefined;
+  return errno ? { ...serialized, errno } : serialized;
+}
+function serializeErrorShape(error) {
+  if (error instanceof MalloyError2) {
+    return {
+      name: error.name,
+      message: error.message,
+      stack: error.stack,
+      malloyProblems: error.problems,
+      isCompilationError: true
+    };
+  }
+  if (error instanceof ModelCompilationError) {
+    return {
+      name: error.name,
+      message: error.message,
+      stack: error.stack,
+      isCompilationError: true
+    };
+  }
+  if (error instanceof PackageManifestError) {
+    return {
+      name: error.name,
+      message: error.message,
+      stack: error.stack,
+      isManifestError: true
+    };
+  }
+  if (error instanceof Error) {
+    return {
+      name: error.name,
+      message: error.message,
+      stack: error.stack
+    };
+  }
+  return { name: "Error", message: String(error) };
+}
+function deserializeError(serialized) {
+  const err = new Error(serialized.message);
+  err.name = serialized.name;
+  if (serialized.stack)
+    err.stack = serialized.stack;
+  if (serialized.errno)
+    Object.assign(err, serialized.errno);
+  if (serialized.malloyProblems) {
+    err.problems = serialized.malloyProblems;
+  }
+  if (serialized.isCompilationError) {
+    const wrapped = new ModelCompilationError(err);
+    if (serialized.stack)
+      wrapped.stack = serialized.stack;
+    return wrapped;
+  }
+  if (serialized.isManifestError) {
+    const manifestError = new PackageManifestError(serialized.message);
+    if (serialized.stack)
+      manifestError.stack = serialized.stack;
+    return manifestError;
+  }
+  return err;
+}
+var init_error_wire = __esm(() => {
+  init_errors();
+});
+
 // src/service/annotations.ts
 import { Annotations } from "@malloydata/malloy";
 function isReservedRoute(route) {
@@ -15384,72 +15510,21 @@ function onMotlyRoute(text) {
 function hasEnvReference(annotation) {
   return annotation.includes("@env.");
 }
-function pollutionTargets() {
-  const targets = [Object.prototype];
-  for (const key of Object.getOwnPropertyNames(Object.prototype)) {
-    const descriptor = Object.getOwnPropertyDescriptor(Object.prototype, key);
-    if (!descriptor)
-      continue;
-    let value;
-    if ("value" in descriptor) {
-      value = descriptor.value;
-    } else {
-      if (BUILT_IN_PROTO_GETTER === undefined || descriptor.get !== BUILT_IN_PROTO_GETTER) {
-        return;
-      }
-      continue;
-    }
-    if ((typeof value === "object" || typeof value === "function") && value !== null && !targets.includes(value)) {
-      targets.push(value);
-    }
-  }
-  return targets;
-}
-function parseGuarded(texts) {
-  const targets = pollutionTargets();
-  if (targets === undefined) {
-    return { tag: undefined, messages: [UNSAFE_TO_PARSE] };
-  }
-  let unreadable = false;
-  const ownNames = (target) => {
-    try {
-      return Object.getOwnPropertyNames(target);
-    } catch {
-      unreadable = true;
-      return [];
-    }
-  };
-  const before = targets.map(ownNames);
-  if (unreadable)
-    return { tag: undefined, messages: [UNSAFE_TO_PARSE] };
-  const undoPollution = () => {
-    let polluted = false;
-    targets.forEach((target, index) => {
-      for (const key of ownNames(target)) {
-        if (before[index].includes(key))
-          continue;
-        polluted = true;
-        try {
-          delete target[key];
-        } catch {}
-      }
-    });
-    return polluted || unreadable;
-  };
+function parseBounded(texts) {
   if (texts.some((text) => text.length > MAX_ANNOTATION_CHARS)) {
     return { tag: undefined, messages: [ANNOTATION_TOO_LONG] };
   }
   try {
     const result = parseAnnotation([...texts]);
-    if (undoPollution())
-      return { tag: undefined, messages: [UNSAFE_TO_PARSE] };
     return {
       tag: result.tag,
       messages: result.log.map((error) => error.message)
     };
-  } catch {
-    undoPollution();
-    return { tag: undefined, messages: [UNSAFE_TO_PARSE] };
+  } catch (error) {
+    return {
+      tag: undefined,
+      messages: [error instanceof Error ? error.message : String(error)]
+    };
   }
 }
 function docCommentText(texts) {
@@ -15581,16 +15656,16 @@ function parseMotly(texts) {
   const envErrors = envDropped > 0 ? [ENV_REFERENCE_DROPPED] : [];
   if (motly.length === 0)
     return { tag: undefined, errors: envErrors };
-  const direct = parseGuarded(motly);
+  const direct = parseBounded(motly);
   if (direct.messages.length === 0)
     return { tag: direct.tag, errors: envErrors };
   const rescued = motly.map((text) => {
-    if (parseGuarded([text]).messages.length === 0)
+    if (parseBounded([text]).messages.length === 0)
       return text;
     const rewritten = quoteFilterLiterals(text);
-    return parseGuarded([rewritten]).messages.length === 0 ? rewritten : text;
+    return parseBounded([rewritten]).messages.length === 0 ? rewritten : text;
   });
-  const after = parseGuarded(rescued);
+  const after = parseBounded(rescued);
   return { tag: after.tag, errors: [...envErrors, ...after.messages] };
 }
 function tagText(tag, ...path) {
@@ -15656,9 +15731,8 @@ function readStartingGivens(tag, declaredType) {
   }
   return Object.keys(collected).length > 0 ? collected : undefined;
 }
-var BUILT_IN_PROTO_GETTER, MAX_ANNOTATION_CHARS = 8192, ANNOTATION_TOO_LONG, ENV_REFERENCE_DROPPED = "annotation dropped for carrying an @env. reference", UNSAFE_TO_PARSE = "annotation could not be parsed safely";
+var MAX_ANNOTATION_CHARS = 8192, ANNOTATION_TOO_LONG, ENV_REFERENCE_DROPPED = "annotation dropped for carrying an @env. reference";
 var init_motly = __esm(() => {
-  BUILT_IN_PROTO_GETTER = Object.getOwnPropertyDescriptor(Object.prototype, "__proto__")?.get;
   ANNOTATION_TOO_LONG = `annotation exceeds ${MAX_ANNOTATION_CHARS} characters and was not parsed`;
 });
 
@@ -23391,9 +23465,6 @@ function lintDashboard(facts, manifest) {
   return findings;
 }
 function describeParseFailure(message) {
-  if (message === UNSAFE_TO_PARSE) {
-    return `was refused rather than parsed (${message}), which can be caused by something outside this file`;
-  }
   if (message === ENV_REFERENCE_DROPPED) {
     return `was dropped rather than parsed (${message}), so nothing on that line took effect`;
   }
@@ -23990,6 +24061,7 @@ init_constants();
 init_authorize_metrics();
 init_data_styles();
 init_errors();
+init_error_wire();
 init_authorize();
 init_gate_classification();
 init_gate_dimension();
@@ -23998,7 +24070,6 @@ import {
   contextOverlay,
   isSourceDef as isSourceDef7,
   MalloyConfig,
-  MalloyError as MalloyError2,
   modelDefToModelInfo as modelDefToModelInfo2,
   Runtime
 } from "@malloydata/malloy";
@@ -24777,48 +24848,6 @@ async function loadPackage(job) {
     }
   };
 }
-function serializeError(error) {
-  if (error instanceof MalloyError2) {
-    return {
-      name: error.name,
-      message: error.message,
-      stack: error.stack,
-      malloyProblems: error.problems,
-      isCompilationError: true
-    };
-  }
-  if (error instanceof ModelCompilationError) {
-    return {
-      name: error.name,
-      message: error.message,
-      stack: error.stack,
-      isCompilationError: true
-    };
-  }
-  if (error instanceof PackageManifestError) {
-    return {
-      name: error.name,
-      message: error.message,
-      stack: error.stack,
-      isManifestError: true
-    };
-  }
-  if (error instanceof Error) {
-    return {
-      name: error.name,
-      message: error.message,
-      stack: error.stack
-    };
-  }
-  return { name: "Error", message: String(error) };
-}
-function deserializeError(serialized) {
-  const err = new Error(serialized.message);
-  err.name = serialized.name;
-  if (serialized.stack)
-    err.stack = serialized.stack;
-  return err;
-}
 var shuttingDown = false;
 var inFlightJobs = new Set;
 port.on("message", (message) => {