@malloy-publisher/server 0.10.3 → 0.10.4

package/dist/app/api-doc.yaml

@@ -7990,17 +7990,18 @@ components:
     BuildPlan:
       type: object
       description: |
-        The package's persist build plan. Mirrors Malloy's native build plan plus
-        the minimal per-source detail a caller needs to assign
-        identity/naming/realization. Lineage, policy, and connection capability
-        are intentionally omitted until they carry real data.
+        The package's persist build plan, from Malloy's build targets: the order
+        its persist sources build in, the tables each reads, and the minimal
+        per-source detail a caller needs to assign identity/naming/realization.
+        Policy and connection capability are intentionally omitted until they
+        carry real data.
       required: [graphs, sources]
       properties:
         graphs:
           type: array
           description: >-
             Dependency-ordered build graphs. One per connection per model, not one
-            per connection: a model contributes a graph for each connection its ROOT
+            per connection: a model contributes a graph for each connection its
             persist sources use, and a package's plan concatenates every model's, so
             the same source appears in the graph of every model that imports it.
           items:
@@ -8143,8 +8144,9 @@ components:
         nodes:
           type: array
           description:
-            Leveled build nodes; each inner array is one parallelizable level,
-            levels run in order.
+            A single level holding every persist source of the graph, in build
+            order. Each node's `dependsOn` names every source on every table it
+            reads, so the edges are complete without walking anything.
           items:
             type: array
             items:
@@ -8159,7 +8161,11 @@ components:
           description: "sourceName@modelURL"
         dependsOn:
           type: array
-          description: Upstream sourceIDs in this graph.
+          description: >-
+            sourceIDs of the sources on the tables this source reads. Sources on
+            one table (a source and its extensions) read none of each other. A
+            source Malloy cannot plan, which is refused rather than built, lists
+            none.
           items:
             type: string
 

package/dist/instrumentation.mjs

@@ -164831,7 +164831,7 @@ var init_telemetry = __esm(() => {
 });
 
 // package.json
-var version = "0.10.3";
+var version = "0.10.4";
 var init_package = () => {};
 
 // src/version.ts

package/dist/package_load_worker.mjs

@@ -22216,7 +22216,7 @@ async function compileSynthesizedPreaggregation(args) {
   const { runtime, importBaseURL } = await args.getRuntime(new Map([[synthesizedURL.href, text]]));
   const materializer = runtime.loadModel(synthesizedURL, { importBaseURL });
   const model = await materializer.getModel();
-  return { plans, model, materializer, text };
+  return { plans, model, materializer, runtime, text };
 }
 async function tryCompileSynthesizedPreaggregation(args) {
   try {
@@ -23215,27 +23215,47 @@ function composeDeclaredQueryMetadata(layers) {
   const resolved = Object.assign({}, ...ordered);
   return Object.keys(resolved).length > 0 ? resolved : null;
 }
-function flattenDependsOn(node) {
-  return node.dependsOn.map((d) => d.sourceID);
-}
-function* iterGraphSources(graph, sources) {
-  const seen = new Set;
-  function* visit(node) {
-    if (seen.has(node.sourceID))
-      return;
-    for (const dep of node.dependsOn) {
-      yield* visit(dep);
+function sourceBuildOf(build, unbuildable) {
+  const order = [];
+  const dependsOn = {};
+  for (const target of build.targets) {
+    const reads = target.dependsOn.flatMap((t) => t.sources.map((s) => s.sourceID));
+    for (const source of target.sources) {
+      order.push(source.sourceID);
+      dependsOn[source.sourceID] = reads;
     }
-    seen.add(node.sourceID);
-    const source = sources[node.sourceID];
+  }
+  for (const { source } of unbuildable) {
+    if (source.connectionName !== build.connectionName)
+      continue;
+    order.push(source.sourceID);
+    dependsOn[source.sourceID] = [];
+  }
+  return { connectionName: build.connectionName, order, dependsOn };
+}
+function sourceBuildsOf(targets) {
+  const builds = targets.connections.map((c) => sourceBuildOf(c, targets.unbuildable));
+  const planned = new Set(builds.map((b) => b.connectionName));
+  for (const { source } of targets.unbuildable) {
+    if (planned.has(source.connectionName))
+      continue;
+    planned.add(source.connectionName);
+    builds.push(sourceBuildOf({ connectionName: source.connectionName, targets: [] }, targets.unbuildable));
+  }
+  return builds;
+}
+function plannedSources(targets) {
+  return [
+    ...targets.connections.flatMap((c) => c.targets.flatMap((t) => t.sources)),
+    ...targets.unbuildable.map((u) => u.source)
+  ];
+}
+function* sourcesInBuildOrder(build, sources) {
+  for (const sourceID of build.order) {
+    const source = sources[sourceID];
     if (source)
       yield source;
   }
-  for (const level of graph.nodes) {
-    for (const node of level) {
-      yield* visit(node);
-    }
-  }
 }
 function computeSourceEntityId(source, connectionDigests) {
   return source.makeBuildId(connectionDigests[source.connectionName], addressPartitionLayout(source, source.getSQL()));
@@ -23324,7 +23344,7 @@ async function classifyPersistSourceGate(persistSource, modelDef, materializer,
 }
 function emptyBuildPlanParts() {
   return {
-    graphs: [],
+    builds: [],
     sources: {},
     sourceModelPaths: {},
     droppedPersistSources: [],
@@ -23333,7 +23353,7 @@ function emptyBuildPlanParts() {
   };
 }
 function mergeBuildPlanParts(into, from) {
-  into.graphs.push(...from.graphs);
+  into.builds.push(...from.builds);
   Object.assign(into.sources, from.sources);
   Object.assign(into.sourceModelPaths, from.sourceModelPaths);
   into.droppedPersistSources.push(...from.droppedPersistSources);
@@ -23341,7 +23361,14 @@ function mergeBuildPlanParts(into, from) {
   Object.assign(into.sourceGateOutcomes, from.sourceGateOutcomes);
 }
 async function collectModelBuildPlan(parts, args) {
-  const { modelPath, packagePath, materializer, malloyModel, getRuntime } = args;
+  const {
+    modelPath,
+    packagePath,
+    materializer,
+    malloyModel,
+    runtime,
+    getRuntime
+  } = args;
   const synthesized = args.synthesized !== undefined ? args.synthesized : await tryCompileSynthesizedPreaggregation({
     packagePath,
     modelPath,
@@ -23349,14 +23376,14 @@ async function collectModelBuildPlan(parts, args) {
     contents: malloyModel._modelDef?.contents ?? {}
   });
   if (synthesized) {
-    const rollupPlan = synthesized.model.getBuildPlan();
-    const rollupNames = new Set(synthesized.plans.map((p) => p.rollupSourceName));
-    parts.graphs.push(...rollupPlan.graphs);
+    const rollupTargets = await synthesized.runtime.getBuildTargets(synthesized.model);
+    parts.builds.push(...sourceBuildsOf(rollupTargets));
     const planByName = new Map(synthesized.plans.map((p) => [p.rollupSourceName, p]));
     let rollupClassificationCtx;
-    for (const [sourceID, source] of Object.entries(rollupPlan.sources)) {
-      if (!rollupNames.has(source.name))
+    for (const source of plannedSources(rollupTargets)) {
+      if (!planByName.has(source.name))
         continue;
+      const sourceID = source.sourceID;
       parts.sources[sourceID] = source;
       parts.sourceModelPaths[sourceID] = modelPath;
       const rollup = planByName.get(source.name);
@@ -23375,23 +23402,25 @@ async function collectModelBuildPlan(parts, args) {
   const modelTag = malloyModel.modelAnnotations.parseAsTag("!").tag;
   if (!modelTag.has("experimental", "persistence"))
     return;
-  const buildPlan = malloyModel.getBuildPlan();
-  for (const msg of buildPlan.tagParseLog) {
+  const targets = await runtime.getBuildTargets(malloyModel);
+  for (const msg of targets.tagParseLog) {
     logger.warn("Persist annotation issue", {
       modelPath,
       message: msg.message,
       severity: msg.severity
     });
   }
-  const recognizedNames = new Set(Object.values(buildPlan.sources).map((s) => s.name));
+  const planned = plannedSources(targets);
+  const recognizedNames = new Set(planned.map((s) => s.name));
   for (const name of detectDroppedPersistSources(malloyModel, recognizedNames)) {
     parts.droppedPersistSources.push({ name, modelPath });
   }
-  if (buildPlan.graphs.length === 0)
+  if (planned.length === 0)
     return;
-  parts.graphs.push(...buildPlan.graphs);
+  parts.builds.push(...sourceBuildsOf(targets));
   let classificationCtx;
-  for (const [sourceID, source] of Object.entries(buildPlan.sources)) {
+  for (const source of planned) {
+    const sourceID = source.sourceID;
     parts.sources[sourceID] = source;
     parts.sourceModelPaths[sourceID] = modelPath;
     if (!classificationCtx) {
@@ -23404,28 +23433,30 @@ async function collectModelBuildPlan(parts, args) {
     parts.sourceGateOutcomes[sourceID] = await classifyPersistSourceGate(source, classificationCtx.modelDef, materializer, classificationCtx.deps, modelPath);
   }
 }
-async function resolveConnectionDigests(connections, graphs, onSkipped) {
+async function resolveConnectionDigests(connections, builds, onSkipped) {
   const connectionDigests = {};
-  for (const graph of graphs) {
-    const conn = connections.get(graph.connectionName);
+  for (const build of builds) {
+    const conn = connections.get(build.connectionName);
     if (!conn) {
-      onSkipped(graph.connectionName);
+      onSkipped(build.connectionName);
       continue;
     }
-    if (!connectionDigests[graph.connectionName]) {
-      connectionDigests[graph.connectionName] = await conn.getDigest();
+    if (!connectionDigests[build.connectionName]) {
+      connectionDigests[build.connectionName] = await conn.getDigest();
     }
   }
   return connectionDigests;
 }
-function deriveBuildPlan(graphs, sources, connectionDigests, sourceNames, sourceModelPaths, packageMaterialization, options) {
+function deriveBuildPlan(builds, sources, connectionDigests, sourceNames, sourceModelPaths, packageMaterialization, options) {
   const include = sourceNames ? new Set(sourceNames) : null;
-  const wireGraphs = graphs.map((graph) => ({
-    connectionName: graph.connectionName,
-    nodes: graph.nodes.map((level) => level.map((node) => ({
-      sourceID: node.sourceID,
-      dependsOn: flattenDependsOn(node)
-    })))
+  const wireGraphs = builds.map((build) => ({
+    connectionName: build.connectionName,
+    nodes: [
+      build.order.map((sourceID) => ({
+        sourceID,
+        dependsOn: build.dependsOn[sourceID] ?? []
+      }))
+    ]
   }));
   const wireSources = {};
   const refusedSources = {};
@@ -23514,7 +23545,7 @@ function deriveBuildPlan(graphs, sources, connectionDigests, sourceNames, source
 function deriveBuildPlanOutcome(compiled, materializationConfig) {
   const droppedPersistSources = compiled.droppedPersistSources ?? [];
   const incrementalDeclarations = collectIncrementalDeclarations(compiled.sources);
-  const plan = compiled.graphs.length === 0 ? null : deriveBuildPlan(compiled.graphs, compiled.sources, compiled.connectionDigests, undefined, compiled.sourceModelPaths, materializationConfig, {
+  const plan = compiled.builds.length === 0 ? null : deriveBuildPlan(compiled.builds, compiled.sources, compiled.connectionDigests, undefined, compiled.sourceModelPaths, materializationConfig, {
     preaggregatePlans: compiled.preaggregatePlans,
     sourceGateOutcomes: compiled.sourceGateOutcomes
   });
@@ -24474,6 +24505,7 @@ async function compileMalloyModel(job, malloyConfig, modelPath, load) {
     modelPath,
     materializer: mm,
     model: compiled,
+    runtime,
     importBaseURL,
     queries,
     sources
@@ -24559,6 +24591,7 @@ async function prepareForMainThread(job, malloyConfig, load, model) {
         packagePath: job.packagePath,
         materializer,
         malloyModel: model.model,
+        runtime: model.runtime,
         getRuntime: companionRuntime,
         synthesized: companion
       });
@@ -24798,8 +24831,8 @@ async function finishWorkerBuildPlan(malloyConfig, modelPaths, load, materializa
     }
     const connections = await resolvePackageConnections({
       getMalloyConnection: (name) => malloyConfig.connections.lookupConnection(name)
-    }, parts.graphs.map((g) => g.connectionName));
-    const connectionDigests = await resolveConnectionDigests(connections, parts.graphs, (name) => digestSkipped.push(name));
+    }, parts.builds.map((b) => b.connectionName));
+    const connectionDigests = await resolveConnectionDigests(connections, parts.builds, (name) => digestSkipped.push(name));
     const outcome = deriveBuildPlanOutcome({ ...parts, connectionDigests }, materializationConfig);
     return {
       ok: true,

package/dist/server.mjs

@@ -164832,7 +164832,7 @@ var init_telemetry = __esm(() => {
 });
 
 // package.json
-var version = "0.10.3";
+var version = "0.10.4";
 var init_package = () => {};
 
 // src/version.ts
@@ -348115,7 +348115,7 @@ async function compileSynthesizedPreaggregation(args) {
   const { runtime, importBaseURL } = await args.getRuntime(new Map([[synthesizedURL.href, text]]));
   const materializer = runtime.loadModel(synthesizedURL, { importBaseURL });
   const model = await materializer.getModel();
-  return { plans, model, materializer, text };
+  return { plans, model, materializer, runtime, text };
 }
 async function tryCompileSynthesizedPreaggregation(args) {
   try {
@@ -348302,27 +348302,47 @@ function composeDeclaredQueryMetadata(layers) {
   const resolved = Object.assign({}, ...ordered);
   return Object.keys(resolved).length > 0 ? resolved : null;
 }
-function flattenDependsOn(node) {
-  return node.dependsOn.map((d) => d.sourceID);
-}
-function* iterGraphSources(graph, sources) {
-  const seen = new Set;
-  function* visit(node) {
-    if (seen.has(node.sourceID))
-      return;
-    for (const dep of node.dependsOn) {
-      yield* visit(dep);
+function sourceBuildOf(build, unbuildable) {
+  const order = [];
+  const dependsOn = {};
+  for (const target of build.targets) {
+    const reads = target.dependsOn.flatMap((t2) => t2.sources.map((s2) => s2.sourceID));
+    for (const source of target.sources) {
+      order.push(source.sourceID);
+      dependsOn[source.sourceID] = reads;
     }
-    seen.add(node.sourceID);
-    const source = sources[node.sourceID];
+  }
+  for (const { source } of unbuildable) {
+    if (source.connectionName !== build.connectionName)
+      continue;
+    order.push(source.sourceID);
+    dependsOn[source.sourceID] = [];
+  }
+  return { connectionName: build.connectionName, order, dependsOn };
+}
+function sourceBuildsOf(targets) {
+  const builds = targets.connections.map((c) => sourceBuildOf(c, targets.unbuildable));
+  const planned = new Set(builds.map((b) => b.connectionName));
+  for (const { source } of targets.unbuildable) {
+    if (planned.has(source.connectionName))
+      continue;
+    planned.add(source.connectionName);
+    builds.push(sourceBuildOf({ connectionName: source.connectionName, targets: [] }, targets.unbuildable));
+  }
+  return builds;
+}
+function plannedSources(targets) {
+  return [
+    ...targets.connections.flatMap((c) => c.targets.flatMap((t2) => t2.sources)),
+    ...targets.unbuildable.map((u) => u.source)
+  ];
+}
+function* sourcesInBuildOrder(build, sources) {
+  for (const sourceID of build.order) {
+    const source = sources[sourceID];
     if (source)
       yield source;
   }
-  for (const level of graph.nodes) {
-    for (const node of level) {
-      yield* visit(node);
-    }
-  }
 }
 function computeSourceEntityId(source, connectionDigests) {
   return source.makeBuildId(connectionDigests[source.connectionName], addressPartitionLayout(source, source.getSQL()));
@@ -348411,7 +348431,7 @@ async function classifyPersistSourceGate(persistSource, modelDef, materializer,
 }
 function emptyBuildPlanParts() {
   return {
-    graphs: [],
+    builds: [],
     sources: {},
     sourceModelPaths: {},
     droppedPersistSources: [],
@@ -348420,7 +348440,7 @@ function emptyBuildPlanParts() {
   };
 }
 function mergeBuildPlanParts(into, from) {
-  into.graphs.push(...from.graphs);
+  into.builds.push(...from.builds);
   Object.assign(into.sources, from.sources);
   Object.assign(into.sourceModelPaths, from.sourceModelPaths);
   into.droppedPersistSources.push(...from.droppedPersistSources);
@@ -348428,7 +348448,14 @@ function mergeBuildPlanParts(into, from) {
   Object.assign(into.sourceGateOutcomes, from.sourceGateOutcomes);
 }
 async function collectModelBuildPlan(parts, args) {
-  const { modelPath, packagePath, materializer, malloyModel, getRuntime } = args;
+  const {
+    modelPath,
+    packagePath,
+    materializer,
+    malloyModel,
+    runtime,
+    getRuntime
+  } = args;
   const synthesized = args.synthesized !== undefined ? args.synthesized : await tryCompileSynthesizedPreaggregation({
     packagePath,
     modelPath,
@@ -348436,14 +348463,14 @@ async function collectModelBuildPlan(parts, args) {
     contents: malloyModel._modelDef?.contents ?? {}
   });
   if (synthesized) {
-    const rollupPlan = synthesized.model.getBuildPlan();
-    const rollupNames = new Set(synthesized.plans.map((p) => p.rollupSourceName));
-    parts.graphs.push(...rollupPlan.graphs);
+    const rollupTargets = await synthesized.runtime.getBuildTargets(synthesized.model);
+    parts.builds.push(...sourceBuildsOf(rollupTargets));
     const planByName = new Map(synthesized.plans.map((p) => [p.rollupSourceName, p]));
     let rollupClassificationCtx;
-    for (const [sourceID, source] of Object.entries(rollupPlan.sources)) {
-      if (!rollupNames.has(source.name))
+    for (const source of plannedSources(rollupTargets)) {
+      if (!planByName.has(source.name))
         continue;
+      const sourceID = source.sourceID;
       parts.sources[sourceID] = source;
       parts.sourceModelPaths[sourceID] = modelPath;
       const rollup = planByName.get(source.name);
@@ -348462,23 +348489,25 @@ async function collectModelBuildPlan(parts, args) {
   const modelTag = malloyModel.modelAnnotations.parseAsTag("!").tag;
   if (!modelTag.has("experimental", "persistence"))
     return;
-  const buildPlan = malloyModel.getBuildPlan();
-  for (const msg of buildPlan.tagParseLog) {
+  const targets = await runtime.getBuildTargets(malloyModel);
+  for (const msg of targets.tagParseLog) {
     logger.warn("Persist annotation issue", {
       modelPath,
       message: msg.message,
       severity: msg.severity
     });
   }
-  const recognizedNames = new Set(Object.values(buildPlan.sources).map((s2) => s2.name));
+  const planned = plannedSources(targets);
+  const recognizedNames = new Set(planned.map((s2) => s2.name));
   for (const name of detectDroppedPersistSources(malloyModel, recognizedNames)) {
     parts.droppedPersistSources.push({ name, modelPath });
   }
-  if (buildPlan.graphs.length === 0)
+  if (planned.length === 0)
     return;
-  parts.graphs.push(...buildPlan.graphs);
+  parts.builds.push(...sourceBuildsOf(targets));
   let classificationCtx;
-  for (const [sourceID, source] of Object.entries(buildPlan.sources)) {
+  for (const source of planned) {
+    const sourceID = source.sourceID;
     parts.sources[sourceID] = source;
     parts.sourceModelPaths[sourceID] = modelPath;
     if (!classificationCtx) {
@@ -348491,28 +348520,30 @@ async function collectModelBuildPlan(parts, args) {
     parts.sourceGateOutcomes[sourceID] = await classifyPersistSourceGate(source, classificationCtx.modelDef, materializer, classificationCtx.deps, modelPath);
   }
 }
-async function resolveConnectionDigests(connections, graphs, onSkipped) {
+async function resolveConnectionDigests(connections, builds, onSkipped) {
   const connectionDigests = {};
-  for (const graph of graphs) {
-    const conn = connections.get(graph.connectionName);
+  for (const build of builds) {
+    const conn = connections.get(build.connectionName);
     if (!conn) {
-      onSkipped(graph.connectionName);
+      onSkipped(build.connectionName);
       continue;
     }
-    if (!connectionDigests[graph.connectionName]) {
-      connectionDigests[graph.connectionName] = await conn.getDigest();
+    if (!connectionDigests[build.connectionName]) {
+      connectionDigests[build.connectionName] = await conn.getDigest();
     }
   }
   return connectionDigests;
 }
-function deriveBuildPlan(graphs, sources, connectionDigests, sourceNames, sourceModelPaths, packageMaterialization, options) {
+function deriveBuildPlan(builds, sources, connectionDigests, sourceNames, sourceModelPaths, packageMaterialization, options) {
   const include = sourceNames ? new Set(sourceNames) : null;
-  const wireGraphs = graphs.map((graph) => ({
-    connectionName: graph.connectionName,
-    nodes: graph.nodes.map((level) => level.map((node) => ({
-      sourceID: node.sourceID,
-      dependsOn: flattenDependsOn(node)
-    })))
+  const wireGraphs = builds.map((build) => ({
+    connectionName: build.connectionName,
+    nodes: [
+      build.order.map((sourceID) => ({
+        sourceID,
+        dependsOn: build.dependsOn[sourceID] ?? []
+      }))
+    ]
   }));
   const wireSources = {};
   const refusedSources = {};
@@ -348601,7 +348632,7 @@ function deriveBuildPlan(graphs, sources, connectionDigests, sourceNames, source
 function deriveBuildPlanOutcome(compiled, materializationConfig) {
   const droppedPersistSources = compiled.droppedPersistSources ?? [];
   const incrementalDeclarations = collectIncrementalDeclarations(compiled.sources);
-  const plan = compiled.graphs.length === 0 ? null : deriveBuildPlan(compiled.graphs, compiled.sources, compiled.connectionDigests, undefined, compiled.sourceModelPaths, materializationConfig, {
+  const plan = compiled.builds.length === 0 ? null : deriveBuildPlan(compiled.builds, compiled.sources, compiled.connectionDigests, undefined, compiled.sourceModelPaths, materializationConfig, {
     preaggregatePlans: compiled.preaggregatePlans,
     sourceGateOutcomes: compiled.sourceGateOutcomes
   });
@@ -350136,14 +350167,14 @@ async function buildDownstreamIntoStorage(params) {
         message: `Chained build model did not compile over the rebound parents: ${errMessage(err)}`
       });
     }
-    const plan = model.getBuildPlan();
-    let downstream;
-    for (const ps of Object.values(plan.sources)) {
-      if (ps.name === downstreamName) {
-        downstream = ps;
-        break;
-      }
+    const targets = await runtime.getBuildTargets(model, { virtualMap });
+    const unbuildable = targets.unbuildable.find((u) => u.source.name === downstreamName);
+    if (unbuildable) {
+      throw new MaterializationEligibilityError({
+        message: `Chained build model could not plan '${downstreamName}' over ` + `the rebound parents: ${unbuildable.problem.message}`
+      });
     }
+    const downstream = plannedSources(targets).find((ps) => ps.name === downstreamName);
     if (!downstream) {
       throw new MaterializationEligibilityError({
         message: `Chained build model did not yield a persist source named ` + `'${downstreamName}' (the downstream references something the ` + `rebound parents don't provide).`
@@ -359860,6 +359891,98 @@ var require_recursive_readdir = __commonJS((exports, module) => {
   module.exports = readdir3;
 });
 
+// src/service/preaggregation_coverage.ts
+function rollupMeasuresByMember(plans) {
+  return new Map(plans.map((p2) => [
+    p2.rollupSourceName,
+    new Set(p2.measures.map((m3) => m3.name))
+  ]));
+}
+function rollupCoverageViolation(query, rollupMeasures) {
+  const ir2 = query;
+  const member = ir2?.compositeResolvedSourceDef?.as;
+  if (!member)
+    return;
+  const merged = rollupMeasures.get(member);
+  if (!merged)
+    return;
+  const memberFields = new Map((ir2?.compositeResolvedSourceDef?.fields ?? []).map((f5) => [
+    f5.as ?? f5.name,
+    f5
+  ]));
+  const followed = new Set;
+  let violation;
+  const visitRef = (path16) => {
+    if (!path16)
+      return;
+    if (path16.length !== 1) {
+      violation = `reference ${path16.join(".")} reaches past the rollup's own fields`;
+      return;
+    }
+    const name = path16[0];
+    if (merged.has(name) || followed.has(name))
+      return;
+    followed.add(name);
+    visitExpr(memberFields.get(name)?.e);
+  };
+  const visitExpr = (e2) => {
+    if (violation || !e2 || typeof e2 !== "object")
+      return;
+    if (Array.isArray(e2)) {
+      for (const item of e2)
+        visitExpr(item);
+      return;
+    }
+    const n = e2;
+    if (n.node === "aggregate") {
+      violation = `aggregate ${String(n.function)}() is computed over the rollup's rows, not from a stored partial`;
+      return;
+    }
+    if (n.node === "function_call" && n.overload?.returnType?.expressionType === "aggregate") {
+      violation = `aggregate function ${String(n.name)}() is computed over the rollup's rows, not from a stored partial`;
+      return;
+    }
+    if (n.node === "field") {
+      visitRef(n.path);
+      return;
+    }
+    for (const [key, value] of Object.entries(n)) {
+      if (key === "overload" || key === "at")
+        continue;
+      visitExpr(value);
+    }
+  };
+  const visitStage = (stage) => {
+    if (violation)
+      return;
+    if (stage?.type === "project" || stage?.type === "index") {
+      violation = `${stage.type === "project" ? "a select:" : "an index:"} stage over the rollup returns one row per grain group, not the source's rows`;
+      return;
+    }
+    for (const field of stage?.queryFields ?? []) {
+      if (field.type === "fieldref")
+        visitRef(field.path);
+      else if (field.type === "turtle")
+        visitStage(field.pipeline?.[0]);
+      else
+        visitExpr(field.e);
+    }
+    for (const filter2 of stage?.filterList ?? [])
+      visitExpr(filter2.e);
+  };
+  visitStage(ir2?.pipeline?.[0]);
+  return violation ? `${member}: ${violation}` : undefined;
+}
+var RollupCoverageError;
+var init_preaggregation_coverage = __esm(() => {
+  RollupCoverageError = class RollupCoverageError extends Error {
+    constructor(message) {
+      super(message);
+      this.name = "RollupCoverageError";
+    }
+  };
+});
+
 // src/service/render_tag_targets.ts
 function renderTagTargets(queries, sources) {
   const targets = [];
@@ -363064,6 +363187,11 @@ class StorageServeShape {
     await this.host.ensureSharedQueryModel(this.serveShapeCache.materializer);
     const runnable = this.serveShapeCache.materializer.loadRestrictedQuery(queryString);
     const probeSQL = await runnable.getSQL({ virtualMap, givens });
+    if (groups.length > 0) {
+      const uncovered = rollupCoverageViolation((await runnable.getPreparedQuery())._query, rollupMeasuresByMember(this.host.rollupPlans()));
+      if (uncovered)
+        throw new RollupCoverageError(uncovered);
+    }
     const rollupPaths = [
       ...buildVirtualMap(groups.flatMap((g2) => g2.members))
     ].flatMap(([, byHandle]) => [...byHandle.values()]);
@@ -363264,6 +363392,7 @@ var init_model_serve_shape = __esm(() => {
   init_materialization_metrics();
   init_connection();
   init_materialization_serve_transform();
+  init_preaggregation_coverage();
   init_preaggregation_serve_bindings();
   staleBindingsWithheld = lazyCounter("publisher_storage_bindings_withheld_total", "Storage serve bindings withheld from a routed query because the freshness gate found them stale; each one is read live instead. Until now staleness was visible only as a later live read.");
 });
@@ -363306,6 +363435,7 @@ var init_model = __esm(() => {
   init_config();
   init_preaggregation_synthesis();
   init_preaggregation_compile();
+  init_preaggregation_coverage();
   init_render_tag_targets();
   init_model_info();
   init_logger();
@@ -365487,13 +365617,17 @@ run: ${sourceName ? `${quoteMalloyIdentifier2(sourceName)} -> ` : ""}${quoteMall
             });
           } catch (shapeErr) {
             recordStorageServeRouting("live_fallback");
-            const { shapeSources, staleSources } = serveShapeDiagnostics(this.storageServe.serveBindings, this.storageServe.freshServeBindings(Date.now()));
-            logger.info("storage serve-shape ineligible for this query; serving live", {
-              modelPath: this.modelPath,
-              error: shapeErr instanceof Error ? shapeErr.message : String(shapeErr),
-              shapeSources,
-              staleSources
-            });
+            if (shapeErr instanceof RollupCoverageError) {
+              logger.debug("storage rollup cannot answer this query; serving live", { modelPath: this.modelPath, error: shapeErr.message });
+            } else {
+              const { shapeSources, staleSources } = serveShapeDiagnostics(this.storageServe.serveBindings, this.storageServe.freshServeBindings(Date.now()));
+              logger.info("storage serve-shape ineligible for this query; serving live", {
+                modelPath: this.modelPath,
+                error: shapeErr instanceof Error ? shapeErr.message : String(shapeErr),
+                shapeSources,
+                staleSources
+              });
+            }
           }
         }
         const everyRollupIsStorageBound = this.preaggregateRollupPlans.length > 0 && this.preaggregateRollupPlans.every((plan) => !!plan.storage);
@@ -365504,10 +365638,13 @@ run: ${sourceName ? `${quoteMalloyIdentifier2(sourceName)} -> ` : ""}${quoteMall
               givens: querySurfaceGivens,
               buildManifest
             });
+            const uncovered = rollupCoverageViolation((await candidate.getPreparedQuery())._query, rollupMeasuresByMember(this.preaggregateRollupPlans));
+            if (uncovered)
+              throw new RollupCoverageError(uncovered);
             runnable = candidate;
             preaggRouted = true;
           } catch (preaggErr) {
-            logger.debug("query does not compile against the pre-aggregation model; serving live", {
+            logger.debug("query cannot be served from the pre-aggregation model; serving live", {
               modelPath: this.modelPath,
               error: preaggErr instanceof Error ? preaggErr.message : String(preaggErr)
             });
@@ -366140,18 +366277,19 @@ async function compilePackageBuildPlan(pkg, signal) {
       packagePath: pkg.getPackagePath(),
       materializer,
       malloyModel,
+      runtime,
       getRuntime: (overlay) => Model.getModelRuntime(pkg.getPackagePath(), modelPath, pkg.getMalloyConfig(), { overlay })
     });
   }
-  const connections = await resolvePackageConnections(pkg, parts.graphs.map((g2) => g2.connectionName));
-  const connectionDigests = await resolveConnectionDigests(connections, parts.graphs, (connectionName) => {
+  const connections = await resolvePackageConnections(pkg, parts.builds.map((b3) => b3.connectionName));
+  const connectionDigests = await resolveConnectionDigests(connections, parts.builds, (connectionName) => {
     recordConnectionDigestSkipped();
     logger.warn("Skipping connection digest; connection did not resolve", {
       connectionName
     });
   });
   return {
-    graphs: parts.graphs,
+    builds: parts.builds,
     sources: parts.sources,
     connectionDigests,
     connections,
@@ -374591,11 +374729,11 @@ function resolveInstruction(index, persistSource, connectionDigests) {
     return;
   return { instruction, orchestrated: false, sourceEntityId };
 }
-function assertNoTableCollisions(graphs, sources, connectionDigests, index) {
+function assertNoTableCollisions(builds, sources, connectionDigests, index) {
   const claimedBy = new Map;
   const collisions = [];
-  for (const graph of graphs) {
-    for (const persistSource of iterGraphSources(graph, sources)) {
+  for (const build of builds) {
+    for (const persistSource of sourcesInBuildOrder(build, sources)) {
       let address;
       try {
         address = computeSourceEntityId(persistSource, connectionDigests);
@@ -374605,7 +374743,7 @@ function assertNoTableCollisions(graphs, sources, connectionDigests, index) {
       const instruction = index.bySourceID.get(persistSource.sourceID) ?? index.bySourceEntityId.get(address);
       if (!instruction)
         continue;
-      const target = physicalTargetKey(instruction, graph.connectionName);
+      const target = physicalTargetKey(instruction, build.connectionName);
       const claim = claimedBy.get(target);
       if (!claim) {
         claimedBy.set(target, {
@@ -374896,8 +375034,8 @@ class MaterializationService {
     const refusals = [];
     const cleared = new Map;
     const seen = new Set;
-    for (const graph of compiled.graphs) {
-      for (const persistSource of iterGraphSources(graph, compiled.sources)) {
+    for (const build of compiled.builds) {
+      for (const persistSource of sourcesInBuildOrder(build, compiled.sources)) {
         if (include && !include.has(persistSource.name))
           continue;
         if (getPersistStorageMode() === "off" && declaredStorage(persistSource)) {
@@ -375153,7 +375291,7 @@ class MaterializationService {
     return incrementalRunContext(compiled, run, this.repository);
   }
   async executeInstructedBuild(compiled, environment, instructions, seedEntries, signal, strict = false, owner, buildMetadata, incremental, priorRefusals = [], clearedTiers) {
-    const { graphs, sources, connectionDigests, connections } = compiled;
+    const { builds, sources, connectionDigests, connections } = compiled;
     const index = indexInstructions(instructions);
     const run = {
       compiled,
@@ -375173,17 +375311,17 @@ class MaterializationService {
       builtSources: [],
       writtenTargets: new Map
     };
-    assertNoTableCollisions(graphs, sources, connectionDigests, index);
+    assertNoTableCollisions(builds, sources, connectionDigests, index);
     try {
-      for (const graph of graphs) {
-        const connection = connections.get(graph.connectionName);
+      for (const build of builds) {
+        const connection = connections.get(build.connectionName);
         if (!connection) {
-          throw new BadRequestError(`Connection '${graph.connectionName}' not found`);
+          throw new BadRequestError(`Connection '${build.connectionName}' not found`);
         }
-        for (const persistSource of iterGraphSources(graph, sources)) {
+        for (const persistSource of sourcesInBuildOrder(build, sources)) {
           if (signal.aborted)
             throw new Error("Build cancelled");
-          await this.buildInstructedSource(run, persistSource, graph.connectionName, connection);
+          await this.buildInstructedSource(run, persistSource, build.connectionName, connection);
         }
       }
       if (run.builtSources.length === 0 && run.failedReasons.length > 0) {

package/package.json

@@ -19,7 +19,7 @@
       "snowflake"
    ],
    "homepage": "https://docs.malloydata.dev/documentation/user_guides/publishing/mcp_agents",
-   "version": "0.10.3",
+   "version": "0.10.4",
    "main": "dist/server.mjs",
    "bin": {
       "malloy-publisher": "dist/server.mjs"