@malloy-publisher/sdk 0.0.128 → 0.0.130

package/package.json

@@ -1,7 +1,7 @@
 {
    "name": "@malloy-publisher/sdk",
    "description": "Malloy Publisher SDK",
-   "version": "0.0.128",
+   "version": "0.0.130",
    "type": "module",
    "main": "dist/index.cjs.js",
    "module": "dist/index.es.js",

package/src/components/Connections/common.ts

@@ -130,6 +130,16 @@ export const connectionFieldsByType: Record<
          name: "responseTimeoutMilliseconds",
          type: "text",
       },
+      {
+         label: "Private Key",
+         name: "privateKey",
+         type: "password",
+      },
+      {
+         label: "Private Key Passphrase",
+         name: "privateKeyPass",
+         type: "password",
+      },
    ],
    trino: [
       {

package/src/components/Model/Model.tsx

@@ -23,6 +23,7 @@ interface ModelProps {
    onChange?: (query: QueryExplorerResult) => void;
    resourceUri: string;
    runOnDemand?: boolean;
+   maxResultSize?: number;
 }
 
 // Note: For this to properly render outside of publisher,
@@ -33,6 +34,7 @@ export default function Model({
    onChange,
    resourceUri,
    runOnDemand = false,
+   maxResultSize = 0,
 }: ModelProps) {
    const { modelPath } = parseResourceUri(resourceUri);
    const { data, isError, isLoading, error } = useModelData(resourceUri);
@@ -190,6 +192,7 @@ export default function Model({
                         annotations={query.annotations}
                         resourceUri={resourceUri}
                         runOnDemand={runOnDemand}
+                        maxResultSize={maxResultSize}
                      />
                   ))}
                </Stack>

package/src/components/Model/ModelCell.tsx

@@ -17,6 +17,7 @@ interface ModelCellProps {
    annotations?: string[];
    resourceUri: string;
    runOnDemand?: boolean;
+   maxResultSize?: number;
 }
 
 export function ModelCell({
@@ -24,6 +25,7 @@ export function ModelCell({
    annotations,
    resourceUri,
    runOnDemand = false,
+   maxResultSize = 0,
 }: ModelCellProps) {
    const [highlightedAnnotations, setHighlightedAnnotations] =
       React.useState<string>();
@@ -176,6 +178,7 @@ export function ModelCell({
                      minHeight={300}
                      maxHeight={600}
                      hideToggle={false}
+                     maxResultSize={maxResultSize}
                   />
                )}
          </CleanMetricCard>

package/src/components/Notebook/Notebook.tsx

@@ -4,18 +4,22 @@ import { CompiledNotebook } from "../../client";
 import { useQueryWithApiError } from "../../hooks/useQueryWithApiError";
 import { ApiErrorDisplay } from "../ApiErrorDisplay";
 
+import { parseResourceUri } from "../../utils/formatting";
 import { Loading } from "../Loading";
+import { useServer } from "../ServerProvider";
 import { CleanNotebookContainer, CleanNotebookSection } from "../styles";
 import { NotebookCell } from "./NotebookCell";
-import { parseResourceUri } from "../../utils/formatting";
-import { useServer } from "../ServerProvider";
 
 interface NotebookProps {
    resourceUri: string;
+   maxResultSize?: number;
 }
 
 // Requires PackageProvider
-export default function Notebook({ resourceUri }: NotebookProps) {
+export default function Notebook({
+   resourceUri,
+   maxResultSize = 0,
+}: NotebookProps) {
    const { apiClients } = useServer();
    const {
       projectName,
@@ -55,6 +59,7 @@ export default function Notebook({ resourceUri }: NotebookProps) {
                         key={index}
                         index={index}
                         resourceUri={resourceUri}
+                        maxResultSize={maxResultSize}
                      />
                   ))}
                {isError && error.status === 404 && (

package/src/components/Notebook/NotebookCell.tsx

@@ -32,6 +32,7 @@ interface NotebookCellProps {
    hideEmbeddingIcon?: boolean;
    resourceUri: string;
    index: number;
+   maxResultSize?: number;
 }
 
 export function NotebookCell({
@@ -40,6 +41,7 @@ export function NotebookCell({
    hideEmbeddingIcon,
    resourceUri,
    index,
+   maxResultSize,
 }: NotebookCellProps) {
    const [codeDialogOpen, setCodeDialogOpen] = React.useState<boolean>(false);
    const [embeddingDialogOpen, setEmbeddingDialogOpen] =
@@ -420,6 +422,7 @@ export function NotebookCell({
                         result={cell.result}
                         minHeight={300}
                         maxHeight={1000}
+                        maxResultSize={maxResultSize}
                      />
                   </Box>
 

package/src/components/RenderedResult/ResultContainer.tsx

@@ -1,5 +1,5 @@
-import { ExpandLess, ExpandMore } from "@mui/icons-material";
-import { Box, IconButton } from "@mui/material";
+import { ExpandLess, ExpandMore, Warning } from "@mui/icons-material";
+import { Box, Button, IconButton, Typography } from "@mui/material";
 import {
    lazy,
    Suspense,
@@ -17,6 +17,10 @@ interface ResultContainerProps {
    minHeight: number;
    maxHeight: number;
    hideToggle?: boolean;
+   // if Results are larger than this size, show a warning and a button to proceed
+   // this is to prevent performance issues with large results.
+   // the default is 0, which means no warning will be shown.
+   maxResultSize?: number;
 }
 
 // ResultContainer is a component that renders a result, with a toggle button to expand/collapse the result.
@@ -28,6 +32,7 @@ export default function ResultContainer({
    minHeight,
    maxHeight,
    hideToggle = false,
+   maxResultSize = 0,
 }: ResultContainerProps) {
    const [isExpanded, setIsExpanded] = useState(false);
    const [contentHeight, setContentHeight] = useState<number>(0);
@@ -36,6 +41,7 @@ export default function ResultContainer({
    const containerRef = useRef<HTMLDivElement>(null);
    const [explicitHeight, setExplicitHeight] = useState<number>(undefined);
    const [isFillElement, setIsFillElement] = useState(false);
+   const [userAcknowledged, setUserAcknowledged] = useState(false);
    const handleToggle = useCallback(() => {
       const wasExpanded = isExpanded;
       setIsExpanded(!isExpanded);
@@ -85,6 +91,42 @@ export default function ResultContainer({
    if (!result) {
       return null;
    }
+
+   // Check if result exceeds max size and user hasn't acknowledged yet
+   const exceedsMaxSize = maxResultSize > 0 && result.length > maxResultSize;
+   if (exceedsMaxSize && !userAcknowledged) {
+      return (
+         <Box
+            sx={{
+               minHeight: `${minHeight}px`,
+               display: "flex",
+               flexDirection: "column",
+               alignItems: "center",
+               justifyContent: "center",
+               gap: 2,
+               p: 4,
+               backgroundColor: "#fafafa",
+               border: "1px solid",
+               borderColor: "#e0e0e0",
+               borderRadius: 1,
+            }}
+         >
+            <Warning sx={{ fontSize: 48, color: "#757575" }} />
+            <Typography variant="h6" color="text.secondary" align="center">
+               Processing large results may cause browser performance issues.
+               Proceed?
+            </Typography>
+            <Button
+               variant="contained"
+               color="primary"
+               onClick={() => setUserAcknowledged(true)}
+            >
+               Proceed
+            </Button>
+         </Box>
+      );
+   }
+
    const loading = <Loading text="Loading..." centered={true} size={32} />;
    const renderedHeight = isFillElement
       ? isExpanded