@mallardbay/cursor-rules 1.0.32 → 1.0.33
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.cursor/shared/rules/code-review.mdc +1 -1
- package/.cursor/shared/skills/commit-and-pr/SKILL.md +3 -3
- package/.cursor/shared/skills/prep-for-pr/SKILL.md +1 -1
- package/.cursor/shared/skills/review-pr/SKILL.md +1 -1
- package/.cursor/shared/skills/should-we-merge/SKILL.md +1 -1
- package/.cursor/skills/prep-for-pr/SKILL.md +1 -1
- package/.cursor/skills/review-pr/SKILL.md +1 -1
- package/package.json +1 -1
|
@@ -28,7 +28,7 @@ You can invoke this skill with a GitHub issue number:
|
|
|
28
28
|
- `commit and create PR for issue 456` - Extract issue number from message
|
|
29
29
|
- `commit-and-pr` - Will extract issue number from commit or ask for it
|
|
30
30
|
|
|
31
|
-
The issue number can be provided in various formats: `123`, `#123`, `issue 123`,
|
|
31
|
+
The issue number can be provided in various formats: `123`, `#123`, `issue 123`, etc.
|
|
32
32
|
|
|
33
33
|
## Instructions
|
|
34
34
|
|
|
@@ -101,7 +101,7 @@ git status
|
|
|
101
101
|
|
|
102
102
|
1. **Check user's message** (if skill was invoked with issue number):
|
|
103
103
|
- Look for GitHub issue number patterns in the user's message when invoking the skill
|
|
104
|
-
- Common patterns: `#123`, `123`, `issue 123`, `
|
|
104
|
+
- Common patterns: `#123`, `123`, `issue 123`, `[#123]`, `(#123)`, `Closes #123`, `Closes 123`
|
|
105
105
|
- Examples: User says "/commit-and-pr 123" or "/commit-and-pr #123" or "commit and create PR for issue 123"
|
|
106
106
|
- Extract the issue number from the message if present (remove # prefix if present, store as plain number)
|
|
107
107
|
|
|
@@ -270,7 +270,7 @@ Use the Mallard Bay PR template from: https://github.com/mallardbay/.github/blob
|
|
|
270
270
|
|
|
271
271
|
- [Generate from commit messages and changed files]
|
|
272
272
|
|
|
273
|
-
**2. What
|
|
273
|
+
**2. What issue does this PR address?**
|
|
274
274
|
|
|
275
275
|
- #<issue-number>
|
|
276
276
|
|
|
@@ -34,7 +34,7 @@ Systematically check the new work on this branch and fix issues as you find them
|
|
|
34
34
|
### Code Quality Checks
|
|
35
35
|
|
|
36
36
|
**Feature Gaps**
|
|
37
|
-
- [ ] Are all requirements from the
|
|
37
|
+
- [ ] Are all requirements from the issue addressed?
|
|
38
38
|
- [ ] Are edge cases handled appropriately?
|
|
39
39
|
- [ ] Is error handling comprehensive?
|
|
40
40
|
- [ ] Are user-facing features complete (no TODOs or placeholders)?
|
|
@@ -45,7 +45,7 @@ gh pr list --head <branch-name> --json number,title,url
|
|
|
45
45
|
|
|
46
46
|
- [ ] PR size is reasonable (see [code-review.mdc](mdc:.cursor/rules/code-review.mdc) - max 400 lines)
|
|
47
47
|
- [ ] PR description is clear and explains purpose
|
|
48
|
-
- [ ] Related issues
|
|
48
|
+
- [ ] Related issues are referenced
|
|
49
49
|
- [ ] Changes align with PR description
|
|
50
50
|
- [ ] No unrelated changes included
|
|
51
51
|
|
|
@@ -104,7 +104,7 @@ Review the PR against project standards. **Assign every finding to exactly one s
|
|
|
104
104
|
|
|
105
105
|
**PR hygiene:**
|
|
106
106
|
- [ ] PR description explains purpose
|
|
107
|
-
- [ ] Related issues
|
|
107
|
+
- [ ] Related issues referenced
|
|
108
108
|
- [ ] No unrelated changes
|
|
109
109
|
- [ ] Commit messages are descriptive
|
|
110
110
|
|
|
@@ -34,7 +34,7 @@ Systematically check the new work on this branch and fix issues as you find them
|
|
|
34
34
|
### Code Quality Checks
|
|
35
35
|
|
|
36
36
|
**Feature Gaps**
|
|
37
|
-
- [ ] Are all requirements from the
|
|
37
|
+
- [ ] Are all requirements from the issue addressed?
|
|
38
38
|
- [ ] Are edge cases handled appropriately?
|
|
39
39
|
- [ ] Is error handling comprehensive?
|
|
40
40
|
- [ ] Are user-facing features complete (no TODOs or placeholders)?
|
|
@@ -45,7 +45,7 @@ gh pr list --head <branch-name> --json number,title,url
|
|
|
45
45
|
|
|
46
46
|
- [ ] PR size is reasonable (see [code-review.mdc](mdc:.cursor/rules/code-review.mdc) - max 400 lines)
|
|
47
47
|
- [ ] PR description is clear and explains purpose
|
|
48
|
-
- [ ] Related issues
|
|
48
|
+
- [ ] Related issues are referenced
|
|
49
49
|
- [ ] Changes align with PR description
|
|
50
50
|
- [ ] No unrelated changes included
|
|
51
51
|
|