@mallardbay/cursor-rules 1.0.28 → 1.0.29

package/.cursor/rules/code-quality.mdc

@@ -14,7 +14,13 @@ alwaysApply: false
     -   Functions: camelCase
     -   Constants: UPPER_SNAKE_CASE
     -   Types: PascalCase
--   Types should be defined at the bottom of files
+-   Follow this ordering within files:
+    1.  Imports
+    2.  Constants
+    3.  Exported functions / components
+    4.  Helpers and other non-exported definitions
+    5.  Types (when not imported)
+-   Exported members always come before non-exported members
 -   PropTypes should be defined before component definitions
 -   Prefer using alias for importing components. Only use relative for tests or when there's a direct sibling
 

package/.cursor/rules/testing.mdc

@@ -53,13 +53,14 @@ We do not chase 100% coverage for its own sake. If a test doesn’t meaningfully
 
 ### Mocking Guidelines
 
--   Use mock helpers instead of inline mocks
--   Follow existing patterns for:
+-   **Always use mock helpers**—never define mocks inline. All mocks should come from dedicated mock helper files following existing patterns for:
     -   Entity mocks
     -   Apollo mocks
     -   Provider mocks
+-   **Mock data through Apollo mocks, not module mocks**—use Apollo mock providers to control query/mutation responses instead of mocking modules or components directly
 -   Keep mocks simple and maintainable
 -   **Do not use variable matchers for Apollo mocks**—match exact variables (e.g. avoid `expect.anything()` or `variables: {}`) so tests fail when the component passes incorrect variables to queries or mutations
+-   **Never mock `@mallardbay/lib-react-components`**—if truly unavoidable, stop and ask for approval first
 
 ### Test Utilities
 

package/.cursor/rules/typescript.mdc

@@ -14,7 +14,13 @@ Be as strictly as possible where it delivers clear value—specifically in preve
 
 ### File Organization
 
--   Place types at the bottom of files
+-   Follow this ordering within files:
+    1.  Imports
+    2.  Constants
+    3.  Exported functions / components
+    4.  Helpers and other non-exported definitions
+    5.  Types (when not imported)
+-   Exported members always come before non-exported members
 -   Define PropTypes before component definitions
 
 ## Best Practices

package/.cursor/shared/rules/code-quality.mdc

@@ -14,7 +14,13 @@ alwaysApply: false
     -   Functions: camelCase
     -   Constants: UPPER_SNAKE_CASE
     -   Types: PascalCase
--   Types should be defined at the bottom of files
+-   Follow this ordering within files:
+    1.  Imports
+    2.  Constants
+    3.  Exported functions / components
+    4.  Helpers and other non-exported definitions
+    5.  Types (when not imported)
+-   Exported members always come before non-exported members
 -   PropTypes should be defined before component definitions
 -   Prefer using alias for importing components. Only use relative for tests or when there's a direct sibling
 

package/.cursor/shared/rules/testing.mdc

@@ -56,13 +56,14 @@ We do not chase 100% coverage for its own sake. If a test doesn’t meaningfully
 
 ### Mocking Guidelines
 
--   Use mock helpers instead of inline mocks
--   Follow existing patterns for:
+-   **Always use mock helpers**—never define mocks inline. All mocks should come from dedicated mock helper files following existing patterns for:
     -   Entity mocks
     -   Apollo mocks
     -   Provider mocks
+-   **Mock data through Apollo mocks, not module mocks**—use Apollo mock providers to control query/mutation responses instead of mocking modules or components directly
 -   Keep mocks simple and maintainable
 -   **Do not use variable matchers for Apollo mocks**—match exact variables (e.g. avoid `expect.anything()` or `variables: {}`) so tests fail when the component passes incorrect variables to queries or mutations
+-   **Never mock `@mallardbay/lib-react-components`**—if truly unavoidable, stop and ask for approval first
 
 ### Test Utilities
 

package/.cursor/shared/rules/typescript.mdc

@@ -14,7 +14,13 @@ Be as strictly as possible where it delivers clear value—specifically in preve
 
 ### File Organization
 
--   Place types at the bottom of files
+-   Follow this ordering within files:
+    1.  Imports
+    2.  Constants
+    3.  Exported functions / components
+    4.  Helpers and other non-exported definitions
+    5.  Types (when not imported)
+-   Exported members always come before non-exported members
 -   Define PropTypes before component definitions
 
 ## Best Practices

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mallardbay/cursor-rules",
-    "version": "1.0.28",
+    "version": "1.0.29",
     "description": "Mallard Bay shared cursor rules",
     "main": "bin/setup-cursor.sh",
     "repository": "git@github.com:mallardbay/cursor-rules.git",