@makolabs/ripple 0.0.1-dev.42 → 0.0.1-dev.43

package/dist/elements/dropdown/Dropdown.svelte

@@ -5,6 +5,7 @@
 	import { dropdownMenu } from '../../index.js';
 	import { onMount, onDestroy } from 'svelte';
 	import { Size } from '../../variants.js';
+	import Portal from '../../utils/Portal.svelte';
 
 	let {
 		sections = [],
@@ -26,7 +27,6 @@
 
 	let dropdownRef = $state<HTMLDivElement | undefined>();
 	let triggerRef = $state<HTMLDivElement | undefined>();
-	let portalEl = $state<HTMLDivElement | undefined>();
 	let triggerRect = $state<DOMRect | null>(null);
 
 	const {
@@ -90,10 +90,10 @@
 				posStyles += `left: ${right - triggerWidth}px;`;
 			}
 		} else {
-			const centeredLeft = left + (triggerWidth / 2);
-			if (centeredLeft + (dropdownWidthPx / 2) > viewportWidth - 20) {
+			const centeredLeft = left + triggerWidth / 2;
+			if (centeredLeft + dropdownWidthPx / 2 > viewportWidth - 20) {
 				posStyles += `right: 20px; left: auto;`;
-			} else if (centeredLeft - (dropdownWidthPx / 2) < 20) {
+			} else if (centeredLeft - dropdownWidthPx / 2 < 20) {
 				posStyles += `left: 20px; right: auto;`;
 			} else {
 				posStyles += `left: ${centeredLeft}px; transform: translateX(-50%);`;
@@ -111,18 +111,16 @@
 	function handleToggle() {
 		if (disabled) return;
 		isOpen = !isOpen;
-
-		if (isOpen) {
-			setTimeout(updatePosition, 0); // Use setTimeout to ensure DOM is updated
-		}
 	}
 
 	function handleClickOutside(event: MouseEvent) {
-		if (isOpen &&
+		if (
+			isOpen &&
 			dropdownRef &&
 			!dropdownRef.contains(event.target as Node) &&
 			triggerRef &&
-			!triggerRef.contains(event.target as Node)) {
+			!triggerRef.contains(event.target as Node)
+		) {
 			isOpen = false;
 		}
 	}
@@ -131,49 +129,6 @@
 		if (item.onclick) item.onclick();
 		isOpen = false;
 	}
-
-	function updatePosition() {
-		if (triggerRef) {
-			triggerRect = triggerRef.getBoundingClientRect();
-		}
-	}
-
-	function renderPortalDropdown() {
-		if (!portalEl || !document.body.contains(portalEl)) {
-			portalEl = document.createElement('div');
-			portalEl.id = 'dropdown-portal';
-			portalEl.style.position = 'fixed';
-			portalEl.style.top = '0';
-			portalEl.style.left = '0';
-			portalEl.style.width = '100%';
-			portalEl.style.height = '100%';
-			portalEl.style.pointerEvents = 'none';
-			portalEl.style.zIndex = '9999';
-			document.body.appendChild(portalEl);
-		}
-	}
-
-	onMount(() => {
-		renderPortalDropdown();
-		window.addEventListener('scroll', updatePosition, true);
-		window.addEventListener('resize', updatePosition);
-	});
-
-	onDestroy(() => {
-		if (!triggerRef) return;
-		window.removeEventListener('scroll', updatePosition, true);
-		window.removeEventListener('resize', updatePosition);
-		if (portalEl && document.body.contains(portalEl)) {
-			document.body.removeChild(portalEl);
-		}
-	});
-
-	$effect(() => {
-		if (isOpen) {
-			renderPortalDropdown();
-			updatePosition();
-		}
-	});
 </script>
 
 <svelte:window onclick={handleClickOutside} />
@@ -194,68 +149,80 @@
 			{/if}
 
 			{#if Icon}
-				<Icon class="size-5 text-default-400" />
+				<Icon class="text-default-400 size-5" />
 			{:else if label}
-				<svg xmlns="http://www.w3.org/2000/svg" width="28" height="28" viewBox="0 0 28 28" class="size-5">
-					<path fill="currentColor"
-								d="M4.22 9.47a.75.75 0 0 1 1.06 0L14 18.19l8.72-8.72a.75.75 0 1 1 1.06 1.06l-9.25 9.25a.75.75 0 0 1-1.06 0l-9.25-9.25a.75.75 0 0 1 0-1.06" />
+				<svg
+					xmlns="http://www.w3.org/2000/svg"
+					width="28"
+					height="28"
+					viewBox="0 0 28 28"
+					class="size-5"
+				>
+					<path
+						fill="currentColor"
+						d="M4.22 9.47a.75.75 0 0 1 1.06 0L14 18.19l8.72-8.72a.75.75 0 1 1 1.06 1.06l-9.25 9.25a.75.75 0 0 1-1.06 0l-9.25-9.25a.75.75 0 0 1 0-1.06"
+					/>
 				</svg>
 			{/if}
 		</button>
 	</div>
 </div>
 
-{#if isOpen && portalEl}
-	<div
-		bind:this={dropdownRef}
-		class={containerClass_}
-		role="menu"
-		aria-orientation="vertical"
-		aria-labelledby="menu-button"
-		style={dropdownStyles}
-		transition:fly={{ duration: 150, y: 5, opacity: 0 }}
-	>
-		{#if header}
-			<button class={headerClass_} onclick={header.onclick} aria-label="Header Actions">
-				{#if header.content}
-					{@render header.content()}
-				{:else}
-					{#if header.title}
-						<span class={headerTitleClass}>{header.title}</span>
-					{/if}
-					{#if header.subtitle}
-						<span class={headerSubtitleClass}>{header.subtitle}</span>
-					{/if}
-				{/if}
-			</button>
-		{/if}
-
-		{#each sections as section_, sectionIndex (sectionIndex)}
-			<div class={sectionClass}>
-				{#each section_.items as menuItem, itemIndex (itemIndex)}
-					{@const itemProps = {
-						class: itemClass_,
-						role: 'menuitem',
-						tabindex: -1,
-						id: `menu-item-${sectionIndex}-${itemIndex}`,
-						'data-active': menuItem.active
-					}}
-					{#if menuItem.href}
-						<a href={menuItem.href} {...itemProps}>
-							{@render DropItemContent(menuItem)}
-						</a>
+{#if isOpen}
+	<Portal target={triggerRef}>
+		<div
+			bind:this={dropdownRef}
+			class={containerClass_}
+			role="menu"
+			aria-orientation="vertical"
+			aria-labelledby="menu-button"
+			style={dropdownStyles}
+			transition:fly={{ duration: 150, y: 5, opacity: 0 }}
+		>
+			{#if header}
+				<button class={headerClass_} onclick={header.onclick} aria-label="Header Actions">
+					{#if header.content}
+						{@render header.content()}
 					{:else}
-						<button
-							type="button"
-							onclick={() => handleItemClick(menuItem)}
-							disabled={!menuItem.onclick} {...itemProps}>
-							{@render DropItemContent(menuItem)}
-						</button>
+						{#if header.title}
+							<span class={headerTitleClass}>{header.title}</span>
+						{/if}
+						{#if header.subtitle}
+							<span class={headerSubtitleClass}>{header.subtitle}</span>
+						{/if}
 					{/if}
-				{/each}
-			</div>
-		{/each}
-	</div>
+				</button>
+			{/if}
+
+			{#each sections as section_, sectionIndex (sectionIndex)}
+				<div class={sectionClass}>
+					{#each section_.items as menuItem, itemIndex (itemIndex)}
+						{@const itemProps = {
+							class: itemClass_,
+							role: 'menuitem',
+							tabindex: -1,
+							id: `menu-item-${sectionIndex}-${itemIndex}`,
+							'data-active': menuItem.active
+						}}
+						{#if menuItem.href}
+							<a href={menuItem.href} {...itemProps}>
+								{@render DropItemContent(menuItem)}
+							</a>
+						{:else}
+							<button
+								type="button"
+								onclick={() => handleItemClick(menuItem)}
+								disabled={!menuItem.onclick}
+								{...itemProps}
+							>
+								{@render DropItemContent(menuItem)}
+							</button>
+						{/if}
+					{/each}
+				</div>
+			{/each}
+		</div>
+	</Portal>
 {/if}
 
 {#snippet DropItemContent(menuItem: DropdownItem)}
@@ -264,4 +231,4 @@
 		<ItemIcon class={iconClass} />
 	{/if}
 	<span class="truncate">{menuItem.label}</span>
-{/snippet}
+{/snippet}

package/dist/elements/dropdown/Select.svelte

@@ -5,6 +5,7 @@
 	import type { SelectItem, SelectProps } from '../../index.js';
 	import Badge from '../badge/Badge.svelte';
 	import { Size } from '../../variants.js';
+	import Portal from '../../utils/Portal.svelte';
 
 	let {
 		items = [],
@@ -29,7 +30,7 @@
 
 	let open = $state(false);
 	let searchQuery = $state('');
-	let selectRef = $state<HTMLDivElement | null>(null);
+	let labelRef = $state<HTMLLabelElement | null>(null);
 	let searchInputRef = $state<HTMLInputElement | null>(null);
 	let highlightedIndex = $state(-1);
 
@@ -50,7 +51,7 @@
 	);
 
 	const baseClass = $derived(cn(base(), className));
-	const triggerClass_ = $derived(cn(trigger(), triggerClass));
+	const triggerClass_ = $derived(cn(trigger(), triggerClass, baseClass));
 	const triggerIconClass = $derived(cn(triggerIcon(), iconClass));
 	const containerClass_ = $derived(cn(container(), containerClass));
 	const searchInputClass_ = $derived(cn(searchInput(), searchInputClass));
@@ -122,7 +123,7 @@
 	}
 
 	function handleClickOutside(event: MouseEvent) {
-		if (selectRef && !selectRef.contains(event.target as Node) && open) {
+		if (labelRef && !labelRef.contains(event.target as Node) && open) {
 			open = false;
 			onclose();
 		}
@@ -130,7 +131,7 @@
 
 	function handleKeydown(event: KeyboardEvent) {
 		// check if the event is fired from the select
-		if (!selectRef || !selectRef.contains(event.target as Node)) return;
+		if (!labelRef || !labelRef.contains(event.target as Node)) return;
 
 		if (!open) {
 			if (event.key === 'Enter' || event.key === ' ' || event.key === 'ArrowDown') {
@@ -182,59 +183,61 @@
 
 <svelte:window onclick={handleClickOutside} onkeydown={handleKeydown} />
 
-<div bind:this={selectRef} class={baseClass} data-state={open ? 'open' : 'closed'}>
-	<label
-		class={triggerClass_}
-		aria-disabled={disabled}
-		aria-haspopup="listbox"
-		aria-labelledby="select-label"
-	>
-		<button
-			type="button"
-			aria-label="Toggle dropdown"
-			{disabled}
-			aria-expanded={open}
-			onclick={handleToggle}
-		></button>
-		<span class="flex min-h-[1.5rem] flex-1 flex-wrap items-center gap-1 overflow-hidden">
-			{#if multiple && selectedItems.length > 0}
-				{#each selectedItems as item (item.value)}
-					<Badge {size} color="info" onclose={() => removeItem(item.value)}>
-						{item.value}
-					</Badge>
-				{/each}
-			{:else if !multiple && selectedItem}
-				<span id="select-label" class="flex-1 truncate text-left">
-					{selectedItem.label}
-				</span>
-			{:else}
-				<span id="select-label" class="text-default-500 px-1">
-					{placeholder}
-				</span>
-			{/if}
-		</span>
-
-		<span class="ml-auto flex flex-shrink-0 items-center pl-2">
-			{#if Icon}
-				<Icon class={triggerIconClass} />
-			{:else}
-				<svg
-					xmlns="http://www.w3.org/2000/svg"
-					viewBox="0 0 20 20"
-					fill="currentColor"
-					class={cn(triggerIconClass, open && 'rotate-180 transform')}
-				>
-					<path
-						fill-rule="evenodd"
-						d="M5.293 7.293a1 1 0 011.414 0L10 10.586l3.293-3.293a1 1 0 111.414 1.414l-4 4a1 1 0 01-1.414 0l-4-4a1 1 0 010-1.414z"
-						clip-rule="evenodd"
-					/>
-				</svg>
-			{/if}
-		</span>
-	</label>
-
-	{#if open}
+<label
+	bind:this={labelRef}
+	class={triggerClass_}
+	aria-disabled={disabled}
+	aria-haspopup="listbox"
+	aria-labelledby="select-label"
+	data-state={open ? 'open' : 'closed'}
+>
+	<button
+		type="button"
+		aria-label="Toggle dropdown"
+		{disabled}
+		aria-expanded={open}
+		onclick={handleToggle}
+	></button>
+	<span class="flex min-h-[1.5rem] flex-1 flex-wrap items-center gap-1 overflow-hidden">
+		{#if multiple && selectedItems.length > 0}
+			{#each selectedItems as item (item.value)}
+				<Badge {size} color="info" onclose={() => removeItem(item.value)}>
+					{item.value}
+				</Badge>
+			{/each}
+		{:else if !multiple && selectedItem}
+			<span id="select-label" class="flex-1 truncate text-left">
+				{selectedItem.label}
+			</span>
+		{:else}
+			<span id="select-label" class="text-default-500 px-1">
+				{placeholder}
+			</span>
+		{/if}
+	</span>
+
+	<span class="ml-auto flex flex-shrink-0 items-center pl-2">
+		{#if Icon}
+			<Icon class={triggerIconClass} />
+		{:else}
+			<svg
+				xmlns="http://www.w3.org/2000/svg"
+				viewBox="0 0 20 20"
+				fill="currentColor"
+				class={cn(triggerIconClass, open && 'rotate-180 transform')}
+			>
+				<path
+					fill-rule="evenodd"
+					d="M5.293 7.293a1 1 0 011.414 0L10 10.586l3.293-3.293a1 1 0 111.414 1.414l-4 4a1 1 0 01-1.414 0l-4-4a1 1 0 010-1.414z"
+					clip-rule="evenodd"
+				/>
+			</svg>
+		{/if}
+	</span>
+</label>
+
+{#if open}
+	<Portal target={labelRef}>
 		<div class={containerClass_} role="listbox" aria-labelledby="select-label">
 			{#if searchable}
 				<div class={searchInputClass_}>
@@ -269,7 +272,10 @@
 						<li>
 							<button
 								type="button"
-								onclick={() => handleSelect(item)}
+								onclick={(event) => {
+									handleSelect(item);
+									event.preventDefault();
+								}}
 								disabled={item.disabled}
 								class={itemClass_}
 								role="option"
@@ -310,5 +316,5 @@
 				</ul>
 			{/if}
 		</div>
-	{/if}
-</div>
+	</Portal>
+{/if}

package/dist/elements/dropdown/dropdown.js

@@ -2,7 +2,7 @@ import { tv } from '../../helper/cls.js';
 import { Size } from '../../variants.js';
 export const dropdownMenu = tv({
     slots: {
-        base: 'relative inline-block text-left',
+        base: 'inline-block text-left',
         trigger: 'inline-flex w-full justify-center items-center gap-x-1.5 rounded-md bg-white px-3 py-2 text-sm font-semibold text-default-900 shadow-xs ring-1 ring-inset ring-default-300 hover:bg-default-50 cursor-pointer disabled:opacity-50 disabled:cursor-not-allowed',
         container: 'absolute z-50 mt-2 origin-top-right divide-y divide-default-100 rounded-md bg-white ring-1 ring-black/5 shadow-lg focus:outline-none',
         section: 'py-1',

package/dist/elements/dropdown/select.js

@@ -2,11 +2,11 @@ import { tv } from 'tailwind-variants';
 import { Size } from '../../variants.js';
 export const selectTV = tv({
     slots: {
-        base: 'relative inline-block',
+        base: '',
         trigger: `flex items-center justify-between w-full text-left bg-white border
 			border-default-200 text-default-700 hover:border-default-300 rounded-md cursor-pointer`,
         triggerIcon: 'transition-transform duration-200 text-default-500',
-        container: 'absolute z-50 w-full mt-1 bg-white overflow-clip border border-default-200 rounded-md shadow-md',
+        container: 'absolute z-50 w-full mt-1 bg-white overflow-clip border border-default-200 rounded-md shadow-md origin-top-left top-full left-0 mt-2',
         searchInput: 'flex items-center gap-x-3 w-full outline-none px-2 h-10 border-b border-b-default-200',
         list: 'py-1 max-h-60 overflow-x-clip overflow-y-auto h-full',
         item: `w-full px-3 py-2 text-sm text-left

package/dist/utils/Portal.svelte

@@ -0,0 +1,98 @@
+<script lang="ts">
+	import { onMount, onDestroy, type Snippet } from 'svelte';
+
+	/**
+	 * Target element to mount the portal content to
+	 * Defaults to document.body
+	 */
+	let { target, children }: { target?: HTMLElement | null; children: Snippet } = $props();
+
+	let ref: HTMLElement;
+	let portal: HTMLElement;
+	let animationFrameId: number;
+	let isPositioned = $state(false);
+
+	// Position update without animation - for immediate positioning
+	function updatePosition() {
+		if (!ref || !target) return;
+
+		const { top, left, width, height } = target.getBoundingClientRect();
+
+		// Set instant positioning without transitions for first render
+		if (!isPositioned) {
+			ref.style.position = 'fixed';
+			ref.style.width = `${width}px`;
+			ref.style.height = `${height}px`;
+			ref.style.top = '0';
+			ref.style.left = '0';
+			ref.style.transform = `translate(${left}px, ${top}px)`;
+			ref.style.visibility = 'hidden'; // Keep hidden until fully positioned
+
+			// Wait for next frame to ensure positioning is applied before showing
+			animationFrameId = requestAnimationFrame(() => {
+				ref.style.opacity = '1';
+				ref.style.visibility = 'visible';
+				isPositioned = true;
+
+				// Now add transition for subsequent updates
+				ref.style.transition = 'transform 0.1s ease-out';
+			});
+		} else {
+			// For subsequent updates, smoothly transition
+			ref.style.transform = `translate(${left}px, ${top}px)`;
+		}
+	}
+
+	// Handle scroll and resize with animation frames for smooth updates
+	function handlePositionUpdate() {
+		if (animationFrameId) {
+			cancelAnimationFrame(animationFrameId);
+		}
+
+		animationFrameId = requestAnimationFrame(updatePosition);
+	}
+
+	onMount(() => {
+		// Create portal container
+		portal = document.createElement('div');
+		portal.className = 'ripple-portal';
+
+		// Default to document.body if no target is provided
+		const targetElement = target || document.body;
+		targetElement.appendChild(portal);
+
+		// Move the content to the portal
+		portal.appendChild(ref);
+
+		// Initially hide the content
+		ref.style.opacity = '0';
+
+		// Position immediately - critical for first render
+		updatePosition();
+
+		// Add event listeners for position updates
+		window.addEventListener('resize', handlePositionUpdate);
+		window.addEventListener('scroll', handlePositionUpdate, true);
+	});
+
+	onDestroy(() => {
+		// Clean up on component destruction
+		if (portal && portal.parentNode) {
+			portal.parentNode.removeChild(portal);
+		}
+
+		// Clean up event listeners
+		window.removeEventListener('resize', handlePositionUpdate);
+		window.removeEventListener('scroll', handlePositionUpdate, true);
+
+		// Cancel any pending animation frame
+		if (animationFrameId) {
+			cancelAnimationFrame(animationFrameId);
+		}
+	});
+</script>
+
+<div class="portal-content" bind:this={ref}>
+	{@render children()}
+</div>
+

package/dist/utils/Portal.svelte.d.ts

@@ -0,0 +1,8 @@
+import { type Snippet } from 'svelte';
+type $$ComponentProps = {
+    target?: HTMLElement | null;
+    children: Snippet;
+};
+declare const Portal: import("svelte").Component<$$ComponentProps, {}, "">;
+type Portal = ReturnType<typeof Portal>;
+export default Portal;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@makolabs/ripple",
-	"version": "0.0.1-dev.42",
+	"version": "0.0.1-dev.43",
 	"description": "Simple Svelte 5 powered component library ✨",
 	"repository": {
 		"type": "git",