@makerx/yoke 0.8.0 → 0.8.1

package/dist/cli.js

@@ -7,7 +7,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@makerx/yoke",
-  version: "0.8.0",
+  version: "0.8.1",
   description: "Lean, user-invoked Claude Code skills for MakerX AI-assisted delivery, plus the CLI they call.",
   license: "MIT",
   author: "MakerX",
@@ -670,7 +670,8 @@ function renderCallerWorkflow({ inputs }) {
     `    uses: ${reviewWorkflowRef}`,
     "    with:",
     ...inputs.map(([name, value]) => `      ${name}: ${yamlValue(value)}`),
-    "    secrets: inherit",
+    "    secrets:",
+    ...ciSecrets.map((secret2) => `      ${secret2}: \${{ secrets.${secret2} }}`),
     ""
   ].join("\n");
 }
@@ -912,10 +913,22 @@ function formatSynthesis({ summary, findings }) {
   return lines.join("\n").trimEnd();
 }
 
-// src/features/review/request.ts
+// src/features/review/diff.ts
 var fileHeader = /^\+\+\+ (.+)$/;
 var hunkHeader = /^@@ -\d+(?:,(\d+))? \+(\d+)(?:,(\d+))? @@/;
-var gutterWidth = 6;
+var escapes = { a: 7, b: 8, t: 9, n: 10, v: 11, f: 12, r: 13 };
+function parseDiff(diff) {
+  let file = null;
+  const hunk = { next: 0, oldLeft: 0, newLeft: 0 };
+  return diff.split("\n").map((text2) => {
+    if (hunk.oldLeft > 0 || hunk.newLeft > 0) return { text: text2, file, line: hunkLine(text2, hunk) };
+    const header = text2.match(fileHeader)?.[1];
+    if (header) file = header === "/dev/null" ? null : diffPath(header);
+    const range = text2.match(hunkHeader);
+    if (range) Object.assign(hunk, { oldLeft: Number(range[1] ?? 1), next: Number(range[2]), newLeft: Number(range[3] ?? 1) });
+    return { text: text2, file, line: null };
+  });
+}
 function hunkLine(text2, hunk) {
   if (text2.startsWith("-")) hunk.oldLeft--;
   else if (text2.startsWith("+")) hunk.newLeft--;
@@ -925,33 +938,42 @@ function hunkLine(text2, hunk) {
   } else return null;
   return text2.startsWith("-") ? null : hunk.next++;
 }
-var escapes = { a: 7, b: 8, t: 9, n: 10, v: 11, f: 12, r: 13 };
-function escapedBytes(escape) {
-  const code = escape.slice(1);
-  if (/^[0-7]{3}$/.test(code)) return Buffer.from([parseInt(code, 8)]);
-  return Buffer.from([escapes[code] ?? code.charCodeAt(0)]);
+function diffPath(raw) {
+  const quoted = raw.match(/^"(.*)"$/)?.[1];
+  const path = quoted === void 0 ? raw : unquote(quoted);
+  return path.startsWith("b/") ? path.slice(2) : path;
 }
 function unquote(quoted) {
   const parts = quoted.split(/(\\[0-7]{3}|\\.)/);
   return Buffer.concat(parts.map((part, i) => i % 2 ? escapedBytes(part) : Buffer.from(part))).toString("utf8");
 }
-function diffPath(raw) {
-  const quoted = raw.match(/^"(.*)"$/)?.[1];
-  const path = quoted === void 0 ? raw : unquote(quoted);
-  return path.startsWith("b/") ? path.slice(2) : path;
+function escapedBytes(escape) {
+  const code = escape.slice(1);
+  if (/^[0-7]{3}$/.test(code)) return Buffer.from([parseInt(code, 8)]);
+  return Buffer.from([escapes[code] ?? code.charCodeAt(0)]);
 }
-function parseDiff(diff) {
-  let file = null;
-  const hunk = { next: 0, oldLeft: 0, newLeft: 0 };
-  return diff.split("\n").map((text2) => {
-    if (hunk.oldLeft > 0 || hunk.newLeft > 0) return { text: text2, file, line: hunkLine(text2, hunk) };
-    const header = text2.match(fileHeader)?.[1];
-    if (header) file = header === "/dev/null" ? null : diffPath(header);
-    const range = text2.match(hunkHeader);
-    if (range) Object.assign(hunk, { oldLeft: Number(range[1] ?? 1), next: Number(range[2]), newLeft: Number(range[3] ?? 1) });
-    return { text: text2, file, line: null };
-  });
+
+// src/features/review/selfReviewNote.ts
+var yokeCaller = /\buses:\s*['"]?MakerXStudio\/yoke\/\.github\/workflows\/review\.yml@/i;
+function editsYokeCaller(diff) {
+  return parseDiff(diff).some(({ text: text2, file, line }) => line !== null && file?.startsWith(".github/workflows/") && yokeCaller.test(text2));
 }
+function selfReviewNote(diff) {
+  if (!editsYokeCaller(diff)) return "";
+  return `## Yoke's own review workflow
+
+This change adds or edits a workflow that calls \`MakerXStudio/yoke/.github/workflows/review.yml\`, the CI setup for this review. Review it like any other file, but these are yoke's deliberate design: do not raise them as findings, keep them in a consolidated review, or mention them in a summary.
+
+- Calling the workflow at \`@main\` rather than a tag or SHA.
+- The trigger types, including leaving out \`synchronize\`: a review is re-run by marking the PR as draft and then ready for review.
+- Draft PRs being reviewed twice: the reusable workflow already skips drafts.
+
+Real defects in it are still findings, such as passing every secret with \`secrets: inherit\` instead of only \`REVIEW_CI_BASE_URL\` and \`REVIEW_CI_API_KEY\`, or an input the reusable workflow does not declare.
+`;
+}
+
+// src/features/review/request.ts
+var gutterWidth = 6;
 function gutter(line) {
   return `${(line === null ? "" : String(line)).padStart(gutterWidth)}  `;
 }
@@ -970,6 +992,7 @@ function commentableLines(diff) {
 function buildRequest(pr2, diff, prior = []) {
   const files = pr2.files.map((f) => `- ${f.path}`).join("\n") || "(none)";
   const priorSection = formatPriorComments(prior);
+  const note = selfReviewNote(diff);
   return `# Code review request
 
 - PR: #${pr2.number} ${pr2.title}
@@ -987,7 +1010,8 @@ Each added or context line is prefixed with a left gutter showing its line numbe
 \`\`\`diff
 ${withNewFileLineNumbers(diff.trimEnd())}
 \`\`\`
-${priorSection && `
+${note && `
+${note}`}${priorSection && `
 ${priorSection}`}`;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@makerx/yoke",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Lean, user-invoked Claude Code skills for MakerX AI-assisted delivery, plus the CLI they call.",
   "license": "MIT",
   "author": "MakerX",