@makefully/platypus 4.1.17 → 4.1.20

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@makefully/platypus",
-    "version": "4.1.17",
+    "version": "4.1.20",
     "description": "2D tile-based HTML5 game engine with a component-based entity model",
     "license": "MIT",
     "contributors": [
@@ -82,7 +82,7 @@
     },
     "optionalDependencies": {
         "box2d3-wasm": "^4.2.0",
-        "jsmediatags": "github:probityrules/jsmediatags",
+        "@probityrules/jsmediatags": "^4.0.4",
         "poly-decomp": "^0.3.0"
     },
     "engines": {

package/src/Component.js

@@ -64,9 +64,15 @@ export default class Component {
         if (this.listener) {
             const
                 publicMethods = this.publicMethods,
-                keys = Object.keys(publicMethods);
+                keys = Object.keys(publicMethods),
+                // Detach first so re-entrant removeEventListener during teardown
+                // cannot read a recycled listener's deleted `events` array.
+                listener = this.listener,
+                {events, messages} = listener;
             let i = keys.length;
 
+            this.listener = null;
+
             // Handle component's destroy method before removing messaging and methods.
             if (this._destroy) {
                 this._destroy();
@@ -77,12 +83,21 @@ export default class Component {
                 this.removeMethod(keys[i]);
             }
             this.publicMethods.recycle();
-            
-            this.removeEventListeners();
-            arrayCache.recycle(this.listener.events);
-            arrayCache.recycle(this.listener.messages);
-            this.listener.recycle();
-            this.listener = null;
+
+            if (events && messages) {
+                const
+                    {owner} = this,
+                    {length} = events;
+
+                for (let j = 0; j < length; j++) {
+                    owner.off(events[j], messages[j]);
+                }
+                events.length = 0;
+                messages.length = 0;
+                arrayCache.recycle(events);
+                arrayCache.recycle(messages);
+            }
+            listener.recycle();
         }
     }
 
@@ -96,7 +111,13 @@ export default class Component {
     removeEventListeners (listeners) {
         if (!listeners) {
             const
-                {listener, owner} = this,
+                {listener, owner} = this;
+
+            if (!listener?.events || !listener.messages) {
+                return;
+            }
+
+            const
                 {events, messages} = listener,
                 {length} = events;
 
@@ -188,7 +209,13 @@ export default class Component {
      */
     removeEventListener (event, callback) {
         const
-            {listener, owner} = this,
+            {listener, owner} = this;
+
+        if (!listener?.events || !listener.messages) {
+            return;
+        }
+
+        const
             {events, messages} = listener;
         
         for (let i = events.length - 1; i >= 0; i--) {

package/src/components/AudioSFX.js

@@ -298,13 +298,15 @@ export default createComponentClass(/** @lends platypus.components.AudioSFX.prot
                 const
                     key = keys[i],
                     sound = audioMap[key],
+                    // Must match the resolved id stored on clips in playSound / stopAudio.
+                    soundId = platypus.assetCache.getFileId(sound.sound ?? sound),
                     playClip = playSound(sound);
 
                 if (this.eventBased) {
                     this.addEventListener(key, playClip);
                 }
                 if (this.stateBased) {
-                    this.addStateCheck(key, sound.sound ?? sound, playClip);
+                    this.addStateCheck(key, soundId, playClip);
                 }
             }
         }
@@ -623,7 +625,7 @@ export default createComponentClass(/** @lends platypus.components.AudioSFX.prot
                     if (active) {
                         play.call(this);
                     } else {
-                        this.stopAudio(audioId, this.forcePlaythrough);
+                        this.stopAudio(audioId, this.forcePlayThrough);
                     }
                     checkData.playing = active;
                 }