@maka/maka-cli 5.226.0 → 5.227.0

package/bundle/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maka/maka-cli",
-  "version": "5.226.0",
+  "version": "5.227.0",
   "type": "module",
   "summary": "A command line tool for scaffolding Meteor 3.x applications using either React.",
   "description": "A command line tool for scaffolding Meteor 3.x applications using React.",

package/bundle/typescript/src/commands/game/sideQuest/types/repro.js

@@ -1,3 +1,39 @@
+/**
+ * THE BENCH'S ACTOR. One name, used for the seat, for the transcript's
+ * visibility filter, and for the post-boot fixture state below.
+ *
+ * IT LIVES HERE, in the types module, on purpose. utilities/repro-launch
+ * declared it, and the launcher's whole design is that the game graph
+ * (repro-scene, the harness, blessed, 150 files) stays behind a dynamic
+ * import so `maka --help` does not pay for it. Once the site needed the
+ * same constant, anything that re-exported it from a module importing
+ * the builder would have dragged that graph back across the lazy
+ * boundary. This file imports nothing, so both sides can share the name
+ * for free.
+ */
+export const REPRO_ACTOR = 'Tester';
+/**
+ * THE FIXTURE A BENCH ACTUALLY BUILDS FROM.
+ *
+ * One rule, and it is not a convenience: a bench written with
+ * `repro.premise` and no `fixture.premise` is the common shape, so the
+ * reader's framing doubles as the scene's story when the fixture has
+ * none of its own. Three callers build a bench -- the headless dry run,
+ * the CLI's live launcher, and maka-cli.com's web bench -- and each had
+ * to know this. Two of them spelling it the same way and a third
+ * forgetting is how a bench acquires a different opening line depending
+ * on where it was run from.
+ *
+ * Here rather than beside the builder because this file imports nothing,
+ * so the launcher can apply the rule without reaching across its lazy
+ * boundary into the game graph.
+ */
+export function reproFixtureOf(repro) {
+    const fixture = { ...(repro.fixture ?? {}) };
+    if (!fixture.premise && repro.premise)
+        fixture.premise = repro.premise;
+    return fixture;
+}
 /**
  * THE FIXTURE SCHEMA'S VERSION, and the engine side is the source of
  * truth for it. Anything that GENERATES repro drafts -- the

package/bundle/typescript/src/commands/game/sideQuest/utilities/repro-boot.js

@@ -0,0 +1,62 @@
+import { buildReproScene, reproArchetypeName } from '../factories/repro-scene.js';
+import { saveForArchetype } from '../headless-harness.js';
+import { REPRO_ACTOR, reproFixtureOf } from '../types/repro.js';
+/**
+ * The scene and the runner a bench starts with.
+ */
+export function buildReproBoot(repro) {
+    const fixture = reproFixtureOf(repro);
+    const build = buildReproScene(fixture);
+    const archetype = reproArchetypeName(fixture);
+    return {
+        fixture,
+        build,
+        seed: build.seed,
+        archetype,
+        save: saveForArchetype(REPRO_ACTOR, archetype),
+        warnings: build.warnings,
+    };
+}
+/**
+ * THE KNOBS THE SEED CANNOT CARRY, applied to a booted session.
+ *
+ * Call this after the session is up and before the first step (or, on
+ * the site, before the first status push) -- the point of both knobs is
+ * that the bench OPENS on a runner already in that state, so a reporter
+ * reads the condition on their first look rather than watching it be
+ * applied.
+ *
+ * Silent when the fixture asks for neither, and silent when the actor is
+ * missing: a bench whose runner did not boot has a larger problem than
+ * its damage boxes, and it will say so in the transcript.
+ */
+export async function applyReproFixtureState(game, fixture, actorName = REPRO_ACTOR) {
+    // START WOUNDED (fixture.wounded): the boxes go on before the first
+    // step, so the transcript opens on a runner who already needs the
+    // verb under test.
+    if (fixture.wounded) {
+        const runner = game.scene.getPlayerByName(actorName);
+        if (runner) {
+            if (fixture.wounded.physical)
+                runner.takeDamage(fixture.wounded.physical);
+            if (fixture.wounded.stun)
+                runner.takeStun(fixture.wounded.stun);
+        }
+    }
+    // NUYEN (fixture.nuyen): a credstick in the pack, because money lives
+    // on a carrier item (Player.currency sums them) and the pregen has none.
+    if (fixture.nuyen && fixture.nuyen > 0) {
+        const runner = game.scene.getPlayerByName(actorName);
+        if (runner) {
+            const { ItemFactory } = await import('../factories/item-factory.js');
+            const stick = await new ItemFactory().createItemFromJson({
+                name: 'Certified Credstick', description: 'Cash that does not ask questions.',
+                size: 'Tiny', category: 'Credstick', shape: 'Slab', color: 'Black', texture: 'Plastic',
+                rating: 'Common', weight: 0.1, transferable: true,
+            });
+            stick.addCurrency(fixture.nuyen);
+            runner.addInventory(stick);
+        }
+    }
+}
+//# sourceMappingURL=repro-boot.js.map

package/bundle/typescript/src/commands/game/sideQuest/utilities/repro-launch.js

@@ -1,5 +1,6 @@
 import fs from 'fs';
 import { fetchReviewQueue } from './backlog.js';
+import { REPRO_ACTOR } from '../types/repro.js';
 /**
  * Resolve `<id>` or `<n>` against a FRESH review queue.
  *
@@ -157,8 +158,14 @@ export function readReproFile(candidate) {
  * since the last step and print them under the output they explain.
  */
 /** The bench's actor. One name, used for the seat and for the
- *  visibility filter below. */
-export const REPRO_ACTOR = 'Tester';
+ *  visibility filter below.
+ *
+ *  Defined in types/repro.ts and re-exported here so the many callers
+ *  that import it from the launcher keep working. It had to move: the
+ *  site needs the same constant, and a module that reaches it through
+ *  anything importing the scene builder would drag the game graph back
+ *  across this file's lazy boundary. See the note on the constant. */
+export { REPRO_ACTOR };
 const stripTags = (s) => s.replace(/\{\/?[a-z-]+\}/g, '');
 /**
  * ONE STEP OF TRANSCRIPT, pure: the command's return string, then what
@@ -221,49 +228,23 @@ export function renderStepLines(step, text, fresh, actor = REPRO_ACTOR) {
     return lines;
 }
 export async function dryRunRepro(repro) {
-    const [{ buildReproScene, reproArchetypeName }, { bootSession, saveForArchetype }] = await Promise.all([
-        import('../factories/repro-scene.js'),
+    // The scene, the runner and the post-boot knobs all come from
+    // repro-boot, which is the ONE definition of what a bench boots as --
+    // shared with maka-cli.com's live bench so the transcript below and
+    // the session a reporter types into cannot describe different
+    // scenarios. See that module's header.
+    const [{ buildReproBoot, applyReproFixtureState }, { bootSession }] = await Promise.all([
+        import('./repro-boot.js'),
         import('../headless-harness.js'),
     ]);
-    const fixture = { ...(repro.fixture ?? {}) };
-    // The reader's framing doubles as the bench's story when the fixture
-    // has none of its own -- one sentence, written once.
-    if (!fixture.premise && repro.premise)
-        fixture.premise = repro.premise;
-    const built = buildReproScene(fixture);
+    const built = buildReproBoot(repro);
     const events = [];
     const session = await bootSession({
         seed: built.seed,
-        players: [saveForArchetype(REPRO_ACTOR, reproArchetypeName(fixture))],
+        players: [built.save],
         events,
     });
-    // START WOUNDED (fixture.wounded): the boxes go on before the first
-    // step, so the transcript opens on a runner who already needs the
-    // verb under test.
-    if (fixture.wounded) {
-        const runner = session.game.scene.getPlayerByName(REPRO_ACTOR);
-        if (runner) {
-            if (fixture.wounded.physical)
-                runner.takeDamage(fixture.wounded.physical);
-            if (fixture.wounded.stun)
-                runner.takeStun(fixture.wounded.stun);
-        }
-    }
-    // NUYEN (fixture.nuyen): a credstick in the pack, because money lives
-    // on a carrier item (Player.currency sums them) and the pregen has none.
-    if (fixture.nuyen && fixture.nuyen > 0) {
-        const runner = session.game.scene.getPlayerByName(REPRO_ACTOR);
-        if (runner) {
-            const { ItemFactory } = await import('../factories/item-factory.js');
-            const stick = await new ItemFactory().createItemFromJson({
-                name: 'Certified Credstick', description: 'Cash that does not ask questions.',
-                size: 'Tiny', category: 'Credstick', shape: 'Slab', color: 'Black', texture: 'Plastic',
-                rating: 'Common', weight: 0.1, transferable: true,
-            });
-            stick.addCurrency(fixture.nuyen);
-            runner.addInventory(stick);
-        }
-    }
+    await applyReproFixtureState(session.game, built.fixture);
     const lines = [];
     // THE FIRST PAINT IS NOT PART OF STEP ONE. bootSession pushes every
     // player's panels the moment the session comes up (B7NNNesy5gvRSbZpp),

package/bundle/typescript/src/commands/game/sideQuest.sub.cmd.js

@@ -6,6 +6,10 @@ import { Actions } from '../../tools/actions/actions.class.js';
 import { Log } from '../../tools/log/log.class.js';
 import { AI } from '../../tools/ai/ai.class.js';
 import { spawnSelf } from '../../tools/self-spawn/self-spawn.js';
+// A value import, not a type-only one, for reproFixtureOf -- safe
+// against this file's "no game graph on `maka --help`" rule because
+// types/repro.ts reaches only two leaf enum modules.
+import { reproFixtureOf } from './sideQuest/types/repro.js';
 /**
  * SPAWN THE GAME AND BE ITS JANITOR.
  *
@@ -77,9 +81,12 @@ export async function spawnGame(launchFilePath, logFilePath) {
  */
 async function launchReproBench(repro, item, makaDir) {
     const { buildReproScene, reproArchetypeName } = await import('./sideQuest/factories/repro-scene.js');
-    const fixture = { ...(repro.fixture ?? {}) };
-    if (!fixture.premise && repro.premise)
-        fixture.premise = repro.premise;
+    // The one premise rule, shared with the dry run and the web bench --
+    // see reproFixtureOf. This path stops at the scene: the game rolls the
+    // character itself from `archetype` below, so it deliberately does NOT
+    // go through repro-boot, which would pull the headless harness (and
+    // with it game.ts) into the PARENT process that only spawns the child.
+    const fixture = reproFixtureOf(repro);
     let built;
     try {
         built = buildReproScene(fixture);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maka/maka-cli",
-  "version": "5.226.0",
+  "version": "5.227.0",
   "type": "module",
   "summary": "A command line tool for scaffolding Meteor 3.x applications using either React.",
   "description": "A command line tool for scaffolding Meteor 3.x applications using React.",