@maka/maka-cli 5.149.0 → 5.151.0

package/bundle/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maka/maka-cli",
-  "version": "5.149.0",
+  "version": "5.151.0",
   "type": "module",
   "summary": "A command line tool for scaffolding Meteor 3.x applications using either React.",
   "description": "A command line tool for scaffolding Meteor 3.x applications using React.",

package/bundle/typescript/src/commands/game/sideQuest/commands/look.js

@@ -51,6 +51,45 @@ export class LookCommand extends Command {
                 return `${containerHit.description}\n  Open. ${items.length === 0 ? 'Empty.'
                     : `Inside: ${items.map(i => i.quantity > 1 ? `${i.name} ×${i.quantity}` : i.name).join(', ')}.`}`;
             }
+            // "look deck" (W7fzZRb6Asa7Qqjzg): a decker's cyberdeck is
+            // usually branded gear ("Sony CIY-720"), not literally named
+            // "deck" -- so the generic name-match below missed it entirely
+            // and "look deck" read "You cannot see deck" even carrying one.
+            // Resolved through the SAME lookup "deck" (deck.ts) already uses
+            // for the active/best-carried deck, then handed to the ordinary
+            // inspectItem by its real name so the two verbs describe one
+            // object identically.
+            if (target === 'deck') {
+                const carried = this.actor.getAnyCyberdeck();
+                if (carried) {
+                    this.logger.write(`Looking at active deck '${carried.name}' in ${this.actor.name} inventory.`);
+                    return this.inspectItem(carried.name, this.actor.inventory);
+                }
+            }
+            // AN EXACT NAME BEATS A FUZZY ITEM SUBSTRING (Sjjy52mjSqSdjFGdg:
+            // "look Jo" resolved to "Certified Credstick (job payments)" --
+            // Inventory.resolveKey does deliberately generous substring
+            // matching for item-name typos ("jo" sits inside "job payments"),
+            // and that ran before the room's actor list was ever consulted.
+            // A present person's EXACT name is a far stronger signal than an
+            // incidental item substring, so it wins first; an inexact query
+            // still falls through to the item/direction ladder below exactly
+            // as before.
+            // AN EXACT NAME BEATS A FUZZY ITEM SUBSTRING (Sjjy52mjSqSdjFGdg:
+            // "look Jo" resolved to "Certified Credstick (job payments)" --
+            // Inventory.resolveKey does deliberately generous substring
+            // matching for item-name typos ("jo" sits inside "job payments"),
+            // and that ran before the room's actor list was ever consulted.
+            // A present person's EXACT name is a far stronger signal than an
+            // incidental item substring, so it wins first; an inexact query
+            // still falls through to the item/direction ladder below exactly
+            // as before.
+            const exactActorMatch = this.scene
+                .getActorsInRoom(this.actor.currentLocation)
+                .find(a => a.name.toLowerCase() === target.toLowerCase() && this.actor.canPerceive(a));
+            if (exactActorMatch) {
+                return this.inspectActor(exactActorMatch.name);
+            }
             if (this.actor.inventory.hasItem(target)) {
                 this.logger.write(`Looking at item '${target}' in ${this.actor.name} inventory.`);
                 return this.inspectItem(target, this.actor.inventory);
@@ -64,14 +103,9 @@ export class LookCommand extends Command {
                 return this.lookOutside(target);
             }
             else {
-                // Check if it's another player or NPC in the room (that this
-                // actor's plane can perceive -- see Player.canPerceive)
-                const actorMatch = this.scene
-                    .getActorsInRoom(this.actor.currentLocation)
-                    .find(a => a.name.toLowerCase() === target.toLowerCase() && this.actor.canPerceive(a));
-                if (actorMatch) {
-                    return this.inspectActor(actorMatch.name);
-                }
+                // The exact-name actor check above already covers a present
+                // person; reaching here means the target is neither an item,
+                // a direction, nor anyone in the room by that exact name.
                 return `You cannot see ${target}`;
             }
         }

package/bundle/typescript/src/commands/game/sideQuest/commands/take.js

@@ -88,6 +88,10 @@ export class TakeCommand extends Command {
                     taken.push(item.name);
                 }
             }
+            // Same durable-change rule as the loose-floor pickups below
+            // (RKLbzxQQRJk8eD8Az) -- only when something actually moved.
+            if (taken.length > 0)
+                this.game?.requestSave('take');
             const lines = [taken.length > 0 ? `${prefix}You take ${taken.join(', ')} from the ${container.name}.` : `${prefix}You take nothing from the ${container.name}.`, ...left];
             return lines.join('\n');
         }
@@ -100,6 +104,7 @@ export class TakeCommand extends Command {
         if (!container.inventory.transferItemTo(item.name.toLowerCase(), this.actor.inventory)) {
             return `${prefix}You can't lift the ${item.name} right now.`;
         }
+        this.game?.requestSave('take');
         this.actor.performAction('takes', `${item.name} from the ${container.name}`);
         return `${prefix}You take the ${item.name} from the ${container.name}.`;
     }
@@ -223,6 +228,14 @@ export class TakeCommand extends Command {
         }
         if (tookAnything) {
             this.scene.updateInventory(this.scene.getPlayer().inventory);
+            // A PICKUP IS A DURABLE CHANGE (RKLbzxQQRJk8eD8Az: "I picked up
+            // the 'Ferret's ledger Service Log', but I don't see it reflected
+            // in the character sheet"). buy.ts's own fix comment named this
+            // file as a sibling that never learned the lesson (vR8ajvm3wXdexxdF2)
+            // -- the web sheet reads the last SAVED snapshot, and nothing here
+            // ever asked for one, so a swept haul sat invisible until the next
+            // unrelated save beat (homecoming, rest, a trade).
+            this.game?.requestSave('take');
         }
         // Win-condition checks run AFTER the sweep summary renders: the check
         // logs the JOB COMPLETE banner itself, and running it per-item used to
@@ -363,6 +376,15 @@ export class TakeCommand extends Command {
             room.inventory.removeItem(itemName);
             room.plainSightItems.delete(item.name.toLowerCase());
             this.logger.write(`Successfully removed "${itemName}" from ${room.name} room's inventory during 'Take' command.`);
+            // A PICKUP IS A DURABLE CHANGE (RKLbzxQQRJk8eD8Az: "I picked up
+            // the 'Ferret's ledger Service Log', but I don't see it reflected
+            // in the character sheet"). buy.ts's own fix comment named this
+            // file as a sibling that never learned the lesson (vR8ajvm3wXdexxdF2)
+            // -- the web sheet reads the last SAVED snapshot, and nothing here
+            // ever asked for one. Placed after the item has actually changed
+            // hands (the try's own catch below handles a too-heavy rollback
+            // before this line is ever reached), same rule as buy.ts/unequip.ts.
+            this.game?.requestSave('take');
             // Possession-based win condition: if some OTHER actor ends up with
             // the item the win condition's target NPC wants, that counts just as
             // much as the player handing it over directly (emergent delivery).

package/bundle/typescript/src/commands/game/sideQuest/game.js

@@ -185,6 +185,7 @@ import { clockTime, worldNow } from './utilities/world-clock.js';
 import { CommandFactory } from './factories/command-factory.js';
 import { SceneSynthesizer } from './factories/scene-factory.js';
 import { SceneSeedGenerator, FIXER_NAME, isFixerName } from './factories/scene-seed-generator.js';
+import { draftFailureNote } from './utilities/draft-failure-note.js';
 import { CALL_ICON, CALL_COLOR, END_CALL_SENTINEL } from './utilities/comm-style.js';
 import { AI } from '../../../tools/ai/ai.class.js';
 import { BULLET } from './utilities/log-style.js';
@@ -4147,33 +4148,7 @@ ${client.name} won't be remembering anything. Dead Johnsons pay nothing -- and t
         // caller but the ask-for-data-work door passes.
         const nextSeed = await SceneSeedGenerator.generate(this._logFilePath, nextTier, this.player, this.activeRumor, localCrew, undefined, runType);
         if (!nextSeed) {
-            // NAME the cause when it's the PROVIDER, not luck (real session:
-            // six Krow calls into an out-of-credits key, indistinguishable
-            // from flaky clients). Credit/auth failures are the player's to
-            // fix -- say so, out of character, once per ping.
-            const why = SceneSeedGenerator.lastFailure ?? '';
-            // TELL THE TRUTH ABOUT WHOSE FAULT IT IS (playtest 2026-08-26).
-            // The old test carried `invalid.*key`, meant for "invalid API
-            // key" -- but `.*` spans the whole message, so a skeleton
-            // validation error reading "Skeleton INVALID: ... locked doors
-            // and KEY placements" matched, and a map-generation bug was
-            // reported to the player as a billing problem. Sending someone to
-            // rotate a working key is worse than saying nothing.
-            //
-            // Every pattern here is now anchored to the phrase it actually
-            // means: a bare "invalid" or a stray "key" no longer counts, and
-            // the status codes need word boundaries so they can't match
-            // inside some other number.
-            const providerDown = /credit balance|billing|quota|insufficient (?:credit|fund|quota|balance)|invalid[\s_-]*api[\s_-]*key|api[\s_-]*key (?:is )?(?:invalid|expired|missing|not)|unauthorized|authentication|\b(?:401|403|429)\b|Plans & Billing/i.test(why);
-            // A structural failure is OURS, not the player's -- name it as
-            // the generator's problem so nobody goes hunting their billing
-            // page, and keep it short: the fiction already covers the beat.
-            const structural = !providerDown && /^Skeleton invalid|validation failed|isn't placed|unreachable from the start/i.test(why);
-            const opsNote = providerDown
-                ? `\n{yellow-fg}(Out of character: the AI provider refused -- "${why.slice(0, 120)}". Jobs can't generate until the API key/credits are fixed.){/yellow-fg}`
-                : structural
-                    ? `\n{yellow-fg}(Out of character: the job generator couldn't lay out a solvable map this time -- nothing wrong with your key or credits. Call again; the next draft usually takes.){/yellow-fg}`
-                    : '';
+            const opsNote = draftFailureNote(SceneSeedGenerator.lastFailure ?? '');
             return `Incoming call -- ${FIXER_NAME}: "Job fell through, chummer. Client got cold feet before the ink dried. Give me another call in a bit -- I'll shake something loose."${opsNote}`;
         }
         // HUB sessions: the draft lands as a MESSAGE, never a teleport (real

package/bundle/typescript/src/commands/game/sideQuest/utilities/draft-failure-note.js

@@ -0,0 +1,66 @@
+/**
+ * THE OUT-OF-CHARACTER NOTE ON A FAILED JOB DRAFT (game.ts's
+ * draftNextScene). SceneSeedGenerator.generate() gives up after three
+ * pipeline attempts and hands back a bare error string; Krow's "Job
+ * fell through" callback fires either way, and this decides what --
+ * if anything -- rides after it, so the player can tell "you did
+ * something wrong" from "this is on us" from "pure bad luck, try
+ * again."
+ *
+ * Extracted to its own module (2026-09-10) so the classification --
+ * pure string matching against known provider/generator error prose --
+ * can be pinned directly, without standing up a Game instance or
+ * mocking SceneSeedGenerator to reach it.
+ *
+ * TELL THE TRUTH ABOUT WHOSE FAULT IT IS (playtest 2026-08-26). The old
+ * test carried `invalid.*key`, meant for "invalid API key" -- but `.*`
+ * spans the whole message, so a skeleton validation error reading
+ * "Skeleton INVALID: ... locked doors and KEY placements" matched, and
+ * a map-generation bug was reported to the player as a billing problem.
+ * Sending someone to rotate a working key is worse than saying nothing.
+ * Every pattern here is anchored to the phrase it actually means: a
+ * bare "invalid" or a stray "key" no longer counts, and the status
+ * codes need word boundaries so they can't match inside some other
+ * number.
+ */
+export function draftFailureNote(why) {
+    // NAME THE CAUSE WHEN IT'S THE PROVIDER, NOT LUCK (real session: six
+    // Krow calls into an out-of-credits key, indistinguishable from flaky
+    // clients). Credit/auth failures are the player's to fix -- say so,
+    // out of character, once per ping.
+    // Widened 2026-09-10: the site's own current wording (ai-error-envelope.ts
+    // classifyUpstream's upstream_billing branch) reads "has run out of
+    // credit at its provider, or its key was rejected" -- neither phrase
+    // matched any pattern below, so the ORIGINAL motivating bug (the "six
+    // Krow calls into an out-of-credits key" session) would silently fall
+    // through to no note again today, on the site's real current message.
+    const providerDown = /credit balance|billing|quota|insufficient (?:credit|fund|quota|balance)|run out of credit|key was rejected|invalid[\s_-]*api[\s_-]*key|api[\s_-]*key (?:is )?(?:invalid|expired|missing|not)|unauthorized|authentication|\b(?:401|403|429)\b|Plans & Billing/i.test(why);
+    // TRANSIENT INFRASTRUCTURE, not billing and not a generation bug
+    // (real session, e8dLKM9j5P9yQn5yz's sibling report: a fresh
+    // character's very first homecoming draft, plus four manual "call
+    // Krow" retries, all failed in under half a second each against "The
+    // AI provider behind maka-cli.com is overloaded or down" --
+    // ai-error-envelope.ts's upstream_unavailable/rate_limited/
+    // upstream_timeout/upstream_error text, none of which this classifier
+    // recognized, so every one of those five calls read as the same
+    // unexplained "Job fell through" with nothing after it --
+    // indistinguishable from a broken loop rather than one outage. These
+    // are OURS and retryable, same tone as `structural` below, but a
+    // different truth: nothing was malformed, the provider just wasn't
+    // answering. Matched on the SITE'S OWN wording (ai-error-envelope.ts
+    // classifyUpstream/classifyTransportFailure) rather than status
+    // codes, since only the prose crosses the wire.
+    const providerOutage = !providerDown && /overloaded or down|rate-limited by its provider|took too long to answer|could not (?:complete that request|reach its ai provider)/i.test(why);
+    // A structural failure is OURS, not the player's -- name it as the
+    // generator's problem so nobody goes hunting their billing page, and
+    // keep it short: the fiction already covers the beat.
+    const structural = !providerDown && !providerOutage && /^Skeleton invalid|validation failed|isn't placed|unreachable from the start/i.test(why);
+    return providerDown
+        ? `\n{yellow-fg}(Out of character: the AI provider refused -- "${why.slice(0, 120)}". Jobs can't generate until the API key/credits are fixed.){/yellow-fg}`
+        : providerOutage
+            ? `\n{yellow-fg}(Out of character: the AI provider maka-cli.com talks to is overloaded, rate-limited, or unreachable right now -- nothing wrong with your account or your key. Give it a few minutes and call again.){/yellow-fg}`
+            : structural
+                ? `\n{yellow-fg}(Out of character: the job generator couldn't lay out a solvable map this time -- nothing wrong with your key or credits. Call again; the next draft usually takes.){/yellow-fg}`
+                : '';
+}
+//# sourceMappingURL=draft-failure-note.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maka/maka-cli",
-  "version": "5.149.0",
+  "version": "5.151.0",
   "type": "module",
   "summary": "A command line tool for scaffolding Meteor 3.x applications using either React.",
   "description": "A command line tool for scaffolding Meteor 3.x applications using React.",