@maheidem/pi-auto-image-attach 0.1.0 → 0.1.1

package/index.ts

@@ -29,27 +29,31 @@ const IMAGE_EXTENSIONS = new Set([
 	".png", ".jpg", ".jpeg", ".webp", ".gif", ".bmp",
 ]);
 
+/** Images above this size are skipped (protects context/cost). */
+const MAX_IMAGE_BYTES = 10 * 1024 * 1024;
+
 function isImagePath(filePath: string): boolean {
 	return IMAGE_EXTENSIONS.has(path.extname(filePath).toLowerCase());
 }
 
 async function detectImageMimeType(filePath: string): Promise<string | null> {
-	try {
-		const fd = await fs.promises.open(filePath, "r");
-		const buffer = Buffer.alloc(4100);
-		const { bytesRead } = await fd.read(buffer, 0, 4100, 0);
-		await fd.close();
-		const s = buffer.subarray(0, bytesRead);
-		if (s[0] === 0x89 && s[1] === 0x50 && s[2] === 0x4e && s[3] === 0x47 &&
-			s[4] === 0x0d && s[5] === 0x0a && s[6] === 0x1a && s[7] === 0x0a) return "image/png";
-		if (s[0] === 0xff && s[1] === 0xd8 && s[2] === 0xff) return "image/jpeg";
-		if (s[0] === 0x47 && s[1] === 0x49 && s[2] === 0x46 && s[3] === 0x38) return "image/gif";
-		if (s[0] === 0x52 && s[1] === 0x49 && s[2] === 0x46 && s[3] === 0x46 &&
-			s[8] === 0x57 && s[9] === 0x45 && s[10] === 0x42 && s[11] === 0x50) return "image/webp";
-		if (s[0] === 0x42 && s[1] === 0x4d) return "image/bmp";
-		return null;
-	}
-	catch { return null; }
+	const fd = await fs.promises.open(filePath, "r");
+	const buffer = Buffer.alloc(4100);
+	const { bytesRead } = await fd.read(buffer, 0, 4100, 0);
+	await fd.close();
+	const s = buffer.subarray(0, bytesRead);
+	if (s[0] === 0x89 && s[1] === 0x50 && s[2] === 0x4e && s[3] === 0x47 &&
+		s[4] === 0x0d && s[5] === 0x0a && s[6] === 0x1a && s[7] === 0x0a) return "image/png";
+	if (s[0] === 0xff && s[1] === 0xd8 && s[2] === 0xff) return "image/jpeg";
+	if (s[0] === 0x47 && s[1] === 0x49 && s[2] === 0x46 && s[3] === 0x38) return "image/gif";
+	if (s[0] === 0x52 && s[1] === 0x49 && s[2] === 0x46 && s[3] === 0x46 &&
+		s[8] === 0x57 && s[9] === 0x45 && s[10] === 0x42 && s[11] === 0x50) return "image/webp";
+	if (s[0] === 0x42 && s[1] === 0x4d) return "image/bmp";
+	return null;
+}
+
+function skip(filePath: string, reason: string): void {
+	console.error(`[auto-image-attach] skipped ${filePath}: ${reason}`);
 }
 
 interface ImagePathEntry {
@@ -69,10 +73,12 @@ export default function (pi: ExtensionAPI) {
 		const extRegex = /\.(png|jpe?g|webp|gif|bmp)($|["'\s,;:])/gi;
 		let m;
 		while ((m = extRegex.exec(text)) !== null) {
-			const end = m.index + m[0].length;
+			// m[0] may include a trailing delimiter (space/quote/punct); exclude it from the path
+			const end = m.index + m[0].length - (m[2] ? m[2].length : 0);
 			// Scan back to unescaped space or beginning
 			let start = end - 1;
 			while (start > 0 && !(text[start] === " " && text[start - 1] !== "\\")) start--;
+			if (text[start] === " " && text[start - 1] !== "\\") start++; // drop the delimiter space
 			const raw = text.substring(start, end);
 			const clean = raw.replace(/\\/g, "");
 			if ((clean.startsWith("/") || clean.startsWith("./") || clean.startsWith("../"))
@@ -85,20 +91,39 @@ export default function (pi: ExtensionAPI) {
 
 		// Read and encode images
 		const images: ImageContent[] = [];
-		for (const { cleanPath } of entries) {
+		const attached: string[] = []; // rawPaths of successfully attached entries
+		for (const { rawPath, cleanPath } of entries) {
 			try {
+				let size = 0;
+				try {
+					size = fs.statSync(cleanPath).size;
+				} catch (err) {
+					skip(cleanPath, `stat failed (${(err as Error).message})`);
+					continue;
+				}
+				if (size > MAX_IMAGE_BYTES) {
+					// Oversize: do not attach; leave the path in the text (user may need it)
+					console.error(`[auto-image-attach] skipped ${cleanPath}: ${size} exceeds 10MB cap`);
+					continue;
+				}
 				const mimeType = await detectImageMimeType(cleanPath);
-				if (!mimeType) continue;
+				if (!mimeType) {
+					skip(cleanPath, "unrecognized image format");
+					continue;
+				}
 				const data = fs.readFileSync(cleanPath).toString("base64");
 				images.push({ type: "image", data, mimeType });
-			} catch { /* skip unreadable */ }
+				attached.push(rawPath);
+			} catch (err) {
+				skip(cleanPath, `read failed (${(err as Error).message})`);
+			}
 		}
 
 		if (images.length === 0) return { action: "continue" };
 
-		// Remove image paths from text
+		// Remove attached image paths from text (skipped entries keep their path)
 		let cleaned = text;
-		for (const { rawPath } of entries) {
+		for (const rawPath of attached) {
 			const escaped = rawPath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
 			cleaned = cleaned.replace(new RegExp(escaped, "g"), "");
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maheidem/pi-auto-image-attach",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "type": "module",
   "description": "Pi extension: auto-attaches pasted/dragged image file paths as ImageContent blocks so the model actually sees the image.",
   "keywords": [
@@ -14,7 +14,9 @@
     "LICENSE"
   ],
   "scripts": {
-    "typecheck": "tsc -p tsconfig.json"
+    "typecheck": "tsc -p tsconfig.json",
+    "test": "node --test *.test.ts",
+    "prepack": "npm run typecheck && npm test"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": ">=0.84.0"
@@ -43,4 +45,4 @@
   "bugs": {
     "url": "https://github.com/Maheidem/pi-coder-management/issues"
   }
-}
+}