@magnusekdahl/parallix 1.3.2 → 1.3.4

package/lib/review/review-artifacts.ts

@@ -102,12 +102,12 @@ function postWorkflowComment(
   slug: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    readTokenFn?: (user: string, opts: { rootDir?: string }) => string | null;
-    postCommentFn?: (branch: string, token: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    readReviewStateFn?: (s: string, r?: string) => any;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    readTokenFn?: (_user: string, _opts: { rootDir?: string }) => string | null;
+    postCommentFn?: (_branch: string, _token: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    readReviewStateFn?: (_s: string, _r?: string) => any;
     rootDir?: string;
     reviewIdentity?: string;
     forgejoUser?: string;
@@ -172,11 +172,11 @@ function recordLocalReviewVerdict(
   outcome: string,
   options: {
     worktree?: string;
-    writeReviewStateFn?: (s: string, st: any, w: string) => boolean;
-    createEventFn?: (s: string, t: string, p: Record<string, unknown>, o: Record<string, unknown>) => CreateResult;
-    readReviewStateFn?: (s: string, r?: string) => any;
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    writeReviewStateFn?: (_s: string, _st: any, _w: string) => boolean;
+    createEventFn?: (_s: string, _t: string, _p: Record<string, unknown>, _o: Record<string, unknown>) => CreateResult;
+    readReviewStateFn?: (_s: string, _r?: string) => any;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     reviewer?: string;
   } = {}
 ): void {
@@ -216,18 +216,18 @@ function postWorkflowReview(
   outcome: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    readTokenFn?: (user: string, opts: { rootDir?: string }) => string | null;
-    postReviewFn?: (branch: string, token: string, outcome: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    readReviewStateFn?: (s: string, r?: string) => any;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    readTokenFn?: (_user: string, _opts: { rootDir?: string }) => string | null;
+    postReviewFn?: (_branch: string, _token: string, _outcome: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    readReviewStateFn?: (_s: string, _r?: string) => any;
     worktree?: string;
     reviewIdentity?: string;
     forgejoUser?: string;
-    getPrAuthorFn?: (branch: string, token: string, opts?: Record<string, unknown>) => unknown;
-    writeReviewStateFn?: (s: string, st: any, w: string) => boolean;
-    createEventFn?: (s: string, t: string, p: Record<string, unknown>, o: Record<string, unknown>) => CreateResult;
+    getPrAuthorFn?: (_branch: string, _token: string, _opts?: Record<string, unknown>) => unknown;
+    writeReviewStateFn?: (_s: string, _st: any, _w: string) => boolean;
+    createEventFn?: (_s: string, _t: string, _p: Record<string, unknown>, _o: Record<string, unknown>) => CreateResult;
   } = {}
 ): { ok: boolean; error?: string; skipped?: boolean; reason?: string; prAuthor?: unknown } {
   const log = options.log || fmt.log.plain;
@@ -292,8 +292,8 @@ async function consumeReviewerArtifacts(
   slug: string,
   reviewer: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     readArtifactFn?: typeof readArtifactFile;
     deleteArtifactFn?: typeof deleteArtifactFile;
     tmpDir?: string | null;
@@ -301,12 +301,12 @@ async function consumeReviewerArtifacts(
     worktree?: string;
     providerEnabled?: boolean | null;
     forgejoEnabled?: boolean | null;
-    readTokenFn?: (user: string, opts?: Record<string, unknown>) => string | null;
-    getCommentsFn?: (branch: string, token: string) => Promise<unknown[]>;
-    postCommentFn?: (branch: string, token: string, body: string, opts?: Record<string, unknown>) => unknown;
-    postReviewFn?: (branch: string, token: string, outcome: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    createEventFn?: (s: string, t: string, p: CreateEventParams, o: CreateEventOptions) => CreateEventResult;
+    readTokenFn?: (_user: string, _opts?: Record<string, unknown>) => string | null;
+    getCommentsFn?: (_branch: string, _token: string) => Promise<unknown[]>;
+    postCommentFn?: (_branch: string, _token: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    postReviewFn?: (_branch: string, _token: string, _outcome: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    createEventFn?: (_s: string, _t: string, _p: CreateEventParams, _o: CreateEventOptions) => CreateEventResult;
   } = {}
 ): Promise<{ consumed: boolean; ok?: boolean; reviewState?: string | null }> {
   const log = options.log || fmt.log.plain;
@@ -452,8 +452,8 @@ async function consumeImplementerArtifacts(
   slug: string,
   implementer: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     readArtifactFn?: typeof readArtifactFile;
     deleteArtifactFn?: typeof deleteArtifactFile;
     tmpDir?: string | null;
@@ -461,11 +461,11 @@ async function consumeImplementerArtifacts(
     worktree?: string;
     providerEnabled?: boolean | null;
     forgejoEnabled?: boolean | null;
-    readTokenFn?: (user: string, opts?: Record<string, unknown>) => string | null;
-    getCommentsFn?: (branch: string, token: string) => Promise<unknown[]>;
-    postCommentFn?: (branch: string, token: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    createEventFn?: (s: string, t: string, p: CreateEventParams, o: CreateEventOptions) => CreateEventResult;
+    readTokenFn?: (_user: string, _opts?: Record<string, unknown>) => string | null;
+    getCommentsFn?: (_branch: string, _token: string) => Promise<unknown[]>;
+    postCommentFn?: (_branch: string, _token: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    createEventFn?: (_s: string, _t: string, _p: CreateEventParams, _o: CreateEventOptions) => CreateEventResult;
   } = {}
 ): Promise<{ consumed: boolean; ok?: boolean; disposition?: string | null }> {
   const log = options.log || fmt.log.plain;

package/lib/review/review-commands.ts

@@ -51,7 +51,7 @@ export function readTextFlag(
   inlineFlag: string,
   fileFlag: string,
   label: string,
-  options: { readFileSync?: typeof fs.readFileSync; error?: (msg: string) => void; exit?: (code: number) => never } = {}
+  options: { readFileSync?: typeof fs.readFileSync; error?: (_msg: string) => void; exit?: (_code: number) => never } = {}
 ): string | null {
   const readFileSync = options.readFileSync || fs.readFileSync;
   const error = options.error || fmt.log.plainError;
@@ -98,8 +98,8 @@ export function formatStaticReviewSuccess(slug: string): string {
 function repairStaleActiveTaskAfterReview(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     getTaskStatusFn?: typeof getTaskStatus;
     resolveTaskFileFn?: typeof resolveTaskFile;
     transitionTaskFn?: typeof transitionTask;
@@ -133,7 +133,7 @@ function repairStaleActiveTaskAfterReview(
 
 async function commitPersistedReviewOutputs(
   slug: string,
-  options: { worktree?: string; taskFile?: string | null; log?: (msg: string) => void; error?: (msg: string) => void } = {}
+  options: { worktree?: string; taskFile?: string | null; log?: (_msg: string) => void; error?: (_msg: string) => void } = {}
 ): Promise<{ ok: boolean; dirty?: boolean; unsafe?: boolean }> {
   return commitSafeMissionArtifacts(slug, options.worktree || process.cwd(), {
     taskFile: options.taskFile || null,
@@ -146,8 +146,8 @@ export function postStaticReviewComment(
   slug: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     resolveTaskFileFn?: typeof resolveTaskFile;
     getTaskImplementerFn?: typeof getTaskImplementer;
     resolveWorktreeFn?: typeof resolveWorktree;
@@ -215,7 +215,7 @@ export function postStaticReviewComment(
 export function performStaticReview(
   slug: string,
   options: {
-    log?: (msg: string) => void;
+    log?: (_msg: string) => void;
     findMissionDir?: typeof findMissionDir;
     findCheckpoints?: typeof findCheckpoints;
     readFileSync?: typeof fs.readFileSync;
@@ -338,9 +338,9 @@ export function verifyReview(
   slug: string,
   skipGate: boolean | string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
     findMissionDirFn?: typeof findMissionDir;
     getCurrentBranchFn?: typeof getCurrentBranch;
@@ -522,15 +522,15 @@ export async function submitForReview(
   slug: string,
   skipGate: boolean | string,
   options: {
-    exit?: (code: number) => never;
+    exit?: (_code: number) => never;
     resolveTaskFileFn?: typeof resolveTaskFile;
     getTaskImplementerFn?: typeof getTaskImplementer;
     resolveWorktreeFn?: typeof resolveWorktree;
-    performHandoffFn?: (slug: string, opts?: Record<string, unknown>) => Promise<Record<string, unknown>>;
+    performHandoffFn?: (_slug: string, _opts?: Record<string, unknown>) => Promise<Record<string, unknown>>;
     readReviewStateFn?: typeof readReviewState;
     isReviewProviderEnabledFn?: typeof isProviderEnabled;
     isForgejoReviewEnabledFn?: typeof isProviderEnabled;
-    log?: (msg: string) => void;
+    log?: (_msg: string) => void;
   } = {}
 ): Promise<void> {
   const exit = options.exit || process.exit;
@@ -583,9 +583,9 @@ export async function submitForReview(
 export async function readComments(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     readTokenFn?: typeof readToken;
     readReviewStateFn?: typeof readReviewState;
     resolveReviewUserFn?: typeof resolveReviewUser;
@@ -676,9 +676,9 @@ export async function readComments(
 export async function pushRound(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
     resolveTaskFileFn?: typeof resolveTaskFile;
     getTaskImplementerFn?: typeof getTaskImplementer;
@@ -800,7 +800,7 @@ export async function pushRound(
 export function showReviewStatus(
   slug: string,
   options: {
-    log?: (msg: string) => void;
+    log?: (_msg: string) => void;
     readReviewStateFn?: typeof readReviewState;
     resolveWorktreeFn?: typeof resolveWorktree;
   } = {}
@@ -843,9 +843,9 @@ export function commentRound(
   slug: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     readReviewStateFn?: typeof readReviewState;
     writeReviewStateFn?: typeof writeReviewState;
     resolveReviewUserFn?: typeof resolveReviewUser;
@@ -902,8 +902,8 @@ export function commentRound(
 export async function consumeArtifacts(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     resolveWorktreeFn?: typeof resolveWorktree;
     transitionTaskFn?: typeof transitionTask;
     consumeReviewerArtifactsFn?: typeof consumeReviewerArtifacts;
@@ -1015,9 +1015,9 @@ export function submitReviewRound(
   outcome: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     transitionTaskFn?: typeof transitionTask;
     readReviewStateFn?: typeof readReviewState;
     writeReviewStateFn?: typeof writeReviewState;
@@ -1178,9 +1178,9 @@ export function submitReviewRound(
 export async function closeMissionPr(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     readTokenFn?: typeof readToken;
     readReviewStateFn?: typeof readReviewState;
     resolveReviewUserFn?: typeof resolveReviewUser;
@@ -1233,9 +1233,9 @@ export function createEventHandler(
   slug: string,
   args: string[],
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
     readReviewStateFn?: typeof readReviewState;
   } = {}
@@ -1349,9 +1349,9 @@ export function importLegacyHandler(
   slug: string,
   args: string[],
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
   } = {}
 ): void {
@@ -1383,9 +1383,9 @@ export async function review(
   args: string[],
   options: {
     inferSlugFn?: typeof inferSlug;
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     verifyReviewFn?: typeof verifyReview;
     submitForReviewFn?: typeof submitForReview;
     consumeArtifactsFn?: typeof consumeArtifacts;

package/lib/review/review-events.ts

@@ -207,8 +207,8 @@ export interface CreateEventParams {
 export interface CreateEventOptions {
   skipGit?: boolean;
   gitFn?: typeof git;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
   worktree?: string;
   allowMissingRequiredFields?: boolean;
 }
@@ -247,7 +247,7 @@ export interface ReadAllEventsOptions {
   rootDir?: string;
   readdirSync?: typeof fs.readdirSync;
   readFileSync?: typeof fs.readFileSync;
-  error?: (msg: string) => void;
+  error?: (_msg: string) => void;
 }
 
 export interface ParseEventResult {
@@ -352,14 +352,14 @@ function classifyComment(comment: { body?: string }): string | null {
 }
 
 export interface ConsumeHumanNotesOptions {
-  getCommentsFn?: (branch: string, token: string) => Promise<unknown[]>;
-  createEventFn?: typeof createEvent;
-  readTokenFn?: (user: string) => string | null;
+  getCommentsFn?: (_branch: string, _token: string) => Promise<unknown[]>;
+    createEventFn?: typeof createEvent;
+    readTokenFn?: (_user: string) => string | null;
   reviewIdentity?: string | null;
   forgejoUser?: string | null;
   worktree?: string;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
 }
 
 /**
@@ -578,8 +578,8 @@ function createEvent(slug: string, eventType: string, params: CreateEventParams,
 
 export interface ImportLegacyArtifactOptions {
   tmpDir?: string;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
   worktree?: string;
 }
 
@@ -650,9 +650,9 @@ const LEGACY_ARTIFACT_TO_EVENT_TYPE: Readonly<Record<string, string>> = Object.f
 
 export interface ImportAllLegacyOptions {
   tmpDir?: string;
-  error?: (msg: string) => void;
+  error?: (_msg: string) => void;
   worktree?: string;
-  log?: (msg: string) => void;
+  log?: (_msg: string) => void;
 }
 
 /**