@magnusekdahl/parallix 1.2.1 → 1.3.0

package/lib/review/review-state.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Reviewer-family persistence for the autonomous review loop.
  *
@@ -6,13 +7,52 @@
  *
  * Owned by the Node workflow harness (ADR 0037 / task-089).
  */
-
-const fs = require('fs');
-const path = require('path');
-const { git } = require('../core/git');
-const { findMissionDir, resolveWorktree } = require('../core/mission-utils');
-const fmt = require('../core/fmt');
-
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ReviewState = exports.VALID_PHASES = void 0;
+exports.reviewStateFile = reviewStateFile;
+exports.readReviewState = readReviewState;
+exports.resolveReviewIdentity = resolveReviewIdentity;
+exports.normalizeReviewPhase = normalizeReviewPhase;
+exports.writeReviewState = writeReviewState;
+exports.resetReviewState = resetReviewState;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const git_js_1 = require("../core/git.js");
+const mission_utils_js_1 = require("../core/mission-utils.js");
+const fmt_js_1 = require("../core/fmt.js");
 /**
  * Return the path to the review-state file for a given slug.
  * Resolves using the same mission-dir discovery as other workflow commands.
@@ -22,11 +62,12 @@ const fmt = require('../core/fmt');
  * @returns {string|null}  Absolute path, or null if mission dir not found
  */
 function reviewStateFile(slug, rootDir = process.cwd()) {
-  const missionDir = findMissionDir(slug, rootDir);
-  if (!missionDir) {return null;}
-  return path.join(missionDir, 'review-state.json');
+    const missionDir = (0, mission_utils_js_1.findMissionDir)(slug, rootDir);
+    if (!missionDir) {
+        return null;
+    }
+    return path.join(missionDir, 'review-state.json');
 }
-
 /**
  * Read the persisted review state for a mission.
  *
@@ -35,21 +76,22 @@ function reviewStateFile(slug, rootDir = process.cwd()) {
  * @returns {ReviewState|null}
  */
 function readReviewState(slug, rootDir = process.cwd()) {
-  const statePath = reviewStateFile(slug, rootDir);
-  if (!statePath || !fs.existsSync(statePath)) {return null;}
-
-  try {
-    const raw = fs.readFileSync(statePath, 'utf8');
-    const parsed = JSON.parse(raw);
-    if (parsed && parsed.reviewer && parsed.implementer) {
-      return new ReviewState(slug, parsed);
+    const statePath = reviewStateFile(slug, rootDir);
+    if (!statePath || !fs.existsSync(statePath)) {
+        return null;
+    }
+    try {
+        const raw = fs.readFileSync(statePath, 'utf8');
+        const parsed = JSON.parse(raw);
+        if (parsed && parsed.reviewer && parsed.implementer) {
+            return new ReviewState(slug, parsed);
+        }
+        return null;
+    }
+    catch {
+        return null;
     }
-    return null;
-  } catch (_) {
-    return null;
-  }
 }
-
 /**
  * Resolve the review-provider identity for a review workflow path.
  *
@@ -61,197 +103,188 @@ function readReviewState(slug, rootDir = process.cwd()) {
  * @param {{readReviewStateFn?: Function}} [options]
  * @returns {{ identityUser: string|null, commentIdentityUser: string|null, forgejoUser: string|null, commentForgejoUser: string|null, reviewState: ReviewState|null, source: 'review-state'|null }}
  */
-function resolveReviewIdentity(slug, rootDir = process.cwd(), /** @type {{readReviewStateFn?: Function}} */ options = {}) {
-  const readReviewStateFn = options.readReviewStateFn || readReviewState;
-  const reviewState = readReviewStateFn(slug, rootDir);
-  const reviewerUser = reviewState ? (reviewState.reviewer || reviewState.implementer || null) : null;
-  const implementerUser = reviewState ? (reviewState.implementer || reviewState.reviewer || null) : null;
-
-  return {
-    identityUser: reviewerUser || null,
-    commentIdentityUser: implementerUser || null,
-    // Legacy aliases kept for compatibility while generic review orchestration
-    // moves to provider-neutral option names.
-    forgejoUser: reviewerUser || null,
-    commentForgejoUser: implementerUser || null,
-    reviewState,
-    source: reviewerUser ? 'review-state' : null
-  };
+function resolveReviewIdentity(slug, rootDir = process.cwd(), options = {}) {
+    const readReviewStateFn = options.readReviewStateFn || readReviewState;
+    const reviewState = readReviewStateFn(slug, rootDir);
+    const reviewerUser = reviewState ? (reviewState.reviewer || reviewState.implementer || null) : null;
+    const implementerUser = reviewState ? (reviewState.implementer || reviewState.reviewer || null) : null;
+    return {
+        identityUser: reviewerUser || null,
+        commentIdentityUser: implementerUser || null,
+        forgejoUser: reviewerUser || null,
+        commentForgejoUser: implementerUser || null,
+        reviewState,
+        source: reviewerUser ? 'review-state' : null
+    };
 }
-
 /**
  * Manager class for mission review state.
  * Expanded to include phase, disposition, and metadata for canonical state ownership.
  */
-const VALID_PHASES = ['reviewing', 'fixing', 'pending-approval', 'approved'];
+exports.VALID_PHASES = ['reviewing', 'fixing', 'pending-approval', 'approved'];
 const PHASE_ALIASES = new Map([
-  ['review', 'reviewing'],
-  ['rewiewing', 'reviewing'],
-  ['fix', 'fixing'],
-  ['pending_approval', 'pending-approval'],
-  ['pending approval', 'pending-approval']
+    ['review', 'reviewing'],
+    ['rewiewing', 'reviewing'],
+    ['fix', 'fixing'],
+    ['pending_approval', 'pending-approval'],
+    ['pending approval', 'pending-approval']
 ]);
-
 const PHASE_TRANSITIONS = {
-  'reviewing': ['fixing', 'approved'],
-  'fixing': ['reviewing', 'pending-approval'],
-  'pending-approval': ['reviewing'],
-  'approved': []
+    'reviewing': ['fixing', 'approved'],
+    'fixing': ['reviewing', 'pending-approval'],
+    'pending-approval': ['reviewing'],
+    'approved': []
 };
-
 /** @param {string} disposition */
 function inferPhaseFromDisposition(disposition) {
-  switch (String(disposition || '').trim().toUpperCase()) {
-  case 'APPROVED':
-    return 'approved';
-  case 'REQUEST_CHANGES':
-  case 'COMMENT':
-  case 'PUSHBACK_ALL':
-  case 'BLOCKED':
-  case 'PARKED':
-    return 'fixing';
-  case 'CHANGES_MADE':
-    return 'reviewing';
-  default:
-    return 'reviewing';
-  }
+    switch (String(disposition || '').trim().toUpperCase()) {
+        case 'APPROVED':
+            return 'approved';
+        case 'REQUEST_CHANGES':
+        case 'COMMENT':
+        case 'PUSHBACK_ALL':
+        case 'BLOCKED':
+        case 'PARKED':
+            return 'fixing';
+        case 'CHANGES_MADE':
+            return 'reviewing';
+        default:
+            return 'reviewing';
+    }
 }
-
 /** @param {string} phase @param {string} disposition */
 function normalizeReviewPhase(phase, disposition) {
-  if (!phase) {
-    return { phase: 'reviewing', original: null, normalized: false };
-  }
-
-  const raw = String(phase).trim();
-  const canonical = raw.toLowerCase().replace(/[_\s]+/g, '-');
-  if (VALID_PHASES.includes(canonical)) {
-    return { phase: canonical, original: raw, normalized: canonical !== raw };
-  }
-
-  const alias = PHASE_ALIASES.get(raw.toLowerCase()) || PHASE_ALIASES.get(canonical);
-  if (alias) {
-    return { phase: alias, original: raw, normalized: true };
-  }
-
-  return {
-    phase: inferPhaseFromDisposition(disposition),
-    original: raw,
-    normalized: true
-  };
+    if (!phase) {
+        return { phase: 'reviewing', original: null, normalized: false };
+    }
+    const raw = String(phase).trim();
+    const canonical = raw.toLowerCase().replace(/[_\s]+/g, '-');
+    if (exports.VALID_PHASES.includes(canonical)) {
+        return { phase: canonical, original: raw, normalized: canonical !== raw };
+    }
+    const alias = PHASE_ALIASES.get(raw.toLowerCase()) || PHASE_ALIASES.get(canonical);
+    if (alias) {
+        return { phase: alias, original: raw, normalized: true };
+    }
+    return {
+        phase: inferPhaseFromDisposition(disposition),
+        original: raw,
+        normalized: true
+    };
 }
-
-/**
- * @typedef {{reviewer?: string, implementer?: string, round?: number, startedAt?: string, phase?: string, disposition?: string | null, reviewerRetryCount?: number, implementerRetryCount?: number, metadata?: {[key: string]: any}}} ReviewStateData
- */
-
 class ReviewState {
-  /**
-   * @param {string} slug
-   * @param {ReviewStateData} [data]
-   */
-  constructor(slug, /** @type {ReviewStateData} */ data = {}) {
-    const phaseInfo = normalizeReviewPhase(/** @type {string} */ (data.phase || ''), /** @type {string} */ (data.disposition || ''));
-    this.slug = slug;
-    this.reviewer = data.reviewer;
-    this.implementer = data.implementer;
-    this.round = data.round || 1;
-    this.startedAt = data.startedAt || new Date().toISOString();
-    this.phase = phaseInfo.phase;
-    this.disposition = data.disposition || null;
-    this.reviewerRetryCount = data.reviewerRetryCount || 0;
-    this.implementerRetryCount = data.implementerRetryCount || 0;
-    this.metadata = data.metadata || {};
-    this.phaseOriginal = phaseInfo.normalized ? phaseInfo.original : null;
-  }
-
-  /**
-   * @param {string} slug
-   * @param {ReviewState|ReviewStateData} dataOrInstance
-   * @returns {ReviewState}
-   */
-  static from(slug, dataOrInstance) {
-    if (dataOrInstance instanceof ReviewState) {
-      if (dataOrInstance.slug !== slug) {
-        throw new Error(`ReviewState slug mismatch: expected "${slug}", got "${dataOrInstance.slug}"`);
-      }
-      return dataOrInstance;
+    slug;
+    reviewer;
+    implementer;
+    round;
+    startedAt;
+    phase;
+    disposition;
+    reviewerRetryCount;
+    implementerRetryCount;
+    metadata;
+    phaseOriginal;
+    /**
+     * @param {string} slug
+     * @param {ReviewStateData} [data]
+     */
+    constructor(slug, data = {}) {
+        const phaseInfo = normalizeReviewPhase(data.phase || '', data.disposition || '');
+        this.slug = slug;
+        this.reviewer = data.reviewer;
+        this.implementer = data.implementer;
+        this.round = data.round || 1;
+        this.startedAt = data.startedAt || new Date().toISOString();
+        this.phase = phaseInfo.phase;
+        this.disposition = data.disposition || null;
+        this.reviewerRetryCount = data.reviewerRetryCount || 0;
+        this.implementerRetryCount = data.implementerRetryCount || 0;
+        this.metadata = data.metadata || {};
+        this.phaseOriginal = phaseInfo.normalized ? phaseInfo.original : null;
     }
-    return new ReviewState(slug, dataOrInstance || {});
-  }
-
-  /**
-   * @param {string} nextPhase
-   * @returns {ReviewState}
-   */
-  transitionTo(nextPhase) {
-    if (!VALID_PHASES.includes(nextPhase)) {
-      throw new Error(`Invalid phase: "${nextPhase}". Valid: ${VALID_PHASES.join(', ')}`);
+    /**
+     * @param {string} slug
+     * @param {ReviewState|ReviewStateData} dataOrInstance
+     * @returns {ReviewState}
+     */
+    static from(slug, dataOrInstance) {
+        if (dataOrInstance instanceof ReviewState) {
+            if (dataOrInstance.slug !== slug) {
+                throw new Error(`ReviewState slug mismatch: expected "${slug}", got "${dataOrInstance.slug}"`);
+            }
+            return dataOrInstance;
+        }
+        return new ReviewState(slug, dataOrInstance || {});
     }
-    const transitions = /** @type {{[key: string]: string[]}} */ (PHASE_TRANSITIONS);
-    const allowedArr = transitions[this.phase];
-    if (!allowedArr || !allowedArr.includes(nextPhase)) {
-      throw new Error(`Cannot transition from "${this.phase}" to "${nextPhase}". Allowed: ${(allowedArr || []).join(', ') || 'none'}`);
+    /**
+     * @param {string} nextPhase
+     * @returns {ReviewState}
+     */
+    transitionTo(nextPhase) {
+        if (!exports.VALID_PHASES.includes(nextPhase)) {
+            throw new Error(`Invalid phase: "${nextPhase}". Valid: ${exports.VALID_PHASES.join(', ')}`);
+        }
+        const allowedArr = PHASE_TRANSITIONS[this.phase];
+        if (!allowedArr || !allowedArr.includes(nextPhase)) {
+            throw new Error(`Cannot transition from "${this.phase}" to "${nextPhase}". Allowed: ${(allowedArr || []).join(', ') || 'none'}`);
+        }
+        this.phase = nextPhase;
+        return this;
     }
-    this.phase = nextPhase;
-    return this;
-  }
-
-  advanceRound() {
-    this.round += 1;
-    this.phase = 'reviewing';
-    this.disposition = null;
-    this.reviewerRetryCount = 0;
-    this.implementerRetryCount = 0;
-    this.startedAt = new Date().toISOString();
-    return this;
-  }
-
-  /**
-   * @returns {{reviewer?: string, implementer?: string, round?: number, startedAt?: string, phase?: string, disposition?: string, reviewerRetryCount?: number, implementerRetryCount?: number, metadata?: {[key: string]: any}}}
-   */
-  toJSON() {
-    /** @type {{reviewer?: string, implementer?: string, round?: number, startedAt?: string, phase?: string, disposition?: string, reviewerRetryCount?: number, implementerRetryCount?: number, metadata?: {[key: string]: any}}} */
-    const payload = {
-      reviewer: this.reviewer,
-      implementer: this.implementer,
-      round: this.round,
-      startedAt: this.startedAt,
-      phase: this.phase,
-      disposition: this.disposition || undefined
-    };
-
-    if (this.reviewerRetryCount > 0) {payload.reviewerRetryCount = this.reviewerRetryCount;}
-    if (this.implementerRetryCount > 0) {payload.implementerRetryCount = this.implementerRetryCount;}
-    if (Object.keys(this.metadata || {}).length > 0) {payload.metadata = this.metadata;}
-
-    return payload;
-  }
-
-  save(worktree = resolveWorktree(this.slug) || process.cwd(), gitFn = git) {
-    const statePath = reviewStateFile(this.slug, worktree);
-    if (!statePath) {return false;}
-
-    const payload = this.toJSON();
-    fs.writeFileSync(statePath, JSON.stringify(payload, null, 2) + '\n', 'utf8');
-
-    const relPath = path.relative(worktree, statePath);
-    gitFn(['-C', worktree, 'add', relPath]);
-    const msg = `review-state(${this.slug}): round ${this.round} (${this.phase}) [${this.reviewer} -> ${this.implementer}]${this.disposition ? ` disposition=${this.disposition}` : ''}`;
-    const result = gitFn(['-C', worktree, 'commit', '-m', msg]);
-
-    if (result.status !== 0) {
-      const statusResult = gitFn(['-C', worktree, 'status', '--porcelain', relPath]);
-      if (statusResult.stdout.trim() === '') {
+    advanceRound() {
+        this.round += 1;
+        this.phase = 'reviewing';
+        this.disposition = null;
+        this.reviewerRetryCount = 0;
+        this.implementerRetryCount = 0;
+        this.startedAt = new Date().toISOString();
+        return this;
+    }
+    /**
+     * @returns {{reviewer?: string, implementer?: string, round?: number, startedAt?: string, phase?: string, disposition?: string, reviewerRetryCount?: number, implementerRetryCount?: number, metadata?: {[key: string]: unknown}}}
+     */
+    toJSON() {
+        const payload = {
+            reviewer: this.reviewer,
+            implementer: this.implementer,
+            round: this.round,
+            startedAt: this.startedAt,
+            phase: this.phase,
+            disposition: this.disposition || undefined
+        };
+        if (this.reviewerRetryCount > 0) {
+            payload.reviewerRetryCount = this.reviewerRetryCount;
+        }
+        if (this.implementerRetryCount > 0) {
+            payload.implementerRetryCount = this.implementerRetryCount;
+        }
+        if (Object.keys(this.metadata || {}).length > 0) {
+            payload.metadata = this.metadata;
+        }
+        return payload;
+    }
+    save(worktree = (0, mission_utils_js_1.resolveWorktree)(this.slug) || process.cwd(), gitFn = git_js_1.git) {
+        const statePath = reviewStateFile(this.slug, worktree);
+        if (!statePath) {
+            return false;
+        }
+        const payload = this.toJSON();
+        fs.writeFileSync(statePath, JSON.stringify(payload, null, 2) + '\n', 'utf8');
+        const relPath = path.relative(worktree, statePath);
+        const result = gitFn(['-C', worktree, 'add', relPath]);
+        const msg = `review-state(${this.slug}): round ${this.round} (${this.phase}) [${this.reviewer} -> ${this.implementer}]${this.disposition ? ` disposition=${this.disposition}` : ''}`;
+        const commitResult = gitFn(['-C', worktree, 'commit', '-m', msg]);
+        if (commitResult.status !== 0) {
+            const statusResult = gitFn(['-C', worktree, 'status', '--porcelain', relPath]);
+            if (statusResult.stdout.trim() === '') {
+                return true;
+            }
+            fmt_js_1.log.warn(`Failed to commit review state update: ${commitResult.stderr}`);
+        }
         return true;
-      }
-      fmt.log.warn(`Failed to commit review state update: ${result.stderr}`);
     }
-
-    return true;
-  }
 }
-
+exports.ReviewState = ReviewState;
 /**
  * Write and commit the review state for a mission.
  * Commits to the current branch so the state is visible after session restarts.
@@ -260,11 +293,10 @@ class ReviewState {
  * @param {ReviewState|object} state
  * @returns {boolean}  true if written successfully
  */
-function writeReviewState(slug, state, worktree = resolveWorktree(slug) || process.cwd(), gitFn = git) {
-  const instance = state instanceof ReviewState ? state : new ReviewState(slug, state);
-  return instance.save(worktree, gitFn);
+function writeReviewState(slug, state, worktree = (0, mission_utils_js_1.resolveWorktree)(slug) || process.cwd(), gitFn = git_js_1.git) {
+    const instance = state instanceof ReviewState ? state : new ReviewState(slug, state);
+    return instance.save(worktree, gitFn);
 }
-
 /**
  * Delete the review state file for a mission (used by --reset).
  * Commits the deletion if the file was tracked.
@@ -272,33 +304,22 @@ function writeReviewState(slug, state, worktree = resolveWorktree(slug) || proce
  * @param {string} slug
  * @returns {boolean}  true if a file was deleted
  */
-function resetReviewState(slug, worktree = resolveWorktree(slug) || process.cwd(), gitFn = git) {
-  const statePath = reviewStateFile(slug, worktree);
-  if (!statePath || !fs.existsSync(statePath)) {return false;}
-
-  fs.unlinkSync(statePath);
-
-  const relPath = path.relative(worktree, statePath);
-  try {
-    gitFn(['-C', worktree, 'rm', '--cached', relPath]);
-    const result = gitFn(['-C', worktree, 'commit', '-m', `review-state(${slug}): reset (--reset flag)`]);
-    if (result.status !== 0) {
-      fmt.log.warn(`Failed to commit review state reset: ${result.stderr}`);
+function resetReviewState(slug, worktree = (0, mission_utils_js_1.resolveWorktree)(slug) || process.cwd(), gitFn = git_js_1.git) {
+    const statePath = reviewStateFile(slug, worktree);
+    if (!statePath || !fs.existsSync(statePath)) {
+        return false;
+    }
+    fs.unlinkSync(statePath);
+    const relPath = path.relative(worktree, statePath);
+    try {
+        gitFn(['-C', worktree, 'rm', '--cached', relPath]);
+        const result = gitFn(['-C', worktree, 'commit', '-m', `review-state(${slug}): reset (--reset flag)`]);
+        if (result.status !== 0) {
+            fmt_js_1.log.warn(`Failed to commit review state reset: ${result.stderr}`);
+        }
     }
-  } catch (_) {
-    // file may not have been tracked yet
-  }
-
-  return true;
+    catch {
+        // file may not have been tracked yet
+    }
+    return true;
 }
-
-module.exports = {
-  ReviewState,
-  VALID_PHASES,
-  normalizeReviewPhase,
-  reviewStateFile,
-  readReviewState,
-  resolveReviewIdentity,
-  writeReviewState,
-  resetReviewState
-};