@magic/types 0.1.29 → 0.1.30

package/README.md

@@ -364,6 +364,11 @@ update dependencies
 
 - change types of is.ln, is.len, is.length and is.count to reflect their type as function with subfunctions
 
-##### 0.1.30 - unreleased
+##### 0.1.30
+
+- fix deep.equal and deep.different implementations and tests
+- update dependencies
+
+##### 0.1.31 - unreleased
 
 ...

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@magic/types",
-  "version": "0.1.29",
+  "version": "0.1.30",
   "author": "Wizards & Witches",
   "homepage": "https://github.com/magic/types",
   "license": "AGPL-3.0",
@@ -20,7 +20,8 @@
     "test": "t",
     "format": "f -w --exclude docs",
     "format:check": "f --exclude docs",
-    "calls": "calls"
+    "calls": "calls",
+    "lint": "tsc --noEmit"
   },
   "engines": {
     "node": ">=18"
@@ -45,8 +46,7 @@
     "@magic-themes/docs": "0.0.15",
     "@magic/core": "0.0.156",
     "@magic/format": "0.0.68",
-    "@magic/fs": "0.0.31",
-    "@magic/test": "0.2.20",
+    "@magic/test": "0.2.24",
     "typescript": "5.9.3"
   },
   "keywords": [
@@ -61,6 +61,6 @@
     }
   ],
   "dependencies": {
-    "@types/node": "24.7.1"
+    "@types/node": "24.9.2"
   }
 }

package/src/deep/equal.js

@@ -18,9 +18,12 @@ import is from '../lib.js'
  * @param {unknown} [b]
  * @param {object} [options]
  * @param {boolean} [options.strict=false]
+ * @param {boolean} [options.arrayOrderStrict=true]
  * @returns {boolean | ((c: unknown) => boolean)}
  */
-export const equal = (a, b, options = { strict: false }) => {
+export const equal = (a, b, options = {}) => {
+  const { strict = false, arrayOrderStrict = false } = options
+
   // curry
   if (is.undefined(b)) {
     if (is.undefined(a)) {
@@ -39,15 +42,11 @@ export const equal = (a, b, options = { strict: false }) => {
     return false
   }
 
-  // bool, string, number, falsy values
-  if (is.comparable(a) || is.comparable(b)) {
-    return a === b
+  /* functions are handled by their toString value */
+  if (is.function(a) && is.function(b)) {
+    return a.toString() === b.toString()
   }
 
-  // if (is.arguments(a)) {
-  //  return is.length.eq(a, b)
-  // }
-
   if (!is.object(a) || !is.object(b)) {
     return a === b
   }
@@ -58,30 +57,17 @@ export const equal = (a, b, options = { strict: false }) => {
   }
 
   // real types must match too
-  // if (Object.prototype.toString.call(a) !== Object.prototype.toString.call(b)) {
-  //   return false
-  // }
+  if (Object.prototype.toString.call(a) !== Object.prototype.toString.call(b)) {
+    return false
+  }
 
   // dates
   if (is.date(a)) {
-    return a === b
+    return a.toString() === b.toString()
   }
 
-  /* functions are handled by prototype comparison above */
-  // if (is.function(a)) {
-  //   if (!is.function(b)) {
-  //     return false
-  //   }
-
-  //   return a.toString() === b.toString()
-  // }
-
   // buffers
-  if (is.buffer(a)) {
-    if (!is.buffer(b)) {
-      return false
-    }
-
+  if (is.buffer(a) && is.buffer(b)) {
     if (a.length !== b.length) {
       return false
     }
@@ -95,24 +81,17 @@ export const equal = (a, b, options = { strict: false }) => {
     return true
   }
 
-  if (is.objectNative(a) || is.array(a)) {
-    if (is.array(a)) {
-      if (!is.array(b)) {
-        return false
-      }
-
-      if (!options.strict) {
-        a.sort()
-        b.sort()
-      }
-
-      return !a.some((v, i) => v !== b[i])
+  if (is.array(a) && is.array(b)) {
+    if (!strict && !arrayOrderStrict) {
+      a.sort()
+      b.sort()
     }
 
-    if (!is.objectNative(b)) {
-      return false
-    }
+    const allEqual = !a.some((v, i) => !equal(v, b[i]))
+    return allEqual
+  }
 
+  if (is.objectNative(a) && is.objectNative(b)) {
     const aObj = a
     const bObj = b
 
@@ -124,7 +103,7 @@ export const equal = (a, b, options = { strict: false }) => {
       return false
     }
 
-    if (!options.strict) {
+    if (!strict) {
       ka.sort()
       kb.sort()
     }
@@ -137,15 +116,8 @@ export const equal = (a, b, options = { strict: false }) => {
     }
 
     // equivalent values for every corresponding key, and
-    // ~~~possibly expensive deep test
-    let key
-    for (let i = ka.length - 1; i >= 0; i--) {
-      key = ka[i]
-
-      if (!equal(aObj[key], bObj[key])) {
-        return false
-      }
-    }
+    // ~~~ possibly expensive deep test
+    return !ka.some(key => !equal(aObj[key], bObj[key]))
   }
 
   return typeof a === typeof b

package/src/fns.js

@@ -340,7 +340,7 @@ export const isLengthSmallerOrEqual = (a, b) =>
  * - null/undefined → true
  * - arrays, objects, regex → empty if size < 1
  * - errors/dates → never empty
- * - numbers, strings → falsy or 0/""
+ * - numbers, strings → falsy or 0, ""
  * @param {unknown} e
  * @returns {boolean}
  */