@magic-spells/collapsible-content 0.2.0 → 1.0.0

package/src/collapsible-content.css

@@ -0,0 +1,31 @@
+collapsible-component {
+  display: block;
+}
+
+collapsible-component button {
+  width: 100%;
+  text-align: left;
+  background: none;
+  border: none;
+  cursor: pointer;
+}
+
+collapsible-component button:focus-visible {
+  outline: 2px solid currentColor;
+  outline-offset: 2px;
+}
+
+collapsible-content {
+  --collapsible-duration: 0.35s;
+  --collapsible-easing: ease-out;
+
+  display: block;
+  overflow: hidden;
+  transition: height var(--collapsible-duration) var(--collapsible-easing);
+}
+
+@media (prefers-reduced-motion: reduce) {
+  collapsible-content {
+    transition: none;
+  }
+}

package/src/collapsible-content.js

@@ -1,10 +1,11 @@
-import './index.scss';
+import './collapsible-content.css';
 
 /**
  * Custom element that creates a collapsible/expandable component with proper accessibility
  */
 class CollapsibleComponent extends HTMLElement {
 	#handleClick;
+	#abortController;
 
 	/**
 	 * Initializes the component and sets up references to child elements
@@ -23,7 +24,7 @@ class CollapsibleComponent extends HTMLElement {
 			// toggle expanded value
 			const expanded = _.button.getAttribute('aria-expanded') !== 'true';
 			_.button.setAttribute('aria-expanded', expanded);
-			_.content.hidden = !expanded;
+			_.content.collapsed = !expanded;
 		};
 	}
 
@@ -39,7 +40,16 @@ class CollapsibleComponent extends HTMLElement {
 		_.content = _.querySelector('collapsible-content');
 
 		if (!_.button || !_.content) {
-			console.error('CollapsibleComponent requires a <button> and a <collapsible-content>.');
+			const error = new Error(
+				'CollapsibleComponent requires a <button> and a <collapsible-content>.'
+			);
+			console.error(error.message);
+			_.dispatchEvent(
+				new CustomEvent('collapsible-error', {
+					bubbles: true,
+					detail: { error },
+				})
+			);
 			return;
 		}
 
@@ -48,18 +58,20 @@ class CollapsibleComponent extends HTMLElement {
 		_.content.id ||= `collapsible-content-${crypto.randomUUID().slice(0, 8)}`;
 
 		// set accessibility attributes
+		_.button.type ||= 'button';
 		_.button.setAttribute('aria-controls', _.content.id);
-		_.content.setAttribute('role', 'region');
 		_.content.setAttribute('aria-labelledby', _.button.id);
 
-		// set initial state based on aria-expanded attribute
-		const expanded = _.button.getAttribute('aria-expanded') === 'true';
+		// set initial state based on open attribute
+		const open = _.content.hasAttribute('open');
+		_.button.setAttribute('aria-expanded', open);
+		_.content.collapsed = !open;
 
-		// make sure content state matches button state
-		_.content.hidden = !expanded;
-
-		// add event listener
-		_.button.addEventListener('click', _.#handleClick);
+		// use AbortController to prevent duplicate listeners on reconnection
+		_.#abortController = new AbortController();
+		_.button.addEventListener('click', _.#handleClick, {
+			signal: _.#abortController.signal,
+		});
 	}
 
 	/**
@@ -68,8 +80,9 @@ class CollapsibleComponent extends HTMLElement {
 	 */
 	disconnectedCallback() {
 		const _ = this;
-		if (_.button) {
-			_.button.removeEventListener('click', _.#handleClick);
+		if (_.#abortController) {
+			_.#abortController.abort();
+			_.#abortController = null;
 		}
 	}
 }
@@ -79,6 +92,8 @@ class CollapsibleComponent extends HTMLElement {
  */
 class CollapsibleContent extends HTMLElement {
 	#handleTransitionEnd;
+	#abortController;
+	#animating = false;
 
 	/**
 	 * Initializes the content element and binds event handlers
@@ -90,35 +105,30 @@ class CollapsibleContent extends HTMLElement {
 		// define event handler using arrow function for proper binding
 		_.#handleTransitionEnd = (event) => {
 			// exit if isn't height property
-			if (event.propertyName != 'height') return;
+			if (event.propertyName !== 'height') return;
+
+			_.#animating = false;
 
 			// remove the inline height to allow dynamic content changes
-			if (!_.hidden) {
+			if (!_.collapsed) {
 				_.style.height = 'auto';
 			}
 		};
-
-		// add event listener to remove height after transition
-		_.addEventListener('transitionend', _.#handleTransitionEnd);
 	}
 
 	/**
 	 * Called when element is added to the DOM
-	 * Sets initial height based on hidden state
+	 * Sets initial height based on open attribute
 	 */
 	connectedCallback() {
 		const _ = this;
+		_.style.height = _.hasAttribute('open') ? 'auto' : '0';
 
-		// get aria-expanded state from button
-		const component = _.closest('collapsible-component');
-		const button = component.querySelector('button');
-		const expanded = button.getAttribute('aria-expanded') === 'true';
-
-		if (expanded) {
-			_.style.height = 'auto';
-		} else {
-			_.style.height = '0';
-		}
+		// use AbortController to prevent duplicate listeners on reconnection
+		_.#abortController = new AbortController();
+		_.addEventListener('transitionend', _.#handleTransitionEnd, {
+			signal: _.#abortController.signal,
+		});
 	}
 
 	/**
@@ -127,56 +137,73 @@ class CollapsibleContent extends HTMLElement {
 	 */
 	disconnectedCallback() {
 		const _ = this;
-		_.removeEventListener('transitionend', _.#handleTransitionEnd);
+		if (_.#abortController) {
+			_.#abortController.abort();
+			_.#abortController = null;
+		}
 	}
 
 	/**
-	 * Handles setting the hidden attribute with animation
-	 * @param {boolean} value - Whether element should be hidden
+	 * Handles setting the collapsed state with animation
+	 * @param {boolean} value - Whether element should be collapsed
 	 */
-	set hidden(value) {
+	set collapsed(value) {
 		const _ = this;
 
-		// animate to closed
+		// prevent rapid clicking during animation
+		if (_.#animating) return;
+
+		// check if transitions are enabled (respects prefers-reduced-motion)
+		const hasTransition = getComputedStyle(_).transitionDuration !== '0s';
+
 		if (value) {
-			// reset height to animate from
+			if (hasTransition) {
+				_.#animating = true;
+			}
+
+			// animate to closed
 			_.style.height = `${_.scrollHeight}px`;
 
-			// wait one frame and animate to 0
-			setTimeout(() => {
-				_.style.height = '0px';
-			}, 1);
+			// use requestAnimationFrame for reliable frame timing
+			requestAnimationFrame(() => {
+				requestAnimationFrame(() => {
+					_.style.height = '0px';
+				});
+			});
 
-			// set accessibility attributes
+			_.removeAttribute('open');
 			_.setAttribute('aria-hidden', 'true');
 			_.setAttribute('inert', '');
-			_.setAttribute('hidden', '');
 		} else {
-			// only animate if not set to auto
+			// only animate if not already auto
 			if (_.style.height !== 'auto') {
-				// animate to open
+				if (hasTransition) {
+					_.#animating = true;
+				}
 				_.style.height = `${_.scrollHeight}px`;
 			}
 
-			// remove accessibility attributes
+			_.setAttribute('open', '');
 			_.removeAttribute('aria-hidden');
 			_.removeAttribute('inert');
-			_.removeAttribute('hidden');
 		}
 	}
 
 	/**
-	 * Gets the hidden state from the attribute
-	 * @returns {boolean} Whether element is hidden
+	 * Gets the collapsed state
+	 * @returns {boolean} Whether element is collapsed
 	 */
-	get hidden() {
-		const _ = this;
-		return _.hasAttribute('hidden');
+	get collapsed() {
+		return !this.hasAttribute('open');
 	}
 }
 
-// register custom elements
-customElements.define('collapsible-content', CollapsibleContent);
-customElements.define('collapsible-component', CollapsibleComponent);
+// register custom elements if not already defined
+if (!customElements.get('collapsible-content')) {
+	customElements.define('collapsible-content', CollapsibleContent);
+}
+if (!customElements.get('collapsible-component')) {
+	customElements.define('collapsible-component', CollapsibleComponent);
+}
 
 export { CollapsibleContent, CollapsibleComponent };

package/dist/collapsible-content.scss

@@ -1,2 +0,0 @@
-@forward "scss/variables";
-@forward "scss/collapsible-content";

package/dist/scss/collapsible-content.scss

@@ -1,25 +0,0 @@
-// Import variables using the modern @use rule
-@use 'variables' as vars;
-
-collapsible-component {
-  display: var(--cc-component-display, block);
-  
-  button {
-    width: var(--cc-button-width, 100%);
-    text-align: var(--cc-button-text-align, left);
-    background: var(--cc-button-background, none);
-    border: var(--cc-button-border, none);
-    cursor: var(--cc-button-cursor, pointer);
-  }
-  
-  collapsible-content[hidden] {
-    display: var(--cc-content-display, block);
-  }
-}
-
-collapsible-content {
-  padding: var(--cc-content-padding, 0px);
-  display: var(--cc-content-display, block);
-  overflow: var(--cc-content-overflow, hidden);
-  transition: height var(--cc-transition-duration, 0.35s) var(--cc-transition-timing, ease-out);
-}

package/dist/scss/variables.scss

@@ -1,40 +0,0 @@
-// Collapsible Content variables
-// SCSS variables for internal component use and customization
-// these variables can be customized by the user
-
-// layout
-$component-display: block !default;
-$button-width: 100% !default;
-$button-text-align: left !default;
-
-// appearance
-$button-background: none !default;
-$button-border: none !default;
-$button-cursor: pointer !default;
-
-// animation
-$content-padding: 0px !default;
-$content-display: block !default;
-$content-overflow: hidden !default;
-$transition-duration: 0.35s !default;
-$transition-timing: ease-out !default;
-
-// Define CSS Custom Properties using SCSS values
-:root {
-  // layout
-  --cc-component-display: #{$component-display};
-  --cc-button-width: #{$button-width};
-  --cc-button-text-align: #{$button-text-align};
-  
-  // appearance
-  --cc-button-background: #{$button-background};
-  --cc-button-border: #{$button-border};
-  --cc-button-cursor: #{$button-cursor};
-  
-  // animation
-  --cc-content-padding: #{$content-padding};
-  --cc-content-display: #{$content-display};
-  --cc-content-overflow: #{$content-overflow};
-  --cc-transition-duration: #{$transition-duration};
-  --cc-transition-timing: #{$transition-timing};
-}

package/src/index.scss

@@ -1,2 +0,0 @@
-@forward "scss/variables";
-@forward "scss/collapsible-content";

package/src/scss/collapsible-content.scss

@@ -1,25 +0,0 @@
-// Import variables using the modern @use rule
-@use 'variables' as vars;
-
-collapsible-component {
-  display: var(--cc-component-display, block);
-  
-  button {
-    width: var(--cc-button-width, 100%);
-    text-align: var(--cc-button-text-align, left);
-    background: var(--cc-button-background, none);
-    border: var(--cc-button-border, none);
-    cursor: var(--cc-button-cursor, pointer);
-  }
-  
-  collapsible-content[hidden] {
-    display: var(--cc-content-display, block);
-  }
-}
-
-collapsible-content {
-  padding: var(--cc-content-padding, 0px);
-  display: var(--cc-content-display, block);
-  overflow: var(--cc-content-overflow, hidden);
-  transition: height var(--cc-transition-duration, 0.35s) var(--cc-transition-timing, ease-out);
-}

package/src/scss/variables.scss

@@ -1,40 +0,0 @@
-// Collapsible Content variables
-// SCSS variables for internal component use and customization
-// these variables can be customized by the user
-
-// layout
-$component-display: block !default;
-$button-width: 100% !default;
-$button-text-align: left !default;
-
-// appearance
-$button-background: none !default;
-$button-border: none !default;
-$button-cursor: pointer !default;
-
-// animation
-$content-padding: 0px !default;
-$content-display: block !default;
-$content-overflow: hidden !default;
-$transition-duration: 0.35s !default;
-$transition-timing: ease-out !default;
-
-// Define CSS Custom Properties using SCSS values
-:root {
-  // layout
-  --cc-component-display: #{$component-display};
-  --cc-button-width: #{$button-width};
-  --cc-button-text-align: #{$button-text-align};
-  
-  // appearance
-  --cc-button-background: #{$button-background};
-  --cc-button-border: #{$button-border};
-  --cc-button-cursor: #{$button-cursor};
-  
-  // animation
-  --cc-content-padding: #{$content-padding};
-  --cc-content-display: #{$content-display};
-  --cc-content-overflow: #{$content-overflow};
-  --cc-transition-duration: #{$transition-duration};
-  --cc-transition-timing: #{$transition-timing};
-}