@magic-marker/prosemirror-suggest-changes 0.3.3-wrap-unwrap.3 → 0.3.3-wrap-unwrap.4

package/dist/ensureSelectionPlugin.js

@@ -1,7 +1,7 @@
 import { Plugin, PluginKey, TextSelection } from "prosemirror-state";
 import { getSuggestionMarks } from "./utils.js";
 import { ZWSP } from "./constants.js";
-const TRACE_ENABLED = true;
+const TRACE_ENABLED = false;
 function trace(...args) {
     // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (!TRACE_ENABLED) return;

package/dist/features/wrapUnwrap/buildMaterializedPaths.js

@@ -1,5 +1,12 @@
 import { getNodeId } from "./getNodeId.js";
+const TRACE_ENABLED = true;
+function trace(...args) {
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+    if (!TRACE_ENABLED) return;
+    console.log("[structureChanges]", ...args);
+}
 export function buildMaterializedPaths(doc) {
+    const perfPaths = performance.now();
     const paths = new Map();
     // add direct doc children first since they have a specific parent signature due to doc not having an ID
     doc.children.forEach((node, index, children)=>{
@@ -67,5 +74,6 @@ export function buildMaterializedPaths(doc) {
         });
         return true;
     });
+    trace("perf", "buildMaterializedPaths", "took", Number((performance.now() - perfPaths).toFixed(2)), "ms");
     return paths;
 }

package/dist/features/wrapUnwrap/revertStructureSuggestions.js

@@ -232,10 +232,10 @@ function findOrderedSuggestionIdsToRevert(node, suggestionId, materializedPaths)
         if (attrs.data.op.op !== "move") return false;
         return !sameParentChain(attrs.data.op.to, parentChain.chain);
     });
-    console.log("findOrderedSuggestionIdsToRevert", "mismatch?", mismatch);
     if (mismatch == null) {
         return Array.from(suggestionIds).reverse();
     }
+    console.log("findOrderedSuggestionIdsToRevert", "suggestion", suggestionId, "contains mark with a mismatched 'to':", mismatch, "searching a different suggestion with the matching 'to'...");
     // find first mark on the node that does have a matching op.to
     const match = mismatch.node.marks.find((mark)=>{
         if (mark.type !== structure) return false;
@@ -249,6 +249,7 @@ function findOrderedSuggestionIdsToRevert(node, suggestionId, materializedPaths)
         return sameParentChain(attrs.data.op.to, parentChain.chain);
     });
     if (match) {
+        console.log("findOrderedSuggestionIdsToRevert", "found suggestin with matching 'to'", match);
         suggestionIds.add(match.attrs["id"]);
     }
     return Array.from(suggestionIds).reverse();

package/dist/features/wrapUnwrap/structureChangesPlugin.js

@@ -7,6 +7,12 @@ import { Transform } from "prosemirror-transform";
 import { isSuggestChangesEnabled, suggestChangesKey } from "../../plugin.js";
 import { buildMaterializedPaths } from "./buildMaterializedPaths.js";
 import { sameParentChain } from "./sameParentChain.js";
+const TRACE_ENABLED = true;
+function trace(...args) {
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+    if (!TRACE_ENABLED) return;
+    console.log("[structureChanges]", ...args);
+}
 export const structureChangesKey = new PluginKey("@handlewithcare/prosemirror-suggest-changes-structure-changes");
 // const listStructure = {
 //   type: [LIST_NODE],
@@ -82,7 +88,7 @@ export function structureChangesPlugin(generateId) {
                 });
                 return;
             }
-            console.log("structureChangesPlugin", "appendTransaction", [
+            trace("structureChangesPlugin", "appendTransaction", [
                 ...transactions
             ]);
             const transform = suggestStructureChanges(oldDoc, newDoc, generateId);
@@ -105,12 +111,12 @@ export function suggestStructureChanges(docBefore, docAfter, generateId) {
     const suggestionId = generateId ? generateId(docBefore.type.schema, docBefore) : generateNextNumberId(docBefore.type.schema, docBefore);
     const pathsBefore = buildMaterializedPaths(docBefore);
     const pathsAfter = buildMaterializedPaths(docAfter);
-    console.log("suggestStructureChanges", "materialized paths", {
+    trace("suggestStructureChanges", "materialized paths", {
         pathsBefore: Object.fromEntries(pathsBefore.entries()),
         pathsAfter: Object.fromEntries(pathsAfter.entries())
     });
     const ops = getOps(pathsBefore, pathsAfter);
-    console.log("suggestStructureChanges", "ops", {
+    trace("suggestStructureChanges", "ops", {
         ops: Object.fromEntries(ops.entries())
     });
     const transform = new Transform(docAfter);
@@ -118,6 +124,7 @@ export function suggestStructureChanges(docBefore, docAfter, generateId) {
     return transform;
 }
 function addMarks(ops, tr, suggestionId) {
+    const perfAddMarks = performance.now();
     const { structure } = getSuggestionMarks(tr.doc.type.schema);
     tr.doc.descendants((node, pos)=>{
         if (node.isText) return true;
@@ -133,6 +140,7 @@ function addMarks(ops, tr, suggestionId) {
         }));
         return true;
     });
+    trace("perf", "addMarks", "took", Number((performance.now() - perfAddMarks).toFixed(2)), "ms");
 }
 function getOps(beforePaths, afterPaths) {
     const ops = new Map();

package/dist/withSuggestChanges.js

@@ -126,15 +126,19 @@ function getStepHandler(step) {
                 // after a transaction, some nodes may not yet have unique ids (they were just added, and the unique id plugin has not yet run)
                 // this hook allows to "post-process" the transaction and add the missing ids
                 // basically it allows to run the core logic of the unique ids plugin earlier
+                const perfUid = performance.now();
                 const uniqueNodeIdsTransform = opts.experimental_ensureUniqueNodeIds([
                     transaction
                 ], docBefore, transaction.doc);
+                trace("perf", "structure", "ensureUniqueNodsIds took", Number((performance.now() - perfUid).toFixed(2)), "ms");
                 const docAfter = uniqueNodeIdsTransform.doc;
                 trace("unique node ids set", docAfter);
                 // try running structure changes first
                 // if handled, then ignore the main plugin
                 // otherwise use the main plugin
+                const perfStructure = performance.now();
                 structureChangesTransform = suggestStructureChanges(docBefore, docAfter, generateId);
+                trace("perf", "structure", "suggestStructureChanges took", Number((performance.now() - perfStructure).toFixed(2)), "ms");
                 trace("structure changes transform completed", structureChangesTransform);
                 if (structureChangesTransform.steps.length > 0) {
                     uniqueNodeIdsTransform.steps.forEach((step)=>{
@@ -148,7 +152,9 @@ function getStepHandler(step) {
             }
             if (transaction.docChanged && (structureChangesTransform == null || structureChangesTransform.steps.length === 0)) {
                 trace("running the main suggestions plugin...");
+                const perfSuggestions = performance.now();
                 transaction = transformToSuggestionTransaction(tr, this.state, generateId);
+                trace("perf", "suggestions", "transformToSuggestionTransaction took", Number((performance.now() - perfSuggestions).toFixed(2)), "ms");
                 trace("main suggestions plugin completed", transaction);
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@magic-marker/prosemirror-suggest-changes",
-  "version": "0.3.3-wrap-unwrap.3",
+  "version": "0.3.3-wrap-unwrap.4",
   "license": "MIT",
   "type": "module",
   "module": "dist/index.js",