@maci-protocol/core 0.0.0-ci.ba71b1e → 0.0.0-ci.bd42e06

package/build/ts/Poll.js

@@ -7,6 +7,7 @@ exports.Poll = void 0;
 const crypto_1 = require("@maci-protocol/crypto");
 const domainobjs_1 = require("@maci-protocol/domainobjs");
 const lean_imt_1 = require("@zk-kit/lean-imt");
+const omit_1 = __importDefault(require("lodash/omit"));
 const assert_1 = __importDefault(require("assert"));
 const constants_1 = require("./utils/constants");
 const errors_1 = require("./utils/errors");
@@ -23,7 +24,7 @@ class Poll {
      * @param maciStateRef - The reference to the MACI state.
      * @param pollId - The poll id
      */
-    constructor(pollEndTimestamp, coordinatorKeypair, treeDepths, batchSizes, maciStateRef, voteOptions) {
+    constructor(pollEndTimestamp, coordinatorKeypair, treeDepths, batchSizes, maciStateRef, voteOptions, mode) {
         this.ballots = [];
         this.messages = [];
         this.commands = [];
@@ -34,7 +35,7 @@ class Poll {
         this.numBatchesProcessed = 0;
         this.sbSalts = {};
         this.resultRootSalts = {};
-        this.preVOSpentVoiceCreditsRootSalts = {};
+        this.perVoteOptionSpentVoiceCreditsRootSalts = {};
         this.spentVoiceCreditSubtotalSalts = {};
         // For vote tallying
         this.tallyResult = [];
@@ -86,7 +87,7 @@ class Poll {
             // not match. For this, we must only copy up to the number of signups
             // Copy the state tree, ballot tree, state leaves, and ballot leaves
             // start by setting the number of signups
-            this.settotalSignups(totalSignups);
+            this.setTotalSignups(totalSignups);
             // copy up to totalSignups state leaves
             this.publicKeys = this.maciStateRef.publicKeys.slice(0, Number(this.totalSignups)).map((x) => x.copy());
             // ensure we have the correct actual state tree depth value
@@ -118,11 +119,11 @@ class Poll {
          * @param encryptionPublicKey - The public key associated with the encryption private key.
          * @returns A number of variables which will be used in the zk-SNARK circuit.
          */
-        this.processMessage = (message, encryptionPublicKey, qv = true) => {
+        this.processMessage = (message, encryptionPublicKey) => {
             try {
                 // Decrypt the message
                 const sharedKey = domainobjs_1.Keypair.generateEcdhSharedKey(this.coordinatorKeypair.privateKey, encryptionPublicKey);
-                const { command, signature } = domainobjs_1.PCommand.decrypt(message, sharedKey);
+                const { command, signature } = domainobjs_1.VoteCommand.decrypt(message, sharedKey);
                 const stateLeafIndex = command.stateIndex;
                 // If the state tree index in the command is invalid, do nothing
                 if (stateLeafIndex >= BigInt(this.ballots.length) ||
@@ -148,24 +149,20 @@ class Poll {
                 }
                 const voteOptionIndex = Number(command.voteOptionIndex);
                 const originalVoteWeight = ballot.votes[voteOptionIndex];
-                // the voice credits left are:
-                // voiceCreditsBalance (how many the user has) +
-                // voiceCreditsPreviouslySpent (the original vote weight for this option) ** 2 -
-                // command.newVoteWeight ** 2 (the new vote weight squared)
-                // basically we are replacing the previous vote weight for this
-                // particular vote option with the new one
-                // but we need to ensure that we are not going >= balance
-                // @note that above comment is valid for quadratic voting
-                // for non quadratic voting, we simply remove the exponentiation
-                const voiceCreditsLeft = qv
-                    ? stateLeaf.voiceCreditBalance +
-                        originalVoteWeight * originalVoteWeight -
-                        command.newVoteWeight * command.newVoteWeight
-                    : stateLeaf.voiceCreditBalance + originalVoteWeight - command.newVoteWeight;
+                const voiceCreditsLeft = this.getVoiceCreditsLeft({
+                    stateLeaf,
+                    originalVoteWeight,
+                    newVoteWeight: command.newVoteWeight,
+                    mode: this.mode,
+                });
                 // If the remaining voice credits is insufficient, do nothing
                 if (voiceCreditsLeft < 0n) {
                     throw new errors_1.ProcessMessageError(errors_1.ProcessMessageErrors.InsufficientVoiceCredits);
                 }
+                // If there are some voice credits left for full spent mode, do nothing
+                if (this.mode === constants_1.EMode.FULL && voiceCreditsLeft > 0n) {
+                    throw new errors_1.ProcessMessageError(errors_1.ProcessMessageErrors.InvalidVoiceCredits);
+                }
                 // Deep-copy the state leaf and update its attributes
                 const newStateLeaf = stateLeaf.copy();
                 newStateLeaf.voiceCreditBalance = voiceCreditsLeft;
@@ -177,20 +174,23 @@ class Poll {
                 newBallot.nonce += 1n;
                 // we change the vote for this exact vote option
                 newBallot.votes[voteOptionIndex] = command.newVoteWeight;
+                if (this.mode === constants_1.EMode.FULL) {
+                    newBallot.votes = newBallot.votes.map((votes, index) => (voteOptionIndex === index ? votes : 0n));
+                }
                 // calculate the path elements for the state tree given the original state tree (before any changes)
                 // changes could effectively be made by this new vote - either a key change or vote change
                 // would result in a different state leaf
-                const originalStateLeafPathElements = this.pollStateTree?.genProof(Number(stateLeafIndex)).pathElements;
+                const { pathElements: originalStateLeafPathElements } = this.pollStateTree.genProof(Number(stateLeafIndex));
                 // calculate the path elements for the ballot tree given the original ballot tree (before any changes)
                 // changes could effectively be made by this new ballot
-                const originalBallotPathElements = this.ballotTree?.genProof(Number(stateLeafIndex)).pathElements;
+                const { pathElements: originalBallotPathElements } = this.ballotTree.genProof(Number(stateLeafIndex));
                 // create a new quinary tree where we insert the votes of the origin (up until this message is processed) ballot
-                const vt = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
+                const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
                 for (let i = 0; i < this.ballots[0].votes.length; i += 1) {
-                    vt.insert(ballot.votes[i]);
+                    voteTree.insert(ballot.votes[i]);
                 }
                 // calculate the path elements for the vote option tree given the original vote option tree (before any changes)
-                const originalVoteWeightsPathElements = vt.genProof(voteOptionIndex).pathElements;
+                const { pathElements: originalVoteWeightsPathElements } = voteTree.genProof(voteOptionIndex);
                 // we return the data which is then to be used in the processMessage circuit
                 // to generate a proof of processing
                 return {
@@ -239,14 +239,14 @@ class Poll {
             const sharedKey = domainobjs_1.Keypair.generateEcdhSharedKey(this.coordinatorKeypair.privateKey, encryptionPublicKey);
             try {
                 // step 2. we decrypt it
-                const { command } = domainobjs_1.PCommand.decrypt(message, sharedKey);
+                const { command } = domainobjs_1.VoteCommand.decrypt(message, sharedKey);
                 // step 3. we store it in the commands array
                 this.commands.push(command);
             }
             catch (e) {
                 // if there is an error we store an empty command
-                const keyPair = new domainobjs_1.Keypair();
-                const command = new domainobjs_1.PCommand(0n, keyPair.publicKey, 0n, 0n, 0n, 0n, 0n);
+                const keypair = new domainobjs_1.Keypair();
+                const command = new domainobjs_1.VoteCommand(0n, keypair.publicKey, 0n, 0n, 0n, 0n, 0n);
                 this.commands.push(command);
             }
         };
@@ -362,7 +362,7 @@ class Poll {
          * @param quiet - Whether to log errors or not
          * @returns stringified circuit inputs
          */
-        this.processMessages = (pollId, qv = true, quiet = true) => {
+        this.processMessages = (pollId, quiet = true) => {
             (0, assert_1.default)(this.hasUnprocessedMessages(), "No more messages to process");
             const batchSize = this.batchSizes.messageBatchSize;
             if (this.numBatchesProcessed === 0) {
@@ -411,23 +411,23 @@ class Poll {
                     encryptionPublicKey = this.encryptionPublicKeys[idx];
                     try {
                         // check if the command is valid
-                        const r = this.processMessage(message, encryptionPublicKey, qv);
-                        const index = r.stateLeafIndex;
+                        const { stateLeafIndex, originalStateLeaf, originalBallot, originalVoteWeight, originalVoteWeightsPathElements, originalStateLeafPathElements, originalBallotPathElements, newStateLeaf, newBallot, } = this.processMessage(message, encryptionPublicKey);
+                        const index = stateLeafIndex;
                         // we add at position 0 the original data
-                        currentStateLeaves.unshift(r.originalStateLeaf);
-                        currentBallots.unshift(r.originalBallot);
-                        currentVoteWeights.unshift(r.originalVoteWeight);
-                        currentVoteWeightsPathElements.unshift(r.originalVoteWeightsPathElements);
-                        currentStateLeavesPathElements.unshift(r.originalStateLeafPathElements);
-                        currentBallotsPathElements.unshift(r.originalBallotPathElements);
+                        currentStateLeaves.unshift(originalStateLeaf);
+                        currentBallots.unshift(originalBallot);
+                        currentVoteWeights.unshift(originalVoteWeight);
+                        currentVoteWeightsPathElements.unshift(originalVoteWeightsPathElements);
+                        currentStateLeavesPathElements.unshift(originalStateLeafPathElements);
+                        currentBallotsPathElements.unshift(originalBallotPathElements);
                         // update the state leaves with the new state leaf (result of processing the message)
-                        this.pollStateLeaves[index] = r.newStateLeaf.copy();
+                        this.pollStateLeaves[index] = newStateLeaf.copy();
                         // we also update the state tree with the hash of the new state leaf
-                        this.pollStateTree?.update(index, r.newStateLeaf.hash());
+                        this.pollStateTree?.update(index, newStateLeaf.hash());
                         // store the new ballot
-                        this.ballots[index] = r.newBallot;
+                        this.ballots[index] = newBallot;
                         // update the ballot tree
-                        this.ballotTree?.update(index, r.newBallot.hash());
+                        this.ballotTree?.update(index, newBallot.hash());
                     }
                     catch (e) {
                         // if the error is not a ProcessMessageError we throw it and exit here
@@ -449,7 +449,7 @@ class Poll {
                             // generate shared key
                             const sharedKey = domainobjs_1.Keypair.generateEcdhSharedKey(this.coordinatorKeypair.privateKey, encryptionPublicKey);
                             // force decrypt it
-                            const { command } = domainobjs_1.PCommand.decrypt(message, sharedKey, true);
+                            const { command } = domainobjs_1.VoteCommand.decrypt(message, sharedKey, true);
                             // cache state leaf index
                             const stateLeafIndex = command.stateIndex;
                             // if the state leaf index is valid then use it
@@ -467,24 +467,24 @@ class Poll {
                                 if (command.voteOptionIndex < this.voteOptions) {
                                     currentVoteWeights.unshift(ballot.votes[Number(command.voteOptionIndex)]);
                                     // create a new quinary tree and add all votes we have so far
-                                    const vt = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
+                                    const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
                                     // fill the vote option tree with the votes we have so far
                                     for (let j = 0; j < this.ballots[0].votes.length; j += 1) {
-                                        vt.insert(ballot.votes[j]);
+                                        voteTree.insert(ballot.votes[j]);
                                     }
                                     // get the path elements for the first vote leaf
-                                    currentVoteWeightsPathElements.unshift(vt.genProof(Number(command.voteOptionIndex)).pathElements);
+                                    currentVoteWeightsPathElements.unshift(voteTree.genProof(Number(command.voteOptionIndex)).pathElements);
                                 }
                                 else {
                                     currentVoteWeights.unshift(ballot.votes[0]);
                                     // create a new quinary tree and add all votes we have so far
-                                    const vt = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
+                                    const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
                                     // fill the vote option tree with the votes we have so far
                                     for (let j = 0; j < this.ballots[0].votes.length; j += 1) {
-                                        vt.insert(ballot.votes[j]);
+                                        voteTree.insert(ballot.votes[j]);
                                     }
                                     // get the path elements for the first vote leaf
-                                    currentVoteWeightsPathElements.unshift(vt.genProof(0).pathElements);
+                                    currentVoteWeightsPathElements.unshift(voteTree.genProof(0).pathElements);
                                 }
                             }
                             else {
@@ -496,10 +496,10 @@ class Poll {
                                 // Since the command is invalid, we use a zero vote weight
                                 currentVoteWeights.unshift(this.ballots[0].votes[0]);
                                 // create a new quinary tree and add an empty vote
-                                const vt = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
-                                vt.insert(this.ballots[0].votes[0]);
+                                const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
+                                voteTree.insert(this.ballots[0].votes[0]);
                                 // get the path elements for this empty vote weight leaf
-                                currentVoteWeightsPathElements.unshift(vt.genProof(0).pathElements);
+                                currentVoteWeightsPathElements.unshift(voteTree.genProof(0).pathElements);
                             }
                         }
                         else {
@@ -517,10 +517,10 @@ class Poll {
                     // Since the command is invalid, we use a zero vote weight
                     currentVoteWeights.unshift(this.ballots[0].votes[0]);
                     // create a new quinary tree and add an empty vote
-                    const vt = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
-                    vt.insert(this.ballots[0].votes[0]);
+                    const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
+                    voteTree.insert(this.ballots[0].votes[0]);
                     // get the path elements for this empty vote weight leaf
-                    currentVoteWeightsPathElements.unshift(vt.genProof(0).pathElements);
+                    currentVoteWeightsPathElements.unshift(voteTree.genProof(0).pathElements);
                 }
             }
             // store the data in the circuit inputs object
@@ -585,14 +585,14 @@ class Poll {
             // generate ecdh key
             const ecdh = domainobjs_1.Keypair.generateEcdhSharedKey(key.privateKey, this.coordinatorKeypair.publicKey);
             // create an empty command with state index 0n
-            const emptyCommand = new domainobjs_1.PCommand(0n, key.publicKey, 0n, 0n, 0n, 0n, 0n);
+            const emptyCommand = new domainobjs_1.VoteCommand(0n, key.publicKey, 0n, 0n, 0n, 0n, 0n);
             // encrypt it
-            const msg = emptyCommand.encrypt(emptyCommand.sign(key.privateKey), ecdh);
+            const emptyMessage = emptyCommand.encrypt(emptyCommand.sign(key.privateKey), ecdh);
             // copy the messages to a new array
             let messages = this.messages.map((x) => x.asCircuitInputs());
             // pad with our state index 0 message
             while (messages.length % messageBatchSize > 0) {
-                messages.push(msg.asCircuitInputs());
+                messages.push(emptyMessage.asCircuitInputs());
             }
             // copy the public keys, pad the array with the last keys if needed
             let encryptionPublicKeys = this.encryptionPublicKeys.map((x) => x.copy());
@@ -661,6 +661,7 @@ class Poll {
         this.hasUntalliedBallots = () => this.numBatchesTallied * this.batchSizes.tallyBatchSize < this.ballots.length;
         /**
          * This method tallies a ballots and updates the tally results.
+         *
          * @returns the circuit inputs for the TallyVotes circuit.
          */
         this.tallyVotes = () => {
@@ -674,31 +675,40 @@ class Poll {
             const batchStartIndex = this.numBatchesTallied * batchSize;
             // get the salts needed for the commitments
             const currentResultsRootSalt = batchStartIndex === 0 ? 0n : this.resultRootSalts[batchStartIndex - batchSize];
-            const currentPerVOSpentVoiceCreditsRootSalt = batchStartIndex === 0 ? 0n : this.preVOSpentVoiceCreditsRootSalts[batchStartIndex - batchSize];
+            const currentPerVoteOptionSpentVoiceCreditsRootSalt = batchStartIndex === 0 ? 0n : this.perVoteOptionSpentVoiceCreditsRootSalts[batchStartIndex - batchSize];
             const currentSpentVoiceCreditSubtotalSalt = batchStartIndex === 0 ? 0n : this.spentVoiceCreditSubtotalSalts[batchStartIndex - batchSize];
             // generate a commitment to the current results
             const currentResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, currentResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
             // generate a commitment to the current per vote option spent voice credits
-            const currentPerVOSpentVoiceCreditsCommitment = this.genPerVOSpentVoiceCreditsCommitment(currentPerVOSpentVoiceCreditsRootSalt, batchStartIndex, true);
+            const currentPerVoteOptionSpentVoiceCreditsCommitment = this.generatePerVoteOptionSpentVoiceCreditsCommitment(currentPerVoteOptionSpentVoiceCreditsRootSalt, batchStartIndex, this.mode);
             // generate a commitment to the current spent voice credits
-            const currentSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(currentSpentVoiceCreditSubtotalSalt, batchStartIndex, true);
+            const currentSpentVoiceCreditsCommitment = this.generateSpentVoiceCreditSubtotalCommitment(currentSpentVoiceCreditSubtotalSalt, batchStartIndex, this.mode);
             // the current commitment for the first batch will be 0
             // otherwise calculate as
             // hash([
             //  currentResultsCommitment,
             //  currentSpentVoiceCreditsCommitment,
-            //  currentPerVOSpentVoiceCreditsCommitment
             // ])
-            const currentTallyCommitment = batchStartIndex === 0
+            // or for QV
+            // hash([
+            //  currentResultsCommitment,
+            //  currentSpentVoiceCreditsCommitment,
+            //  currentPerVoteOptionSpentVoiceCreditsCommitment
+            // ])
+            const currentTallyCommitmentQv = this.mode !== constants_1.EMode.QV || batchStartIndex === 0
                 ? 0n
                 : (0, crypto_1.hash3)([
                     currentResultsCommitment,
                     currentSpentVoiceCreditsCommitment,
-                    currentPerVOSpentVoiceCreditsCommitment,
+                    currentPerVoteOptionSpentVoiceCreditsCommitment,
                 ]);
+            const currentTallyCommitmentNonQv = this.mode === constants_1.EMode.QV || batchStartIndex === 0
+                ? 0n
+                : (0, crypto_1.hashLeftRight)(currentResultsCommitment, currentSpentVoiceCreditsCommitment);
+            const currentTallyCommitment = currentTallyCommitmentNonQv || currentTallyCommitmentQv;
             const ballots = [];
             const currentResults = this.tallyResult.map((x) => BigInt(x.toString()));
-            const currentPerVOSpentVoiceCredits = this.perVoteOptionSpentVoiceCredits.map((x) => BigInt(x.toString()));
+            const currentPerVoteOptionSpentVoiceCredits = this.perVoteOptionSpentVoiceCredits.map((x) => BigInt(x.toString()));
             const currentSpentVoiceCreditSubtotal = BigInt(this.totalSpentVoiceCredits.toString());
             // loop in normal order to tally the ballots one by one
             for (let i = this.numBatchesTallied * batchSize; i < this.numBatchesTallied * batchSize + batchSize; i += 1) {
@@ -711,12 +721,17 @@ class Poll {
                 // for each possible vote option we loop and calculate
                 for (let j = 0; j < this.maxVoteOptions; j += 1) {
                     const v = this.ballots[i].votes[j];
-                    // the vote itself will be a quadratic vote (sqrt(voiceCredits))
                     this.tallyResult[j] += v;
-                    // the per vote option spent voice credits will be the sum of the squares of the votes
-                    this.perVoteOptionSpentVoiceCredits[j] += v * v;
-                    // the total spent voice credits will be the sum of the squares of the votes
-                    this.totalSpentVoiceCredits += v * v;
+                    if (this.mode === constants_1.EMode.QV) {
+                        // the per vote option spent voice credits will be the sum of the squares of the votes
+                        this.perVoteOptionSpentVoiceCredits[j] += v * v;
+                        // the total spent voice credits will be the sum of the squares of the votes
+                        this.totalSpentVoiceCredits += v * v;
+                    }
+                    else {
+                        // the total spent voice credits will be the sum of the votes
+                        this.totalSpentVoiceCredits += v;
+                    }
                 }
             }
             const emptyBallot = new domainobjs_1.Ballot(this.maxVoteOptions, this.treeDepths.voteOptionTreeDepth);
@@ -726,24 +741,22 @@ class Poll {
             }
             // generate the new salts
             const newResultsRootSalt = (0, crypto_1.generateRandomSalt)();
-            const newPerVOSpentVoiceCreditsRootSalt = (0, crypto_1.generateRandomSalt)();
+            const newPerVoteOptionSpentVoiceCreditsRootSalt = (0, crypto_1.generateRandomSalt)();
             const newSpentVoiceCreditSubtotalSalt = (0, crypto_1.generateRandomSalt)();
             // and save them to be used in the next batch
             this.resultRootSalts[batchStartIndex] = newResultsRootSalt;
-            this.preVOSpentVoiceCreditsRootSalts[batchStartIndex] = newPerVOSpentVoiceCreditsRootSalt;
+            this.perVoteOptionSpentVoiceCreditsRootSalts[batchStartIndex] = newPerVoteOptionSpentVoiceCreditsRootSalt;
             this.spentVoiceCreditSubtotalSalts[batchStartIndex] = newSpentVoiceCreditSubtotalSalt;
             // generate the new results commitment with the new salts and data
             const newResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, newResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
             // generate the new spent voice credits commitment with the new salts and data
-            const newSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(newSpentVoiceCreditSubtotalSalt, batchStartIndex + batchSize, true);
+            const newSpentVoiceCreditsCommitment = this.generateSpentVoiceCreditSubtotalCommitment(newSpentVoiceCreditSubtotalSalt, batchStartIndex + batchSize, this.mode);
             // generate the new per vote option spent voice credits commitment with the new salts and data
-            const newPerVOSpentVoiceCreditsCommitment = this.genPerVOSpentVoiceCreditsCommitment(newPerVOSpentVoiceCreditsRootSalt, batchStartIndex + batchSize, true);
+            const newPerVoteOptionSpentVoiceCreditsCommitment = this.generatePerVoteOptionSpentVoiceCreditsCommitment(newPerVoteOptionSpentVoiceCreditsRootSalt, batchStartIndex + batchSize, this.mode);
             // generate the new tally commitment
-            const newTallyCommitment = (0, crypto_1.hash3)([
-                newResultsCommitment,
-                newSpentVoiceCreditsCommitment,
-                newPerVOSpentVoiceCreditsCommitment,
-            ]);
+            const newTallyCommitment = this.mode === constants_1.EMode.QV
+                ? (0, crypto_1.hash3)([newResultsCommitment, newSpentVoiceCreditsCommitment, newPerVoteOptionSpentVoiceCreditsCommitment])
+                : (0, crypto_1.hashLeftRight)(newResultsCommitment, newSpentVoiceCreditsCommitment);
             // cache vars
             const stateRoot = this.pollStateTree.root;
             const ballotRoot = this.ballotTree.root;
@@ -751,7 +764,7 @@ class Poll {
             const sbCommitment = (0, crypto_1.hash3)([stateRoot, ballotRoot, sbSalt]);
             const ballotSubrootProof = this.ballotTree?.genSubrootProof(batchStartIndex, batchStartIndex + batchSize);
             const votes = ballots.map((x) => x.votes);
-            const circuitInputs = (0, crypto_1.stringifyBigInts)({
+            const circuitInputs = (0, crypto_1.stringifyBigInts)((0, omit_1.default)({
                 stateRoot,
                 ballotRoot,
                 sbSalt,
@@ -767,100 +780,18 @@ class Poll {
                 currentResultsRootSalt,
                 currentSpentVoiceCreditSubtotal,
                 currentSpentVoiceCreditSubtotalSalt,
-                currentPerVOSpentVoiceCredits,
-                currentPerVOSpentVoiceCreditsRootSalt,
+                currentPerVoteOptionSpentVoiceCredits,
+                currentPerVoteOptionSpentVoiceCreditsRootSalt,
+                newPerVoteOptionSpentVoiceCreditsRootSalt,
                 newResultsRootSalt,
-                newPerVOSpentVoiceCreditsRootSalt,
                 newSpentVoiceCreditSubtotalSalt,
-            });
-            this.numBatchesTallied += 1;
-            return circuitInputs;
-        };
-        this.tallyVotesNonQv = () => {
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-            if (this.sbSalts[this.currentMessageBatchIndex] === undefined) {
-                throw new Error("You must process the messages first");
-            }
-            const batchSize = this.batchSizes.tallyBatchSize;
-            (0, assert_1.default)(this.hasUntalliedBallots(), "No more ballots to tally");
-            // calculate where we start tallying next
-            const batchStartIndex = this.numBatchesTallied * batchSize;
-            // get the salts needed for the commitments
-            const currentResultsRootSalt = batchStartIndex === 0 ? 0n : this.resultRootSalts[batchStartIndex - batchSize];
-            const currentSpentVoiceCreditSubtotalSalt = batchStartIndex === 0 ? 0n : this.spentVoiceCreditSubtotalSalts[batchStartIndex - batchSize];
-            // generate a commitment to the current results
-            const currentResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, currentResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
-            // generate a commitment to the current spent voice credits
-            const currentSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(currentSpentVoiceCreditSubtotalSalt, batchStartIndex, false);
-            // the current commitment for the first batch will be 0
-            // otherwise calculate as
-            // hash([
-            //  currentResultsCommitment,
-            //  currentSpentVoiceCreditsCommitment,
-            // ])
-            const currentTallyCommitment = batchStartIndex === 0 ? 0n : (0, crypto_1.hashLeftRight)(currentResultsCommitment, currentSpentVoiceCreditsCommitment);
-            const ballots = [];
-            const currentResults = this.tallyResult.map((x) => BigInt(x.toString()));
-            const currentSpentVoiceCreditSubtotal = BigInt(this.totalSpentVoiceCredits.toString());
-            // loop in normal order to tally the ballots one by one
-            for (let i = this.numBatchesTallied * batchSize; i < this.numBatchesTallied * batchSize + batchSize; i += 1) {
-                // we stop if we have no more ballots to tally
-                if (i >= this.ballots.length) {
-                    break;
-                }
-                // save to the local ballot array
-                ballots.push(this.ballots[i]);
-                // for each possible vote option we loop and calculate
-                for (let j = 0; j < this.maxVoteOptions; j += 1) {
-                    const v = this.ballots[i].votes[j];
-                    this.tallyResult[j] += v;
-                    // the total spent voice credits will be the sum of the votes
-                    this.totalSpentVoiceCredits += v;
-                }
-            }
-            const emptyBallot = new domainobjs_1.Ballot(this.maxVoteOptions, this.treeDepths.voteOptionTreeDepth);
-            // pad the ballots array
-            while (ballots.length < batchSize) {
-                ballots.push(emptyBallot);
-            }
-            // generate the new salts
-            const newResultsRootSalt = (0, crypto_1.generateRandomSalt)();
-            const newSpentVoiceCreditSubtotalSalt = (0, crypto_1.generateRandomSalt)();
-            // and save them to be used in the next batch
-            this.resultRootSalts[batchStartIndex] = newResultsRootSalt;
-            this.spentVoiceCreditSubtotalSalts[batchStartIndex] = newSpentVoiceCreditSubtotalSalt;
-            // generate the new results commitment with the new salts and data
-            const newResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, newResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
-            // generate the new spent voice credits commitment with the new salts and data
-            const newSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(newSpentVoiceCreditSubtotalSalt, batchStartIndex + batchSize, false);
-            // generate the new tally commitment
-            const newTallyCommitment = (0, crypto_1.hashLeftRight)(newResultsCommitment, newSpentVoiceCreditsCommitment);
-            // cache vars
-            const stateRoot = this.pollStateTree.root;
-            const ballotRoot = this.ballotTree.root;
-            const sbSalt = this.sbSalts[this.currentMessageBatchIndex];
-            const sbCommitment = (0, crypto_1.hash3)([stateRoot, ballotRoot, sbSalt]);
-            const ballotSubrootProof = this.ballotTree?.genSubrootProof(batchStartIndex, batchStartIndex + batchSize);
-            const votes = ballots.map((x) => x.votes);
-            const circuitInputs = (0, crypto_1.stringifyBigInts)({
-                stateRoot,
-                ballotRoot,
-                sbSalt,
-                index: BigInt(batchStartIndex),
-                totalSignups: BigInt(this.totalSignups),
-                sbCommitment,
-                currentTallyCommitment,
-                newTallyCommitment,
-                ballots: ballots.map((x) => x.asCircuitInputs()),
-                ballotPathElements: ballotSubrootProof.pathElements,
-                votes,
-                currentResults,
-                currentResultsRootSalt,
-                currentSpentVoiceCreditSubtotal,
-                currentSpentVoiceCreditSubtotalSalt,
-                newResultsRootSalt,
-                newSpentVoiceCreditSubtotalSalt,
-            });
+            }, this.mode !== constants_1.EMode.QV
+                ? [
+                    "currentPerVoteOptionSpentVoiceCredits",
+                    "currentPerVoteOptionSpentVoiceCreditsRootSalt",
+                    "newPerVoteOptionSpentVoiceCreditsRootSalt",
+                ]
+                : []));
             this.numBatchesTallied += 1;
             return circuitInputs;
         };
@@ -869,19 +800,19 @@ class Poll {
          *
          * This is the hash of the total spent voice credits and a salt, computed as Poseidon([totalCredits, _salt]).
          * @param salt - The salt used in the hash function.
-         * @param numBallotsToCount - The number of ballots to count for the calculation.
-         * @param useQuadraticVoting - Whether to use quadratic voting or not. Default is true.
+         * @param ballotsToCount - The number of ballots to count for the calculation.
+         * @param mode - Voting mode, default QV.
          * @returns Returns the hash of the total spent voice credits and a salt, computed as Poseidon([totalCredits, _salt]).
          */
-        this.genSpentVoiceCreditSubtotalCommitment = (salt, numBallotsToCount, useQuadraticVoting = true) => {
+        this.generateSpentVoiceCreditSubtotalCommitment = (salt, ballotsToCount, mode = constants_1.EMode.QV) => {
             let subtotal = 0n;
-            for (let i = 0; i < numBallotsToCount; i += 1) {
+            for (let i = 0; i < ballotsToCount; i += 1) {
                 if (this.ballots.length <= i) {
                     break;
                 }
                 for (let j = 0; j < this.tallyResult.length; j += 1) {
                     const v = BigInt(`${this.ballots[i].votes[j]}`);
-                    subtotal += useQuadraticVoting ? v * v : v;
+                    subtotal += mode === constants_1.EMode.QV ? v * v : v;
                 }
             }
             return (0, crypto_1.hashLeftRight)(subtotal, salt);
@@ -891,20 +822,20 @@ class Poll {
          *
          * This is the hash of the Merkle root of the spent voice credits per vote option and a salt, computed as Poseidon([root, _salt]).
          * @param salt - The salt used in the hash function.
-         * @param numBallotsToCount - The number of ballots to count for the calculation.
-         * @param useQuadraticVoting - Whether to use quadratic voting or not. Default is true.
+         * @param ballotsToCount - The number of ballots to count for the calculation.
+         * @param mode - Voting mode, default is QV.
          * @returns Returns the hash of the Merkle root of the spent voice credits per vote option and a salt, computed as Poseidon([root, _salt]).
          */
-        this.genPerVOSpentVoiceCreditsCommitment = (salt, numBallotsToCount, useQuadraticVoting = true) => {
+        this.generatePerVoteOptionSpentVoiceCreditsCommitment = (salt, ballotsToCount, mode = constants_1.EMode.QV) => {
             const leaves = Array(this.tallyResult.length).fill(0n);
-            for (let i = 0; i < numBallotsToCount; i += 1) {
+            for (let i = 0; i < ballotsToCount; i += 1) {
                 // check that is a valid index
                 if (i >= this.ballots.length) {
                     break;
                 }
                 for (let j = 0; j < this.tallyResult.length; j += 1) {
                     const v = this.ballots[i].votes[j];
-                    leaves[j] += useQuadraticVoting ? v * v : v;
+                    leaves[j] += mode === constants_1.EMode.QV ? v * v : v;
                 }
             }
             return (0, crypto_1.generateTreeCommitment)(leaves, salt, this.treeDepths.voteOptionTreeDepth);
@@ -915,13 +846,13 @@ class Poll {
          */
         this.copy = () => {
             const copied = new Poll(BigInt(this.pollEndTimestamp.toString()), this.coordinatorKeypair.copy(), {
-                intStateTreeDepth: Number(this.treeDepths.intStateTreeDepth),
+                tallyProcessingStateTreeDepth: Number(this.treeDepths.tallyProcessingStateTreeDepth),
                 voteOptionTreeDepth: Number(this.treeDepths.voteOptionTreeDepth),
                 stateTreeDepth: Number(this.treeDepths.stateTreeDepth),
             }, {
                 tallyBatchSize: Number(this.batchSizes.tallyBatchSize.toString()),
                 messageBatchSize: Number(this.batchSizes.messageBatchSize.toString()),
-            }, this.maciStateRef, this.voteOptions);
+            }, this.maciStateRef, this.voteOptions, this.mode);
             copied.publicKeys = this.publicKeys.map((x) => x.copy());
             copied.pollStateLeaves = this.pollStateLeaves.map((x) => x.copy());
             copied.messages = this.messages.map((x) => x.copy());
@@ -941,7 +872,7 @@ class Poll {
             copied.totalSpentVoiceCredits = BigInt(this.totalSpentVoiceCredits.toString());
             copied.sbSalts = {};
             copied.resultRootSalts = {};
-            copied.preVOSpentVoiceCreditsRootSalts = {};
+            copied.perVoteOptionSpentVoiceCreditsRootSalts = {};
             copied.spentVoiceCreditSubtotalSalts = {};
             Object.keys(this.sbSalts).forEach((k) => {
                 copied.sbSalts[k] = BigInt(this.sbSalts[k].toString());
@@ -949,14 +880,14 @@ class Poll {
             Object.keys(this.resultRootSalts).forEach((k) => {
                 copied.resultRootSalts[k] = BigInt(this.resultRootSalts[k].toString());
             });
-            Object.keys(this.preVOSpentVoiceCreditsRootSalts).forEach((k) => {
-                copied.preVOSpentVoiceCreditsRootSalts[k] = BigInt(this.preVOSpentVoiceCreditsRootSalts[k].toString());
+            Object.keys(this.perVoteOptionSpentVoiceCreditsRootSalts).forEach((k) => {
+                copied.perVoteOptionSpentVoiceCreditsRootSalts[k] = BigInt(this.perVoteOptionSpentVoiceCreditsRootSalts[k].toString());
             });
             Object.keys(this.spentVoiceCreditSubtotalSalts).forEach((k) => {
                 copied.spentVoiceCreditSubtotalSalts[k] = BigInt(this.spentVoiceCreditSubtotalSalts[k].toString());
             });
             // update the number of signups
-            copied.settotalSignups(this.totalSignups);
+            copied.setTotalSignups(this.totalSignups);
             return copied;
         };
         /**
@@ -966,7 +897,7 @@ class Poll {
          */
         this.equals = (poll) => {
             const result = this.coordinatorKeypair.equals(poll.coordinatorKeypair) &&
-                this.treeDepths.intStateTreeDepth === poll.treeDepths.intStateTreeDepth &&
+                this.treeDepths.tallyProcessingStateTreeDepth === poll.treeDepths.tallyProcessingStateTreeDepth &&
                 this.treeDepths.voteOptionTreeDepth === poll.treeDepths.voteOptionTreeDepth &&
                 this.batchSizes.tallyBatchSize === poll.batchSizes.tallyBatchSize &&
                 this.batchSizes.messageBatchSize === poll.batchSizes.messageBatchSize &&
@@ -1000,7 +931,7 @@ class Poll {
          * Set the number of signups to match the ones from the contract
          * @param totalSignups - the number of signups
          */
-        this.settotalSignups = (totalSignups) => {
+        this.setTotalSignups = (totalSignups) => {
             this.totalSignups = totalSignups;
         };
         /**
@@ -1021,6 +952,7 @@ class Poll {
         this.pollId = BigInt(maciStateRef.polls.size);
         this.actualStateTreeDepth = treeDepths.stateTreeDepth;
         this.currentMessageBatchIndex = 0;
+        this.mode = mode;
         this.pollNullifiers = new Map();
         this.tallyResult = new Array(this.maxVoteOptions).fill(0n);
         this.perVoteOptionSpentVoiceCredits = new Array(this.maxVoteOptions).fill(0n);
@@ -1028,6 +960,35 @@ class Poll {
         this.emptyBallot = domainobjs_1.Ballot.genBlankBallot(this.maxVoteOptions, treeDepths.voteOptionTreeDepth);
         this.ballots.push(this.emptyBallot);
     }
+    /**
+     * Get voice credits left for the voting command.
+     *
+     * @param args - arguments for getting voice credits
+     * @returns voice credits left
+     */
+    getVoiceCreditsLeft({ stateLeaf, originalVoteWeight, newVoteWeight, mode }) {
+        switch (mode) {
+            case constants_1.EMode.QV: {
+                // the voice credits left are:
+                // voiceCreditsBalance (how many the user has) +
+                // voiceCreditsPreviouslySpent (the original vote weight for this option) ** 2 -
+                // command.newVoteWeight ** 2 (the new vote weight squared)
+                // basically we are replacing the previous vote weight for this
+                // particular vote option with the new one
+                // but we need to ensure that we are not going >= balance
+                return stateLeaf.voiceCreditBalance + originalVoteWeight * originalVoteWeight - newVoteWeight * newVoteWeight;
+            }
+            case constants_1.EMode.NON_QV:
+            case constants_1.EMode.FULL: {
+                // for non quadratic voting, we simply remove the exponentiation
+                // for full spent voting, it will be zero
+                return stateLeaf.voiceCreditBalance + originalVoteWeight - newVoteWeight;
+            }
+            default: {
+                throw new Error("Voting mode is not supported");
+            }
+        }
+    }
     /**
      * Serialize the Poll object to a JSON object
      * @returns a JSON object
@@ -1053,6 +1014,7 @@ class Poll {
             chainHash: this.chainHash.toString(),
             pollNullifiers: [...this.pollNullifiers.keys()].map((nullifier) => nullifier.toString()),
             batchHashes: this.batchHashes.map((batchHash) => batchHash.toString()),
+            mode: this.mode,
         };
     }
     /**
@@ -1062,13 +1024,13 @@ class Poll {
      * @returns a new Poll instance
      */
     static fromJSON(json, maciState) {
-        const poll = new Poll(BigInt(json.pollEndTimestamp), new domainobjs_1.Keypair(), json.treeDepths, json.batchSizes, maciState, BigInt(json.voteOptions));
+        const poll = new Poll(BigInt(json.pollEndTimestamp), new domainobjs_1.Keypair(), json.treeDepths, json.batchSizes, maciState, BigInt(json.voteOptions), json.mode);
         // set all properties
         poll.pollStateLeaves = json.pollStateLeaves.map((leaf) => domainobjs_1.StateLeaf.fromJSON(leaf));
         poll.ballots = json.ballots.map((ballot) => domainobjs_1.Ballot.fromJSON(ballot));
         poll.encryptionPublicKeys = json.encryptionPublicKeys.map((key) => domainobjs_1.PublicKey.deserialize(key));
         poll.messages = json.messages.map((message) => domainobjs_1.Message.fromJSON(message));
-        poll.commands = json.commands.map((command) => domainobjs_1.PCommand.fromJSON(command));
+        poll.commands = json.commands.map((command) => domainobjs_1.VoteCommand.fromJSON(command));
         poll.tallyResult = json.results.map((result) => BigInt(result));
         poll.currentMessageBatchIndex = json.currentMessageBatchIndex;
         poll.numBatchesProcessed = json.numBatchesProcessed;