@maci-protocol/core 0.0.0-ci.a584b1a → 0.0.0-ci.a73cfa9

package/build/ts/Poll.js

@@ -7,6 +7,7 @@ exports.Poll = void 0;
 const crypto_1 = require("@maci-protocol/crypto");
 const domainobjs_1 = require("@maci-protocol/domainobjs");
 const lean_imt_1 = require("@zk-kit/lean-imt");
+const omit_1 = __importDefault(require("lodash/omit"));
 const assert_1 = __importDefault(require("assert"));
 const constants_1 = require("./utils/constants");
 const errors_1 = require("./utils/errors");
@@ -23,18 +24,19 @@ class Poll {
      * @param maciStateRef - The reference to the MACI state.
      * @param pollId - The poll id
      */
-    constructor(pollEndTimestamp, coordinatorKeypair, treeDepths, batchSizes, maciStateRef, voteOptions) {
+    constructor(pollEndTimestamp, coordinatorKeypair, treeDepths, batchSizes, maciStateRef, voteOptions, mode) {
         this.ballots = [];
+        this.voteCounts = [];
         this.messages = [];
         this.commands = [];
         this.encryptionPublicKeys = [];
         this.stateCopied = false;
         this.publicKeys = [domainobjs_1.padKey];
         // For message processing
-        this.numBatchesProcessed = 0;
+        this.totalBatchesProcessed = 0;
         this.sbSalts = {};
         this.resultRootSalts = {};
-        this.preVOSpentVoiceCreditsRootSalts = {};
+        this.perVoteOptionSpentVoiceCreditsRootSalts = {};
         this.spentVoiceCreditSubtotalSalts = {};
         // For vote tallying
         this.tallyResult = [];
@@ -102,7 +104,6 @@ class Poll {
                 this.pollStateTree?.insert(stateLeaf.hash());
             });
             // Create as many ballots as state leaves
-            this.emptyBallotHash = this.emptyBallot.hash();
             this.ballotTree = new crypto_1.IncrementalQuinTree(Number(this.treeDepths.stateTreeDepth), this.emptyBallotHash, constants_1.STATE_TREE_ARITY, crypto_1.hash2);
             this.ballotTree.insert(this.emptyBallotHash);
             // we fill the ballotTree with empty ballots hashes to match the number of signups in the tree
@@ -110,6 +111,13 @@ class Poll {
                 this.ballotTree.insert(this.emptyBallotHash);
                 this.ballots.push(this.emptyBallot);
             }
+            this.voteCountsTree = new crypto_1.IncrementalQuinTree(Number(this.treeDepths.stateTreeDepth), this.emptyVoteCountsHash, constants_1.STATE_TREE_ARITY, crypto_1.hash2);
+            this.voteCountsTree.insert(this.emptyVoteCountsHash);
+            const emptyVoteCounts = domainobjs_1.VoteCounts.generateBlank(this.maxVoteOptions, this.treeDepths.voteOptionTreeDepth);
+            while (this.voteCounts.length < this.publicKeys.length) {
+                this.voteCountsTree.insert(this.emptyVoteCountsHash);
+                this.voteCounts.push(emptyVoteCounts);
+            }
             this.stateCopied = true;
         };
         /**
@@ -118,7 +126,7 @@ class Poll {
          * @param encryptionPublicKey - The public key associated with the encryption private key.
          * @returns A number of variables which will be used in the zk-SNARK circuit.
          */
-        this.processMessage = (message, encryptionPublicKey, qv = true) => {
+        this.processMessage = (message, encryptionPublicKey) => {
             try {
                 // Decrypt the message
                 const sharedKey = domainobjs_1.Keypair.generateEcdhSharedKey(this.coordinatorKeypair.privateKey, encryptionPublicKey);
@@ -148,24 +156,20 @@ class Poll {
                 }
                 const voteOptionIndex = Number(command.voteOptionIndex);
                 const originalVoteWeight = ballot.votes[voteOptionIndex];
-                // the voice credits left are:
-                // voiceCreditsBalance (how many the user has) +
-                // voiceCreditsPreviouslySpent (the original vote weight for this option) ** 2 -
-                // command.newVoteWeight ** 2 (the new vote weight squared)
-                // basically we are replacing the previous vote weight for this
-                // particular vote option with the new one
-                // but we need to ensure that we are not going >= balance
-                // @note that above comment is valid for quadratic voting
-                // for non quadratic voting, we simply remove the exponentiation
-                const voiceCreditsLeft = qv
-                    ? stateLeaf.voiceCreditBalance +
-                        originalVoteWeight * originalVoteWeight -
-                        command.newVoteWeight * command.newVoteWeight
-                    : stateLeaf.voiceCreditBalance + originalVoteWeight - command.newVoteWeight;
+                const voiceCreditsLeft = this.getVoiceCreditsLeft({
+                    stateLeaf,
+                    originalVoteWeight,
+                    newVoteWeight: command.newVoteWeight,
+                    mode: this.mode,
+                });
                 // If the remaining voice credits is insufficient, do nothing
                 if (voiceCreditsLeft < 0n) {
                     throw new errors_1.ProcessMessageError(errors_1.ProcessMessageErrors.InsufficientVoiceCredits);
                 }
+                // If there are some voice credits left for full credits mode, do nothing
+                if (this.mode === constants_1.EMode.FULL && voiceCreditsLeft > 0n) {
+                    throw new errors_1.ProcessMessageError(errors_1.ProcessMessageErrors.InvalidVoiceCredits);
+                }
                 // Deep-copy the state leaf and update its attributes
                 const newStateLeaf = stateLeaf.copy();
                 newStateLeaf.voiceCreditBalance = voiceCreditsLeft;
@@ -177,20 +181,23 @@ class Poll {
                 newBallot.nonce += 1n;
                 // we change the vote for this exact vote option
                 newBallot.votes[voteOptionIndex] = command.newVoteWeight;
+                if (this.mode === constants_1.EMode.FULL) {
+                    newBallot.votes = newBallot.votes.map((votes, index) => (voteOptionIndex === index ? votes : 0n));
+                }
                 // calculate the path elements for the state tree given the original state tree (before any changes)
                 // changes could effectively be made by this new vote - either a key change or vote change
                 // would result in a different state leaf
-                const { pathElements: originalStateLeafPathElements } = this.pollStateTree.genProof(Number(stateLeafIndex));
+                const { pathElements: originalStateLeafPathElements } = this.pollStateTree.generateProof(Number(stateLeafIndex));
                 // calculate the path elements for the ballot tree given the original ballot tree (before any changes)
                 // changes could effectively be made by this new ballot
-                const { pathElements: originalBallotPathElements } = this.ballotTree.genProof(Number(stateLeafIndex));
+                const { pathElements: originalBallotPathElements } = this.ballotTree.generateProof(Number(stateLeafIndex));
                 // create a new quinary tree where we insert the votes of the origin (up until this message is processed) ballot
                 const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
                 for (let i = 0; i < this.ballots[0].votes.length; i += 1) {
                     voteTree.insert(ballot.votes[i]);
                 }
                 // calculate the path elements for the vote option tree given the original vote option tree (before any changes)
-                const { pathElements: originalVoteWeightsPathElements } = voteTree.genProof(voteOptionIndex);
+                const { pathElements: originalVoteWeightsPathElements } = voteTree.generateProof(voteOptionIndex);
                 // we return the data which is then to be used in the processMessage circuit
                 // to generate a proof of processing
                 return {
@@ -270,14 +277,7 @@ class Poll {
             // calculate the path elements for the state tree given the original state tree
             const { siblings, index } = this.stateTree.generateProof(Number(stateLeafIndex));
             const siblingsLength = siblings.length;
-            // The index must be converted to a list of indices, 1 for each tree level.
-            // The circuit tree depth is this.treeDepths.stateTreeDepth, so the number of siblings must be this.treeDepths.stateTreeDepth,
-            // even if the tree depth is actually 3. The missing siblings can be set to 0, as they
-            // won't be used to calculate the root in the circuit.
-            const indices = [];
             for (let i = 0; i < this.treeDepths.stateTreeDepth; i += 1) {
-                // eslint-disable-next-line no-bitwise
-                indices.push(BigInt((index >> i) & 1));
                 if (i >= siblingsLength) {
                     siblings[i] = BigInt(0);
                 }
@@ -294,7 +294,7 @@ class Poll {
                 privateKey: maciPrivateKey.asCircuitInputs(),
                 pollPublicKey: pollPublicKey.asCircuitInputs(),
                 siblings: siblingsArray,
-                indices,
+                index: BigInt(index),
                 nullifier,
                 stateRoot,
                 actualStateTreeDepth,
@@ -309,19 +309,18 @@ class Poll {
          */
         this.joinedCircuitInputs = ({ maciPrivateKey, stateLeafIndex, voiceCreditsBalance, }) => {
             // calculate the path elements for the state tree given the original state tree
-            const { root: stateRoot, pathElements, pathIndices } = this.pollStateTree.genProof(Number(stateLeafIndex));
+            const { root: stateRoot, pathElements, pathIndices } = this.pollStateTree.generateProof(Number(stateLeafIndex));
             const elementsLength = pathIndices.length;
             for (let i = 0; i < this.treeDepths.stateTreeDepth; i += 1) {
                 if (i >= elementsLength) {
                     pathElements[i] = [0n];
-                    pathIndices[i] = 0;
                 }
             }
             const circuitInputs = {
                 privateKey: maciPrivateKey.asCircuitInputs(),
                 pathElements: pathElements.map((item) => item.toString()),
                 voiceCreditsBalance: voiceCreditsBalance.toString(),
-                pathIndices: pathIndices.map((item) => item.toString()),
+                index: BigInt(stateLeafIndex),
                 actualStateTreeDepth: BigInt(this.actualStateTreeDepth),
                 stateRoot,
             };
@@ -346,7 +345,7 @@ class Poll {
             if (this.messages.length > batchSize && this.messages.length % batchSize > 0) {
                 totalBatches += 1;
             }
-            return this.numBatchesProcessed < totalBatches;
+            return this.totalBatchesProcessed < totalBatches;
         };
         /**
          * Process _batchSize messages starting from the saved index. This
@@ -362,10 +361,10 @@ class Poll {
          * @param quiet - Whether to log errors or not
          * @returns stringified circuit inputs
          */
-        this.processMessages = (pollId, qv = true, quiet = true) => {
+        this.processMessages = (pollId, quiet = true) => {
             (0, assert_1.default)(this.hasUnprocessedMessages(), "No more messages to process");
             const batchSize = this.batchSizes.messageBatchSize;
-            if (this.numBatchesProcessed === 0) {
+            if (this.totalBatchesProcessed === 0) {
                 // Prevent other polls from being processed until this poll has
                 // been fully processed
                 this.maciStateRef.pollBeingProcessed = true;
@@ -411,7 +410,7 @@ class Poll {
                     encryptionPublicKey = this.encryptionPublicKeys[idx];
                     try {
                         // check if the command is valid
-                        const { stateLeafIndex, originalStateLeaf, originalBallot, originalVoteWeight, originalVoteWeightsPathElements, originalStateLeafPathElements, originalBallotPathElements, newStateLeaf, newBallot, } = this.processMessage(message, encryptionPublicKey, qv);
+                        const { stateLeafIndex, originalStateLeaf, originalBallot, originalVoteWeight, originalVoteWeightsPathElements, originalStateLeafPathElements, originalBallotPathElements, newStateLeaf, newBallot, } = this.processMessage(message, encryptionPublicKey);
                         const index = stateLeafIndex;
                         // we add at position 0 the original data
                         currentStateLeaves.unshift(originalStateLeaf);
@@ -455,11 +454,11 @@ class Poll {
                             // if the state leaf index is valid then use it
                             if (stateLeafIndex < this.pollStateLeaves.length) {
                                 currentStateLeaves.unshift(this.pollStateLeaves[Number(stateLeafIndex)].copy());
-                                currentStateLeavesPathElements.unshift(this.pollStateTree.genProof(Number(stateLeafIndex)).pathElements);
+                                currentStateLeavesPathElements.unshift(this.pollStateTree.generateProof(Number(stateLeafIndex)).pathElements);
                                 // copy the ballot
                                 const ballot = this.ballots[Number(stateLeafIndex)].copy();
                                 currentBallots.unshift(ballot);
-                                currentBallotsPathElements.unshift(this.ballotTree.genProof(Number(stateLeafIndex)).pathElements);
+                                currentBallotsPathElements.unshift(this.ballotTree.generateProof(Number(stateLeafIndex)).pathElements);
                                 // @note we check that command.voteOptionIndex is valid so < voteOptions
                                 // this might be unnecessary but we do it to prevent a possible DoS attack
                                 // from voters who could potentially encrypt a message in such as way that
@@ -473,7 +472,7 @@ class Poll {
                                         voteTree.insert(ballot.votes[j]);
                                     }
                                     // get the path elements for the first vote leaf
-                                    currentVoteWeightsPathElements.unshift(voteTree.genProof(Number(command.voteOptionIndex)).pathElements);
+                                    currentVoteWeightsPathElements.unshift(voteTree.generateProof(Number(command.voteOptionIndex)).pathElements);
                                 }
                                 else {
                                     currentVoteWeights.unshift(ballot.votes[0]);
@@ -484,22 +483,22 @@ class Poll {
                                         voteTree.insert(ballot.votes[j]);
                                     }
                                     // get the path elements for the first vote leaf
-                                    currentVoteWeightsPathElements.unshift(voteTree.genProof(0).pathElements);
+                                    currentVoteWeightsPathElements.unshift(voteTree.generateProof(0).pathElements);
                                 }
                             }
                             else {
                                 // just use state leaf index 0
                                 currentStateLeaves.unshift(this.pollStateLeaves[0].copy());
-                                currentStateLeavesPathElements.unshift(this.pollStateTree.genProof(0).pathElements);
+                                currentStateLeavesPathElements.unshift(this.pollStateTree.generateProof(0).pathElements);
                                 currentBallots.unshift(this.ballots[0].copy());
-                                currentBallotsPathElements.unshift(this.ballotTree.genProof(0).pathElements);
+                                currentBallotsPathElements.unshift(this.ballotTree.generateProof(0).pathElements);
                                 // Since the command is invalid, we use a zero vote weight
                                 currentVoteWeights.unshift(this.ballots[0].votes[0]);
                                 // create a new quinary tree and add an empty vote
                                 const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
                                 voteTree.insert(this.ballots[0].votes[0]);
                                 // get the path elements for this empty vote weight leaf
-                                currentVoteWeightsPathElements.unshift(voteTree.genProof(0).pathElements);
+                                currentVoteWeightsPathElements.unshift(voteTree.generateProof(0).pathElements);
                             }
                         }
                         else {
@@ -510,17 +509,17 @@ class Poll {
                 else {
                     // Since we don't have a command at that position, use a blank state leaf
                     currentStateLeaves.unshift(this.pollStateLeaves[0].copy());
-                    currentStateLeavesPathElements.unshift(this.pollStateTree.genProof(0).pathElements);
+                    currentStateLeavesPathElements.unshift(this.pollStateTree.generateProof(0).pathElements);
                     // since the command is invliad we use the blank ballot
                     currentBallots.unshift(this.ballots[0].copy());
-                    currentBallotsPathElements.unshift(this.ballotTree.genProof(0).pathElements);
+                    currentBallotsPathElements.unshift(this.ballotTree.generateProof(0).pathElements);
                     // Since the command is invalid, we use a zero vote weight
                     currentVoteWeights.unshift(this.ballots[0].votes[0]);
                     // create a new quinary tree and add an empty vote
                     const voteTree = new crypto_1.IncrementalQuinTree(this.treeDepths.voteOptionTreeDepth, 0n, constants_1.VOTE_OPTION_TREE_ARITY, crypto_1.hash5);
                     voteTree.insert(this.ballots[0].votes[0]);
                     // get the path elements for this empty vote weight leaf
-                    currentVoteWeightsPathElements.unshift(voteTree.genProof(0).pathElements);
+                    currentVoteWeightsPathElements.unshift(voteTree.generateProof(0).pathElements);
                 }
             }
             // store the data in the circuit inputs object
@@ -538,7 +537,7 @@ class Poll {
             circuitInputs.currentVoteWeights = currentVoteWeights;
             circuitInputs.currentVoteWeightsPathElements = currentVoteWeightsPathElements;
             // record that we processed one batch
-            this.numBatchesProcessed += 1;
+            this.totalBatchesProcessed += 1;
             if (this.currentMessageBatchIndex > 0) {
                 this.currentMessageBatchIndex -= 1;
             }
@@ -557,7 +556,7 @@ class Poll {
             circuitInputs.newSbCommitment = (0, crypto_1.hash3)([newStateRoot, newBallotRoot, newSbSalt]);
             const coordinatorPublicKeyHash = this.coordinatorKeypair.publicKey.hash();
             // If this is the last batch, release the lock
-            if (this.numBatchesProcessed * batchSize >= this.messages.length) {
+            if (this.totalBatchesProcessed * batchSize >= this.messages.length) {
                 this.maciStateRef.pollBeingProcessed = false;
             }
             // ensure we pass the dynamic tree depth
@@ -661,7 +660,8 @@ class Poll {
         this.hasUntalliedBallots = () => this.numBatchesTallied * this.batchSizes.tallyBatchSize < this.ballots.length;
         /**
          * This method tallies a ballots and updates the tally results.
-         * @returns the circuit inputs for the TallyVotes circuit.
+         *
+         * @returns the circuit inputs for the VoteTally circuit.
          */
         this.tallyVotes = () => {
             // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
@@ -674,84 +674,118 @@ class Poll {
             const batchStartIndex = this.numBatchesTallied * batchSize;
             // get the salts needed for the commitments
             const currentResultsRootSalt = batchStartIndex === 0 ? 0n : this.resultRootSalts[batchStartIndex - batchSize];
-            const currentPerVoteOptionSpentVoiceCreditsRootSalt = batchStartIndex === 0 ? 0n : this.preVOSpentVoiceCreditsRootSalts[batchStartIndex - batchSize];
+            const currentPerVoteOptionSpentVoiceCreditsRootSalt = batchStartIndex === 0 ? 0n : this.perVoteOptionSpentVoiceCreditsRootSalts[batchStartIndex - batchSize];
             const currentSpentVoiceCreditSubtotalSalt = batchStartIndex === 0 ? 0n : this.spentVoiceCreditSubtotalSalts[batchStartIndex - batchSize];
             // generate a commitment to the current results
             const currentResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, currentResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
             // generate a commitment to the current per vote option spent voice credits
-            const currentPerVOSpentVoiceCreditsCommitment = this.genPerVOSpentVoiceCreditsCommitment(currentPerVoteOptionSpentVoiceCreditsRootSalt, batchStartIndex, true);
+            const currentPerVoteOptionSpentVoiceCreditsCommitment = this.generatePerVoteOptionSpentVoiceCreditsCommitment(currentPerVoteOptionSpentVoiceCreditsRootSalt, batchStartIndex, this.mode);
             // generate a commitment to the current spent voice credits
-            const currentSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(currentSpentVoiceCreditSubtotalSalt, batchStartIndex, true);
+            const currentSpentVoiceCreditsCommitment = this.generateSpentVoiceCreditSubtotalCommitment(currentSpentVoiceCreditSubtotalSalt, batchStartIndex, this.mode);
             // the current commitment for the first batch will be 0
             // otherwise calculate as
             // hash([
             //  currentResultsCommitment,
             //  currentSpentVoiceCreditsCommitment,
-            //  currentPerVOSpentVoiceCreditsCommitment
             // ])
-            const currentTallyCommitment = batchStartIndex === 0
+            // or for QV
+            // hash([
+            //  currentResultsCommitment,
+            //  currentSpentVoiceCreditsCommitment,
+            //  currentPerVoteOptionSpentVoiceCreditsCommitment
+            // ])
+            // TODO: use commitment for vote counts
+            const currentTallyCommitmentQv = this.mode !== constants_1.EMode.QV || batchStartIndex === 0
                 ? 0n
                 : (0, crypto_1.hash3)([
                     currentResultsCommitment,
                     currentSpentVoiceCreditsCommitment,
-                    currentPerVOSpentVoiceCreditsCommitment,
+                    currentPerVoteOptionSpentVoiceCreditsCommitment,
                 ]);
+            const currentTallyCommitmentNonQv = this.mode === constants_1.EMode.QV || batchStartIndex === 0
+                ? 0n
+                : (0, crypto_1.hashLeftRight)(currentResultsCommitment, currentSpentVoiceCreditsCommitment);
+            const currentTallyCommitment = currentTallyCommitmentNonQv || currentTallyCommitmentQv;
+            const startIndex = this.numBatchesTallied * batchSize;
+            const endIndex = this.numBatchesTallied * batchSize + batchSize;
             const ballots = [];
+            const voteCounts = [];
+            const voteCountsData = [];
             const currentResults = this.tallyResult.map((x) => BigInt(x.toString()));
             const currentPerVoteOptionSpentVoiceCredits = this.perVoteOptionSpentVoiceCredits.map((x) => BigInt(x.toString()));
             const currentSpentVoiceCreditSubtotal = BigInt(this.totalSpentVoiceCredits.toString());
             // loop in normal order to tally the ballots one by one
-            for (let i = this.numBatchesTallied * batchSize; i < this.numBatchesTallied * batchSize + batchSize; i += 1) {
+            for (let i = startIndex; i < endIndex; i += 1) {
                 // we stop if we have no more ballots to tally
                 if (i >= this.ballots.length) {
                     break;
                 }
                 // save to the local ballot array
                 ballots.push(this.ballots[i]);
+                const ballot = this.ballots[i];
+                const newVoteCounts = this.voteCounts[i].copy();
+                newVoteCounts.counts = ballot.votes.map((votes, voteOptionIndex) => this.voteCounts[i].counts[voteOptionIndex] + BigInt(votes !== 0n));
+                // save to the local vote counts array
+                this.voteCountsTree?.update(i, newVoteCounts.hash());
+                this.voteCounts[i] = newVoteCounts;
+                voteCounts.push(newVoteCounts);
+                voteCountsData.push(newVoteCounts.counts);
                 // for each possible vote option we loop and calculate
                 for (let j = 0; j < this.maxVoteOptions; j += 1) {
-                    const v = this.ballots[i].votes[j];
-                    // the vote itself will be a quadratic vote (sqrt(voiceCredits))
-                    this.tallyResult[j] += v;
-                    // the per vote option spent voice credits will be the sum of the squares of the votes
-                    this.perVoteOptionSpentVoiceCredits[j] += v * v;
-                    // the total spent voice credits will be the sum of the squares of the votes
-                    this.totalSpentVoiceCredits += v * v;
+                    const votes = this.ballots[i].votes[j];
+                    this.tallyResult[j] += votes;
+                    if (this.mode === constants_1.EMode.QV) {
+                        // the per vote option spent voice credits will be the sum of the squares of the votes
+                        this.perVoteOptionSpentVoiceCredits[j] += votes * votes;
+                        // the total spent voice credits will be the sum of the squares of the votes
+                        this.totalSpentVoiceCredits += votes * votes;
+                    }
+                    else {
+                        // the total spent voice credits will be the sum of the votes
+                        this.totalSpentVoiceCredits += votes;
+                    }
                 }
             }
             const emptyBallot = new domainobjs_1.Ballot(this.maxVoteOptions, this.treeDepths.voteOptionTreeDepth);
+            const emptyVoteCounts = new domainobjs_1.VoteCounts(this.maxVoteOptions, this.treeDepths.voteOptionTreeDepth);
             // pad the ballots array
             while (ballots.length < batchSize) {
                 ballots.push(emptyBallot);
             }
+            // pad the vote counts array
+            while (voteCounts.length < batchSize) {
+                voteCounts.push(emptyVoteCounts);
+            }
             // generate the new salts
             const newResultsRootSalt = (0, crypto_1.generateRandomSalt)();
             const newPerVoteOptionSpentVoiceCreditsRootSalt = (0, crypto_1.generateRandomSalt)();
             const newSpentVoiceCreditSubtotalSalt = (0, crypto_1.generateRandomSalt)();
             // and save them to be used in the next batch
             this.resultRootSalts[batchStartIndex] = newResultsRootSalt;
-            this.preVOSpentVoiceCreditsRootSalts[batchStartIndex] = newPerVoteOptionSpentVoiceCreditsRootSalt;
+            this.perVoteOptionSpentVoiceCreditsRootSalts[batchStartIndex] = newPerVoteOptionSpentVoiceCreditsRootSalt;
             this.spentVoiceCreditSubtotalSalts[batchStartIndex] = newSpentVoiceCreditSubtotalSalt;
             // generate the new results commitment with the new salts and data
             const newResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, newResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
             // generate the new spent voice credits commitment with the new salts and data
-            const newSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(newSpentVoiceCreditSubtotalSalt, batchStartIndex + batchSize, true);
+            const newSpentVoiceCreditsCommitment = this.generateSpentVoiceCreditSubtotalCommitment(newSpentVoiceCreditSubtotalSalt, batchStartIndex + batchSize, this.mode);
             // generate the new per vote option spent voice credits commitment with the new salts and data
-            const newPerVOSpentVoiceCreditsCommitment = this.genPerVOSpentVoiceCreditsCommitment(newPerVoteOptionSpentVoiceCreditsRootSalt, batchStartIndex + batchSize, true);
+            const newPerVoteOptionSpentVoiceCreditsCommitment = this.generatePerVoteOptionSpentVoiceCreditsCommitment(newPerVoteOptionSpentVoiceCreditsRootSalt, batchStartIndex + batchSize, this.mode);
             // generate the new tally commitment
-            const newTallyCommitment = (0, crypto_1.hash3)([
-                newResultsCommitment,
-                newSpentVoiceCreditsCommitment,
-                newPerVOSpentVoiceCreditsCommitment,
-            ]);
+            const newTallyCommitment = this.mode === constants_1.EMode.QV
+                ? (0, crypto_1.hash3)([newResultsCommitment, newSpentVoiceCreditsCommitment, newPerVoteOptionSpentVoiceCreditsCommitment])
+                : (0, crypto_1.hashLeftRight)(newResultsCommitment, newSpentVoiceCreditsCommitment);
             // cache vars
             const stateRoot = this.pollStateTree.root;
             const ballotRoot = this.ballotTree.root;
+            const voteCountsRoot = this.voteCountsTree.root;
             const sbSalt = this.sbSalts[this.currentMessageBatchIndex];
             const sbCommitment = (0, crypto_1.hash3)([stateRoot, ballotRoot, sbSalt]);
-            const ballotSubrootProof = this.ballotTree?.genSubrootProof(batchStartIndex, batchStartIndex + batchSize);
+            const ballotSubrootProof = this.ballotTree?.generateSubrootProof(batchStartIndex, batchStartIndex + batchSize);
+            const voteCountsSubrootProof = this.voteCountsTree?.generateSubrootProof(batchStartIndex, batchStartIndex + batchSize);
             const votes = ballots.map((x) => x.votes);
-            const circuitInputs = (0, crypto_1.stringifyBigInts)({
+            // Don't include these inputs in the circuit inputs until individual vote counts are implemented
+            const excludedCircuitInputs = ["voteCountsData", "voteCountsPathElements", "voteCounts", "voteCountsRoot"];
+            const circuitInputs = (0, crypto_1.stringifyBigInts)((0, omit_1.default)({
                 stateRoot,
                 ballotRoot,
                 sbSalt,
@@ -763,104 +797,27 @@ class Poll {
                 ballots: ballots.map((x) => x.asCircuitInputs()),
                 ballotPathElements: ballotSubrootProof.pathElements,
                 votes,
+                voteCountsRoot,
+                voteCounts: voteCounts.map((x) => x.asCircuitInputs()),
+                voteCountsPathElements: voteCountsSubrootProof.pathElements,
+                voteCountsData,
                 currentResults,
                 currentResultsRootSalt,
                 currentSpentVoiceCreditSubtotal,
                 currentSpentVoiceCreditSubtotalSalt,
                 currentPerVoteOptionSpentVoiceCredits,
                 currentPerVoteOptionSpentVoiceCreditsRootSalt,
-                newResultsRootSalt,
                 newPerVoteOptionSpentVoiceCreditsRootSalt,
-                newSpentVoiceCreditSubtotalSalt,
-            });
-            this.numBatchesTallied += 1;
-            return circuitInputs;
-        };
-        this.tallyVotesNonQv = () => {
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-            if (this.sbSalts[this.currentMessageBatchIndex] === undefined) {
-                throw new Error("You must process the messages first");
-            }
-            const batchSize = this.batchSizes.tallyBatchSize;
-            (0, assert_1.default)(this.hasUntalliedBallots(), "No more ballots to tally");
-            // calculate where we start tallying next
-            const batchStartIndex = this.numBatchesTallied * batchSize;
-            // get the salts needed for the commitments
-            const currentResultsRootSalt = batchStartIndex === 0 ? 0n : this.resultRootSalts[batchStartIndex - batchSize];
-            const currentSpentVoiceCreditSubtotalSalt = batchStartIndex === 0 ? 0n : this.spentVoiceCreditSubtotalSalts[batchStartIndex - batchSize];
-            // generate a commitment to the current results
-            const currentResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, currentResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
-            // generate a commitment to the current spent voice credits
-            const currentSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(currentSpentVoiceCreditSubtotalSalt, batchStartIndex, false);
-            // the current commitment for the first batch will be 0
-            // otherwise calculate as
-            // hash([
-            //  currentResultsCommitment,
-            //  currentSpentVoiceCreditsCommitment,
-            // ])
-            const currentTallyCommitment = batchStartIndex === 0 ? 0n : (0, crypto_1.hashLeftRight)(currentResultsCommitment, currentSpentVoiceCreditsCommitment);
-            const ballots = [];
-            const currentResults = this.tallyResult.map((x) => BigInt(x.toString()));
-            const currentSpentVoiceCreditSubtotal = BigInt(this.totalSpentVoiceCredits.toString());
-            // loop in normal order to tally the ballots one by one
-            for (let i = this.numBatchesTallied * batchSize; i < this.numBatchesTallied * batchSize + batchSize; i += 1) {
-                // we stop if we have no more ballots to tally
-                if (i >= this.ballots.length) {
-                    break;
-                }
-                // save to the local ballot array
-                ballots.push(this.ballots[i]);
-                // for each possible vote option we loop and calculate
-                for (let j = 0; j < this.maxVoteOptions; j += 1) {
-                    const v = this.ballots[i].votes[j];
-                    this.tallyResult[j] += v;
-                    // the total spent voice credits will be the sum of the votes
-                    this.totalSpentVoiceCredits += v;
-                }
-            }
-            const emptyBallot = new domainobjs_1.Ballot(this.maxVoteOptions, this.treeDepths.voteOptionTreeDepth);
-            // pad the ballots array
-            while (ballots.length < batchSize) {
-                ballots.push(emptyBallot);
-            }
-            // generate the new salts
-            const newResultsRootSalt = (0, crypto_1.generateRandomSalt)();
-            const newSpentVoiceCreditSubtotalSalt = (0, crypto_1.generateRandomSalt)();
-            // and save them to be used in the next batch
-            this.resultRootSalts[batchStartIndex] = newResultsRootSalt;
-            this.spentVoiceCreditSubtotalSalts[batchStartIndex] = newSpentVoiceCreditSubtotalSalt;
-            // generate the new results commitment with the new salts and data
-            const newResultsCommitment = (0, crypto_1.generateTreeCommitment)(this.tallyResult, newResultsRootSalt, this.treeDepths.voteOptionTreeDepth);
-            // generate the new spent voice credits commitment with the new salts and data
-            const newSpentVoiceCreditsCommitment = this.genSpentVoiceCreditSubtotalCommitment(newSpentVoiceCreditSubtotalSalt, batchStartIndex + batchSize, false);
-            // generate the new tally commitment
-            const newTallyCommitment = (0, crypto_1.hashLeftRight)(newResultsCommitment, newSpentVoiceCreditsCommitment);
-            // cache vars
-            const stateRoot = this.pollStateTree.root;
-            const ballotRoot = this.ballotTree.root;
-            const sbSalt = this.sbSalts[this.currentMessageBatchIndex];
-            const sbCommitment = (0, crypto_1.hash3)([stateRoot, ballotRoot, sbSalt]);
-            const ballotSubrootProof = this.ballotTree?.genSubrootProof(batchStartIndex, batchStartIndex + batchSize);
-            const votes = ballots.map((x) => x.votes);
-            const circuitInputs = (0, crypto_1.stringifyBigInts)({
-                stateRoot,
-                ballotRoot,
-                sbSalt,
-                index: BigInt(batchStartIndex),
-                totalSignups: BigInt(this.totalSignups),
-                sbCommitment,
-                currentTallyCommitment,
-                newTallyCommitment,
-                ballots: ballots.map((x) => x.asCircuitInputs()),
-                ballotPathElements: ballotSubrootProof.pathElements,
-                votes,
-                currentResults,
-                currentResultsRootSalt,
-                currentSpentVoiceCreditSubtotal,
-                currentSpentVoiceCreditSubtotalSalt,
                 newResultsRootSalt,
                 newSpentVoiceCreditSubtotalSalt,
-            });
+            }, this.mode !== constants_1.EMode.QV
+                ? [
+                    ...excludedCircuitInputs,
+                    "currentPerVoteOptionSpentVoiceCredits",
+                    "currentPerVoteOptionSpentVoiceCreditsRootSalt",
+                    "newPerVoteOptionSpentVoiceCreditsRootSalt",
+                ]
+                : [...excludedCircuitInputs]));
             this.numBatchesTallied += 1;
             return circuitInputs;
         };
@@ -869,19 +826,19 @@ class Poll {
          *
          * This is the hash of the total spent voice credits and a salt, computed as Poseidon([totalCredits, _salt]).
          * @param salt - The salt used in the hash function.
-         * @param numBallotsToCount - The number of ballots to count for the calculation.
-         * @param useQuadraticVoting - Whether to use quadratic voting or not. Default is true.
+         * @param ballotsToCount - The number of ballots to count for the calculation.
+         * @param mode - Voting mode, default is QV.
          * @returns Returns the hash of the total spent voice credits and a salt, computed as Poseidon([totalCredits, _salt]).
          */
-        this.genSpentVoiceCreditSubtotalCommitment = (salt, numBallotsToCount, useQuadraticVoting = true) => {
+        this.generateSpentVoiceCreditSubtotalCommitment = (salt, ballotsToCount, mode = constants_1.EMode.QV) => {
             let subtotal = 0n;
-            for (let i = 0; i < numBallotsToCount; i += 1) {
+            for (let i = 0; i < ballotsToCount; i += 1) {
                 if (this.ballots.length <= i) {
                     break;
                 }
                 for (let j = 0; j < this.tallyResult.length; j += 1) {
-                    const v = BigInt(`${this.ballots[i].votes[j]}`);
-                    subtotal += useQuadraticVoting ? v * v : v;
+                    const vote = BigInt(`${this.ballots[i].votes[j]}`);
+                    subtotal += mode === constants_1.EMode.QV ? vote * vote : vote;
                 }
             }
             return (0, crypto_1.hashLeftRight)(subtotal, salt);
@@ -891,20 +848,20 @@ class Poll {
          *
          * This is the hash of the Merkle root of the spent voice credits per vote option and a salt, computed as Poseidon([root, _salt]).
          * @param salt - The salt used in the hash function.
-         * @param numBallotsToCount - The number of ballots to count for the calculation.
-         * @param useQuadraticVoting - Whether to use quadratic voting or not. Default is true.
+         * @param ballotsToCount - The number of ballots to count for the calculation.
+         * @param mode - Voting mode, default is QV.
          * @returns Returns the hash of the Merkle root of the spent voice credits per vote option and a salt, computed as Poseidon([root, _salt]).
          */
-        this.genPerVOSpentVoiceCreditsCommitment = (salt, numBallotsToCount, useQuadraticVoting = true) => {
+        this.generatePerVoteOptionSpentVoiceCreditsCommitment = (salt, ballotsToCount, mode = constants_1.EMode.QV) => {
             const leaves = Array(this.tallyResult.length).fill(0n);
-            for (let i = 0; i < numBallotsToCount; i += 1) {
+            for (let i = 0; i < ballotsToCount; i += 1) {
                 // check that is a valid index
                 if (i >= this.ballots.length) {
                     break;
                 }
                 for (let j = 0; j < this.tallyResult.length; j += 1) {
-                    const v = this.ballots[i].votes[j];
-                    leaves[j] += useQuadraticVoting ? v * v : v;
+                    const vote = this.ballots[i].votes[j];
+                    leaves[j] += mode === constants_1.EMode.QV ? vote * vote : vote;
                 }
             }
             return (0, crypto_1.generateTreeCommitment)(leaves, salt, this.treeDepths.voteOptionTreeDepth);
@@ -915,33 +872,37 @@ class Poll {
          */
         this.copy = () => {
             const copied = new Poll(BigInt(this.pollEndTimestamp.toString()), this.coordinatorKeypair.copy(), {
-                intStateTreeDepth: Number(this.treeDepths.intStateTreeDepth),
+                tallyProcessingStateTreeDepth: Number(this.treeDepths.tallyProcessingStateTreeDepth),
                 voteOptionTreeDepth: Number(this.treeDepths.voteOptionTreeDepth),
                 stateTreeDepth: Number(this.treeDepths.stateTreeDepth),
             }, {
                 tallyBatchSize: Number(this.batchSizes.tallyBatchSize.toString()),
                 messageBatchSize: Number(this.batchSizes.messageBatchSize.toString()),
-            }, this.maciStateRef, this.voteOptions);
+            }, this.maciStateRef, this.voteOptions, this.mode);
             copied.publicKeys = this.publicKeys.map((x) => x.copy());
             copied.pollStateLeaves = this.pollStateLeaves.map((x) => x.copy());
             copied.messages = this.messages.map((x) => x.copy());
             copied.commands = this.commands.map((x) => x.copy());
             copied.ballots = this.ballots.map((x) => x.copy());
             copied.encryptionPublicKeys = this.encryptionPublicKeys.map((x) => x.copy());
+            copied.voteCounts = this.voteCounts.map((x) => x.copy());
             if (this.ballotTree) {
                 copied.ballotTree = this.ballotTree.copy();
             }
+            if (this.voteCountsTree) {
+                copied.voteCountsTree = this.voteCountsTree.copy();
+            }
             copied.currentMessageBatchIndex = this.currentMessageBatchIndex;
             copied.maciStateRef = this.maciStateRef;
             copied.tallyResult = this.tallyResult.map((x) => BigInt(x.toString()));
             copied.perVoteOptionSpentVoiceCredits = this.perVoteOptionSpentVoiceCredits.map((x) => BigInt(x.toString()));
-            copied.numBatchesProcessed = Number(this.numBatchesProcessed.toString());
+            copied.totalBatchesProcessed = Number(this.totalBatchesProcessed.toString());
             copied.numBatchesTallied = Number(this.numBatchesTallied.toString());
             copied.pollId = this.pollId;
             copied.totalSpentVoiceCredits = BigInt(this.totalSpentVoiceCredits.toString());
             copied.sbSalts = {};
             copied.resultRootSalts = {};
-            copied.preVOSpentVoiceCreditsRootSalts = {};
+            copied.perVoteOptionSpentVoiceCreditsRootSalts = {};
             copied.spentVoiceCreditSubtotalSalts = {};
             Object.keys(this.sbSalts).forEach((k) => {
                 copied.sbSalts[k] = BigInt(this.sbSalts[k].toString());
@@ -949,8 +910,8 @@ class Poll {
             Object.keys(this.resultRootSalts).forEach((k) => {
                 copied.resultRootSalts[k] = BigInt(this.resultRootSalts[k].toString());
             });
-            Object.keys(this.preVOSpentVoiceCreditsRootSalts).forEach((k) => {
-                copied.preVOSpentVoiceCreditsRootSalts[k] = BigInt(this.preVOSpentVoiceCreditsRootSalts[k].toString());
+            Object.keys(this.perVoteOptionSpentVoiceCreditsRootSalts).forEach((k) => {
+                copied.perVoteOptionSpentVoiceCreditsRootSalts[k] = BigInt(this.perVoteOptionSpentVoiceCreditsRootSalts[k].toString());
             });
             Object.keys(this.spentVoiceCreditSubtotalSalts).forEach((k) => {
                 copied.spentVoiceCreditSubtotalSalts[k] = BigInt(this.spentVoiceCreditSubtotalSalts[k].toString());
@@ -966,7 +927,7 @@ class Poll {
          */
         this.equals = (poll) => {
             const result = this.coordinatorKeypair.equals(poll.coordinatorKeypair) &&
-                this.treeDepths.intStateTreeDepth === poll.treeDepths.intStateTreeDepth &&
+                this.treeDepths.tallyProcessingStateTreeDepth === poll.treeDepths.tallyProcessingStateTreeDepth &&
                 this.treeDepths.voteOptionTreeDepth === poll.treeDepths.voteOptionTreeDepth &&
                 this.batchSizes.tallyBatchSize === poll.batchSizes.tallyBatchSize &&
                 this.batchSizes.messageBatchSize === poll.batchSizes.messageBatchSize &&
@@ -1007,26 +968,60 @@ class Poll {
          * Get the number of signups
          * @returns The number of signups
          */
-        this.gettotalSignups = () => this.totalSignups;
+        this.getTotalSignups = () => this.totalSignups;
+        if (voteOptions > constants_1.VOTE_OPTION_TREE_ARITY ** treeDepths.voteOptionTreeDepth) {
+            throw new Error("Vote options cannot be greater than the number of leaves in the vote option tree");
+        }
         this.pollEndTimestamp = pollEndTimestamp;
         this.coordinatorKeypair = coordinatorKeypair;
         this.treeDepths = treeDepths;
         this.batchSizes = batchSizes;
-        if (voteOptions > constants_1.VOTE_OPTION_TREE_ARITY ** treeDepths.voteOptionTreeDepth) {
-            throw new Error("Vote options cannot be greater than the number of leaves in the vote option tree");
-        }
         this.voteOptions = voteOptions;
         this.maxVoteOptions = constants_1.VOTE_OPTION_TREE_ARITY ** treeDepths.voteOptionTreeDepth;
         this.maciStateRef = maciStateRef;
         this.pollId = BigInt(maciStateRef.polls.size);
         this.actualStateTreeDepth = treeDepths.stateTreeDepth;
         this.currentMessageBatchIndex = 0;
+        this.mode = mode;
         this.pollNullifiers = new Map();
         this.tallyResult = new Array(this.maxVoteOptions).fill(0n);
         this.perVoteOptionSpentVoiceCredits = new Array(this.maxVoteOptions).fill(0n);
         // we put a blank state leaf to prevent a DoS attack
-        this.emptyBallot = domainobjs_1.Ballot.genBlankBallot(this.maxVoteOptions, treeDepths.voteOptionTreeDepth);
+        this.emptyBallot = domainobjs_1.Ballot.generateBlank(this.maxVoteOptions, treeDepths.voteOptionTreeDepth);
         this.ballots.push(this.emptyBallot);
+        this.emptyBallotHash = this.emptyBallot.hash();
+        this.emptyVoteCounts = domainobjs_1.VoteCounts.generateBlank(this.maxVoteOptions, treeDepths.voteOptionTreeDepth);
+        this.voteCounts.push(this.emptyVoteCounts);
+        this.emptyVoteCountsHash = this.emptyVoteCounts.hash();
+    }
+    /**
+     * Get voice credits left for the voting command.
+     *
+     * @param args - arguments for getting voice credits
+     * @returns voice credits left
+     */
+    getVoiceCreditsLeft({ stateLeaf, originalVoteWeight, newVoteWeight, mode }) {
+        switch (mode) {
+            case constants_1.EMode.QV: {
+                // the voice credits left are:
+                // voiceCreditsBalance (how many the user has) +
+                // voiceCreditsPreviouslySpent (the original vote weight for this option) ** 2 -
+                // command.newVoteWeight ** 2 (the new vote weight squared)
+                // basically we are replacing the previous vote weight for this
+                // particular vote option with the new one
+                // but we need to ensure that we are not going >= balance
+                return stateLeaf.voiceCreditBalance + originalVoteWeight * originalVoteWeight - newVoteWeight * newVoteWeight;
+            }
+            case constants_1.EMode.NON_QV:
+            case constants_1.EMode.FULL: {
+                // for non quadratic voting, we simply remove the exponentiation
+                // for full credits voting, it will be zero
+                return stateLeaf.voiceCreditBalance + originalVoteWeight - newVoteWeight;
+            }
+            default: {
+                throw new Error("Voting mode is not supported");
+            }
+        }
     }
     /**
      * Serialize the Poll object to a JSON object
@@ -1043,16 +1038,18 @@ class Poll {
             messages: this.messages.map((message) => message.toJSON()),
             commands: this.commands.map((command) => command.toJSON()),
             ballots: this.ballots.map((ballot) => ballot.toJSON()),
+            voteCounts: this.voteCounts.map((voteCounts) => voteCounts.toJSON()),
             encryptionPublicKeys: this.encryptionPublicKeys.map((encryptionPublicKey) => encryptionPublicKey.serialize()),
             currentMessageBatchIndex: this.currentMessageBatchIndex,
             publicKeys: this.publicKeys.map((leaf) => leaf.toJSON()),
             pollStateLeaves: this.pollStateLeaves.map((leaf) => leaf.toJSON()),
             results: this.tallyResult.map((result) => result.toString()),
-            numBatchesProcessed: this.numBatchesProcessed,
+            totalBatchesProcessed: this.totalBatchesProcessed,
             totalSignups: this.totalSignups.toString(),
             chainHash: this.chainHash.toString(),
             pollNullifiers: [...this.pollNullifiers.keys()].map((nullifier) => nullifier.toString()),
             batchHashes: this.batchHashes.map((batchHash) => batchHash.toString()),
+            mode: this.mode,
         };
     }
     /**
@@ -1062,16 +1059,17 @@ class Poll {
      * @returns a new Poll instance
      */
     static fromJSON(json, maciState) {
-        const poll = new Poll(BigInt(json.pollEndTimestamp), new domainobjs_1.Keypair(), json.treeDepths, json.batchSizes, maciState, BigInt(json.voteOptions));
+        const poll = new Poll(BigInt(json.pollEndTimestamp), new domainobjs_1.Keypair(), json.treeDepths, json.batchSizes, maciState, BigInt(json.voteOptions), json.mode);
         // set all properties
         poll.pollStateLeaves = json.pollStateLeaves.map((leaf) => domainobjs_1.StateLeaf.fromJSON(leaf));
         poll.ballots = json.ballots.map((ballot) => domainobjs_1.Ballot.fromJSON(ballot));
+        poll.voteCounts = json.voteCounts.map((voteCounts) => domainobjs_1.VoteCounts.fromJSON(voteCounts));
         poll.encryptionPublicKeys = json.encryptionPublicKeys.map((key) => domainobjs_1.PublicKey.deserialize(key));
         poll.messages = json.messages.map((message) => domainobjs_1.Message.fromJSON(message));
         poll.commands = json.commands.map((command) => domainobjs_1.VoteCommand.fromJSON(command));
         poll.tallyResult = json.results.map((result) => BigInt(result));
         poll.currentMessageBatchIndex = json.currentMessageBatchIndex;
-        poll.numBatchesProcessed = json.numBatchesProcessed;
+        poll.totalBatchesProcessed = json.totalBatchesProcessed;
         poll.chainHash = BigInt(json.chainHash);
         poll.batchHashes = json.batchHashes.map((batchHash) => BigInt(batchHash));
         poll.pollNullifiers = new Map(json.pollNullifiers.map((nullifier) => [BigInt(nullifier), true]));