@machinemetrics/mm-erp-sdk 0.1.6-beta.1 → 0.1.7-beta.0

package/dist/services/data-sync-service/jobs/clean-up-expired-cache.js

@@ -1,7 +1,7 @@
-import "../../../config-WKwu1mMo.js";
-import { H as HashedCacheManager } from "../../../hashed-cache-manager-CtDhFqj6.js";
-import { S as SQLiteCoordinator } from "../../../index-aci_wdcn.js";
-import { l as logger } from "../../../logger-hqtl8hFM.js";
+import "../../../config-qat9zgOl.js";
+import { H as HashedCacheManager } from "../../../hashed-cache-manager-CzyFSt2B.js";
+import { S as SQLiteCoordinator } from "../../../index-B9wo8pld.js";
+import { l as logger } from "../../../logger-Db8CkwR6.js";
 logger.level = process.env.LOG_LEVEL || "info";
 const main = async () => {
   const cacheManager = new HashedCacheManager();

package/dist/services/data-sync-service/jobs/from-erp.js

@@ -1,7 +1,7 @@
-import "../../../config-WKwu1mMo.js";
-import { l as logger } from "../../../logger-hqtl8hFM.js";
-import { S as SQLiteCoordinator } from "../../../index-aci_wdcn.js";
-import { c as createConnectorFromPath } from "../../../connector-factory-DHmMYsRs.js";
+import "../../../config-qat9zgOl.js";
+import { l as logger } from "../../../logger-Db8CkwR6.js";
+import { S as SQLiteCoordinator } from "../../../index-B9wo8pld.js";
+import { c as createConnectorFromPath } from "../../../connector-factory-C2czCs9v.js";
 logger.level = process.env.LOG_LEVEL || "info";
 const main = async () => {
   try {

package/dist/services/data-sync-service/jobs/retry-failed-labor-tickets.js

@@ -1,6 +1,6 @@
-import "../../../config-WKwu1mMo.js";
-import { l as logger } from "../../../logger-hqtl8hFM.js";
-import { c as createConnectorFromPath } from "../../../connector-factory-DHmMYsRs.js";
+import "../../../config-qat9zgOl.js";
+import { l as logger } from "../../../logger-Db8CkwR6.js";
+import { c as createConnectorFromPath } from "../../../connector-factory-C2czCs9v.js";
 logger.level = process.env.LOG_LEVEL || "info";
 const main = async () => {
   try {

package/dist/services/data-sync-service/jobs/run-migrations.js

@@ -1,5 +1,5 @@
 import knex from "knex";
-import { l as logger } from "../../../logger-hqtl8hFM.js";
+import { l as logger } from "../../../logger-Db8CkwR6.js";
 import { c as config } from "../../../knexfile-1qKKIORB.js";
 logger.level = process.env.LOG_LEVEL || "info";
 const db = knex(config.local);

package/dist/services/data-sync-service/jobs/to-erp.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"to-erp.d.ts","sourceRoot":"","sources":["../../../../src/services/data-sync-service/jobs/to-erp.ts"],"names":[],"mappings":"AAAA,OAAO,eAAe,CAAC;AAQvB,QAAA,MAAM,IAAI,qBAoCT,CAAC;AAoBF,eAAe,IAAI,CAAC"}
+{"version":3,"file":"to-erp.d.ts","sourceRoot":"","sources":["../../../../src/services/data-sync-service/jobs/to-erp.ts"],"names":[],"mappings":"AAAA,OAAO,eAAe,CAAC;AASvB,QAAA,MAAM,IAAI,qBAoCT,CAAC;AAoBF,eAAe,IAAI,CAAC"}

package/dist/services/data-sync-service/jobs/to-erp.js

@@ -1,6 +1,6 @@
-import "../../../config-WKwu1mMo.js";
-import { l as logger } from "../../../logger-hqtl8hFM.js";
-import { c as createConnectorFromPath } from "../../../connector-factory-DHmMYsRs.js";
+import "../../../config-qat9zgOl.js";
+import { l as logger } from "../../../logger-Db8CkwR6.js";
+import { c as createConnectorFromPath } from "../../../connector-factory-C2czCs9v.js";
 logger.level = process.env.LOG_LEVEL || "info";
 const main = async () => {
   try {

package/dist/services/data-sync-service/jobs/to-erp.js.map

@@ -1 +1 @@
-{"version":3,"file":"to-erp.js","sources":["../../../../src/services/data-sync-service/jobs/to-erp.ts"],"sourcesContent":["import \"dotenv/config\";\n\nimport logger from \"../../reporting-service/logger\";\nimport { createConnectorFromPath } from \"../../../utils/connector-factory\";\n\n// Configure the logger with the correct log level\nlogger.level = process.env.LOG_LEVEL || \"info\";\n\nconst main = async () => {\n  try {\n    logger.info('Worker for job \"to-erp\" online');\n    logger.info(\"==========Starting to-erp job cycle==========\");\n\n    // Get the connector path from the environment variable\n    const connectorPath = process.env.CONNECTOR_PATH;\n\n    if (!connectorPath) {\n      throw new Error(\"Connector path not provided in environment variables\");\n    }\n\n    // Create a new connector instance for this job\n    const connector = await createConnectorFromPath(connectorPath);\n\n    await connector.syncToERP();\n    await connector.syncToERPCompleted();\n\n    logger.info(\"==========Completed to-erp job cycle==========\");\n  } catch (error) {\n    const errorDetails = {\n      message: error instanceof Error ? error.message : String(error),\n      stack: error instanceof Error ? error.stack : undefined,\n      name: error instanceof Error ? error.name : undefined,\n      ...(error && typeof error === \"object\" ? error : {}), // Include all enumerable properties if it's an object\n    };\n    logger.error('Worker for job \"to-erp\" had an error', {\n      error: errorDetails,\n      connectorPath: process.env.CONNECTOR_PATH,\n    });\n\n    // Also log to console for immediate visibility\n    console.error(\"to-erp job error:\", error);\n\n    throw error; // Rethrow so Bree can handle it properly\n  }\n};\n\n// Cross-platform module detection fix for Bree compatibility\n// Windows: process.argv[1] uses backslashes, import.meta.url uses forward slashes\n// Linux/Mac: both use forward slashes, so this normalization is safe\nconst normalizedArgv1 = process.argv[1].replace(/\\\\/g, '/');\nconst fileUrl = normalizedArgv1.startsWith('/') ? \n  `file://${normalizedArgv1}` :  // Unix: file:// + /path = file:///path\n  `file:///${normalizedArgv1}`;  // Windows: file:/// + C:/path = file:///C:/path\nconst isMainModule = import.meta.url === fileUrl;\n\nif (isMainModule) {\n  // This is called when Bree runs this file as a worker\n  try {\n    await main();\n  } catch {\n    process.exitCode = 1; // prefer exitCode so stdout/stderr can flush\n  }\n}\n\nexport default main;\n"],"names":[],"mappings":";;;AAMA,OAAO,QAAQ,QAAQ,IAAI,aAAa;AAExC,MAAM,OAAO,YAAY;AACvB,MAAI;AACF,WAAO,KAAK,gCAAgC;AAC5C,WAAO,KAAK,+CAA+C;AAG3D,UAAM,gBAAgB,QAAQ,IAAI;AAElC,QAAI,CAAC,eAAe;AAClB,YAAM,IAAI,MAAM,sDAAsD;AAAA,IACxE;AAGA,UAAM,YAAY,MAAM,wBAAwB,aAAa;AAE7D,UAAM,UAAU,UAAA;AAChB,UAAM,UAAU,mBAAA;AAEhB,WAAO,KAAK,gDAAgD;AAAA,EAC9D,SAAS,OAAO;AACd,UAAM,eAAe;AAAA,MACnB,SAAS,iBAAiB,QAAQ,MAAM,UAAU,OAAO,KAAK;AAAA,MAC9D,OAAO,iBAAiB,QAAQ,MAAM,QAAQ;AAAA,MAC9C,MAAM,iBAAiB,QAAQ,MAAM,OAAO;AAAA,MAC5C,GAAI,SAAS,OAAO,UAAU,WAAW,QAAQ,CAAA;AAAA;AAAA,IAAC;AAEpD,WAAO,MAAM,wCAAwC;AAAA,MACnD,OAAO;AAAA,MACP,eAAe,QAAQ,IAAI;AAAA,IAAA,CAC5B;AAGD,YAAQ,MAAM,qBAAqB,KAAK;AAExC,UAAM;AAAA,EACR;AACF;AAKA,MAAM,kBAAkB,QAAQ,KAAK,CAAC,EAAE,QAAQ,OAAO,GAAG;AAC1D,MAAM,UAAU,gBAAgB,WAAW,GAAG,IAC5C,UAAU,eAAe;AAAA;AAAA,EACzB,WAAW,eAAe;AAAA;AAC5B,MAAM,eAAe,YAAY,QAAQ;AAEzC,IAAI,cAAc;AAEhB,MAAI;AACF,UAAM,KAAA;AAAA,EACR,QAAQ;AACN,YAAQ,WAAW;AAAA,EACrB;AACF;"}
+{"version":3,"file":"to-erp.js","sources":["../../../../src/services/data-sync-service/jobs/to-erp.ts"],"sourcesContent":["import \"dotenv/config\";\n\nimport logger from \"../../../services/reporting-service/logger\";\nimport { SQLiteCoordinator } from \"../../sqlite-service\";\nimport { createConnectorFromPath } from \"../../../utils/connector-factory\";\n\n// Configure the logger with the correct log level\nlogger.level = process.env.LOG_LEVEL || \"info\";\n\nconst main = async () => {\n  try {\n    logger.info('Worker for job \"to-erp\" online');\n    logger.info(\"==========Starting to-erp job cycle==========\");\n\n    // Get the connector path from the environment variable\n    const connectorPath = process.env.CONNECTOR_PATH;\n\n    if (!connectorPath) {\n      throw new Error(\"Connector path not provided in environment variables\");\n    }\n\n    // Create a new connector instance for this job\n    const connector = await createConnectorFromPath(connectorPath);\n\n    await connector.syncToERP();\n    await connector.syncToERPCompleted();\n\n    logger.info(\"==========Completed to-erp job cycle==========\");\n  } catch (error) {\n    const errorDetails = {\n      message: error instanceof Error ? error.message : String(error),\n      stack: error instanceof Error ? error.stack : undefined,\n      name: error instanceof Error ? error.name : undefined,\n      ...(error && typeof error === \"object\" ? error : {}), // Include all enumerable properties if it's an object\n    };\n    logger.error('Worker for job \"to-erp\" had an error', {\n      error: errorDetails,\n      connectorPath: process.env.CONNECTOR_PATH,\n    });\n\n    // Also log to console for immediate visibility\n    console.error(\"to-erp job error:\", error);\n\n    throw error; // Rethrow so Bree can handle it properly\n  }\n};\n\n// Cross-platform module detection fix for Bree compatibility\n// Windows: process.argv[1] uses backslashes, import.meta.url uses forward slashes\n// Linux/Mac: both use forward slashes, so this normalization is safe\nconst normalizedArgv1 = process.argv[1].replace(/\\\\/g, '/');\nconst fileUrl = normalizedArgv1.startsWith('/') ? \n  `file://${normalizedArgv1}` :  // Unix: file:// + /path = file:///path\n  `file:///${normalizedArgv1}`;  // Windows: file:/// + C:/path = file:///C:/path\nconst isMainModule = import.meta.url === fileUrl;\n\nif (isMainModule) {\n  // This is called when Bree runs this file as a worker\n  try {\n    await main();\n  } catch {\n    process.exitCode = 1; // prefer exitCode so stdout/stderr can flush\n  }\n}\n\nexport default main;\n"],"names":[],"mappings":";;;AAOA,OAAO,QAAQ,QAAQ,IAAI,aAAa;AAExC,MAAM,OAAO,YAAY;AACvB,MAAI;AACF,WAAO,KAAK,gCAAgC;AAC5C,WAAO,KAAK,+CAA+C;AAG3D,UAAM,gBAAgB,QAAQ,IAAI;AAElC,QAAI,CAAC,eAAe;AAClB,YAAM,IAAI,MAAM,sDAAsD;AAAA,IACxE;AAGA,UAAM,YAAY,MAAM,wBAAwB,aAAa;AAE7D,UAAM,UAAU,UAAA;AAChB,UAAM,UAAU,mBAAA;AAEhB,WAAO,KAAK,gDAAgD;AAAA,EAC9D,SAAS,OAAO;AACd,UAAM,eAAe;AAAA,MACnB,SAAS,iBAAiB,QAAQ,MAAM,UAAU,OAAO,KAAK;AAAA,MAC9D,OAAO,iBAAiB,QAAQ,MAAM,QAAQ;AAAA,MAC9C,MAAM,iBAAiB,QAAQ,MAAM,OAAO;AAAA,MAC5C,GAAI,SAAS,OAAO,UAAU,WAAW,QAAQ,CAAA;AAAA;AAAA,IAAC;AAEpD,WAAO,MAAM,wCAAwC;AAAA,MACnD,OAAO;AAAA,MACP,eAAe,QAAQ,IAAI;AAAA,IAAA,CAC5B;AAGD,YAAQ,MAAM,qBAAqB,KAAK;AAExC,UAAM;AAAA,EACR;AACF;AAKA,MAAM,kBAAkB,QAAQ,KAAK,CAAC,EAAE,QAAQ,OAAO,GAAG;AAC1D,MAAM,UAAU,gBAAgB,WAAW,GAAG,IAC5C,UAAU,eAAe;AAAA;AAAA,EACzB,WAAW,eAAe;AAAA;AAC5B,MAAM,eAAe,YAAY,QAAQ;AAEzC,IAAI,cAAc;AAEhB,MAAI;AACF,UAAM,KAAA;AAAA,EACR,QAAQ;AACN,YAAQ,WAAW;AAAA,EACrB;AACF;"}

package/dist/services/psql-erp-service/psql-service.d.ts

@@ -1,4 +1,3 @@
-import odbc from "odbc";
 import { PsqlConfiguration } from "./configuration";
 import { ERPResponse } from "../../types/erp-types";
 type PagingParams = {
@@ -6,10 +5,8 @@ type PagingParams = {
     offset?: number;
 };
 export declare class PsqlService {
-    private connection;
     private config;
     constructor(config: PsqlConfiguration);
-    dispose(): Promise<void>;
     /**
      * Build PSQL ODBC connection string
      * CRITICAL: ServerName must use IP.PORT format (e.g., 10.4.0.11.1583)
@@ -17,7 +14,7 @@ export declare class PsqlService {
     private buildConnectionString;
     /**
      * Execute a query and return the results
-     * Interface matches SqlServerService for consistency
+     * Creates a fresh connection for each query to avoid handle corruption
      *
      * @param query The SQL query to execute
      * @param params Query parameters (currently unused for PSQL read operations)
@@ -25,25 +22,15 @@ export declare class PsqlService {
      * @returns The entities fetched from the database, along with paging information
      */
     executePreparedStatement(query: string, params?: Record<string, string>, paging?: PagingParams): Promise<ERPResponse | undefined>;
-    /**
-     * Opens a connection to PSQL database
-     * Caches the connection so that it can be reused.
-     * On failure to connect, throws
-     */
-    openConnection(): Promise<odbc.Connection>;
     /**
      * Transform ODBC result set to array of Record<string, string> instances.
      * IMPORTANT: PSQL CHAR fields are often padded with spaces - we trim them
-     *
-     * @param recordset Result set from ODBC query
-     * @returns array of Record<string, string> instances
      */
     static recordsetToRecords(recordset: any[]): Record<string, string>[];
     /**
      * Handle ODBC errors and provide meaningful messages
      */
     private handleOdbcError;
-    private closeConnection;
 }
 export {};
 //# sourceMappingURL=psql-service.d.ts.map

package/dist/services/psql-erp-service/psql-service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"psql-service.d.ts","sourceRoot":"","sources":["../../../src/services/psql-erp-service/psql-service.ts"],"names":[],"mappings":"AAAA,OAAO,IAAI,MAAM,MAAM,CAAC;AACxB,OAAO,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAC;AACpD,OAAO,EAAE,WAAW,EAAE,MAAM,uBAAuB,CAAC;AAIpD,KAAK,YAAY,GAAG;IAClB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB,CAAC;AAEF,qBAAa,WAAW;IACtB,OAAO,CAAC,UAAU,CAAgC;IAClD,OAAO,CAAC,MAAM,CAAoB;gBAEtB,MAAM,EAAE,iBAAiB;IAI/B,OAAO;IAIb;;;OAGG;IACH,OAAO,CAAC,qBAAqB;IAgB7B;;;;;;;;OAQG;IACU,wBAAwB,CACnC,KAAK,EAAE,MAAM,EACb,MAAM,GAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAM,EACnC,MAAM,CAAC,EAAE,YAAY,GACpB,OAAO,CAAC,WAAW,GAAG,SAAS,CAAC;IAsDnC;;;;OAIG;IACG,cAAc,IAAI,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC;IA4BhD;;;;;;OAMG;WACW,kBAAkB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAAE;IAmB5E;;OAEG;IACH,OAAO,CAAC,eAAe;YA6BT,eAAe;CAa9B"}
+{"version":3,"file":"psql-service.d.ts","sourceRoot":"","sources":["../../../src/services/psql-erp-service/psql-service.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAC;AACpD,OAAO,EAAE,WAAW,EAAE,MAAM,uBAAuB,CAAC;AAIpD,KAAK,YAAY,GAAG;IAClB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB,CAAC;AAEF,qBAAa,WAAW;IACtB,OAAO,CAAC,MAAM,CAAoB;gBAEtB,MAAM,EAAE,iBAAiB;IASrC;;;OAGG;IACH,OAAO,CAAC,qBAAqB;IAe7B;;;;;;;;OAQG;IACU,wBAAwB,CACnC,KAAK,EAAE,MAAM,EACb,MAAM,GAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAM,EACnC,MAAM,CAAC,EAAE,YAAY,GACpB,OAAO,CAAC,WAAW,GAAG,SAAS,CAAC;IAqEnC;;;OAGG;WACW,kBAAkB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAAE;IAkB5E;;OAEG;IACH,OAAO,CAAC,eAAe;CA4BxB"}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@machinemetrics/mm-erp-sdk",
   "description": "A library for syncing data between MachineMetrics and ERP systems",
-  "version": "0.1.6-beta.1",
+  "version": "0.1.7-beta.0",
   "license": "MIT",
   "author": "machinemetrics",
   "main": "dist/mm-erp-sdk.js",

package/src/services/data-sync-service/jobs/to-erp.ts

@@ -1,6 +1,7 @@
 import "dotenv/config";
 
-import logger from "../../reporting-service/logger";
+import logger from "../../../services/reporting-service/logger";
+import { SQLiteCoordinator } from "../../sqlite-service";
 import { createConnectorFromPath } from "../../../utils/connector-factory";
 
 // Configure the logger with the correct log level

package/src/services/psql-erp-service/psql-service.ts

@@ -10,23 +10,22 @@ type PagingParams = {
 };
 
 export class PsqlService {
-  private connection: odbc.Connection | null = null;
   private config: PsqlConfiguration;
 
   constructor(config: PsqlConfiguration) {
     this.config = config;
   }
 
-  async dispose() {
-    await this.closeConnection();
-  }
+  // REMOVED: dispose() method - not needed anymore
+  // REMOVED: connection property - not needed anymore
+  // REMOVED: openConnection() method - not needed anymore
+  // REMOVED: closeConnection() method - not needed anymore
 
   /**
    * Build PSQL ODBC connection string
    * CRITICAL: ServerName must use IP.PORT format (e.g., 10.4.0.11.1583)
    */
   private buildConnectionString(): string {
-    // PSQL requires ServerName in format IP.PORT (not IP:PORT)
     const serverName = `${this.config.host}.${this.config.port}`;
 
     return (
@@ -43,7 +42,7 @@ export class PsqlService {
 
   /**
    * Execute a query and return the results
-   * Interface matches SqlServerService for consistency
+   * Creates a fresh connection for each query to avoid handle corruption
    *
    * @param query The SQL query to execute
    * @param params Query parameters (currently unused for PSQL read operations)
@@ -55,12 +54,14 @@ export class PsqlService {
     params: Record<string, string> = {},
     paging?: PagingParams
   ): Promise<ERPResponse | undefined> {
-    const connection = await this.openConnection();
+    let connection: odbc.Connection | null = null;
 
-    let records;
     try {
-      // For Phase 1 (read-only), we execute queries directly
-      // Phase 2 will add proper parameter binding for INSERT/UPDATE/DELETE
+      // Create fresh connection for THIS query only
+      const connStr = this.buildConnectionString();
+      logger.debug("Creating fresh PSQL connection for query");
+      connection = await odbc.connect(connStr);
+
       if (Object.keys(params).length > 0) {
         logger.warn(
           "PsqlService: Query parameters provided but parameter binding not yet implemented. " +
@@ -68,85 +69,62 @@ export class PsqlService {
         );
       }
 
-      records = await connection.query(query);
+      const records = await connection.query(query);
+      const allRecords = PsqlService.recordsetToRecords(records);
+      const rowsFetched = allRecords.length;
+
+      // Apply paging if requested
+      const pagedData =
+        paging?.offset !== undefined || paging?.limit !== undefined
+          ? allRecords.slice(
+              paging.offset || 0,
+              (paging.offset || 0) + (paging.limit || allRecords.length)
+            )
+          : allRecords;
+
+      return {
+        data: pagedData,
+        paging: {
+          count: rowsFetched,
+          limit: paging?.limit || 0,
+          offset: paging?.offset || 0,
+          nextPage:
+            paging?.limit && (paging.offset || 0) + paging.limit < rowsFetched
+              ? String((paging.offset || 0) + paging.limit)
+              : undefined,
+          previousPage: paging?.offset
+            ? String(Math.max(0, (paging.offset || 0) - (paging.limit || 10)))
+            : undefined,
+        },
+      };
     } catch (error) {
       const errorInfo = error as OdbcErrorResponse;
       logger.error("Error fetching data from PSQL", {
         error: errorInfo.message,
         odbcErrors: errorInfo.odbcErrors,
+        query: query.substring(0, 200), // Log first 200 chars of query
       });
 
       throw this.handleOdbcError(errorInfo);
-    }
-
-    const allRecords = PsqlService.recordsetToRecords(records);
-    const rowsFetched = allRecords.length;
-
-    // Apply paging if requested
-    const pagedData =
-      paging?.offset !== undefined || paging?.limit !== undefined
-        ? allRecords.slice(
-            paging.offset || 0,
-            (paging.offset || 0) + (paging.limit || allRecords.length)
-          )
-        : allRecords;
-
-    return {
-      data: pagedData,
-      paging: {
-        count: rowsFetched,
-        limit: paging?.limit || 0,
-        offset: paging?.offset || 0,
-        nextPage:
-          paging?.limit && (paging.offset || 0) + paging.limit < rowsFetched
-            ? String((paging.offset || 0) + paging.limit)
-            : undefined,
-        previousPage: paging?.offset
-          ? String(Math.max(0, (paging.offset || 0) - (paging.limit || 10)))
-          : undefined,
-      },
-    };
-  }
-
-  /**
-   * Opens a connection to PSQL database
-   * Caches the connection so that it can be reused.
-   * On failure to connect, throws
-   */
-  async openConnection(): Promise<odbc.Connection> {
-    // If we have a connection, reuse it
-    // Note: ODBC connections don't have a .connected property like SQL Server
-    // We'll keep it simple and reuse if not null
-    if (this.connection) {
-      logger.debug("Reusing existing PSQL connection");
-      return this.connection;
-    }
-
-    try {
-      const connStr = this.buildConnectionString();
-      logger.info("Opening new PSQL connection");
-      logger.debug(
-        "Connection string (password hidden):",
-        connStr.replace(/PWD=[^;]+/, "PWD=***")
-      );
-
-      this.connection = await odbc.connect(connStr);
-      logger.info("Successfully connected to PSQL database");
-      return this.connection;
-    } catch (error) {
-      logger.error("PsqlService>>openConnection>> Connection failed", {
-        error,
-      });
-      throw this.handleOdbcError(error as OdbcErrorResponse);
+    } finally {
+      // CRITICAL: Always close connection, even on error
+      if (connection) {
+        try {
+          await connection.close();
+          logger.debug("PSQL connection closed successfully");
+        } catch (err) {
+          // Don't throw on close errors, just log
+          logger.warn("Error closing PSQL connection (non-fatal)", {
+            error: err,
+          });
+        }
+      }
     }
   }
 
   /**
    * Transform ODBC result set to array of Record<string, string> instances.
    * IMPORTANT: PSQL CHAR fields are often padded with spaces - we trim them
-   *
-   * @param recordset Result set from ODBC query
-   * @returns array of Record<string, string> instances
    */
   public static recordsetToRecords(recordset: any[]): Record<string, string>[] {
     if (!Array.isArray(recordset)) {
@@ -157,7 +135,6 @@ export class PsqlService {
       const transformedRow: Record<string, string> = {};
       Object.keys(row).forEach((key) => {
         const value = row[key];
-        // Convert to string and trim (PSQL CHAR fields have trailing spaces)
         transformedRow[key] =
           value !== null && value !== undefined ? String(value).trim() : "";
       });
@@ -198,18 +175,4 @@ export class PsqlService {
         return new Error(`PSQL error (${errorCode || "unknown"}): ${message}`);
     }
   }
-
-  private async closeConnection(): Promise<void> {
-    if (this.connection) {
-      logger.info("Closing PSQL connection");
-      try {
-        await this.connection.close();
-      } catch (error) {
-        logger.error("PsqlService::closeConnection: Error closing connection", {
-          error,
-        });
-      }
-      this.connection = null;
-    }
-  }
 }