@machinemetrics/mm-erp-sdk 0.1.1-beta.5 → 0.1.2

package/src/services/data-sync-service/jobs/clean-up-expired-cache.ts

@@ -25,13 +25,16 @@ const main = async () => {
     throw error; // Rethrow so Bree can handle it properly
   } finally {
     await cacheManager.destroy();
+    logger.info(`==========Completed clean-up-expired-cache job==========`);
   }
 };
 
 // For Bree compatibility - check if this is running as a worker
 if (require.main === module) {
   // This is called when Bree runs this file as a worker
-  main();
+  (async () => {
+    await main();
+  })();
 } else {
   // Export for potential testing or direct usage
   module.exports = main;

package/src/services/data-sync-service/jobs/from-erp.ts

@@ -47,9 +47,11 @@ const isMainModule = import.meta.url === `file://${process.argv[1]}`;
 
 if (isMainModule) {
   // This is called when Bree runs this file as a worker
-  main().catch(() => {
-    process.exit(1);
-  });
+  try {
+    await main();
+  } catch {
+    process.exitCode = 1; // prefer exitCode so stdout/stderr can flush
+  }
 }
 
 export default main;

package/src/services/data-sync-service/jobs/retry-failed-labor-tickets.ts

@@ -37,7 +37,9 @@ const main = async () => {
 // For Bree compatibility - check if this is running as a worker
 if (require.main === module) {
   // This is called when Bree runs this file as a worker
-  main();
+  main().catch(() => {
+    process.exitCode = 1;
+  });
 } else {
   // Export for potential testing or direct usage
   module.exports = main;

package/src/services/data-sync-service/jobs/run-migrations.ts

@@ -18,4 +18,10 @@ export default async function runMigrations() {
   }
 }
 
-runMigrations();
+const isMainModule = import.meta.url === `file://${process.argv[1]}`;
+if (isMainModule) {
+  runMigrations().catch(err => {
+    logger.error("Top-level error running migrations:", err);
+    process.exit(1);
+  });
+}

package/src/services/erp-api-services/graphql/graphql-service.ts

@@ -113,4 +113,12 @@ export class GraphQLService {
       ErrorHandler.handle(error);
     }
   }
+
+  /**
+   * Cleanup all HTTP connections and resources
+   * Call this when the service is no longer needed
+   */
+  async destroy(): Promise<void> {
+    await this.client.destroy();
+  }
 }

package/src/services/erp-api-services/rest/rest-api-service.ts

@@ -209,4 +209,12 @@ export class RestAPIService {
       ErrorHandler.handle(error);
     }
   }
+
+  /**
+   * Cleanup all HTTP connections and resources
+   * Call this when the service is no longer needed
+   */
+  async destroy(): Promise<void> {
+    await this.client.destroy();
+  }
 }

package/src/services/mm-api-service/mm-api-service.ts

@@ -59,9 +59,8 @@ export class MMApiClient {
       [UrlBase.ErpApiSvcBase]: CoreConfiguration.inst().mmERPSvcApiBaseUrl,
       [UrlBase.ApiBase]: CoreConfiguration.inst().mmApiBaseUrl,
     };
-    // We'll create HTTP clients as needed for different base URLs
     this.api = HTTPClientFactory.getInstance({
-      baseUrl: "", // We'll set the full URL in each request
+      baseUrl: CoreConfiguration.inst().mmERPSvcApiBaseUrl,
       retryAttempts: CoreConfiguration.inst().mmApiRetryAttempts,
     });
   }
@@ -681,5 +680,15 @@ export class MMApiClient {
     )) as unknown as MMGraphQLResourceResponse;
   }
 
+  /**
+   * Cleanup all HTTP connections and resources
+   * Call this when the service is no longer needed
+   */
+  async destroy(): Promise<void> {
+    await this.api.destroy();
+    // Note: MMTokenManager doesn't currently need explicit cleanup
+    // but if it ever acquires resources that need cleanup, add it here
+  }
+
   //#endregion public methods
 }

package/src/services/mm-api-service/types/mm-response-interfaces.ts

@@ -69,6 +69,9 @@ export interface MM200LaborTicketResponse extends MMApiBaseResponse {
  * Response for partial success of non-labor ticket entities
  * Used for: Resources, Parts, PartOperations, WorkOrders, WorkOrderOperations, Persons, Reasons
  *
+ * Note: The API may internally re-batch client submissions. Each error represents
+ * a batch that failed due to at least one record having issues.
+ *
  * Example response:
  * {
  *   message: "WorkOrderOperations partially imported with errors",
@@ -82,7 +85,7 @@ export interface MM200LaborTicketResponse extends MMApiBaseResponse {
  *         batch: 1,
  *         path: "$.selectionSet.insertErpWorkOrderOperations.args.objects",
  *         code: "constraint-violation",
- *         batchData: [{ workOrderId: "24-0196", ... }]
+ *         batchData: [{ workOrderId: "24-0196", ... }] // All records in failing batch
  *       }
  *     ]
  *   },
@@ -101,7 +104,7 @@ export interface MM207NonLaborTicketResponse extends MMApiBaseResponse {
       batch: number;
       path: string;
       code: string;
-      batchData: Record<string, unknown>[];
+      batchData: Record<string, unknown>[]; // Complete batch data where at least one record failed
     }>;
   };
 }
@@ -109,6 +112,9 @@ export interface MM207NonLaborTicketResponse extends MMApiBaseResponse {
 /**
  * Response for partial success of labor tickets
  *
+ * Note: The API may internally re-batch client submissions. Each error represents
+ * a batch that failed due to at least one record having issues.
+ *
  * Example response:
  * {
  *   message: "Labor tickets partially imported with errors",
@@ -121,7 +127,7 @@ export interface MM207NonLaborTicketResponse extends MMApiBaseResponse {
  *         batch: 1,
  *         path: "$.selectionSet.updateErpLaborTickets.args.objects",
  *         code: "constraint-violation",
- *         batchData: [{ workOrderId: "24-0196", ... }]
+ *         batchData: [{ workOrderId: "24-0196", ... }] // All records in failing batch
  *       }
  *     ],
  *     insertErrors: [
@@ -130,7 +136,7 @@ export interface MM207NonLaborTicketResponse extends MMApiBaseResponse {
  *         batch: 1,
  *         path: "$.selectionSet.insertErpLaborTickets.args.objects",
  *         code: "constraint-violation",
- *         batchData: [{ workOrderId: "24-0191", ... }]
+ *         batchData: [{ workOrderId: "24-0191", ... }] // All records in failing batch
  *       }
  *     ]
  *   },
@@ -148,14 +154,14 @@ export interface MM207LaborTicketResponse extends MMApiBaseResponse {
       batch: number;
       path: string;
       code: string;
-      batchData: Record<string, unknown>[];
+      batchData: Record<string, unknown>[]; // Complete batch data where at least one record failed
     }>;
     insertErrors: Array<{
       message: string;
       batch: number;
       path: string;
       code: string;
-      batchData: Record<string, unknown>[];
+      batchData: Record<string, unknown>[]; // Complete batch data where at least one record failed
     }>;
   };
 }
@@ -168,8 +174,13 @@ export interface MM207LaborTicketResponse extends MMApiBaseResponse {
  * Exception structure for complete failure of non-labor ticket entities
  * Used for: Resources, Parts, PartOperations, WorkOrders, WorkOrderOperations, Persons, Reasons
  *
+ * IMPORTANT: This structure only applies to 500 errors caused by data validation failures.
+ * Other 500 errors (network issues, server errors, etc.) may have different structures.
  * This structure appears in caught exceptions when the API returns 500 status
- * for validation issues that contain structured error information.
+ * specifically for validation issues that contain structured error information.
+ *
+ * Note: The API may internally re-batch client submissions. Each error represents
+ * a batch that failed due to at least one record having issues.
  *
  * Example exception.data structure:
  * {
@@ -181,7 +192,7 @@ export interface MM207LaborTicketResponse extends MMApiBaseResponse {
  *     errors: [
  *       {
  *         message: "GraphQL Error: Foreign key violation...",
- *         batchData: [{ workOrderId: "24-0196", ... }]
+ *         batchData: [{ workOrderId: "24-0196", ... }] // All records in failing batch
  *       }
  *     ]
  *   }
@@ -197,7 +208,7 @@ export interface MM500NonLaborTicketException {
       affectedRows: number;
       errors: Array<{
         message: string;
-        batchData: Record<string, unknown>[];
+        batchData: Record<string, unknown>[]; // Complete batch data where at least one record failed
       }>;
     };
   };
@@ -206,8 +217,13 @@ export interface MM500NonLaborTicketException {
 /**
  * Exception structure for complete failure of labor tickets
  *
+ * IMPORTANT: This structure only applies to 500 errors caused by data validation failures.
+ * Other 500 errors (network issues, server errors, etc.) may have different structures.
  * This structure appears in caught exceptions when the API returns 500 status
- * for validation issues that contain structured error information.
+ * specifically for validation issues that contain structured error information.
+ *
+ * Note: The API may internally re-batch client submissions. Each error represents
+ * a batch that failed due to at least one record having issues.
  *
  * Example exception.data structure:
  * {
@@ -216,13 +232,13 @@ export interface MM500NonLaborTicketException {
  *     updateErrors: [
  *       {
  *         message: "GraphQL Error: Foreign key violation...",
- *         batchData: [{ workOrderId: "24-0196", ... }]
+ *         batchData: [{ workOrderId: "24-0196", ... }] // All records in failing batch
  *       }
  *     ],
  *     insertErrors: [
  *       {
  *         message: "GraphQL Error: Foreign key violation...",
- *         batchData: [{ workOrderId: "24-0191", ... }]
+ *         batchData: [{ workOrderId: "24-0191", ... }] // All records in failing batch
  *       }
  *     ]
  *   }
@@ -235,11 +251,11 @@ export interface MM500LaborTicketException {
     message: {
       updateErrors: Array<{
         message: string;
-        batchData: Record<string, unknown>[];
+        batchData: Record<string, unknown>[]; // Complete batch data where at least one record failed
       }>;
       insertErrors: Array<{
         message: string;
-        batchData: Record<string, unknown>[];
+        batchData: Record<string, unknown>[]; // Complete batch data where at least one record failed
       }>;
     };
   };

package/src/services/sql-server-erp-service/internal/sql-server-config.ts

@@ -4,6 +4,7 @@ export const SQLServerConfigSchema = z.object({
   password: z.string().nonempty("Password is required."),
   database: z.string().nonempty("Database name is required."),
   server: z.string().nonempty("Server is required."),
+  port: z.coerce.number().int().positive("Port must be a positive integer.").default(1433),
   connectionTimeout: z.coerce
     .number()
     .int()

package/src/utils/http-client.ts

@@ -31,7 +31,8 @@ export interface HTTPResponse<T = unknown> {
 
 export interface HTTPClient {
   request<T = unknown>(config: HTTPRequestConfig): Promise<HTTPResponse<T>>;
-  handleError(error: unknown, requestConfig?: HTTPRequestConfig): HTTPError;
+  handleError(error: unknown): HTTPError;
+  destroy(): Promise<void>;
 }
 
 export interface HTTPClientConfig {
@@ -50,8 +51,12 @@ export class HTTPClientFactory {
 }
 
 class AxiosClient implements HTTPClient {
-  private client: AxiosInstance;
+  private client: AxiosInstance | null = null;
   private retryAttempts: number;
+  private isDestroyed: boolean = false;
+  private inFlightControllers: Set<AbortController> = new Set();
+  private pendingTimeouts: Set<ReturnType<typeof setTimeout>> = new Set();
+  private pendingSleepResolvers: Set<() => void> = new Set();
 
   /**
    * Note regarding baseURL, from https://github.com/axios/axios
@@ -69,15 +74,39 @@ class AxiosClient implements HTTPClient {
     this.retryAttempts = retryAttempts;
   }
 
+  private sleep(ms: number): Promise<void> {
+    return new Promise<void>((resolve) => {
+      if (this.isDestroyed) {
+        resolve();
+        return;
+      }
+      const timeout = setTimeout(() => {
+        this.pendingTimeouts.delete(timeout);
+        this.pendingSleepResolvers.delete(resolve);
+        resolve();
+      }, ms);
+      this.pendingTimeouts.add(timeout);
+      this.pendingSleepResolvers.add(resolve);
+    });
+  }
+
   async request<T = unknown>(
     config: HTTPRequestConfig
   ): Promise<HTTPResponse<T>> {
+    if (this.isDestroyed || !this.client) {
+      throw new HTTPError("HTTP client has been destroyed", 500);
+    }
+
+    const controller = new AbortController();
+    this.inFlightControllers.add(controller);
+
     const axiosConfig: AxiosRequestConfig = {
       method: config.method,
       url: config.url,
       headers: config.headers,
       data: config.data,
       params: config.params,
+      signal: controller.signal,
     };
 
     logger.info("HTTP request starting", { 
@@ -95,47 +124,64 @@ class AxiosClient implements HTTPClient {
     console.log("method:", config.method);
 
     let lastError: unknown;
-    for (let attempt = 0; attempt <= this.retryAttempts; attempt++) {
-      try {
-        logger.info(`HTTP request attempt ${attempt + 1}/${this.retryAttempts + 1}`);
-        const response = await this.client.request<T>(axiosConfig);
-        logger.info("HTTP request succeeded", { status: response.status });
-        return {
-          data: response.data,
-          status: response.status,
-          headers: response.headers as Record<string, string>,
-        };
-      } catch (error) {
-        lastError = error;
-        logger.info(`HTTP request attempt ${attempt + 1} failed`, {
-          errorType: typeof error,
-          errorConstructor: error?.constructor?.name,
-          isAxiosError: error instanceof AxiosError,
-          message: error instanceof Error ? error.message : String(error),
-          code: (error as any)?.code,
-          status: (error as any)?.response?.status
-        });
+    try {
+      for (let attempt = 0; attempt <= this.retryAttempts; attempt++) {
+        try {
+          logger.info(`HTTP request attempt ${attempt + 1}/${this.retryAttempts + 1}`);
+          const response = await this.client.request<T>(axiosConfig);
+          logger.info("HTTP request succeeded", { status: response.status });
+          return {
+            data: response.data,
+            status: response.status,
+            headers: response.headers as Record<string, string>,
+          };
+        } catch (error) {
+          lastError = error;
+
+          const isAxiosErr = error instanceof AxiosError;
+          const code = isAxiosErr ? error.code : undefined;
+          const status = isAxiosErr ? error.response?.status : undefined;
+          const errorConstructor = error instanceof Error ? error.constructor.name : undefined;
+          const message = error instanceof Error ? error.message : String(error);
         
-        // Don't retry on 4xx errors (client errors)
-        if (
-          error instanceof AxiosError &&
-          error.response?.status &&
-          error.response.status >= 400 &&
-          error.response.status < 500
-        ) {
-          logger.info("Not retrying due to 4xx client error");
-          break;
-        }
-        // If this was the last attempt, don't wait
-        if (attempt < this.retryAttempts) {
-          const waitTime = Math.pow(2, attempt) * 1000;
-          logger.info(`Waiting ${waitTime}ms before retry`);
-          // Exponential backoff: wait 2^attempt * 1000ms
-          await new Promise((resolve) =>
-            setTimeout(resolve, Math.pow(2, attempt) * 1000)
-          );
+          logger.info(`HTTP request attempt ${attempt + 1} failed`, {
+            errorType: typeof error,
+            errorConstructor,
+            isAxiosError: isAxiosErr,
+            message,
+            code,
+            status,
+          });
+
+          // Don't retry on 4xx errors (client errors)
+          if (
+            error instanceof AxiosError &&
+            error.response?.status &&
+            error.response.status >= 400 &&
+            error.response.status < 500
+          ) {
+            logger.info("Not retrying due to 4xx client error");
+            break;
+          }
+
+          // Don't retry canceled/aborted requests
+          if (error instanceof AxiosError && error.code === "ERR_CANCELED") {
+            break;
+          }
+
+          // If this was the last attempt, don't wait
+          if (attempt < this.retryAttempts) {
+            const waitTime = Math.pow(2, attempt) * 1000;
+            logger.info(`Waiting ${waitTime}ms before retry`);
+            await this.sleep(waitTime);
+            if (this.isDestroyed) {
+              throw new HTTPError("HTTP client has been destroyed", 500);
+            }
+          }
         }
       }
+    } finally {
+      this.inFlightControllers.delete(controller);
     }
     logger.info("HTTP request failed after all retries, throwing error");
     throw this.handleError(lastError, config);
@@ -144,7 +190,7 @@ class AxiosClient implements HTTPClient {
   handleError(error: unknown, requestConfig?: HTTPRequestConfig): HTTPError {
     if (error instanceof AxiosError) {
       // Build a more descriptive error message that includes the URL and method
-      const baseUrl = this.client.defaults.baseURL || "";
+      const baseUrl = this.client?.defaults.baseURL || "";
       const fullUrl = requestConfig
         ? `${baseUrl}${requestConfig.url}`
         : "Unknown URL";
@@ -164,4 +210,28 @@ class AxiosClient implements HTTPClient {
       500
     );
   }
+
+  async destroy(): Promise<void> {
+    if (this.isDestroyed) return;
+    this.isDestroyed = true;
+
+    // Abort any in-flight requests
+    for (const c of this.inFlightControllers) {
+      try { c.abort(); } catch { /* ignore: abort may throw in some environments */ }
+    }
+    this.inFlightControllers.clear();
+
+    // Cancel any pending retry waits
+    for (const t of this.pendingTimeouts) {
+      clearTimeout(t);
+    }
+    this.pendingTimeouts.clear();
+    for (const resolve of this.pendingSleepResolvers) {
+      try { resolve(); } catch { /* ignore: resolver threw; cleanup proceeds */ }
+    }
+    this.pendingSleepResolvers.clear();
+
+    // Drop axios instance reference
+    this.client = null;
+  }
 }

package/src/utils/index.ts

@@ -37,6 +37,12 @@ export type {
 } from "./standard-process-drivers/";
 export { getCachedTimezoneOffset } from "./local-data-store/jobs-shared-data";
 
+// Local data store
+export {
+  getInitialLoadComplete,
+  setInitialLoadComplete,
+} from "./local-data-store/jobs-shared-data";
+
 /**
  * ERP API utilities
  */

package/src/utils/standard-process-drivers/error-processor.ts

@@ -22,17 +22,17 @@ export class ErrorProcessor {
     entityType: ERPObjType,
     batchErrors: Array<{
       message: string;
-      errorEntities: IToRESTApiObject[];
+      affectedEntities: IToRESTApiObject[]; // All entities in the failing batch
     }>
   ): Set<string> {
     const failedKeySet = new Set<string>();
 
     batchErrors.forEach((batchError) => {
-      batchError.errorEntities.forEach((errorEntity) => {
+      batchError.affectedEntities.forEach((affectedEntity) => {
         try {
           const primaryKey = EntityTransformer.extractPrimaryKey(
             entityType,
-            errorEntity
+            affectedEntity
           );
           failedKeySet.add(primaryKey);
         } catch (error) {
@@ -93,7 +93,7 @@ export class ErrorProcessor {
     toProcess: IToRESTApiObject[],
     batchErrors: Array<{
       message: string;
-      errorEntities: IToRESTApiObject[];
+      affectedEntities: IToRESTApiObject[]; // All entities in the failing batch
     }>,
     batchCacheManager: BatchCacheManager
   ): Promise<void> {
@@ -120,7 +120,7 @@ export class ErrorProcessor {
   /**
    * Extracts error count and batch errors from MM API response for partial failures (HTTP 207)
    * This supports all entities, including the slightly different format for labor tickets.
-   * In case of labor tickets, the updateErrors and insertErrors arrays are combined into errorEntities.
+   * In case of labor tickets, the updateErrors and insertErrors arrays are combined into affectedEntities.
    * @param mmApiResponse The full MM API response object
    * @param entityType The type of entity being processed (determines response structure)
    * @returns Object containing errorCount and batchErrors
@@ -133,7 +133,7 @@ export class ErrorProcessor {
     errorCount: number;
     batchErrors: Array<{
       message: string;
-      errorEntities: IToRESTApiObject[];
+      affectedEntities: IToRESTApiObject[]; // All entities in the failing batch
     }>;
   } {
     // Type the data property with the expected structure for HTTP 207 responses
@@ -221,13 +221,13 @@ export class ErrorProcessor {
 
           return {
             message: error.message,
-            errorEntities: typedErrorEntities,
+            affectedEntities: typedErrorEntities,
           };
         }
       );
 
     const errorCount = batchErrors.reduce((total: number, batchError) => {
-      return total + batchError.errorEntities.length;
+      return total + batchError.affectedEntities.length;
     }, 0);
 
     return {
@@ -250,7 +250,7 @@ export class ErrorProcessor {
     errorCount: number;
     batchErrors: Array<{
       message: string;
-      errorEntities: IToRESTApiObject[];
+      affectedEntities: IToRESTApiObject[]; // All entities in the failing batch
     }>;
   } | null {
     try {
@@ -383,12 +383,12 @@ export class ErrorProcessor {
           return {
             message:
               typeof err?.message === "string" ? err.message : "Unknown error",
-            errorEntities: typedErrorEntities,
+            affectedEntities: typedErrorEntities,
           };
         });
 
       const errorCount = batchErrors.reduce((total: number, batchError) => {
-        return total + batchError.errorEntities.length;
+        return total + batchError.affectedEntities.length;
       }, 0);
 
       logger.info("writeEntitiesToMM: Extracted 500 error details", {

package/src/utils/standard-process-drivers/standard-process-drivers.ts

@@ -30,7 +30,7 @@ export class MMBatchValidationError extends Error {
   public readonly httpStatus: number;
   public readonly batchErrors: Array<{
     message: string;
-    errorEntities: IToRESTApiObject[];
+    affectedEntities: IToRESTApiObject[]; // All entities in the failing batch
   }>;
 
   constructor(options: {
@@ -42,7 +42,7 @@ export class MMBatchValidationError extends Error {
     httpStatus: number;
     batchErrors: Array<{
       message: string;
-      errorEntities: IToRESTApiObject[];
+      affectedEntities: IToRESTApiObject[]; // All entities in the failing batch
     }>;
   }) {
     super(options.message);
@@ -113,9 +113,10 @@ export class StandardProcessDrivers {
    *
    * } catch (error) {
    *   if (error instanceof MMBatchValidationError) {
-   *     // HTTP 207 - Partial success with some validation errors
-   *     // HTTP 500 - A specific type of which represent complete failure due to validation issues;
+   *     // HTTP 207 - Partial success with some batches failing due to validation errors
+   *     // HTTP 500 - A specific type representing complete failure due to validation issues;
    *     //            other 500 types represent failure due to other issues and are not converted to MMBatchValidationError
+   *     // Note: Each batch error contains ALL entities from the failing batch, not necessarily just the failed ones
    *
    *     console.log(`⚠️  Batch processing completed with errors (HTTP ${error.httpStatus})`);
    *     console.log(`📊 Metrics: ${error.upsertedEntities} upserted, ${error.localDedupeCount} locally deduplicated, ${error.apiDedupeCount} API deduplicated`);
@@ -124,18 +125,18 @@ export class StandardProcessDrivers {
    *     // Process specific batch errors for retry or logging
    *     error.batchErrors.forEach((batchError, index) => {
    *       console.log(`Batch ${index + 1} error: ${batchError.message}`);
-   *       console.log(`Affected entities:`, batchError.errorEntities);
+   *       console.log(`All entities in failing batch:`, batchError.affectedEntities);
    *
-   *       // Example: Queue failed entities for retry
-   *       await queueForRetry(batchError.errorEntities);
+   *       // Example: Queue entire failing batch for retry (contains both successful and failed entities)
+   *       await queueForRetry(batchError.affectedEntities);
    *     });
    *
    *     // Decide whether to continue or halt based on httpStatus
    *     if (error.httpStatus === 207) {
-   *       // Partial success - some records processed successfully
+   *       // Partial success - some batches processed successfully, others failed
    *       console.log('⚠️  Continuing with partial success');
    *     } else if (error.httpStatus === 500) {
-   *       // Complete failure - no records processed
+   *       // Complete failure - all batches failed due to validation issues
    *       console.log('🛑 Complete failure - no records processed');
    *       throw error; // Re-throw if complete failure should halt the process
    *     }