@m8i-51/shoal 0.1.12 → 0.1.14

package/framework/__tests__/coverage.test.ts

@@ -259,7 +259,7 @@ describe("computeWeightedSummary", () => {
 
     // updateCoverage が 31件目を追加してトリムすることを確認
     vi.mocked(fs.existsSync).mockReturnValue(true);
-    vi.mocked(fs.readFileSync).mockReturnValue(JSON.stringify({ entries }) as unknown as Buffer);
+    vi.mocked(fs.readFileSync).mockReturnValue(JSON.stringify({ entries }));
 
     // computeWeightedSummary は entries をそのまま使うだけなので、
     // 35件あってもエラーにならないことを確認

package/framework/__tests__/report.test.ts

@@ -47,12 +47,14 @@ function makeAgentLog(overrides: Partial<AgentLog> = {}): AgentLog {
   return {
     agentId: "a1",
     agentName: "Alice",
-    agentType: "browser",
+    agentType: "explorer",
     role: "tester",
     status: "completed",
     iterations: 3,
+    actions: [],
     issuesPosted: [],
     regressionChecks: [],
+    error: null,
     startedAt: "2026-04-27T00:01:00.000Z",
     completedAt: "2026-04-27T00:03:00.000Z",
     ...overrides,
@@ -172,7 +174,7 @@ describe("generateReport", () => {
 
   it("regression checks がある場合 Progress セクションが表示される", () => {
     const checks: RegressionCheck[] = [
-      { issueNumber: 42, issueTitle: "Login button broken", status: "fixed" },
+      { issueNumber: 42, issueTitle: "Login button broken", status: "fixed", note: "", regressionUrl: null },
     ];
     const agent = makeAgentLog({ agentType: "regression", regressionChecks: checks });
     generateReport(makeRunLog({ agents: [agent] }), [], emptyTriage, makeProductSpec(), [], new Map());
@@ -185,7 +187,7 @@ describe("generateReport", () => {
 
   it("regression が再発した場合 regressed バッジが表示される", () => {
     const checks: RegressionCheck[] = [
-      { issueNumber: 7, issueTitle: "Crash on submit", status: "regressed" },
+      { issueNumber: 7, issueTitle: "Crash on submit", status: "regressed", note: "", regressionUrl: null },
     ];
     const agent = makeAgentLog({ agentType: "regression", regressionChecks: checks });
     generateReport(makeRunLog({ agents: [agent] }), [], emptyTriage, makeProductSpec(), [], new Map());

package/framework/account-manager.ts

@@ -287,7 +287,8 @@ If user management is not accessible from this account, or the app has no role s
           }
 
           case "navigate": {
-            const { path: navPath } = toolUse.input as { path: string };
+            const { path: navPath } = toolUse.input as { path?: string };
+            if (!navPath) { resultText = "navigate: missing path"; break; }
             await saveSnapshotBeforeAction(page, observation);
             await page.goto(`${baseUrl}${navPath}`, { waitUntil: "networkidle" });
             await page.waitForTimeout(500);
@@ -297,7 +298,8 @@ If user management is not accessible from this account, or the app has no role s
           }
 
           case "click": {
-            const { description } = toolUse.input as { description: string };
+            const { description } = toolUse.input as { description?: string };
+            if (!description) { resultText = "click: missing description"; break; }
             await saveSnapshotBeforeAction(page, observation);
             const escaped = description.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
             let clicked = false;
@@ -316,7 +318,8 @@ If user management is not accessible from this account, or the app has no role s
           }
 
           case "fill": {
-            const { label, value } = toolUse.input as { label: string; value: string };
+            const { label, value } = toolUse.input as { label?: string; value?: string };
+            if (!label || value === undefined) { resultText = "fill: missing label or value"; break; }
             await saveSnapshotBeforeAction(page, observation);
             const byLabel = page.getByLabel(new RegExp(label, "i"));
             const byPlaceholder = page.getByPlaceholder(new RegExp(label, "i"));
@@ -340,7 +343,8 @@ If user management is not accessible from this account, or the app has no role s
           }
 
           case "save_account": {
-            const { email, password, role } = toolUse.input as { email: string; password: string; role: string };
+            const { email, password, role } = toolUse.input as { email?: string; password?: string; role?: string };
+            if (!email || !password || !role) { resultText = "save_account: missing required fields"; break; }
             savedAccounts.push({ email, password, role });
             console.log(`  [account-manager] saved account: ${email} (role: ${role})`);
             resultText = `Account saved: ${email} (${role})`;
@@ -348,7 +352,8 @@ If user management is not accessible from this account, or the app has no role s
           }
 
           case "post_finding": {
-            const { title, body } = toolUse.input as { title: string; body: string };
+            const { title, body } = toolUse.input as { title?: string; body?: string };
+            if (!title || !body) { resultText = "post_finding: missing title or body"; break; }
             saveFinding({
               id: `acct_${Date.now()}`,
               runId,

package/framework/llm-client.ts

@@ -157,11 +157,11 @@ function fromOpenAIResponse(response: OpenAI.ChatCompletion): Message {
   const content: ContentBlock[] = [];
 
   if (choice.message.content) {
-    content.push({ type: "text", text: choice.message.content });
+    content.push({ type: "text", text: choice.message.content } as ContentBlock);
   }
 
   if (choice.message.tool_calls) {
-    for (const tc of choice.message.tool_calls) {
+    for (const tc of choice.message.tool_calls.filter((t) => t.type === "function")) {
       let input: Record<string, unknown> = {};
       try {
         input = JSON.parse(tc.function.arguments);
@@ -172,7 +172,7 @@ function fromOpenAIResponse(response: OpenAI.ChatCompletion): Message {
         id: tc.id,
         name: tc.function.name,
         input,
-      });
+      } as ContentBlock);
     }
   }
 
@@ -392,7 +392,7 @@ function fromCodexResponse(response: Record<string, unknown>): Message {
     if (i.type === "message") {
       for (const block of (i.content as unknown[]) ?? []) {
         const b = block as Record<string, unknown>;
-        if (b.type === "output_text") content.push({ type: "text", text: b.text as string });
+        if (b.type === "output_text") content.push({ type: "text", text: b.text as string } as ContentBlock);
       }
     } else if (i.type === "function_call") {
       hasToolUse = true;
@@ -403,7 +403,7 @@ function fromCodexResponse(response: Record<string, unknown>): Message {
         id: (i.call_id ?? i.id) as string,
         name: i.name as string,
         input,
-      });
+      } as ContentBlock);
     }
   }
 

package/framework/product-discovery.ts

@@ -253,7 +253,8 @@ Guidelines for output_spec:
       let result: string;
 
       if (toolUse.name === "navigate_and_read") {
-        const { path } = toolUse.input as { path: string };
+        const { path } = toolUse.input as { path?: string };
+        if (!path) { result = "navigate_and_read: missing path"; toolResults.push({ type: "tool_result", tool_use_id: toolUse.id, content: result }); continue; }
         try {
           await page.goto(`${baseUrl}${path}`, { waitUntil: "networkidle", timeout: 10000 });
           await page.waitForTimeout(500);
@@ -268,7 +269,8 @@ Guidelines for output_spec:
         }
 
       } else if (toolUse.name === "fetch_url") {
-        const { url } = toolUse.input as { url: string };
+        const { url } = toolUse.input as { url?: string };
+        if (!url) { result = "fetch_url: missing url"; toolResults.push({ type: "tool_result", tool_use_id: toolUse.id, content: result }); continue; }
         try {
           const res = await fetch(url, { signal: AbortSignal.timeout(8000) });
           const text = await res.text();

package/framework/triage.ts

@@ -143,11 +143,16 @@ Organize feedback collected by multiple agents and post it as issue tickets.
 
       } else if (toolUse.name === "create_issue") {
         const { title, body, category, merged_finding_ids } = toolUse.input as {
-          title: string;
-          body: string;
-          category: string;
-          merged_finding_ids: string[] | undefined;
+          title?: string;
+          body?: string;
+          category?: string;
+          merged_finding_ids?: string[];
         };
+        if (!title || !body || !category) {
+          result = { error: "create_issue: missing required fields" };
+          toolResults.push({ type: "tool_result", tool_use_id: toolUse.id, content: JSON.stringify(result) });
+          continue;
+        }
         const mergedIds = merged_finding_ids ?? [];
         if (mergedIds.length === 0) {
           result = { error: "merged_finding_ids must contain at least one ID" };
@@ -175,7 +180,12 @@ Organize feedback collected by multiple agents and post it as issue tickets.
         }
 
       } else if (toolUse.name === "skip_finding") {
-        const { finding_id, reason } = toolUse.input as { finding_id: string; reason: string };
+        const { finding_id, reason } = toolUse.input as { finding_id?: string; reason?: string };
+        if (!finding_id) {
+          result = { error: "skip_finding: missing finding_id" };
+          toolResults.push({ type: "tool_result", tool_use_id: toolUse.id, content: JSON.stringify(result) });
+          continue;
+        }
         pendingIds.delete(finding_id);
         skippedIds.push(finding_id);
         skipped++;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m8i-51/shoal",
-  "version": "0.1.12",
+  "version": "0.1.14",
   "type": "module",
   "description": "Multi-agent web exploration framework — finds bugs, UX issues, and missing features by running AI agents against your app",
   "repository": {