@m13v/s4l 1.7.6-rc.25 → 1.7.6-rc.26

package/mcp/dist/version.json

@@ -1,4 +1,4 @@
 {
-  "version": "1.7.6-rc.25",
-  "installedAt": "2026-07-17T23:05:36.790Z"
+  "version": "1.7.6-rc.26",
+  "installedAt": "2026-07-17T23:10:55.248Z"
 }

package/mcp/manifest.json

@@ -2,7 +2,7 @@
   "dxt_version": "0.1",
   "name": "social-autoposter",
   "display_name": "S4L",
-  "version": "1.7.6-rc.25",
+  "version": "1.7.6-rc.26",
   "description": "Draft, review, approve, and autopilot X/Twitter posts.",
   "long_description": "## **⚠️ The disclaimer above is generic Claude boilerplate.** Anthropic shows the same warning on every plugin regardless of what it does; any plugin has the same level of access as any app you download from the internet.\n\nS4L is an open source product developed by Mediar.ai Incorporated, a VC-backed San Francisco-based startup.\n\nTo get started:\n\n1\\. Copy this prompt: **Set me up on S4L plugin end to end**\n\n2\\. Quit with CMD+Q, reopen Claude, paste into a new chat.\n\nWhat happens next:\n\n* About every 5 minutes S4L scans X for posts that match your topics and drafts replies in your voice.\n* Drafts show up as review cards, usually the first within a few minutes. Nothing is posted automatically; you approve each one.\n* Posting autopilot stays off until you explicitly turn it on.",
   "author": {

package/mcp/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l-mcp",
-  "version": "1.7.6-rc.25",
+  "version": "1.7.6-rc.26",
   "private": true,
   "description": "Desktop MCP client for social-autoposter (X/Twitter rail): manual draft/review/approve loop, autopilot control, and stats. Thin wrapper over the existing pipeline scripts.",
   "license": "MIT",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l",
-  "version": "1.7.6-rc.25",
+  "version": "1.7.6-rc.26",
   "description": "Automated social posting pipeline for Reddit, X/Twitter, LinkedIn, and Moltbook. Install as a Claude Code agent skill.",
   "bin": {
     "social-autoposter": "bin/cli.js",

package/scripts/post_github.py

@@ -710,6 +710,14 @@ def parse_claude_json(output):
 # ---------- Posting + logging ------------------------------------------------
 
 def post_comment(owner, repo, number, body):
+    # Identity gate (mirrors twitter_browser.reply_to_tweet /
+    # reddit_browser.post_comment): the gh CLI would happily post as whatever
+    # account it is authed as, but with no resolved accounts.github.username
+    # the row's attribution is blank and self-filtering breaks. Refuse loudly.
+    from account_resolver import resolve as _resolve_gh
+    if not _resolve_gh("github"):
+        return False, ("no_account_configured (set accounts.github.username in "
+                       "config.json or AUTOPOSTER_GITHUB_USERNAME)")
     try:
         out = subprocess.check_output(
             ["gh", "issue", "comment", str(number), "-R", f"{owner}/{repo}", "--body", body],

package/scripts/reddit_browser.py

@@ -536,6 +536,15 @@ def post_comment(thread_url, text):
 
     Returns: {"ok": true, "permalink": "..."} or {"ok": false, "error": "..."}
     """
+    # Identity gate (mirrors twitter_browser.reply_to_tweet): refuse to post
+    # when no Reddit account resolves. Without it we cannot attribute the
+    # comment or find our own permalink afterwards, and posting with a blank
+    # identity pollutes the shared DB. Fail fast and loud instead.
+    if not OUR_USERNAME:
+        print("[reddit_browser] no reddit account configured "
+              "(accounts.reddit.username / reddit_account.username / "
+              "AUTOPOSTER_REDDIT_USERNAME); refusing to post.", file=sys.stderr)
+        return {"ok": False, "error": "no_account_configured"}
     from playwright.sync_api import sync_playwright
 
     with sync_playwright() as p:
@@ -837,6 +846,13 @@ def reply_to_comment(comment_permalink, text, dm_id=None):
     Returns: {"ok": true, "applied_campaigns": [...], "reply_text": "..."}
               or {"ok": false, "error": "..."}
     """
+    # Identity gate (mirrors twitter_browser.reply_to_tweet): no resolved
+    # account -> no post. See post_comment above for the rationale.
+    if not OUR_USERNAME:
+        print("[reddit_browser] no reddit account configured "
+              "(accounts.reddit.username / reddit_account.username / "
+              "AUTOPOSTER_REDDIT_USERNAME); refusing to post.", file=sys.stderr)
+        return {"ok": False, "error": "no_account_configured"}
     from playwright.sync_api import sync_playwright
 
     # Pre-flight: refuse to attempt a reply in a sub we know we can't comment in.

package/scripts/release-mcpb.sh

@@ -204,6 +204,15 @@ say "Regression gate: scripts/test_no_silent_fallbacks.py"
 python3 "$REPO_ROOT/scripts/test_no_silent_fallbacks.py" \
   || die "regression gate failed -- a silent-fallback / bare-python3 issue was (re)introduced. See output above; do not release until it's clean or the finding is reviewed into the test's ALLOWLIST with a reason."
 
+# Cross-language lockstep gate: candidate_state (s4l_state.py vs index.ts) and
+# the short-link fallback host constant (dm_short_links.py vs bin/server.js)
+# are duplicated across runtimes BY NECESSITY; this test is what turns their
+# "keep in lockstep" comments into an enforced invariant. Divergence here has
+# shipped real incidents (post_failed drain asymmetry 2026-07-17).
+say "Regression gate: scripts/test_cross_language_parity.py"
+python3 "$REPO_ROOT/scripts/test_cross_language_parity.py" \
+  || die "cross-language parity gate failed -- a TS/Python lockstep pair diverged (candidate_state or fallback host). Fix BOTH sides before releasing."
+
 # ---- 1. Resolve + WRITE version into the repo-root package.json -------------
 # The repo-root package.json is the SINGLE source of truth: `npm pack` reads it
 # to build the embedded pipeline.tgz, so the bundle shell and the bundled

package/scripts/score_twitter_candidates.py

@@ -538,8 +538,10 @@ def upsert_candidates(tweets, config, batch_id=None, attempts_map=None, scored_s
             # composite unique gives each account its own candidate row.
             # Without this, account A's 'posted' status on tweet X would lock
             # account B out of the same tweet (ON CONFLICT preserved 'posted').
-            # Defaults server-side to 'm13v_' if omitted; new callers should
-            # always pass it explicitly.
+            # If omitted, the server stamps a per-install 'unknown:<install_id>'
+            # sentinel (2026-07-18; it used to default to 'm13v_', silently
+            # impersonating the repo owner). Callers should always pass it —
+            # _resolve_twitter_handle() covers env -> config -> cookie mirror.
             "our_account": _twitter_handle or "",
             # Repost provenance (2026-06-04). The scan derives the author from
             # the status URL, so author_handle/tweet_url already point at the

package/scripts/test_cross_language_parity.py

@@ -0,0 +1,185 @@
+#!/usr/bin/env python3
+"""Cross-language parity gate: constants and state machines that exist in BOTH
+the Python pipeline and the Node/TS MCP server MUST agree. Each pair here has a
+"keep in lockstep" comment at both definition sites; this test is what makes
+that comment enforceable instead of aspirational. Runs in the release gate
+(scripts/release-mcpb.sh) right after test_no_silent_fallbacks.py.
+
+Checks:
+  1. candidate_state parity — mcp/menubar/s4l_state.py::candidate_state (the
+     Python authority) vs mcp/src/index.ts::candidateState (the TS mirror),
+     evaluated with node on a fixture matrix covering every flag combination
+     and truthiness edge case. Divergence between hand-rolled raw-flag filters
+     and the state machine has produced real incidents (post_failed drain
+     asymmetry 2026-07-17, get_stats lane blindness); this pins the two
+     implementations to each other.
+  2. Short-link fallback host parity — scripts/dm_short_links.py
+     DEFAULT_FALLBACK_HOST vs bin/server.js SHORT_LINK_FALLBACK_HOST (CLAUDE.md:
+     "keep them in sync").
+
+Zero third-party deps. Needs `node` on PATH (the release script already does).
+Exit 0 = all pass; exit 1 with a FAIL line = parity broken, do not release.
+"""
+
+import json
+import os
+import re
+import shutil
+import subprocess
+import sys
+
+REPO_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+FAILURES = []
+
+
+def report(ok, label, detail=""):
+    tag = "PASS" if ok else "FAIL"
+    line = f"{tag}  {label}"
+    if detail:
+        line += f"  -- {detail}"
+    print(line)
+    if not ok:
+        FAILURES.append(label)
+
+
+# ---------------------------------------------------------------------------
+# 1. candidate_state parity
+# ---------------------------------------------------------------------------
+
+# Every flag combination that matters, plus truthiness edge cases: Python uses
+# `is True` for posted/terminal/approved but bare truthiness for post_failed;
+# TS uses `=== true` and bare truthiness respectively. The matrix locks in that
+# BOTH implementations make the same call on non-boolean junk values too.
+FIXTURES = [
+    {},
+    {"approved": True},
+    {"approved": True, "post_failed": True},
+    {"post_failed": True},
+    {"post_failed": "posted_0"},
+    {"post_failed": ""},
+    {"post_failed": 0},
+    {"terminal": True},
+    {"terminal": True, "approved": True},
+    {"terminal": True, "post_failed": True, "approved": True},
+    {"posted": True},
+    {"posted": True, "approved": True},
+    {"posted": True, "terminal": True, "post_failed": True, "approved": True},
+    {"posted": False, "terminal": False, "approved": False},
+    {"posted": "yes"},
+    {"approved": 1},
+    {"terminal": 1, "approved": True},
+    {"posted": 1, "terminal": True},
+]
+
+
+def python_states():
+    sys.path.insert(0, os.path.join(REPO_ROOT, "mcp", "menubar"))
+    from s4l_state import candidate_state  # noqa: E402
+    return [candidate_state(dict(c)) for c in FIXTURES]
+
+
+def extract_ts_function():
+    """Pull the candidateState function body out of mcp/src/index.ts and strip
+    the TS type annotations so plain node can evaluate it. Brittle on purpose:
+    if the signature changes shape, this test fails loudly and must be updated
+    alongside it -- which is exactly the review moment the lockstep needs."""
+    src_path = os.path.join(REPO_ROOT, "mcp", "src", "index.ts")
+    with open(src_path, encoding="utf-8") as f:
+        src = f.read()
+    m = re.search(r"function candidateState\(c: PlanCandidate\): CandidateState \{", src)
+    if not m:
+        return None
+    start = m.start()
+    depth = 0
+    for i in range(m.end() - 1, len(src)):
+        if src[i] == "{":
+            depth += 1
+        elif src[i] == "}":
+            depth -= 1
+            if depth == 0:
+                body = src[start : i + 1]
+                return body.replace(
+                    "function candidateState(c: PlanCandidate): CandidateState {",
+                    "function candidateState(c) {",
+                )
+    return None
+
+
+def ts_states(fn_src):
+    node = shutil.which("node") or "/opt/homebrew/bin/node"
+    script = (
+        fn_src
+        + "\nconst fixtures = JSON.parse(require('fs').readFileSync(0, 'utf-8'));"
+        + "\nprocess.stdout.write(JSON.stringify(fixtures.map((c) => candidateState(c))));"
+    )
+    out = subprocess.run(
+        [node, "-e", script],
+        input=json.dumps(FIXTURES),
+        capture_output=True,
+        text=True,
+        timeout=30,
+    )
+    if out.returncode != 0:
+        raise RuntimeError(f"node evaluation failed: {out.stderr.strip()[:300]}")
+    return json.loads(out.stdout)
+
+
+def check_candidate_state():
+    fn_src = extract_ts_function()
+    if fn_src is None:
+        report(False, "candidateState() found in mcp/src/index.ts",
+               "signature changed? update extract_ts_function() alongside it")
+        return
+    try:
+        ts = ts_states(fn_src)
+    except Exception as e:
+        report(False, "candidateState() evaluates under node", str(e)[:200])
+        return
+    py = python_states()
+    for c, p, t in zip(FIXTURES, py, ts):
+        report(p == t, f"candidate_state parity for {json.dumps(c)}",
+               f"py={p} ts={t}")
+
+
+# ---------------------------------------------------------------------------
+# 2. short-link fallback host parity
+# ---------------------------------------------------------------------------
+
+def check_fallback_host():
+    py_path = os.path.join(REPO_ROOT, "scripts", "dm_short_links.py")
+    js_path = os.path.join(REPO_ROOT, "bin", "server.js")
+    py_m = js_m = None
+    try:
+        with open(py_path, encoding="utf-8") as f:
+            py_m = re.search(r"^DEFAULT_FALLBACK_HOST\s*=\s*['\"]([^'\"]+)['\"]",
+                             f.read(), re.M)
+        with open(js_path, encoding="utf-8") as f:
+            js_m = re.search(r"^const SHORT_LINK_FALLBACK_HOST\s*=\s*['\"]([^'\"]+)['\"]",
+                             f.read(), re.M)
+    except OSError as e:
+        report(False, "fallback-host files readable", str(e))
+        return
+    if not py_m or not js_m:
+        report(False, "fallback-host constants found",
+               f"py={'ok' if py_m else 'MISSING'} js={'ok' if js_m else 'MISSING'}")
+        return
+    report(py_m.group(1) == js_m.group(1),
+           "DEFAULT_FALLBACK_HOST (py) == SHORT_LINK_FALLBACK_HOST (js)",
+           f"py={py_m.group(1)} js={js_m.group(1)}")
+
+
+def main():
+    print("-- check 1: candidate_state TS/Python parity --")
+    check_candidate_state()
+    print("-- check 2: short-link fallback host parity --")
+    check_fallback_host()
+    print()
+    if FAILURES:
+        print(f"{len(FAILURES)} FAILURE(S)")
+        return 1
+    print("ALL PASS")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())