@m13v/s4l 1.7.5-rc.19 → 1.7.5-rc.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (46) hide show
  1. package/mcp/dist/index.js +79 -571
  2. package/mcp/dist/panel.html +3 -2
  3. package/mcp/dist/setup.js +5 -142
  4. package/mcp/dist/telemetry.js +3 -13
  5. package/mcp/dist/version.json +2 -2
  6. package/mcp/manifest.json +1 -1
  7. package/mcp/menubar/s4l_card.py +6 -32
  8. package/mcp/menubar/s4l_menubar.py +111 -42
  9. package/mcp/menubar/s4l_state.py +187 -54
  10. package/mcp/package.json +1 -1
  11. package/mcp/shared/onboarding-ledger.cjs +4 -63
  12. package/package.json +1 -1
  13. package/scripts/autopilot_stall_watch.py +6 -3
  14. package/scripts/claude_job.py +0 -21
  15. package/scripts/counterparty_history.py +6 -44
  16. package/scripts/engage_github.py +3 -7
  17. package/scripts/engage_reddit.py +3 -9
  18. package/scripts/learned_preferences.py +14 -37
  19. package/scripts/memory_snapshot.py +0 -45
  20. package/scripts/merge_review_queue.py +3 -67
  21. package/scripts/post_reddit.py +24 -289
  22. package/scripts/reddit_browser.py +63 -62
  23. package/scripts/reddit_browser_fetch.py +0 -32
  24. package/scripts/release-mcpb.sh +0 -17
  25. package/scripts/scan_twitter_thread_followups.py +1 -7
  26. package/scripts/schedule_state.py +1 -1
  27. package/scripts/snapshot.py +4 -96
  28. package/scripts/stats.py +13 -37
  29. package/scripts/twitter_browser.py +342 -183
  30. package/scripts/twitter_scan.py +11 -19
  31. package/scripts/watchdog_hung_runs.py +9 -15
  32. package/skill/lib/linkedin-backend.sh +161 -61
  33. package/skill/lib/reddit-backend.sh +125 -39
  34. package/skill/lib/twitter-backend.sh +273 -51
  35. package/skill/lock.sh +0 -57
  36. package/skill/run-reddit-search-launchd.sh +1 -4
  37. package/skill/run-reddit-search.sh +2 -51
  38. package/skill/run-twitter-cycle.sh +21 -44
  39. package/mcp/dist/redditAuth.js +0 -115
  40. package/scripts/browser_mutex.py +0 -316
  41. package/scripts/config.py +0 -118
  42. package/scripts/engagement_signal_feedback.py +0 -256
  43. package/scripts/setup_reddit_auth.py +0 -925
  44. package/scripts/test_no_silent_fallbacks.py +0 -281
  45. package/scripts/trigger_promo_lane_test.sh +0 -91
  46. package/skill/lib/harness-common.sh +0 -344
package/mcp/dist/index.js CHANGED
@@ -20,9 +20,8 @@ import os from "node:os";
20
20
  import path from "node:path";
21
21
  import fs from "node:fs";
22
22
  import { repoDir, runPython, run, readPlan, writePlan, planPath, } from "./repo.js";
23
- import { applySetup, resolveProject, hasReadyProject, personaReady, listManagedProjectStatus, listProjectSettings, ensureShortLinksDefault, ensurePersonaProject, findPersonaProject, REQUIRED_FIELDS, RECOMMENDED_FIELDS, configPath, ensureConfigInStateDir, normalizeStringList, recordRedditAccount, } from "./setup.js";
23
+ import { applySetup, resolveProject, hasReadyProject, personaReady, listManagedProjectStatus, listProjectSettings, ensureShortLinksDefault, ensurePersonaProject, findPersonaProject, REQUIRED_FIELDS, RECOMMENDED_FIELDS, configPath, normalizeStringList, } from "./setup.js";
24
24
  import { xStatus, xConnect, xDetectSources, xScanProfile, summarizeXAuth } from "./twitterAuth.js";
25
- import { redditStatus, redditConnect, redditDetectSources, summarizeRedditAuth, } from "./redditAuth.js";
26
25
  import { startProvisioning, isProvisioning, readProgress, runtimeReady, readRuntime, resolvePython, resolveChrome, ensureMenubar, menubarRunning, clearMenubarStop, ensurePipelineCurrent, ensureRuntimeProvisioned, ensureHarnessPatched, retryProvisionIfStalled, } from "./runtime.js";
27
26
  import { blockOnboardingMilestone, completeOnboardingMilestone, ensureDoctorPhase, onboardingLedger, onboardingSnapshot, recordOnboardingAttempt, runDoctorPhase, } from "./onboarding.js";
28
27
  import { VERSION, versionStatus, latestPublishedVersion } from "./version.js";
@@ -69,17 +68,6 @@ const PHASE1_TASK_ID = "saps-phase1-query"; // legacy (was: "twitter-query" only
69
68
  const PHASE2B_TASK_ID = "saps-phase2b-draft"; // legacy (was: "twitter-prep" only)
70
69
  const TWITTER_AUTOPILOT_LABEL = "com.m13v.social-twitter-cycle";
71
70
  const TWITTER_AUTOPILOT_PLIST = path.join(os.homedir(), "Library", "LaunchAgents", `${TWITTER_AUTOPILOT_LABEL}.plist`);
72
- // Reddit discovery kicker (optional platform, 2026-07-15). Runs the SAME
73
- // launchd label the operator Mac has used by hand since May
74
- // (com.m13v.social-reddit-search) so there is one canonical name fleet-wide,
75
- // but ensureRedditKickerInstalled() refuses to touch a plist whose program
76
- // path points outside the managed package (the operator's hand-built plist
77
- // stays untouched). Installed only when reddit is connected AND a project is
78
- // configured; never part of onboarding completion.
79
- const REDDIT_SEARCH_LABEL = "com.m13v.social-reddit-search";
80
- const REDDIT_SEARCH_PLIST = path.join(os.homedir(), "Library", "LaunchAgents", `${REDDIT_SEARCH_LABEL}.plist`);
81
- const REDDIT_SEARCH_INTERVAL_SECS = 900;
82
- const REDDIT_CDP_URL_DEFAULT = "http://127.0.0.1:9557";
83
71
  // Self-healing reaper for leaked Claude agent-mode worker sessions. The queue
84
72
  // autopilot fires two scheduled tasks every ~1 min; each fire spawns a ~200 MB
85
73
  // `claude` agent-mode session that finishes its one queue turn but never exits
@@ -325,9 +313,7 @@ const server = new McpServer({
325
313
  "can run them hands-free on autopilot.\n\n" +
326
314
  "ONBOARDING IS A TERMINAL GOAL. When the user asks to set up, install, configure, or onboard " +
327
315
  "social-autoposter, keep taking the next safe action until the owned runtime is ready, a " +
328
- "project is fully configured with seeded search topics, AT LEAST ONE platform is connected " +
329
- "(X with its real handle is the DEFAULT first suggestion; Reddit via connect_reddit counts " +
330
- "equally if the user prefers it or X connection fails or is skipped), AND " +
316
+ "project is fully configured with seeded search topics, X is connected with its real handle, AND " +
331
317
  "the two draft-autopilot scheduled tasks have been created via queue_setup and are firing " +
332
318
  "(see SCHEDULE THE AUTOPILOT below). The owned runtime (private Python + Chromium) provisions " +
333
319
  "ITSELF automatically on boot — you do NOT install it. Just poll runtime action:'status' until it " +
@@ -343,8 +329,7 @@ const server = new McpServer({
343
329
  "or pause for an unavoidable interactive login or OS prompt. Never auto-POST during setup. " +
344
330
  "DO schedule the draft autopilot as the final step (once running it only queues drafts for " +
345
331
  "approval, it never posts on its own). When setup reaches done (" +
346
- "runtime ready, a project configured with seeded topics, at least one platform connected, and the " +
347
- "two scheduled tasks " +
332
+ "runtime ready, a project configured with seeded topics, X connected, and the two scheduled tasks " +
348
333
  "created and firing), call the `dashboard` tool so the user " +
349
334
  "sees the finished setup rendered, then give " +
350
335
  "the completion summary.\n\n" +
@@ -366,16 +351,6 @@ const server = new McpServer({
366
351
  "old 'social-autoposter-autopilot' task — it is deprecated. Do NOT ask the user to review drafts " +
367
352
  "or pause for input mid-onboarding; once the tasks are created and firing, setup is done. If the " +
368
353
  "host exposes no create_scheduled_task tool, tell the user the autopilot couldn't be scheduled here.\n\n" +
369
- "REDDIT IS AN EQUAL, OPTIONAL PLATFORM. Setup is complete with AT LEAST ONE platform " +
370
- "connected: X-only, Reddit-only, or both. X stays the default first suggestion; offer Reddit " +
371
- "as an add-on after X setup completes, OR standalone when the user prefers Reddit or X " +
372
- "connection fails or is skipped. `project_config` action:'connect_reddit' imports the user's " +
373
- "reddit.com session into the autoposter's managed reddit browser, same confirm-first flow and " +
374
- "keychain heads-up as connect_x. Once connected, reddit discovery and drafting run on the same " +
375
- "draft-only queue and review cards as X; nothing posts without approval. If the result carries " +
376
- "a `warning` (fresh or low-karma account), relay it so the user knows AutoMod may gate early " +
377
- "replies. Never make Reddit a requirement, and never nag a happily X-only (or reddit-only) " +
378
- "user about the other platform.\n\n" +
379
354
  "BE PROACTIVE ABOUT MARKETING MOMENTS. Whenever the user ships, finishes, merges, or releases " +
380
355
  "something worth talking about in this session (a new feature, a launch, a long-awaited fix, a " +
381
356
  "milestone), don't wait to be asked: point it out to the user — the draft autopilot runs " +
@@ -852,7 +827,7 @@ function readConfiguredTwitterHandle() {
852
827
  if (env)
853
828
  return env;
854
829
  try {
855
- const cfg = JSON.parse(fs.readFileSync(configPath(), "utf-8"));
830
+ const cfg = JSON.parse(fs.readFileSync(path.join(repoDir(), "config.json"), "utf-8"));
856
831
  const h = cfg?.accounts?.twitter?.handle;
857
832
  const s = (typeof h === "string" ? h : "").trim().replace(/^@/, "");
858
833
  return s || null;
@@ -910,57 +885,6 @@ function expiredStampOverridable(c) {
910
885
  c.posted !== true &&
911
886
  c.discard_reason === "backend_status_expired");
912
887
  }
913
- function mergeApprovedStampsIntoStore(batchId, plan, stamped) {
914
- // Merge posted/terminal stamps into a FRESH read of the store instead of
915
- // rewriting the whole plan from the copy taken minutes ago. The old
916
- // whole-file write was last-writer-wins: while a batch posted, the menubar
917
- // (decision re-stamps) and any peer drain also wrote the store, and
918
- // whichever run finished last erased the others' posted flags (2026-07-06:
919
- // card 344877 posted at 00:29Z ended `posted=None,
920
- // terminal=duplicate_thread_pre_post` after a later run's stale write).
921
- // Merge rules: `posted` is sticky and wins over terminal; `terminal` never
922
- // overwrites a fresh `posted=true`. Fallback: candidates without a
923
- // candidate_id can't be matched into the fresh copy, so keep the legacy
924
- // whole-plan write for those older plans.
925
- try {
926
- const mergeable = stamped.every((c) => c.candidate_id !== undefined && c.candidate_id !== null);
927
- const fresh = mergeable ? readPlan(batchId) : null;
928
- if (fresh && Array.isArray(fresh.candidates)) {
929
- const freshById = new Map();
930
- fresh.candidates.forEach((c) => {
931
- if (c.candidate_id !== undefined && c.candidate_id !== null)
932
- freshById.set(String(c.candidate_id), c);
933
- });
934
- for (const c of stamped) {
935
- const f = freshById.get(String(c.candidate_id));
936
- if (!f)
937
- continue;
938
- if (c.posted === true) {
939
- f.posted = true;
940
- f.terminal = false;
941
- if (c.our_url)
942
- f.our_url = c.our_url;
943
- }
944
- else if (c.terminal === true && f.posted !== true) {
945
- f.terminal = true;
946
- f.terminal_reason = c.terminal_reason;
947
- }
948
- }
949
- writePlan(batchId, fresh);
950
- }
951
- else {
952
- writePlan(batchId, plan);
953
- }
954
- }
955
- catch {
956
- try {
957
- writePlan(batchId, plan);
958
- }
959
- catch {
960
- /* best effort */
961
- }
962
- }
963
- }
964
888
  async function postApproved(batchId, plan) {
965
889
  // Drain serialization (2026-07-06 incident). Every call drains the WHOLE
966
890
  // approved backlog, so overlapping drains are pure waste and actively harmful:
@@ -1027,170 +951,6 @@ async function postApproved(batchId, plan) {
1027
951
  }
1028
952
  if (approved.length === 0)
1029
953
  return { attempted: 0, exit_code: 0, summary: "nothing approved" };
1030
- // ---- Reddit cards (2026-07-14): drain them FIRST, independently ----------
1031
- // A reddit card carries the verbatim draft decision (reddit_decision) plus
1032
- // plan metadata (reddit_plan_meta), so approval reconstructs a one-decision
1033
- // plan and reuses `post_reddit.py --phase post` unchanged — per-row
1034
- // reddit-browser lease, URL wrapping, campaign suffixes, and log_post all
1035
- // stay in the one battle-tested poster. The twitter handle preflight and
1036
- // twitter-browser lock ceremony below are twitter-only, so reddit must not
1037
- // be gated on them (and an all-reddit batch returns before any of it).
1038
- const approvedReddit = approved.filter((c) => c.platform === "reddit");
1039
- const approvedTwitter = approved.filter((c) => c.platform !== "reddit");
1040
- let redditPosted = 0;
1041
- let redditFailed = 0;
1042
- let redditSkippedPeerDrain = false;
1043
- if (approvedReddit.length) {
1044
- // Cross-instance drain gate (2026-07-14 drain storm): every one-shot MCP
1045
- // boot (the queue worker fires ~every minute; each boot runs the startup
1046
- // backlog drain) drained the SAME sticky approvals concurrently — 26
1047
- // drain plans in ~30 minutes, all fighting over the one reddit tab and
1048
- // false-positiving each other's posts. reddit-posting-active.json is the
1049
- // arbiter: post_reddit.py heartbeats it per row, and we stamp it around
1050
- // the whole drain here. A fresh flag (<120s) means a peer is mid-drain:
1051
- // leave the cards for it — approvals are sticky, nothing is lost.
1052
- const redditFlagPath = path.join(s4lStateDir(), "reddit-posting-active.json");
1053
- let redditPeerFresh = false;
1054
- try {
1055
- redditPeerFresh = Date.now() - fs.statSync(redditFlagPath).mtimeMs < 120_000;
1056
- }
1057
- catch {
1058
- redditPeerFresh = false;
1059
- }
1060
- const stampRedditFlag = () => {
1061
- try {
1062
- fs.writeFileSync(redditFlagPath, JSON.stringify({ pid: process.pid, hb: Math.floor(Date.now() / 1000) }));
1063
- }
1064
- catch {
1065
- /* best effort */
1066
- }
1067
- };
1068
- if (redditPeerFresh) {
1069
- redditSkippedPeerDrain = true;
1070
- logPostEvent(`postApproved_reddit_skip batch=${batchId} reason=peer_drain_active cards=${approvedReddit.length}`);
1071
- }
1072
- else {
1073
- stampRedditFlag();
1074
- try {
1075
- for (const c of approvedReddit) {
1076
- stampRedditFlag();
1077
- const cc = c;
1078
- const dec = cc.reddit_decision;
1079
- const meta = (cc.reddit_plan_meta || {});
1080
- if (!dec) {
1081
- c.terminal = true;
1082
- c.terminal_reason = "reddit_decision_missing";
1083
- redditFailed++;
1084
- continue;
1085
- }
1086
- // The card's reply_text is the CANONICAL text (post_drafts edits write
1087
- // there); the embedded decision still carries the draft-time original.
1088
- // Posting dec.text verbatim would silently discard a human edit.
1089
- const decPost = {
1090
- ...dec,
1091
- text: (typeof cc.reply_text === "string" && cc.reply_text.trim())
1092
- ? cc.reply_text
1093
- : dec.text,
1094
- };
1095
- if (cc.engagement_style)
1096
- decPost.engagement_style = cc.engagement_style;
1097
- const miniPlan = {
1098
- project_name: meta.project_name || cc.matched_project,
1099
- batch_id: cc.reddit_batch_id || meta.batch_id || "reddit-mcp-approval",
1100
- phase: "draft",
1101
- decisions: [decPost],
1102
- style_assignment: meta.style_assignment || {},
1103
- generation_trace_path: meta.generation_trace_path,
1104
- session_id: meta.session_id || meta.draft_session_id,
1105
- };
1106
- const tmpPlan = path.join(process.env.S4L_TMP_DIR || "/tmp", `reddit_mcp_post_${Date.now()}_${Math.floor(Math.random() * 1e6)}.json`);
1107
- let r;
1108
- try {
1109
- fs.writeFileSync(tmpPlan, JSON.stringify(miniPlan));
1110
- r = await runPython("scripts/post_reddit.py", ["--phase", "post", "--in", tmpPlan], {
1111
- timeoutMs: 900_000,
1112
- env: {
1113
- REDDIT_CDP_URL: process.env.REDDIT_CDP_URL || "http://127.0.0.1:9557",
1114
- // Reviewed posts never get the active-campaign suffix (same rule
1115
- // as the twitter manual-approval path below).
1116
- S4L_SKIP_CAMPAIGN_SUFFIX: "1",
1117
- },
1118
- onLine: (line) => {
1119
- const t = line.replace(/\s+$/, "");
1120
- if (t.trim())
1121
- console.error(`[post-reddit] ${t}`);
1122
- },
1123
- });
1124
- }
1125
- catch (err) {
1126
- r = { code: -1, stdout: "", stderr: String(err) };
1127
- }
1128
- finally {
1129
- try {
1130
- fs.unlinkSync(tmpPlan);
1131
- }
1132
- catch {
1133
- /* best effort */
1134
- }
1135
- }
1136
- // post_reddit.py's summary marker: `[post_reddit] phase=post ... posted=N failed=M`
1137
- const out = `${r.stdout}\n${r.stderr}`;
1138
- const postedN = Number((/posted=(\d+)/.exec(out) || [])[1] || 0);
1139
- if (r.code === 0 && postedN > 0) {
1140
- c.posted = true;
1141
- c.terminal = false;
1142
- const urlMatch = /(https:\/\/(?:old\.|www\.)?reddit\.com\/r\/\S+)/.exec((/\[post_reddit\][^\n]*posted[^\n]*/i.exec(out) || [""])[0]);
1143
- if (urlMatch)
1144
- c.our_url = urlMatch[1];
1145
- redditPosted++;
1146
- }
1147
- else {
1148
- // Leave the approval sticky (approved && !posted && !terminal) so the
1149
- // next post_drafts call retries, mirroring twitter's failed-drain
1150
- // semantics; only stamp terminal on a conclusive CDP refusal.
1151
- const cdpReason = (/\[post_reddit\] CDP FAILED: ([a-z_]+)/.exec(out) || [])[1];
1152
- if (cdpReason && ["thread_locked", "thread_archived", "thread_not_found", "blocked_by_author"].includes(cdpReason)) {
1153
- c.terminal = true;
1154
- c.terminal_reason = `reddit_${cdpReason}`;
1155
- }
1156
- redditFailed++;
1157
- }
1158
- }
1159
- }
1160
- finally {
1161
- // Clear only OUR stamp; a peer that took over mid-drain keeps its own.
1162
- try {
1163
- const cur = JSON.parse(fs.readFileSync(redditFlagPath, "utf-8"));
1164
- if (cur && cur.pid === process.pid)
1165
- fs.unlinkSync(redditFlagPath);
1166
- }
1167
- catch {
1168
- /* best effort */
1169
- }
1170
- }
1171
- logPostEvent(`postApproved_reddit batch=${batchId} attempted=${approvedReddit.length} posted=${redditPosted} failed=${redditFailed}`);
1172
- }
1173
- }
1174
- if (approvedTwitter.length === 0) {
1175
- // All-reddit batch: persist the stamps and return without touching the
1176
- // twitter preflight/lock path.
1177
- if (redditSkippedPeerDrain) {
1178
- return {
1179
- attempted: 0,
1180
- posted: 0,
1181
- exit_code: 0,
1182
- summary: "reddit: skipped (peer drain active); cards stay approved for the next drain",
1183
- };
1184
- }
1185
- if (approvedReddit.length)
1186
- mergeApprovedStampsIntoStore(batchId, plan, approvedReddit);
1187
- return {
1188
- attempted: approvedReddit.length,
1189
- posted: redditPosted,
1190
- exit_code: redditFailed ? 1 : 0,
1191
- summary: `reddit: posted=${redditPosted} failed=${redditFailed}`,
1192
- };
1193
- }
1194
954
  // PREFLIGHT: posting needs a configured @handle, or twitter_browser.py refuses
1195
955
  // EVERY reply with no_account_configured and the whole batch skips — invisibly.
1196
956
  // If onboarding never persisted it, self-heal from the live session; if even that
@@ -1242,7 +1002,7 @@ async function postApproved(batchId, plan) {
1242
1002
  };
1243
1003
  }
1244
1004
  const approvedBatch = `${batchId}_approved`;
1245
- writePlan(approvedBatch, { ...plan, candidates: approvedTwitter });
1005
+ writePlan(approvedBatch, { ...plan, candidates: approved });
1246
1006
  // S4L_SKIP_CAMPAIGN_SUFFIX=1: manual/reviewed posts from this MCP draft_cycle
1247
1007
  // never get the active-campaign suffix (e.g. " written with ai") appended.
1248
1008
  // twitter_browser.py's reply handler reads this env (inherited through
@@ -1255,7 +1015,7 @@ async function postApproved(batchId, plan) {
1255
1015
  const failure = {
1256
1016
  posted: 0,
1257
1017
  skipped: 0,
1258
- failed: approvedTwitter.length,
1018
+ failed: approved.length,
1259
1019
  failure_reasons: "browser_bootstrap_failed",
1260
1020
  skip_reasons: "",
1261
1021
  };
@@ -1271,7 +1031,7 @@ async function postApproved(batchId, plan) {
1271
1031
  // (Karol 2026-07-09: 0/131 posted, exit=-1). 60s/card headroom covers
1272
1032
  // slow candidates; the 2h cap bounds a hung poster (the browser-lock
1273
1033
  // expiry and per-reply subprocess timeouts still fire underneath).
1274
- timeoutMs: Math.min(7_200_000, Math.max(900_000, approvedTwitter.length * 60_000)),
1034
+ timeoutMs: Math.min(7_200_000, Math.max(900_000, approved.length * 60_000)),
1275
1035
  env: ({
1276
1036
  S4L_SKIP_CAMPAIGN_SUFFIX: "1",
1277
1037
  // Manual approval is an EXCEPTION to the tail-link A/B. The cron pipeline
@@ -1338,7 +1098,7 @@ async function postApproved(batchId, plan) {
1338
1098
  const postLogDir = path.join(repoDir(), "skill", "logs");
1339
1099
  fs.mkdirSync(postLogDir, { recursive: true });
1340
1100
  const stamp = new Date().toISOString().replace(/[:.]/g, "-");
1341
- fs.writeFileSync(path.join(postLogDir, `post-${stamp}.log`), `# post_drafts batch=${batchId} approved=${approvedTwitter.length} exit=${res.code} ` +
1101
+ fs.writeFileSync(path.join(postLogDir, `post-${stamp}.log`), `# post_drafts batch=${batchId} approved=${approved.length} exit=${res.code} ` +
1342
1102
  `shell_lock=${heldShellLock}\n\n=== stdout ===\n${res.stdout}\n\n=== stderr ===\n${res.stderr}\n`);
1343
1103
  }
1344
1104
  catch {
@@ -1361,7 +1121,7 @@ async function postApproved(batchId, plan) {
1361
1121
  const realPosted = summObj && typeof summObj.posted === "number"
1362
1122
  ? summObj.posted
1363
1123
  : res.code === 0 && !summObj
1364
- ? approvedTwitter.length
1124
+ ? approved.length
1365
1125
  : 0;
1366
1126
  // Mark candidates according to the poster's per-candidate outcome. This keeps
1367
1127
  // the review queue honest: posted drafts disappear as posted, terminal skips
@@ -1382,14 +1142,14 @@ async function postApproved(batchId, plan) {
1382
1142
  .filter((r) => r.candidate_id && ["posted", "skipped", "failed"].includes(r.outcome))
1383
1143
  : parsePostCandidateResults(res.stdout);
1384
1144
  const approvedById = new Map();
1385
- approvedTwitter.forEach((c) => {
1145
+ approved.forEach((c) => {
1386
1146
  if (c.candidate_id !== undefined && c.candidate_id !== null)
1387
1147
  approvedById.set(String(c.candidate_id), c);
1388
1148
  });
1389
1149
  let touchedPlan = false;
1390
1150
  if (resultRows.length) {
1391
1151
  resultRows.forEach((r, idx) => {
1392
- const c = approvedById.get(r.candidate_id) || approvedTwitter[idx];
1152
+ const c = approvedById.get(r.candidate_id) || approved[idx];
1393
1153
  if (!c)
1394
1154
  return;
1395
1155
  if (r.outcome === "posted") {
@@ -1409,14 +1169,59 @@ async function postApproved(batchId, plan) {
1409
1169
  else if (realPosted > 0 || (res.code === 0 && !summObj)) {
1410
1170
  // Legacy fallback for older poster output without parseable per-candidate
1411
1171
  // lines. Mark only when we have no finer-grained signal.
1412
- for (const c of approvedTwitter)
1172
+ for (const c of approved)
1413
1173
  c.posted = true;
1414
1174
  touchedPlan = true;
1415
1175
  }
1416
- // Reddit stamps (set in the reddit drain above) merge alongside the twitter
1417
- // ones: `approved` here spans both platforms.
1418
- if (touchedPlan || redditPosted || redditFailed) {
1419
- mergeApprovedStampsIntoStore(batchId, plan, approved);
1176
+ if (touchedPlan) {
1177
+ try {
1178
+ // Merge our stamps into a FRESH read of the store instead of rewriting the
1179
+ // whole plan from the copy we took minutes ago. The old whole-file write
1180
+ // was last-writer-wins: while this batch posted, the menubar (decision
1181
+ // re-stamps) and any peer drain also wrote the store, and whichever run
1182
+ // finished last erased the others' posted flags (2026-07-06: card 344877
1183
+ // posted at 00:29Z ended `posted=None, terminal=duplicate_thread_pre_post`
1184
+ // after a later run's stale write). Merge rules: `posted` is sticky and
1185
+ // wins over terminal; `terminal` never overwrites a fresh `posted=true`.
1186
+ // Fallback: candidates without a candidate_id can't be matched into the
1187
+ // fresh copy, so keep the legacy whole-plan write for those older plans.
1188
+ const mergeable = approved.every((c) => c.candidate_id !== undefined && c.candidate_id !== null);
1189
+ const fresh = mergeable ? readPlan(batchId) : null;
1190
+ if (fresh && Array.isArray(fresh.candidates)) {
1191
+ const freshById = new Map();
1192
+ fresh.candidates.forEach((c) => {
1193
+ if (c.candidate_id !== undefined && c.candidate_id !== null)
1194
+ freshById.set(String(c.candidate_id), c);
1195
+ });
1196
+ for (const c of approved) {
1197
+ const f = freshById.get(String(c.candidate_id));
1198
+ if (!f)
1199
+ continue;
1200
+ if (c.posted === true) {
1201
+ f.posted = true;
1202
+ f.terminal = false;
1203
+ if (c.our_url)
1204
+ f.our_url = c.our_url;
1205
+ }
1206
+ else if (c.terminal === true && f.posted !== true) {
1207
+ f.terminal = true;
1208
+ f.terminal_reason = c.terminal_reason;
1209
+ }
1210
+ }
1211
+ writePlan(batchId, fresh);
1212
+ }
1213
+ else {
1214
+ writePlan(batchId, plan);
1215
+ }
1216
+ }
1217
+ catch {
1218
+ try {
1219
+ writePlan(batchId, plan);
1220
+ }
1221
+ catch {
1222
+ /* best effort */
1223
+ }
1224
+ }
1420
1225
  }
1421
1226
  // Post failures are HANDLED in the pipeline (it returns a count, never throws),
1422
1227
  // so they never reach Sentry on their own. Capture an explicit event whenever
@@ -1435,10 +1240,10 @@ async function postApproved(batchId, plan) {
1435
1240
  // actionable error on its own.
1436
1241
  const hasRealFailure = res.code !== 0 || Boolean(summObj?.failure_reasons);
1437
1242
  if (hasRealFailure) {
1438
- captureError(new Error(`post_drafts: ${realPosted}/${approvedTwitter.length} posted (exit=${res.code})`), {
1243
+ captureError(new Error(`post_drafts: ${realPosted}/${approved.length} posted (exit=${res.code})`), {
1439
1244
  component: "post",
1440
1245
  exit_code: String(res.code),
1441
- attempted: String(approvedTwitter.length),
1246
+ attempted: String(approved.length),
1442
1247
  posted: String(realPosted),
1443
1248
  failure_reasons: String(summObj?.failure_reasons || ""),
1444
1249
  skip_reasons: String(summObj?.skip_reasons || ""),
@@ -1449,11 +1254,9 @@ async function postApproved(batchId, plan) {
1449
1254
  void flushLogs();
1450
1255
  return {
1451
1256
  attempted: approved.length,
1452
- posted: realPosted + redditPosted,
1257
+ posted: realPosted,
1453
1258
  exit_code: res.code,
1454
- summary: approvedReddit.length > 0
1455
- ? { twitter: summary, reddit: { posted: redditPosted, failed: redditFailed } }
1456
- : summary,
1259
+ summary,
1457
1260
  stderr_tail: res.stderr.split("\n").slice(-8).join("\n"),
1458
1261
  };
1459
1262
  }
@@ -1958,14 +1761,7 @@ tool("project_config", {
1958
1761
  inputSchema: {
1959
1762
  status: z.boolean().optional(),
1960
1763
  action: z
1961
- .enum([
1962
- "get",
1963
- "connect_x",
1964
- "detect_x_sources",
1965
- "profile_scan",
1966
- "connect_reddit",
1967
- "detect_reddit_sources",
1968
- ])
1764
+ .enum(["get", "connect_x", "detect_x_sources", "profile_scan"])
1969
1765
  .optional()
1970
1766
  .describe("get = read the CURRENT SAVED VALUES of every project's editable fields (website, " +
1971
1767
  "description, icp, voice, differentiator, search_topics, get_started_link, " +
@@ -1983,13 +1779,7 @@ tool("project_config", {
1983
1779
  "replies to build a 'grounding truth' corpus. Use it to draft voice/icp/search_topics in " +
1984
1780
  "the USER'S OWN register (their phrases, vibe, profession), then save a conservative best " +
1985
1781
  "draft without requiring a confirmation round-trip. Returns {profile, posts, comments, " +
1986
- "grounding_instructions}. " +
1987
- "connect_reddit = OPTIONAL equal platform (setup completes with X-only, Reddit-only, or " +
1988
- "both; offer Reddit after X setup, or standalone when the user prefers it or X fails/is " +
1989
- "skipped): import/validate the user's reddit.com session in the " +
1990
- "autoposter's managed reddit browser, same confirm-first shape as connect_x. " +
1991
- "detect_reddit_sources = list the browsers/profiles the Reddit session can be imported " +
1992
- "from (read-only, no keychain prompt)."),
1782
+ "grounding_instructions}."),
1993
1783
  confirm: z
1994
1784
  .boolean()
1995
1785
  .optional()
@@ -2006,17 +1796,6 @@ tool("project_config", {
2006
1796
  "X login window and waits for them to log in. By default (false), connect_x does NOT pop a " +
2007
1797
  "browser window on an auto-import miss; it returns needs_login and you offer manual login as " +
2008
1798
  "an opt-in. The login window still opens automatically if the user DENIED the keychain prompt."),
2009
- reddit_source: z
2010
- .string()
2011
- .optional()
2012
- .describe("Optional browser profile to import the Reddit session from, e.g. 'arc:Default', " +
2013
- "'chrome:Profile 1'. Default: auto-detect the browser that holds a reddit.com session."),
2014
- reddit_manual_login: z
2015
- .boolean()
2016
- .optional()
2017
- .describe("Set true ONLY when the user explicitly wants to sign into Reddit by hand. Opens a focused " +
2018
- "Reddit login window in the autoposter's reddit browser and waits. Same opt-in discipline " +
2019
- "as x_manual_login."),
2020
1799
  name: z
2021
1800
  .string()
2022
1801
  .optional()
@@ -2186,130 +1965,6 @@ tool("project_config", {
2186
1965
  : "X is not connected yet. " + summarizeXAuth(r),
2187
1966
  });
2188
1967
  }
2189
- // ---- List Reddit import sources (read-only, no keychain prompt) --------
2190
- if (args.action === "detect_reddit_sources") {
2191
- const r = await redditDetectSources();
2192
- return jsonContent({
2193
- action: "detect_reddit_sources",
2194
- ok: r.ok,
2195
- sources: r.sources,
2196
- recommended: r.recommended,
2197
- error: r.error,
2198
- });
2199
- }
2200
- // ---- Connect Reddit: OPTIONAL platform, mirrors connect_x --------------
2201
- // Preview-or-run, same confirm-first shape as connect_x. Reddit is never
2202
- // required for onboarding completion; offer it only after X setup is done
2203
- // and the user wants it.
2204
- if (args.action === "connect_reddit") {
2205
- if (args.confirm !== true) {
2206
- // Cheap probe so the explanation reflects current state (no Chrome launch).
2207
- const cur = await redditStatus();
2208
- if (cur.connected) {
2209
- return jsonContent({
2210
- action: "connect_reddit",
2211
- already_connected: true,
2212
- state: cur.state,
2213
- username: cur.username,
2214
- note: "Reddit is already connected in the autoposter's reddit browser. Nothing to import.",
2215
- });
2216
- }
2217
- return jsonContent({
2218
- action: "connect_reddit",
2219
- requires_confirmation: true,
2220
- current_state: cur.state,
2221
- what_will_happen: "To engage on Reddit for you, the autoposter uses its OWN managed Google Chrome (separate " +
2222
- "from your everyday browser and from the X one). It needs your logged-in reddit.com " +
2223
- "session. If you confirm, it will: (1) start that managed reddit browser if it isn't " +
2224
- "running, (2) copy ONLY your reddit.com cookies (reddit_session, token_v2) from your " +
2225
- "everyday browser (Chrome/Arc/Brave/Edge, auto-detected) into it, and (3) verify you're " +
2226
- "logged in via Reddit's own me.json. No other site's cookies are read, and your passwords " +
2227
- "are never seen. If it can't import a valid session, a Chrome window will open for you to " +
2228
- "sign in once.",
2229
- keychain_prompt: "Reading the saved session requires macOS to unlock the browser's encrypted cookie store, so " +
2230
- "one or more keychain prompts will appear (“... wants to use your confidential information " +
2231
- "stored in '... Safe Storage' in your keychain”). This is expected. The user enters their Mac " +
2232
- "login password and clicks Allow (or Always Allow to avoid repeats). If they use more than one " +
2233
- "browser, the prompt can appear a few times, once per browser.",
2234
- say_to_user: "Heads up: your Mac will pop up a keychain prompt asking to use your browser's Safe Storage. " +
2235
- "That's just us reading your saved Reddit login, nothing else. Type your Mac login password and " +
2236
- "click Allow (or Always Allow). If you use more than one browser you may see it a couple of " +
2237
- "times, once per browser.",
2238
- how_to_proceed: "If the user explicitly requested connecting Reddit, relay the say_to_user line as a brief " +
2239
- "heads-up and immediately call project_config again with action:'connect_reddit', confirm:true; " +
2240
- "do not wait for another yes/no reply. Optionally pass a reddit_source from " +
2241
- "detect_reddit_sources. If the user only asked what connection would do, stop after this " +
2242
- "preview. Reddit is OPTIONAL: never treat it as required for setup completion.",
2243
- });
2244
- }
2245
- recordOnboardingAttempt("reddit_connected", {
2246
- state: args.reddit_source ? "source_selected" : "auto_detect",
2247
- });
2248
- const r = await redditConnect(args.reddit_source, args.reddit_manual_login);
2249
- let verified = false;
2250
- let configNote;
2251
- if (r.connected) {
2252
- completeOnboardingMilestone("reddit_connected", { state: r.state });
2253
- // Persist the discovered username through the server's config-write
2254
- // path (accounts.reddit.username, the field account_resolver reads),
2255
- // never overwriting a deliberately-set value.
2256
- if (r.username) {
2257
- const w = recordRedditAccount(r.username);
2258
- configNote = w.detail;
2259
- }
2260
- // Doctor-style persistence re-check before reddit_verified: a fresh
2261
- // read-only status probe confirms the session actually persisted
2262
- // (live me.json or the on-disk profile cookie row) rather than
2263
- // trusting the connect call's own success.
2264
- const recheck = await redditStatus();
2265
- if (recheck.connected) {
2266
- completeOnboardingMilestone("reddit_verified", { state: recheck.state });
2267
- verified = true;
2268
- }
2269
- else {
2270
- recordOnboardingAttempt("reddit_verified", {
2271
- state: recheck.state || "unverified",
2272
- });
2273
- }
2274
- // Reddit is live: install the discovery kicker (idempotent; gated on
2275
- // runtime + project readiness inside, and it never touches a
2276
- // hand-built plist pointing outside the managed package).
2277
- void ensureRedditKickerInstalled()
2278
- .then((res) => console.error(`[reddit-kicker] post-connect install: ${res.ok ? "ok" : "skip"} (${res.detail})`))
2279
- .catch((e) => console.error("[reddit-kicker] post-connect install failed:", e?.message || e));
2280
- }
2281
- else {
2282
- blockOnboardingMilestone("reddit_connected", `reddit_${r.state || "not_connected"}`, r.error || r.note || summarizeRedditAuth(r), { state: r.state || "not_connected" });
2283
- }
2284
- return jsonContent({
2285
- action: "connect_reddit",
2286
- connected: r.connected,
2287
- state: r.state,
2288
- username: r.username,
2289
- account_age_days: r.account_age_days,
2290
- comment_karma: r.comment_karma,
2291
- // Ready-to-relay expectation setter for fresh/low-karma accounts
2292
- // (AutoMod gates those in most subreddits). Advisory only; never a
2293
- // reason to block or undo the connect.
2294
- warning: r.warning,
2295
- verified,
2296
- config: configNote,
2297
- summary: summarizeRedditAuth(r),
2298
- note: r.note,
2299
- attempts: r.attempts,
2300
- onboarding: onboardingSnapshot(),
2301
- next_step: r.connected
2302
- ? "Reddit is connected. The reddit discovery job installs itself once a project is " +
2303
- "configured; drafts flow into the same review cards as X and nothing posts without " +
2304
- "approval." +
2305
- (r.warning ? " Relay the `warning` field to the user so expectations are set." : "")
2306
- : r.state === "needs_login"
2307
- ? "The user must finish signing in to reddit.com in the Chrome window that opened. Tell " +
2308
- "them that single required action, then call project_config action:'connect_reddit', " +
2309
- "confirm:true again."
2310
- : "Reddit is not connected yet. " + summarizeRedditAuth(r),
2311
- });
2312
- }
2313
1968
  // ---- Profile scan: grounding-truth corpus from the connected account ----
2314
1969
  // Reuses the authenticated managed-Chrome session (so it must run AFTER a
2315
1970
  // successful connect_x) to read the user's bio + recent posts + recent
@@ -2415,9 +2070,6 @@ tool("project_config", {
2415
2070
  const projects = Array.isArray(snap.projects) ? snap.projects : [];
2416
2071
  const rtReady = !!snap.runtime_ready;
2417
2072
  const xConnected = !!snap.x_connected;
2418
- const redditConnected = !!snap.reddit_connected;
2419
- // Any-of platform completion: X or Reddit satisfies the platform leg.
2420
- const anyPlatform = xConnected || redditConnected;
2421
2073
  const configured = (snap.projects_ready || 0) > 0;
2422
2074
  return jsonContent({
2423
2075
  configured,
@@ -2426,9 +2078,6 @@ tool("project_config", {
2426
2078
  x_connected: xConnected,
2427
2079
  x_state: snap.x_state,
2428
2080
  x_handle: snap.x_handle ?? null,
2429
- reddit_connected: redditConnected,
2430
- reddit_state: snap.reddit_state,
2431
- reddit_username: snap.reddit_username ?? null,
2432
2081
  setup_complete: !!snap.setup_complete,
2433
2082
  mcp_version: snap.version,
2434
2083
  latest_version: snap.latest_version,
@@ -2450,15 +2099,14 @@ tool("project_config", {
2450
2099
  ? "Runtime is not ready yet. It provisions automatically on boot — poll runtime action:'status' until ready (only call runtime action:'install' to retry if status shows the boot provision failed or stalled), then continue setup automatically."
2451
2100
  : projects.length === 0
2452
2101
  ? "No projects yet. Discover the product from conversation context and the connected X profile; research its website, infer a conservative complete project, and call project_config. Ask only if no product can be identified." +
2453
- (anyPlatform ? "" : " No platform is connected yet either. X is the default: detect_x_sources, warn about keychain prompts, then run connect_x with confirm:true without a separate permission turn. If the user prefers Reddit (or X can't be connected), connect_reddit works standalone.")
2102
+ (xConnected ? "" : " X is not connected yet either — detect_x_sources, warn about keychain prompts, then run connect_x with confirm:true without a separate permission turn.")
2454
2103
  : projects.every((p) => p.ready)
2455
- ? (anyPlatform
2456
- ? "All configured projects are ready and a platform is connected" +
2457
- (xConnected ? "" : " (Reddit; X was skipped, which is fine)") +
2458
- ". SCHEDULE THE AUTOPILOT: (1) call queue_setup and create each returned task with create_scheduled_task (prompt and notifyOnCompletion verbatim — notifyOnCompletion must be false; 'already exists' is fine, but then call update_scheduled_task with notifyOnCompletion:false to silence per-run notifications); (2) the autopilot then runs on its own (launchd kicker + queue worker). Call the `dashboard` tool to confirm the schedule is firing (schedule_state 'ok') — that is the terminal step; do NOT wait for or verify a draft card. Do NOT pause to ask the user to review drafts."
2459
- : "All configured projects are ready, but NO platform is connected yet; posting needs a logged-in session. X is the default: detect sources and run project_config action:'connect_x', confirm:true; do not ask whether to proceed. If the user prefers Reddit or X can't be connected, run action:'connect_reddit' instead; ONE connected platform completes setup.")
2104
+ ? (xConnected
2105
+ ? "All configured projects are ready and X is connected. SCHEDULE THE AUTOPILOT: (1) call queue_setup and create each returned task with create_scheduled_task (prompt and notifyOnCompletion verbatim — notifyOnCompletion must be false; 'already exists' is fine, but then call update_scheduled_task with notifyOnCompletion:false to silence per-run notifications); (2) the autopilot then runs on its own (launchd kicker + queue worker). Call the `dashboard` tool to confirm the schedule is firing (schedule_state 'ok') — that is the terminal step; do NOT wait for or verify a draft card. Do NOT pause to ask the user to review drafts."
2106
+ : "All configured projects are ready, but X is NOT connected — posting needs a logged-in " +
2107
+ "x.com session. Detect sources and run project_config action:'connect_x', confirm:true; do not ask whether to proceed.")
2460
2108
  : "Some projects are missing required fields (see each project's missing_required). Derive them from config, context, profile_scan, and website research, then call project_config again. Ask only if a required field is genuinely unknowable." +
2461
- (anyPlatform ? "" : " No platform is connected yet either; X is the default (connect_x with confirm:true), or connect_reddit if the user prefers Reddit."),
2109
+ (xConnected ? "" : " X is also not connected yet; detect sources and run connect_x with confirm:true."),
2462
2110
  });
2463
2111
  }
2464
2112
  // Apply mode (incremental): merge whatever fields were supplied onto the
@@ -2684,27 +2332,6 @@ tool("post_drafts", {
2684
2332
  }
2685
2333
  c.approved = false;
2686
2334
  rejected.push(n);
2687
- // Reddit cards: also retire the reddit_candidates row (permanent
2688
- // mark_attempt) so Phase 0 salvage never re-pulls and re-drafts a
2689
- // thread a human just rejected. Twitter gets this for free via the
2690
- // review-events row flip; reddit's id-keyed flows are deliberately
2691
- // firewalled (rd- prefixed ids), so this direct by-thread-url PATCH is
2692
- // the reddit equivalent. Fire-and-forget: a failure leaves the row
2693
- // pending, which at worst re-drafts one card next cycle.
2694
- const ccr = c;
2695
- if (ccr.platform === "reddit" && (ccr.thread_url || ccr.candidate_url)) {
2696
- const rejUrl = String(ccr.thread_url || ccr.candidate_url);
2697
- void runPython("-c", [
2698
- "import sys; sys.path.insert(0, 'scripts')\n" +
2699
- "from http_api import api_patch\n" +
2700
- "api_patch('/api/v1/reddit-candidates/by-thread-url', " +
2701
- "{'thread_url': sys.argv[1], 'action': 'mark_attempt', " +
2702
- "'reason': 'human_rejected', 'permanent': True}, ok_on_404=True)",
2703
- rejUrl,
2704
- ], { timeoutMs: 30_000 }).catch(() => {
2705
- /* best effort */
2706
- });
2707
- }
2708
2335
  });
2709
2336
  // Apply edits first; an edited draft is always posted.
2710
2337
  const approve = new Set();
@@ -3059,9 +2686,9 @@ tool("posting_volume", {
3059
2686
  title: "Read or set posting volume (Aggressive / Steady / Chill)",
3060
2687
  description: "Read or set this install's posting-volume mode, the quality bar that decides how many drafts " +
3061
2688
  "per day the twitter cycle produces. Three modes, shown to users as Aggressive (~100+ posts/day), " +
3062
- "Steady (~30/day, the default every install starts on), and Chill (~5/day, only the very best " +
3063
- "candidates). Internally the modes are high|medium|low and both spellings are accepted. " +
3064
- "action:'get' returns the current mode plus per-mode estimated " +
2689
+ "Steady (~30/day), and Chill (~5/day, only the very best candidates); 'default' clears the " +
2690
+ "override so the cycle's built-in setting applies. Internally the modes are high|medium|low and " +
2691
+ "both spellings are accepted. action:'get' returns the current mode plus per-mode estimated " +
3065
2692
  "posts/day computed from this install's own recent candidate pool (show those numbers with the " +
3066
2693
  "Aggressive/Steady/Chill names when the user is choosing). Use when the user asks to post more, " +
3067
2694
  "post less, slow down, be more aggressive, chill out, raise the quality bar, or change posting " +
@@ -3070,9 +2697,9 @@ tool("posting_volume", {
3070
2697
  inputSchema: {
3071
2698
  action: z.enum(["get", "set"]).default("get").describe("get = read mode + rates; set = change it"),
3072
2699
  mode: z
3073
- .enum(["aggressive", "steady", "chill", "high", "medium", "low"])
2700
+ .enum(["aggressive", "steady", "chill", "high", "medium", "low", "default"])
3074
2701
  .optional()
3075
- .describe("Required for action:'set'. aggressive=high, steady=medium, chill=low."),
2702
+ .describe("Required for action:'set'. aggressive=high, steady=medium, chill=low; 'default' clears the override."),
3076
2703
  },
3077
2704
  }, async (args) => {
3078
2705
  const action = args.action || "get";
@@ -3080,7 +2707,7 @@ tool("posting_volume", {
3080
2707
  const ALIAS = { aggressive: "high", steady: "medium", chill: "low" };
3081
2708
  if (action === "set") {
3082
2709
  if (!args.mode) {
3083
- return jsonContent({ error: "mode is required for action:'set' (aggressive|steady|chill)" });
2710
+ return jsonContent({ error: "mode is required for action:'set' (aggressive|steady|chill|default)" });
3084
2711
  }
3085
2712
  const stored = ALIAS[String(args.mode)] || String(args.mode);
3086
2713
  const r = await runPython("scripts/s4l_posting_mode.py", ["set", stored], {
@@ -3993,101 +3620,6 @@ async function ensureQueueKickerInstalled() {
3993
3620
  return { ok: false, detail: e?.message || String(e) };
3994
3621
  }
3995
3622
  }
3996
- // ---- Reddit discovery kicker (optional platform) ----------------------------
3997
- // Mirrors ensureQueueKickerInstalled for the reddit lane: a 15-minute launchd
3998
- // job that runs skill/run-reddit-search-launchd.sh (the detach wrapper; the
3999
- // real cycle honors the global draft-only flag via s4l_mode.py, and its
4000
- // drafting turn rides the same s4l-worker queue as X). Gates:
4001
- // - runtime ready
4002
- // - reddit connected (connected OR connected_idle; the profile persists)
4003
- // - a managed project is configured and ready
4004
- // It is NEVER an onboarding requirement: installs that never connect reddit
4005
- // simply never get this plist.
4006
- //
4007
- // OPERATOR-MAC SAFETY: a hand-built com.m13v.social-reddit-search plist
4008
- // pointing at ~/social-autoposter (StartCalendarInterval, custom env) exists
4009
- // on the dev box. If an existing plist's program path is not the managed
4010
- // package's wrapper, we log and leave it completely alone: no rewrite, no
4011
- // reload, no unload.
4012
- async function ensureRedditKickerInstalled() {
4013
- try {
4014
- if (process.platform !== "darwin")
4015
- return { ok: false, detail: "not macOS" };
4016
- if (!runtimeReady())
4017
- return { ok: false, detail: "runtime not ready" };
4018
- const productReady = listManagedProjectStatus().some((p) => p.ready);
4019
- if (!productReady)
4020
- return { ok: false, detail: "no ready project yet" };
4021
- // Reddit session gate. status is read-only (never launches Chrome): a live
4022
- // me.json validation when the harness is up, the on-disk profile cookie
4023
- // check (connected_idle) when it isn't.
4024
- const rs = await redditStatus();
4025
- if (!rs.connected) {
4026
- return { ok: false, detail: `reddit not connected (${rs.state})` };
4027
- }
4028
- const managedWrapper = path.join(repoDir(), "skill", "run-reddit-search-launchd.sh");
4029
- // Foreign-plist guard BEFORE any write: if a plist already exists and its
4030
- // ProgramArguments do not point at the managed package's wrapper, it is a
4031
- // hand-built / operator arrangement. Leave it untouched.
4032
- let cur = null;
4033
- try {
4034
- cur = fs.readFileSync(REDDIT_SEARCH_PLIST, "utf-8");
4035
- }
4036
- catch {
4037
- cur = null;
4038
- }
4039
- if (cur !== null && !cur.includes(`<string>${managedWrapper}</string>`)) {
4040
- const msg = `existing ${REDDIT_SEARCH_LABEL} plist points outside the managed package; leaving it untouched`;
4041
- console.error(`[reddit-kicker] ${msg}`);
4042
- return { ok: true, detail: `skip: ${msg}` };
4043
- }
4044
- const logDir = path.join(repoDir(), "skill", "logs");
4045
- try {
4046
- fs.mkdirSync(logDir, { recursive: true });
4047
- }
4048
- catch {
4049
- /* best-effort */
4050
- }
4051
- const xml = plistXml({
4052
- label: REDDIT_SEARCH_LABEL,
4053
- programArgs: ["bash", managedWrapper],
4054
- intervalSecs: REDDIT_SEARCH_INTERVAL_SECS,
4055
- runAtLoad: false, // never fire a discovery cycle the instant Claude launches
4056
- stdoutLog: path.join(logDir, "launchd-reddit-search-stdout.log"),
4057
- stderrLog: path.join(logDir, "launchd-reddit-search-stderr.log"),
4058
- // S4L_REPO_DIR + S4L_PYTHON are baked by plistXml. State dir + CDP url
4059
- // pin the wrapper's children to the managed state and the harness port.
4060
- extraEnv: {
4061
- S4L_STATE_DIR: s4lStateDir(),
4062
- REDDIT_CDP_URL: REDDIT_CDP_URL_DEFAULT,
4063
- },
4064
- // The wrapper double-forks the real cycle into its own session already,
4065
- // but keep launchd away from the harness Chrome all the same.
4066
- abandonProcessGroup: true,
4067
- });
4068
- const uid = process.getuid ? process.getuid() : 0;
4069
- if (cur === xml) {
4070
- const res = await loadPlist(REDDIT_SEARCH_LABEL, REDDIT_SEARCH_PLIST, uid);
4071
- return { ok: true, detail: `current (load rc=${res.code})` };
4072
- }
4073
- if (cur !== null) {
4074
- await unloadPlist(REDDIT_SEARCH_LABEL, REDDIT_SEARCH_PLIST, uid);
4075
- }
4076
- fs.mkdirSync(path.dirname(REDDIT_SEARCH_PLIST), { recursive: true });
4077
- fs.writeFileSync(REDDIT_SEARCH_PLIST, xml, "utf-8");
4078
- const res = await loadPlist(REDDIT_SEARCH_LABEL, REDDIT_SEARCH_PLIST, uid);
4079
- // No first-run kickstart on purpose: reddit discovery is a background
4080
- // add-on, and the connect flow just finished using the harness browser.
4081
- // The first StartInterval tick (≤15 min) is soon enough.
4082
- return {
4083
- ok: true,
4084
- detail: cur === null ? "installed + loaded" : `rewritten + reloaded (rc=${res.code})`,
4085
- };
4086
- }
4087
- catch (e) {
4088
- return { ok: false, detail: e?.message || String(e) };
4089
- }
4090
- }
4091
3623
  // ---- launchd reaper: kill leaked agent-mode claude worker sessions ----------
4092
3624
  // Independent guardrail (NOT gated on a project being ready): the leak happens
4093
3625
  // whenever the scheduled-task workers fire, and a no-leak run is a cheap no-op.
@@ -4575,13 +4107,6 @@ async function buildSnapshot() {
4575
4107
  completeOnboardingMilestone("runtime_ready");
4576
4108
  if (snap.x_connected)
4577
4109
  completeOnboardingMilestone("x_connected", { state: snap.x_state || "connected" });
4578
- // Reddit (optional platform) heal: a live connected reading on a LATER poll
4579
- // is itself persistence evidence, so it may also complete reddit_verified
4580
- // for an install whose post-connect verify probe transiently failed.
4581
- if (snap.reddit_connected) {
4582
- completeOnboardingMilestone("reddit_connected", { state: snap.reddit_state || "connected" });
4583
- completeOnboardingMilestone("reddit_verified", { source: "live_snapshot" });
4584
- }
4585
4110
  if ((snap.projects_ready || 0) > 0)
4586
4111
  completeOnboardingMilestone("project_ready", { missing_count: 0 });
4587
4112
  if (snap.schedule_state === "ok")
@@ -5625,12 +5150,6 @@ async function main() {
5625
5150
  // disk, BEFORE serving, so the very first scan uses the shipped pipeline (not
5626
5151
  // the version first materialized at install). Synchronous + best-effort.
5627
5152
  ensurePipelineCurrent();
5628
- // Config's canonical home is the state dir (2026-07-13): migrate a legacy
5629
- // in-repo config.json up on first boot after update, keep the legacy path
5630
- // working via symlink, and self-heal a missing/wrong link on every boot.
5631
- // Must run AFTER ensurePipelineCurrent() so repoDir() points at the final
5632
- // materialized repo.
5633
- console.error(`[social-autoposter-mcp] config home: ${ensureConfigInStateDir()}`);
5634
5153
  // Deterministically provision the owned runtime on boot: whenever it isn't
5635
5154
  // ready (a fresh install, or one interrupted mid-way because a step failed or
5636
5155
  // Claude/the host died mid-install) kick the full install in the background
@@ -5686,17 +5205,6 @@ async function main() {
5686
5205
  else {
5687
5206
  console.error("[queue-worker] launchd kicker: skip (paused)");
5688
5207
  }
5689
- // Reddit discovery kicker (optional platform): installs only when reddit is
5690
- // connected AND a project is ready; a box that never connected reddit is a
5691
- // cheap no-op skip. Paused-gated like the X kicker (it produces drafts).
5692
- if (!isPaused()) {
5693
- void ensureRedditKickerInstalled()
5694
- .then((r) => console.error(`[reddit-kicker] launchd kicker: ${r.ok ? "ok" : "skip"} (${r.detail})`))
5695
- .catch((e) => console.error("[reddit-kicker] kicker install failed:", e?.message || e));
5696
- }
5697
- else {
5698
- console.error("[reddit-kicker] launchd kicker: skip (paused)");
5699
- }
5700
5208
  // Self-healing reaper for the agent-mode session leak the queue autopilot
5701
5209
  // produces (finished `claude` worker sessions Desktop never tears down). A
5702
5210
  // standalone guardrail; install unconditionally so it caps memory even on a