@m13v/s4l 1.7.2 → 1.7.4-rc.1

package/mcp/menubar/s4l_card.py

@@ -13,9 +13,11 @@ The panel is NONACTIVATING and auto-presented cards never take keyboard focus
 field becomes editable on first click, and only a user-initiated open
 (present_review(focus=True), the menu bar's "Review N pending drafts")
 activates the app and seats the caret immediately. A title-bar "Snooze 1h"
-button sits opposite the close cross; it and the cross both just close the
-panel, and the menu bar interprets any close with undecided drafts as a
-snooze (drafts stay pending, re-present after REVIEW_SNOOZE_SECONDS).
+button sits top-left where the traffic lights would be (they're hidden: the
+panel can't minimize or zoom, and the cross duplicated Snooze); it just
+closes the panel, and the menu bar interprets any close with undecided
+drafts (including Cmd-W) as a snooze (drafts stay pending, re-present after
+REVIEW_SNOOZE_SECONDS).
 
 Decision shape: {"n": int, "approved": bool, "loved": bool, "text": str,
 "edited": bool, "drop_link": bool, "reject_category": str|None,
@@ -134,14 +136,30 @@ try:
     from AppKit import NSWindowStyleMaskNonactivatingPanel
 except Exception:
     NSWindowStyleMaskNonactivatingPanel = 0
-# Title-bar "Snooze 1h" button (sits opposite the close cross). Missing on
-# very old AppKit; the card then degrades to cross-only (closing still
-# snoozes, the label is just absent).
+# Title-bar "Snooze 1h" button (top-left, where the traffic lights would be;
+# those are hidden because minimize/zoom are disabled no-ops on this panel and
+# the close cross just duplicated Snooze). Missing on very old AppKit; the
+# card then degrades to the stock cross (closing still snoozes, the labeled
+# button is just absent) because the traffic lights are only hidden when the
+# accessory actually mounted.
 try:
-    from AppKit import NSTitlebarAccessoryViewController, NSLayoutAttributeRight
+    from AppKit import (
+        NSTitlebarAccessoryViewController,
+        NSLayoutAttributeLeft,
+        NSLayoutAttributeRight,
+    )
 except Exception:
     NSTitlebarAccessoryViewController = None
+    NSLayoutAttributeLeft = None
     NSLayoutAttributeRight = None
+try:
+    from AppKit import (
+        NSWindowCloseButton,
+        NSWindowMiniaturizeButton,
+        NSWindowZoomButton,
+    )
+except Exception:
+    NSWindowCloseButton = NSWindowMiniaturizeButton = NSWindowZoomButton = None
 try:
     from AppKit import NSBezelStyleInline
 except Exception:
@@ -889,41 +907,95 @@ class _ReviewController(NSObject):
 
     @objc.python_method
     def _add_snooze_accessory(self, panel):
-        """"Snooze 1h" in the title bar, opposite the close cross: the explicit
-        "not now" affordance. It just closes the panel; the menu bar treats any
-        close with undecided drafts as a snooze, so the cross and this button
-        are the same action, this one merely says so out loud."""
-        if NSTitlebarAccessoryViewController is None or NSLayoutAttributeRight is None:
+        """Title-bar controls, replacing the traffic lights: "Snooze 1h" at
+        the top-left (minimize/zoom were disabled no-op dots on this panel,
+        and the close cross meant snooze anyway, so one labeled button says
+        what the only dismissal actually does) and "Discard all…" at the
+        top-right (moved here from the menu bar dropdown 2026-07-10; the
+        ellipsis is honest, the handler opens a confirmation alert first).
+        Snooze just closes the panel; the menu bar treats any close with
+        undecided drafts as a snooze. The traffic lights are hidden ONLY once
+        the snooze accessory mounts, so a failure on old AppKit leaves the
+        stock cross as the fallback dismissal. Cmd-W keeps working either way
+        (the Closable mask stays on)."""
+        if NSTitlebarAccessoryViewController is None or NSLayoutAttributeLeft is None:
             return
         try:
-            btn = NSButton.alloc().initWithFrame_(NSMakeRect(0, 0, 80, 17))
-            btn.setTitle_(_snooze_title())
-            if NSBezelStyleInline is not None:
-                btn.setBezelStyle_(NSBezelStyleInline)
-            else:
-                btn.setBezelStyle_(NSBezelStyleRounded)
-            btn.setFont_(NSFont.systemFontOfSize_(10.0))
-            btn.setToolTip_(
-                "Put these drafts away for now. They stay pending and the "
-                "card comes back later (or sooner from the S4L menu)."
+            self._add_titlebar_button(
+                panel,
+                title=_snooze_title(),
+                action="snoozeClicked:",
+                tooltip=(
+                    "Put these drafts away for now. They stay pending and the "
+                    "card comes back later (or sooner from the S4L menu)."
+                ),
+                layout=NSLayoutAttributeLeft,
             )
-            btn.setTarget_(self)
-            btn.setAction_("snoozeClicked:")
-            btn.sizeToFit()
-            bf = btn.frame()
-            holder = NSView.alloc().initWithFrame_(
-                NSMakeRect(0, 0, bf.size.width + 8, max(19, bf.size.height + 2))
-            )
-            btn.setFrameOrigin_(
-                (4, max(0, (holder.frame().size.height - bf.size.height) / 2.0))
-            )
-            holder.addSubview_(btn)
-            acc = NSTitlebarAccessoryViewController.alloc().init()
-            acc.setView_(holder)
-            acc.setLayoutAttribute_(NSLayoutAttributeRight)
-            panel.addTitlebarAccessoryViewController_(acc)
+            self._hide_traffic_lights(panel)
         except Exception as e:
             _log(f"snooze accessory unavailable: {e}")
+        if _discard_all_handler is not None and NSLayoutAttributeRight is not None:
+            try:
+                self._add_titlebar_button(
+                    panel,
+                    title="Discard all…",
+                    action="discardAllClicked:",
+                    tooltip=(
+                        "Throw away every pending draft (asks first). Nothing "
+                        "posts, and unlike a per-card reject this sends no "
+                        "feedback signal to the AI."
+                    ),
+                    layout=NSLayoutAttributeRight,
+                )
+            except Exception as e:
+                _log(f"discard-all accessory unavailable: {e}")
+
+    @objc.python_method
+    def _add_titlebar_button(self, panel, title, action, tooltip, layout):
+        btn = NSButton.alloc().initWithFrame_(NSMakeRect(0, 0, 80, 17))
+        btn.setTitle_(title)
+        if NSBezelStyleInline is not None:
+            btn.setBezelStyle_(NSBezelStyleInline)
+        else:
+            btn.setBezelStyle_(NSBezelStyleRounded)
+        btn.setFont_(NSFont.systemFontOfSize_(10.0))
+        btn.setToolTip_(tooltip)
+        btn.setTarget_(self)
+        btn.setAction_(action)
+        btn.sizeToFit()
+        bf = btn.frame()
+        holder = NSView.alloc().initWithFrame_(
+            NSMakeRect(0, 0, bf.size.width + 8, max(19, bf.size.height + 2))
+        )
+        btn.setFrameOrigin_(
+            (4, max(0, (holder.frame().size.height - bf.size.height) / 2.0))
+        )
+        holder.addSubview_(btn)
+        acc = NSTitlebarAccessoryViewController.alloc().init()
+        acc.setView_(holder)
+        acc.setLayoutAttribute_(layout)
+        panel.addTitlebarAccessoryViewController_(acc)
+
+    @objc.python_method
+    def _hide_traffic_lights(self, panel):
+        """Hide close/minimize/zoom once the Snooze accessory is up: minimize
+        and zoom are disabled dots (no Miniaturizable/Resizable in the mask)
+        and the cross duplicated Snooze. Hiding, not removing: performClose_
+        (Cmd-W and snoozeClicked_) still routes through the hidden close
+        button's machinery, and windowShouldClose_ still fires."""
+        if NSWindowCloseButton is None:
+            return
+        for which in (
+            NSWindowCloseButton,
+            NSWindowMiniaturizeButton,
+            NSWindowZoomButton,
+        ):
+            try:
+                b = panel.standardWindowButton_(which)
+                if b is not None:
+                    b.setHidden_(True)
+            except Exception:
+                pass
 
     def snoozeClicked_(self, sender):
         self._track("snooze")
@@ -933,6 +1005,20 @@ class _ReviewController(NSObject):
         except Exception:
             self._finish()
 
+    def discardAllClicked_(self, sender):
+        """Hand off to the menu bar's bulk-discard handler (registered via
+        set_discard_all_handler); it confirms with the user, flips the store,
+        and dismisses this panel via dismiss_active(), so nothing more happens
+        here. On cancel the card simply stays up."""
+        self._track("discard_all")
+        cb = _discard_all_handler
+        if cb is None:
+            return
+        try:
+            cb()
+        except Exception as e:
+            _log(f"discard-all handler failed: {e}")
+
     @objc.python_method
     def _eye_button(self, frame, kind):
         """Borderless SF-Symbol eye whose hover/click opens a popover. A plain
@@ -2122,6 +2208,21 @@ def set_feedback_handler(cb):
     _feedback_handler = cb
 
 
+# Bulk-discard hook for the title bar's "Discard all…" button, same
+# registration pattern as _feedback_handler above. The menu bar registers
+# _discard_all_pending here (it owns the confirmation alert, the store flip,
+# and dismissing the panel). Cards built while this is None simply don't get
+# the button.
+_discard_all_handler = None
+
+
+def set_discard_all_handler(cb):
+    """Register the title-bar "Discard all…" action. The menu bar calls this
+    before presenting cards with its bulk-discard handler."""
+    global _discard_all_handler
+    _discard_all_handler = cb
+
+
 def _feedback_frame():
     """Just below the open review card when there is one (so it never covers
     the card being reviewed), else the top-right corner of the pointer's

package/mcp/menubar/s4l_log_relay.py

@@ -165,6 +165,38 @@ def _loop():
             pass
 
 
+def emit(line, context="menubar"):
+    """Buffer ONE structured line for the relay under a caller-chosen context
+    (e.g. "browser-foreground"), and mirror it to the real stderr so the local
+    menubar.err.log keeps a copy. Bypasses the _Tee so the line is not ALSO
+    buffered under the default "menubar" context. Best-effort; never raises."""
+    try:
+        t = str(line).strip()
+        if not t or _BASE64_BLOB_RE.match(t):
+            return
+        real = sys.stderr._real if isinstance(sys.stderr, _Tee) else sys.stderr
+        try:
+            real.write(t + "\n")
+            real.flush()
+        except Exception:
+            pass
+        if not ENABLED:
+            return
+        with _lock:
+            _buf.append(
+                {
+                    "ts": _now_iso(),
+                    "stream": "stdout",
+                    "line": t[:MAX_LINE_LEN],
+                    "context": str(context or "menubar")[:200],
+                }
+            )
+            if len(_buf) > MAX_BUFFER:
+                del _buf[: len(_buf) - MAX_BUFFER]
+    except Exception:
+        pass
+
+
 def install():
     """Wrap sys.stderr with the relay tee and start the background flusher.
     Call once at menubar boot, after the S4L_REPO_DIR sys.path insertion."""

package/mcp/menubar/s4l_menubar.py

@@ -117,6 +117,19 @@ try:
 except Exception:
     pass
 
+# Ground-truth browser-foreground telemetry: whenever a MANAGED harness Chrome
+# becomes the frontmost app (fresh-launch activation, screencast bringToFront,
+# macOS clamping the off-screen window back on-screen, anything), ship one
+# structured line with context "browser-foreground" through the relay above.
+# Cause-agnostic OS-level observation; the causing sites (screencast.ts) log
+# their own attribution lines under the same context. Best-effort.
+try:
+    import s4l_browser_foreground  # noqa: E402
+
+    s4l_browser_foreground.install()
+except Exception:
+    pass
+
 
 def _capture(err, **tags):
     """Report a handled menu-bar error to Sentry (component=menubar) without ever
@@ -2800,8 +2813,11 @@ class S4LMenuBar(rumps.App):
 
             # present_feedback (the menu bar's feedback item) falls back to
             # the module-level default handler; register ours before any
-            # card shows.
+            # card shows. Same pattern for the title bar's "Discard all…"
+            # button (moved out of the dropdown 2026-07-10), which reuses the
+            # bulk-discard handler wholesale, confirmation alert included.
             s4l_card.set_feedback_handler(self._on_feedback_text)
+            s4l_card.set_discard_all_handler(self._discard_all_pending)
             s4l_card.present_review(
                 drafts,
                 on_decision=lambda d: self._on_card_decision(batch, d),
@@ -3531,12 +3547,9 @@ class S4LMenuBar(rumps.App):
                     )
                 )
             )
-        items.append(
-            rumps.MenuItem(
-                f"Discard {pending_count} pending draft{plural}…",
-                callback=self._discard_all_pending,
-            )
-        )
+        # No bulk-discard item here anymore: "Discard all…" lives in the
+        # review card's title bar (2026-07-10). Reaching it with no card open
+        # is "Review N pending drafts" -> Discard all, two clicks.
         return items
 
 

package/mcp/menubar/s4l_state.py

@@ -736,6 +736,37 @@ def _match_candidate(data, n, candidate_id):
     return None
 
 
+def candidate_state(c):
+    """Canonical lifecycle state of ONE review-queue candidate. Use this instead
+    of ad hoc flag checks — "not posted" is NOT "awaiting review".
+
+    The review queue (review-queue.json) is an APPEND-FOREVER LEDGER: handled
+    candidates are never removed, they are flag-stamped in place, so most rows
+    in an old queue are retired. States, in precedence order:
+
+      posted          — approved and successfully posted (our_url set).
+      terminal        — retired without a post; terminal_reason says why
+                        (rejected, human_rejected, human_discarded_all,
+                        duplicate_thread_pre_post, ...; None on older rows).
+      post_failed     — approved but the post attempt errored (post_error says
+                        why). Settled from the cards' point of view; the resume
+                        path retries only after a fresh approval clears it.
+      approved        — human approved, post not yet attempted/confirmed.
+      awaiting_review — none of the above. The ONLY state cards present, and
+                        the only honest "pending" count (review-request.json's
+                        .count mirrors it at merge time).
+    """
+    if c.get("posted") is True:
+        return "posted"
+    if c.get("terminal") is True:
+        return "terminal"
+    if c.get("post_failed"):
+        return "post_failed"
+    if c.get("approved") is True:
+        return "approved"
+    return "awaiting_review"
+
+
 def store_stamp_decision(batch, decision):
     """Write a card decision INTO the store the instant the user clicks. This is
     the durable record (the old approved-queue.json ledger is no longer
@@ -784,7 +815,7 @@ def discard_all_pending(drafts):
         done = 0
         for d in drafts:
             c = _match_candidate(data, d.get("n"), d.get("candidate_id"))
-            if c is None or c.get("posted") is True or c.get("terminal") is True:
+            if c is None or candidate_state(c) in ("posted", "terminal"):
                 continue
             c["terminal"] = True
             c["terminal_reason"] = "human_discarded_all"
@@ -865,7 +896,7 @@ def store_pending_posts(batch="review-queue"):
     plan = read_plan(store_path())
     out = []
     for i, c in enumerate((plan or {}).get("candidates") or []):
-        if not c.get("approved") or c.get("posted") or c.get("terminal") or c.get("post_failed"):
+        if candidate_state(c) != "approved":
             continue
         d = c.get("decision") or {}
         out.append(
@@ -932,7 +963,7 @@ def review_queue_posted_count():
     cands = (plan or {}).get("candidates")
     if not cands:
         return None
-    return sum(1 for c in cands if c.get("posted") is True)
+    return sum(1 for c in cands if candidate_state(c) == "posted")
 
 
 def _plan_generation(batch):
@@ -1008,7 +1039,9 @@ def review_drafts(plan, batch="review-queue"):
     settled_ns = {it.get("n") for it in items if it.get("candidate_id") is None}
     out = []
     for i, c in enumerate(((plan or {}).get("candidates") or [])):
-        if c.get("posted") is True or c.get("terminal") is True or c.get("approved") is True:
+        # Only awaiting_review rows become cards. This also skips post_failed
+        # rows (decided-but-failed is settled per the docstring above).
+        if candidate_state(c) != "awaiting_review":
             continue
         cid = c.get("candidate_id")
         if cid is not None and cid in settled_ids:

package/mcp/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l-mcp",
-  "version": "1.7.2",
+  "version": "1.7.4-rc.1",
   "private": true,
   "description": "Desktop MCP client for social-autoposter (X/Twitter rail): manual draft/review/approve loop, autopilot control, and stats. Thin wrapper over the existing pipeline scripts.",
   "license": "MIT",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l",
-  "version": "1.7.2",
+  "version": "1.7.4-rc.1",
   "description": "Automated social posting pipeline for Reddit, X/Twitter, LinkedIn, and Moltbook. Install as a Claude Code agent skill.",
   "bin": {
     "social-autoposter": "bin/cli.js",

package/scripts/build_persona.py

@@ -90,9 +90,14 @@ GROUNDING_INSTRUCTIONS = (
     "  description    2-3 sentences: who this person is as a builder/voice.\n"
     "  content_angle  one paragraph of concrete, first-hand experience the "
     "persona can speak from (real projects, real numbers, real pain).\n"
-    "  voice          {tone, never[]}: how they actually write (read their own "
-    "posts/replies in the x source). Keep the organic rules: first person, "
-    "specific, no links, no feature lists, no sales, no em dashes.\n"
+    "  voice          {tone, never[], examples[]}: how they actually write (read "
+    "their own posts/replies in the x source). Keep the organic rules: first "
+    "person, specific, no links, no feature lists, no sales, no em dashes. For "
+    "examples[], the x source pre-ranks their best real replies/posts by "
+    "engagement (top_replies / top_posts, each with stats, the parent tweet, and "
+    "thread continuations): keep up to 5 verbatim, or run "
+    "`voice_exemplars.py apply --scan <x-source.json>` after apply to write "
+    "voice.examples + the persona_corpus.txt exemplar section deterministically.\n"
     "  search_topics  ~15 topics they have genuine experience with.\n"
     "  content_corpus (OPTIONAL but STRONGLY encouraged) the RAW gathered "
     "corpus as one plain-text block: the persona's actual posts, replies, repo "

package/scripts/engagement_styles.py

@@ -1034,7 +1034,18 @@ def compute_target_distribution(platform, context="posting"):
 # mode="invent" and the prompt hands the model the top N as reference
 # material to derive a new style from.
 
-INVENT_RATE = 0.05  # ~1 in 20 posts forces a new-style invention
+# 2026-07-10: inline invention retired (rate 0). It ran inside the drafting
+# prep session with the top-performers leaderboard + winner exemplars in
+# context, so every "new" style was a renamed clone of the winning
+# agree-then-relocate move; combined with name-only dedup the registry hit
+# ~938 styles that were mostly one structure. Invention now lives in the
+# standalone scripts/invent_styles.py job (operator-only launchd
+# com.m13v.s4l-invent-styles: the registry is global across installs, so a
+# central daily run replaces per-post rolls). The invent-mode plumbing in
+# pickers/posters is kept intact: register_style() is what the standalone
+# job calls, and a nonzero rate here re-enables the inline path if ever
+# wanted.
+INVENT_RATE = 0.0  # retired inline roll (was 0.05, ~1 in 20 posts)
 CURATED_TOP_N = 5   # size of the invent-mode reference list (top 5 by score)
 
 # Fallback target comment length (chars) for any style that lacks an explicit