@m13v/s4l 1.7.2-rc.6 → 1.7.2-rc.8

package/mcp/dist/index.js

@@ -2244,7 +2244,17 @@ tool("post_drafts", {
             return;
         }
         c.terminal = true;
-        c.terminal_reason = "rejected";
+        // Preserve a more specific reason the menu bar already stamped locally
+        // (store_stamp_decision writes "human_rejected" for a card reject,
+        // discard_all_pending writes "human_discarded_all" for the bulk-discard
+        // button) BEFORE this loopback call ever fires, so by the time it lands
+        // here the local reason is already the more informative one. Only
+        // default to "rejected" when nothing more specific got there first
+        // (e.g. a reject driven straight from chat, with no menu-bar card
+        // involved at all).
+        if (!c.terminal_reason) {
+            c.terminal_reason = "rejected";
+        }
         c.approved = false;
         rejected.push(n);
     });

package/mcp/dist/version.json

@@ -1,4 +1,4 @@
 {
-  "version": "1.7.2-rc.6",
-  "installedAt": "2026-07-09T01:53:09.637Z"
+  "version": "1.7.2-rc.8",
+  "installedAt": "2026-07-09T02:48:04.544Z"
 }

package/mcp/manifest.json

@@ -2,7 +2,7 @@
   "dxt_version": "0.1",
   "name": "social-autoposter",
   "display_name": "S4L",
-  "version": "1.7.2-rc.6",
+  "version": "1.7.2-rc.8",
   "description": "Draft, review, approve, and autopilot X/Twitter posts.",
   "long_description": "## **⚠️ The disclaimer above is generic Claude boilerplate.** Anthropic shows the same warning on every plugin regardless of what it does; any plugin has the same level of access as any app you download from the internet.\n\nS4L is an open source product developed by Mediar.ai Incorporated, a VC-backed San Francisco-based startup.\n\nTo get started:\n\n1\\. Copy this prompt: **Set me up on S4L plugin end to end**\n\n2\\. Quit with CMD+Q, reopen Claude, paste into a new chat.\n\nWhat happens next:\n\n* About every 5 minutes S4L scans X for posts that match your topics and drafts replies in your voice.\n* Drafts show up as review cards, usually the first within a few minutes. Nothing is posted automatically; you approve each one.\n* Posting autopilot stays off until you explicitly turn it on.",
   "author": {

package/mcp/menubar/s4l_menubar.py

@@ -2930,12 +2930,17 @@ class S4LMenuBar(rumps.App):
             self._alert("Discard failed", str(e)[:200])
             return
         ns = [d.get("n") for d in drafts if d.get("n") is not None]
+        cids = [d.get("candidate_id") for d in drafts if d.get("candidate_id") is not None]
 
         def _persist_discard():
             try:
                 st.post_drafts(batch, reject=ns, timeout=60)
             except Exception:
                 pass
+            try:
+                st.flip_discarded_candidates_skipped(cids)
+            except Exception:
+                pass
 
         threading.Thread(target=_persist_discard, daemon=True).start()
         try:

package/mcp/menubar/s4l_state.py

@@ -803,6 +803,45 @@ def discard_all_pending(drafts):
     return _store_update(mutate) or 0
 
 
+def flip_discarded_candidates_skipped(candidate_ids):
+    """Flip each bulk-discarded candidate's twitter_candidates row to
+    status='skipped', skip_reason='human_discarded_all' — the same DB effect a
+    normal reject gets for free as a side effect of its review-events insert
+    (see review-events/route.ts). The bulk-discard path deliberately never
+    ships a review event (that's the whole point — it must not reach the
+    feedback digest), so without this direct call the row would stay
+    'pending' until the independent age-based freshness gate happens to expire
+    it, wide open to re-discovery/re-drafting of the exact draft a human just
+    discarded. One PATCH per candidate via the SAME direct-HTTP path
+    flush_review_events already uses (http_api), so this never touches
+    review_events. Best-effort: a candidate that already expired/posted by the
+    time this runs (404, no longer 'pending') is a no-op, not a failure."""
+    if not candidate_ids:
+        return
+    try:
+        from http_api import api_patch
+    except Exception as err:
+        sys.stderr.write(
+            f"[s4l-state] flip_discarded_candidates_skipped: http_api unavailable "
+            f"({type(err).__name__}: {err}); {len(candidate_ids)} candidate(s) left 'pending'\n"
+        )
+        sys.stderr.flush()
+        return
+    for cid in candidate_ids:
+        try:
+            api_patch(
+                "/api/v1/twitter-candidates/by-id",
+                {"id": cid, "action": "mark_skipped", "reason": "human_discarded_all"},
+                ok_on_404=True,
+            )
+        except Exception as err:
+            sys.stderr.write(
+                f"[s4l-state] flip_discarded_candidates_skipped: PATCH failed for "
+                f"candidate_id={cid} ({type(err).__name__}: {err})\n"
+            )
+            sys.stderr.flush()
+
+
 def store_mark_post_failed(batch, n, candidate_id=None, error=None):
     """A decided post that FAILED surfaces via notification/dashboard, not by
     re-presenting the card and not by endless resume retries."""

package/mcp/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l-mcp",
-  "version": "1.7.2-rc.6",
+  "version": "1.7.2-rc.8",
   "private": true,
   "description": "Desktop MCP client for social-autoposter (X/Twitter rail): manual draft/review/approve loop, autopilot control, and stats. Thin wrapper over the existing pipeline scripts.",
   "license": "MIT",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l",
-  "version": "1.7.2-rc.6",
+  "version": "1.7.2-rc.8",
   "description": "Automated social posting pipeline for Reddit, X/Twitter, LinkedIn, and Moltbook. Install as a Claude Code agent skill.",
   "bin": {
     "social-autoposter": "bin/cli.js",

package/scripts/salvage_orphaned_prep_results.py

@@ -18,10 +18,14 @@ Safe by construction:
   - Best-effort: any single failure is logged and skipped; never raises.
 
 Degradation vs a normal cycle: salvaged candidates skip the cycle's post-provider
-top-N selection (so MORE cards, which is fine) and lack the tail-link / experiments
-arm stamp that run-twitter-cycle.sh's plan writer adds after the provider returns.
-The reply text itself is complete. A salvaged card is strictly better than a lost
-draft.
+top-N selection (so MORE cards, which is fine), lack the tail-link / experiments
+arm stamp that run-twitter-cycle.sh's plan writer adds after the provider returns,
+and (two-draft schema only) lack assigned_style/assigned_mode, which live in the
+cycle's shell variables, not the model output. The reply text itself IS complete
+end-to-end (_mirror_two_draft_fields backfills reply_text/drafts from
+draft_a_text/draft_b_text for the post-2026-07-07/08 two-draft schema, since the
+model output alone has no reply_text field to check for completeness). A salvaged
+card is strictly better than a lost draft.
 
 Usage:
     python3 scripts/salvage_orphaned_prep_results.py            # automated (safe age gate)
@@ -59,6 +63,52 @@ except Exception:  # standalone fallbacks
             pass
 
 
+def _mirror_two_draft_fields(candidates):
+    """Backfill reply_text/drafts for two-draft-schema candidates (2026-07-07/08
+    redesign) that reach salvage. The normal cycle path (run-twitter-cycle.sh)
+    mirrors draft_a_text onto reply_text/engagement_style/drafts right after the
+    model returns, but salvage bypasses that shell-side step entirely, so an
+    orphaned post-redesign result reached review cards with NEITHER field set.
+    The menubar card (s4l_card.py) reads d.get("drafts") first, then falls back
+    to d.get("reply_text") or "", so those cards rendered the thread with a
+    completely empty editable reply box despite draft_a_text/draft_b_text
+    holding real, already-drafted content (root-caused 2026-07-09 via
+    candidate 374925 and 4 siblings, all missing 'experiments' too, confirming
+    they came through this salvage path rather than a normal cycle write).
+
+    assigned_style/assigned_mode are deliberately left OUT (not set to None,
+    just absent): the picker's per-cycle style assignment lives only in
+    run-twitter-cycle.sh's shell variables, not in the model's JSON output, so
+    it can't be recovered here. twitter_post_plan.py already has a documented
+    fallback for that ("assigned_mode key absent" -> use the plan-level
+    assignment, itself None for a salvaged plan), so leaving the keys out is
+    the safe, already-supported degradation, same class as the existing
+    no-experiments-stamp degradation.
+    """
+    for c in candidates:
+        if not isinstance(c, dict) or "draft_a_text" not in c or "reply_text" in c:
+            continue
+        c["reply_text"] = c.get("draft_a_text") or ""
+        c["engagement_style"] = c.get("draft_a_style") or ""
+        c["new_style"] = c.get("draft_a_new_style")
+        if c.get("draft_a_text_en"):
+            c["reply_text_en"] = c["draft_a_text_en"]
+        draft_b_text = c.get("draft_b_text")
+        if not c.get("is_reused_draft") and draft_b_text:
+            c["drafts"] = [
+                {
+                    "variant": "a", "text": c.get("draft_a_text") or "",
+                    "style": c.get("draft_a_style") or "",
+                    "text_en": c.get("draft_a_text_en"),
+                },
+                {
+                    "variant": "b", "text": draft_b_text,
+                    "style": c.get("draft_b_style") or "",
+                    "text_en": c.get("draft_b_text_en"),
+                },
+            ]
+
+
 def _is_prep_result(obj):
     """True iff obj looks like a twitter-prep result (drafted candidates).
 
@@ -142,6 +192,7 @@ def main():
                     pass
             continue
 
+        _mirror_two_draft_fields(obj["candidates"])
         n = len(obj["candidates"])
         age_min = (now - st.st_mtime) / 60.0
         _plog(f"[salvage] ORPHAN prep result job {job_id}: producer never consumed it "