@m13v/s4l 1.7.1-rc.21 → 1.7.1-rc.22

package/mcp/dist/version.json

@@ -1,4 +1,4 @@
 {
-  "version": "1.7.1-rc.21",
-  "installedAt": "2026-07-08T19:14:19.569Z"
+  "version": "1.7.1-rc.22",
+  "installedAt": "2026-07-08T20:01:27.584Z"
 }

package/mcp/manifest.json

@@ -2,7 +2,7 @@
   "dxt_version": "0.1",
   "name": "social-autoposter",
   "display_name": "S4L",
-  "version": "1.7.1-rc.21",
+  "version": "1.7.1-rc.22",
   "description": "Draft, review, approve, and autopilot X/Twitter posts.",
   "long_description": "## **⚠️ The disclaimer above is generic Claude boilerplate.** Anthropic shows the same warning on every plugin regardless of what it does; any plugin has the same level of access as any app you download from the internet.\n\nS4L is an open source product developed by Mediar.ai Incorporated, a VC-backed San Francisco-based startup.\n\nTo get started:\n\n1\\. Copy this prompt: **Set me up on S4L plugin end to end**\n\n2\\. Quit with CMD+Q, reopen Claude, paste into a new chat.\n\nWhat happens next:\n\n* About every 5 minutes S4L scans X for posts that match your topics and drafts replies in your voice.\n* Drafts show up as review cards, usually the first within a few minutes. Nothing is posted automatically; you approve each one.\n* Posting autopilot stays off until you explicitly turn it on.",
   "author": {

package/mcp/menubar/s4l_card.py

@@ -619,7 +619,7 @@ class _ReviewController(NSObject):
         # Two-draft cards (2026-07-08 redesign, no-recommendation pass same
         # day): both drafts render at once as separate editable boxes;
         # `_selected_draft` (0=a, 1=b) is "whichever box the reviewer is
-        # currently in", driven by focus (see textDidBeginEditing_ below),
+        # currently in", driven by caret movement (see textViewDidChangeSelection_ below),
         # not a button. None = not yet chosen this card, _render() defaults
         # it to slot 0 (Draft A) — the model never picks a favorite, so
         # there's no recommendation to default to instead. Reset to None on
@@ -1076,9 +1076,9 @@ class _ReviewController(NSObject):
         # day): show BOTH drafts at once, stacked, each independently
         # editable, rather than a toggle that swaps one field's content. No
         # buttons: selection is "whichever box the reviewer is currently in",
-        # shown via that box's own border (an accent outline vs a plain
-        # hairline, mirroring a standard focus ring) and updated live by
-        # textDidBeginEditing_ below. The model never picks a favorite
+        # shown via a dedicated outline view wrapping that box (an accent
+        # outline vs a plain hairline, mirroring a standard focus ring) and
+        # updated live by textViewDidChangeSelection_ below. The model never picks a favorite
         # (removed 2026-07-08 per user: no ask-the-model-to-recommend), so
         # Draft A (slot 0) is simply the fixed default until the reviewer
         # clicks into Draft B. Absent/short (reused stale draft, legacy plan)
@@ -1089,7 +1089,7 @@ class _ReviewController(NSObject):
         if dual:
             self._selected_draft = sel_idx
 
-        edit_top = H - 172 - 6
+        edit_top = H - 172 - 3
         link = d.get("link_url")
 
         # Tail link baked at draft time is normally already in each draft's
@@ -1102,10 +1102,15 @@ class _ReviewController(NSObject):
 
         self._draft_textviews = {}
         self._draft_scrolls = {}
+        self._draft_outlines = {}
         if dual:
             avail_h = edit_top - M
             gap = 5
-            label_h = 15
+            # Reserved only for foreign-language cards, which show a muted
+            # "EN:" line above each box; English drafts (the common case)
+            # have nothing to put there, so reserving it unconditionally used
+            # to leave a dead 15px gap above every box for no reason.
+            label_h = 15 if is_foreign else 0
             unit = (avail_h - gap) / 2.0
             box_h = unit - label_h
             for slot in (0, 1):
@@ -1126,14 +1131,33 @@ class _ReviewController(NSObject):
                             truncates=True,
                         )
                     )
+                # The selection ring can't be drawn on the scroll view's own
+                # layer: NSScrollView's opaque clip/document view fully paints
+                # over its parent layer's border, so setBorderWidth/Color on
+                # scroll.layer() is accepted (no error) but never visibly
+                # renders, at any width or color (verified empirically). A
+                # separate outline view, sized to the box and holding the
+                # scroll view inset a few px inside it, keeps the ring
+                # unobstructed since nothing opaque reaches its edge.
+                outline_frame = NSMakeRect(M, box_y, W - 2 * M, box_h)
+                outline = NSView.alloc().initWithFrame_(outline_frame)
+                _round_rect(outline)
+                inset = 3
                 scroll, tv = _editable_scroll(
-                    NSMakeRect(M, box_y, W - 2 * M, box_h), _compose(draft.get("text"))
+                    NSMakeRect(
+                        inset,
+                        inset,
+                        outline_frame.size.width - 2 * inset,
+                        outline_frame.size.height - 2 * inset,
+                    ),
+                    _compose(draft.get("text")),
                 )
                 tv.setDelegate_(self)
-                content.addSubview_(scroll)
+                outline.addSubview_(scroll)
+                content.addSubview_(outline)
                 self._draft_scrolls[slot] = scroll
+                self._draft_outlines[slot] = outline
                 self._draft_textviews[slot] = tv
-            self._update_draft_borders()
             tv = self._draft_textviews[sel_idx]
         else:
             reply = d.get("reply_text") or ""
@@ -1161,6 +1185,13 @@ class _ReviewController(NSObject):
         self._textview = tv
 
         self._panel.setContentView_(_frosted(content))
+        if dual:
+            # Layer border properties set before a view is attached to its
+            # eventual window get silently dropped when AppKit backs the view
+            # for real on attach, so the accent outline must be (re)applied
+            # only after setContentView_ installs the view tree, not during
+            # construction above.
+            self._update_draft_borders()
         # Counter lives in the native title bar, not inside the content, with
         # the product name so a stray card is identifiable at a glance.
         self._panel.setTitle_(
@@ -1342,14 +1373,18 @@ class _ReviewController(NSObject):
             pass
         return True
 
-    # NSTextView/NSText delegate: fires when a text view becomes the one
-    # being edited, i.e. right when it gains focus (click or tab), before any
-    # keystroke. Two-draft cards use this as the ONLY selection mechanism:
-    # whichever draft box the reviewer is in IS the selected one. Only the
-    # two draft boxes set self as delegate for this notification (the
-    # read-only thread quote never fires it), so no candidate_id lookup is
-    # needed, just a slot match against self._draft_textviews.
-    def textDidBeginEditing_(self, notification):
+    # NSTextView delegate: fires the instant the caret/selection moves inside
+    # a text view, which includes a plain click-to-place-cursor with no
+    # keystroke (unlike NSTextDidBeginEditingNotification/textDidBeginEditing_,
+    # which only fires once an actual edit starts and does NOT fire from
+    # clicking into a box to merely place the cursor, verified empirically —
+    # that gap was the "clicking the other draft doesn't select it" bug).
+    # Two-draft cards use this as the ONLY selection mechanism: whichever
+    # draft box the reviewer is in IS the selected one. Only the two draft
+    # boxes set self as delegate for this notification (the read-only thread
+    # quote never fires it), so no candidate_id lookup is needed, just a slot
+    # match against self._draft_textviews.
+    def textViewDidChangeSelection_(self, notification):
         try:
             tv = notification.object()
         except Exception:
@@ -1363,15 +1398,16 @@ class _ReviewController(NSObject):
 
     @objc.python_method
     def _update_draft_borders(self):
-        """Redraw the two draft boxes' borders in place (no re-render, so an
-        in-progress edit/caret in either box is never disturbed): the
-        selected box gets a thicker system-accent outline (the platform's own
-        selection color, respects the user's macOS accent choice and
-        light/dark mode), the other a plain hairline, matching the existing
-        thread-quote/editable-field border look."""
-        for slot, scroll in (self._draft_scrolls or {}).items():
+        """Redraw the two draft boxes' selection ring in place (no re-render,
+        so an in-progress edit/caret in either box is never disturbed): the
+        selected box's outline view gets a thicker system-accent outline (the
+        platform's own selection color, respects the user's macOS accent
+        choice and light/dark mode), the other a plain hairline. Applied to
+        the dedicated outline wrapper, not the scroll view itself; see the
+        comment at its construction in _render for why."""
+        for slot, outline in (self._draft_outlines or {}).items():
             try:
-                layer = scroll.layer()
+                layer = outline.layer()
                 if layer is None:
                     continue
                 if slot == self._selected_draft:

package/mcp/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l-mcp",
-  "version": "1.7.1-rc.21",
+  "version": "1.7.1-rc.22",
   "private": true,
   "description": "Desktop MCP client for social-autoposter (X/Twitter rail): manual draft/review/approve loop, autopilot control, and stats. Thin wrapper over the existing pipeline scripts.",
   "license": "MIT",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@m13v/s4l",
-  "version": "1.7.1-rc.21",
+  "version": "1.7.1-rc.22",
   "description": "Automated social posting pipeline for Reddit, X/Twitter, LinkedIn, and Moltbook. Install as a Claude Code agent skill.",
   "bin": {
     "social-autoposter": "bin/cli.js",
@@ -155,6 +155,7 @@
     "node": ">=16"
   },
   "dependencies": {
+    "@sentry/node": "^10.64.0",
     "firebase-admin": "^13.8.0",
     "pg": "^8.20.0",
     "ws": "^8.0.0"

package/scripts/merge_review_queue.py

@@ -262,22 +262,48 @@ def main() -> int:
     plan_obj = {"candidates": merged}
     if plan_created_at:
         plan_obj["created_at"] = plan_created_at
-    _atomic_write(dst, plan_obj)
-    ensure_store_symlink()
-
-    # Refresh the review-request marker the menu bar polls (count = pending, not posted).
-    pending = len([c for c in merged if not c.get("posted")])
-    project = ns.project or batch.get("project") or (new_cands[0].get("matched_project") if new_cands else None)
-    _atomic_write(
-        review_request_path(),
-        {
-            "batch_id": REVIEW_QUEUE_ID,
-            "project": project,
-            "count": pending,
-            "plan_path": dst,
-            "created_at": time.strftime("%Y-%m-%dT%H:%M:%SZ", time.gmtime()),
-        },
-    )
+
+    # This is the actual delivery: if anything below throws, the cycle's drafts
+    # were computed but never reached the store the menu bar reads, and the
+    # wrapper (run-draft-and-publish.sh) captures this process's whole stdout+
+    # stderr with `|| true`, so a crash here previously vanished into a local
+    # log nothing central reads — the exact blind spot that cost the 2026-07-08
+    # Karol investigation its root cause. Report it like any other handled
+    # pipeline failure (see twitter_post_plan.py's post-failure capture).
+    try:
+        _atomic_write(dst, plan_obj)
+        ensure_store_symlink()
+
+        # Refresh the review-request marker the menu bar polls (count = pending, not posted).
+        pending = len([c for c in merged if not c.get("posted")])
+        project = ns.project or batch.get("project") or (new_cands[0].get("matched_project") if new_cands else None)
+        _atomic_write(
+            review_request_path(),
+            {
+                "batch_id": REVIEW_QUEUE_ID,
+                "project": project,
+                "count": pending,
+                "plan_path": dst,
+                "created_at": time.strftime("%Y-%m-%dT%H:%M:%SZ", time.gmtime()),
+            },
+        )
+    except Exception as e:
+        print(f"[merge_review_queue] delivery failed (drafts NOT merged into cards): {e}", file=sys.stderr)
+        try:
+            import sentry_init
+
+            sentry_init.init()
+            sentry_init.capture_message(
+                f"merge_review_queue delivery failed: {e}",
+                level="error",
+                tags={"component": "merge_review_queue", "added": str(added)},
+                extra={"plan_src": src},
+            )
+            sentry_init.flush(2.0)
+        except Exception:
+            pass
+        return 1
+
     print(
         f"[merge_review_queue] merged {added} new draft(s) into {REVIEW_QUEUE_ID} "
         f"({pending} pending total) from {os.path.basename(src)}",

package/scripts/scan_pii.py

@@ -56,6 +56,14 @@ SECRET_PATTERNS = [
 # Absolute home path leak. Placeholder forms (/Users/<you>, /Users/USERNAME) pass.
 HOME_PATH_RE = re.compile(r"/Users/(?!<|USER|USERNAME|you\b|me\b|name\b)[a-z0-9._-]{2,}", re.I)
 
+
+def _home_path_exempt(path: str) -> bool:
+    """launchd .plist files legitimately require absolute paths — launchd does not
+    expand ~ or $HOME in ProgramArguments/StandardOutPath/etc. The repo already
+    tracks 70+ of them, so exempt this file class from the absolute-home-path rule.
+    Secrets, PII, and image checks still apply."""
+    return path.startswith("launchd/") and path.endswith(".plist")
+
 IMAGE_EXT = {".png", ".jpg", ".jpeg", ".gif", ".webp", ".heic", ".bmp", ".tiff"}
 
 
@@ -146,7 +154,7 @@ def scan(paths: list[str], staged: bool) -> tuple[list[str], list[str]]:
             if deny_re and deny_re.search(text):
                 m = deny_re.search(text)
                 hard.append(f"{path}:{lineno}: PII denylist match ('{m.group(0)}')")
-            if HOME_PATH_RE.search(text):
+            if HOME_PATH_RE.search(text) and not _home_path_exempt(path):
                 m = HOME_PATH_RE.search(text)
                 (hard if staged else soft).append(
                     f"{path}:{lineno}: absolute home path ('{m.group(0)}...')"