@m13v/s4l 1.6.202 → 1.6.203-rc.10

package/mcp/dist/index.js

@@ -408,8 +408,8 @@ function toolActivityLabel(name, args) {
     const fallback = TOOL_ACTIVITY[name];
     if (!fallback)
         return null;
-    const override = typeof args?.__saps_activity_label === "string"
-        ? args.__saps_activity_label.replace(/\s+/g, " ").trim().slice(0, 80)
+    const override = typeof args?.__s4l_activity_label === "string"
+        ? args.__s4l_activity_label.replace(/\s+/g, " ").trim().slice(0, 80)
         : "";
     return override || fallback;
 }
@@ -1247,7 +1247,7 @@ async function seedSearchQueriesForProject(project, rawQueries) {
 // ---- engagement_mode: choose personal-brand vs product (setup-time) --------
 // Part of onboarding: AFTER X connect + profile_scan, BEFORE product config, the
 // agent asks the user which mode they want and calls this. It persists the mode
-// (scripts/saps_mode.py, the single source of truth the cycle reads) and
+// (scripts/s4l_mode.py, the single source of truth the cycle reads) and
 // provisions the persona project (grounded in the profile scan), then the agent
 // continues to product setup — a product is always configured regardless of mode.
 tool("engagement_mode", {
@@ -1301,7 +1301,7 @@ tool("engagement_mode", {
             .optional()
             .describe("The RAW voice-memo transcript from the onboarding dictation interview, VERBATIM (do NOT " +
             "paraphrase or summarize). Persisted to the persona_corpus.txt sidecar (never config.json), " +
-            "capped ~8000 chars. This is the grounding pool the drafter quotes real specifics from " +
+            "capped ~100000 chars. This is the grounding pool the drafter quotes real specifics from " +
             "(actual projects, numbers, opinions, phrasing), so keep it dense and first-hand."),
         voice: z
             .any()
@@ -1323,7 +1323,7 @@ tool("engagement_mode", {
 }, async (args) => {
     const action = args.action || "get";
     const readFlags = async () => {
-        const cur = await runPython("scripts/saps_mode.py", ["flags"], { timeoutMs: 15_000 });
+        const cur = await runPython("scripts/s4l_mode.py", ["flags"], { timeoutMs: 15_000 });
         try {
             const f = JSON.parse((cur.stdout || "").trim());
             return { personal_brand: !!f.personal_brand, promotion: !!f.promotion };
@@ -1339,11 +1339,11 @@ tool("engagement_mode", {
         return jsonContent({ flags, mode, persona: persona ? persona.name : null });
     }
     // Lightweight flip of ONE lane (the dashboard/menu-bar quick toggle): just
-    // rewrite mode.json via saps_mode.py — NO persona provisioning. Mirrors the
+    // rewrite mode.json via s4l_mode.py — NO persona provisioning. Mirrors the
     // menu bar's pure-local _toggle_lane so flipping from either surface is cheap.
     if (action === "toggle") {
         const lane = args.lane === "promotion" ? "promotion" : "personal_brand";
-        const res = await runPython("scripts/saps_mode.py", ["toggle", lane], { timeoutMs: 15_000 });
+        const res = await runPython("scripts/s4l_mode.py", ["toggle", lane], { timeoutMs: 15_000 });
         if (res.code !== 0) {
             const tail = (res.stderr || res.stdout).trim().split("\n").slice(-1)[0] || "unknown error";
             return textContent(`Could not switch lane: ${tail}`);
@@ -1373,12 +1373,18 @@ tool("engagement_mode", {
     }
     const mode = personalBrand ? "personal_brand" : "promotion";
     recordOnboardingAttempt("mode_chosen", { personal_brand: personalBrand, promotion });
-    const setRes = await runPython("scripts/saps_mode.py", ["set-flags", personalBrand ? "1" : "0", promotion ? "1" : "0"], { timeoutMs: 15_000 });
+    const setRes = await runPython("scripts/s4l_mode.py", ["set-flags", personalBrand ? "1" : "0", promotion ? "1" : "0"], { timeoutMs: 15_000 });
     if (setRes.code !== 0) {
         const tail = (setRes.stderr || setRes.stdout).trim().split("\n").slice(-1)[0] || "unknown error";
         blockOnboardingMilestone("mode_chosen", "mode_set_failed", tail, { personal_brand: personalBrand, promotion });
         return textContent(`Couldn't save the engagement lanes: ${tail}`);
     }
+    // NOTE (2026-07-06): the draft-only flag (mode.json {"draft_only": false} —
+    // promotion cycles POST autonomously instead of drafting cards) is
+    // DELIBERATELY NOT exposed on this tool or any user surface. It is an
+    // operator-only switch, set via `scripts/s4l_mode.py draft-only on|off`.
+    // run-draft-and-publish.sh reads it per cycle. Do not add a tool param,
+    // menubar toggle, or onboarding step for it.
     // Provision the persona (grounded from the scan when supplied) regardless of
     // mode, so the toggle always has a real persona to flip to.
     let personaName;
@@ -1794,70 +1800,52 @@ tool("project_config", {
     }
     // Status / discovery mode: no project name supplied, or explicitly asked.
     if (args.status === true || !args.name) {
-        const projects = listManagedProjectStatus();
-        const rtReady = runtimeReady();
-        // On a bare .mcpb install the runtime step also materializes the pipeline
-        // source that xStatus shells into. Status must still work before that first
-        // install, otherwise the agent cannot discover that installation is the
-        // next milestone. Avoid probing Python until the owned runtime is ready.
-        const x = rtReady
-            ? await xStatus().catch(() => ({ connected: false, state: "status_unavailable" }))
-            : { connected: false, state: "runtime_not_ready" };
-        await ensureDoctorPhase(x.connected ? "full" : "pre_connect");
-        const ver = await versionStatus();
-        const configured = projects.some((p) => p.ready);
-        if (rtReady)
-            completeOnboardingMilestone("runtime_ready");
-        if (x.connected) {
-            completeOnboardingMilestone("x_connected", { state: x.state || "connected" });
-        }
-        if (configured) {
-            completeOnboardingMilestone("project_ready", {
-                missing_count: 0,
-            });
-        }
-        // mode_chosen completes when the user explicitly picked a mode (mode.json
-        // exists) OR this is a legacy install already past setup (a ready product),
-        // so adding this step never regresses an already-onboarded box.
-        if (modeChosen() || configured) {
-            completeOnboardingMilestone("mode_chosen", {
-                source: modeChosen() ? "chosen" : "backfilled_legacy",
-            });
-        }
+        // ONE compute path: buildSnapshot -> scripts/snapshot.py, the same source
+        // the menu bar and browser dashboard read. This branch used to recompute
+        // projects/X/version inline (listManagedProjectStatus + xStatus), which
+        // excluded the persona project and carried no setup_complete — so the
+        // panel's refresh() disagreed with the dashboard tool and the menu bar on
+        // persona-only setups. Do not reintroduce a parallel compute here.
+        const snap = await buildSnapshot();
+        const projects = Array.isArray(snap.projects) ? snap.projects : [];
+        const rtReady = !!snap.runtime_ready;
+        const xConnected = !!snap.x_connected;
+        const configured = (snap.projects_ready || 0) > 0;
         return jsonContent({
             configured,
             projects,
             runtime_ready: rtReady,
-            x_connected: x.connected,
-            x_state: x.state,
-            x_handle: x.handle ?? null,
-            mcp_version: ver.installed,
-            latest_version: ver.latest,
-            update_available: ver.update_available,
-            mode: currentMode(),
-            flags: currentFlags(),
-            update_hint: ver.update_available
-                ? `A newer version (${ver.latest}) is available — you're on ${ver.installed}. ` +
+            x_connected: xConnected,
+            x_state: snap.x_state,
+            x_handle: snap.x_handle ?? null,
+            setup_complete: !!snap.setup_complete,
+            mcp_version: snap.version,
+            latest_version: snap.latest_version,
+            update_available: !!snap.update_available,
+            mode: snap.mode,
+            flags: snap.flags,
+            update_hint: snap.update_available
+                ? `A newer version (${snap.latest_version}) is available — you're on ${snap.version}. ` +
                     `Tell the user and offer to run the \`runtime\` tool with action:'update' ` +
                     `(or \`npx social-autoposter@latest update\`).`
                 : undefined,
             required_fields: REQUIRED_FIELDS,
             recommended_fields: RECOMMENDED_FIELDS,
             config_path: configPath(),
-            ready_for_verification: rtReady && configured && x.connected,
-            onboarding: onboardingSnapshot(),
+            ready_for_verification: !!snap.setup_complete,
+            onboarding: snap.onboarding,
             next_step: !rtReady
                 ? "Runtime is not ready yet. It provisions automatically on boot — poll runtime action:'status' until ready (only call runtime action:'install' to retry if status shows the boot provision failed or stalled), then continue setup automatically."
                 : projects.length === 0
                     ? "No projects yet. Discover the product from conversation context and the connected X profile; research its website, infer a conservative complete project, and call project_config. Ask only if no product can be identified." +
-                        (x.connected ? "" : " X is not connected yet either — detect_x_sources, warn about keychain prompts, then run connect_x with confirm:true without a separate permission turn.")
+                        (xConnected ? "" : " X is not connected yet either — detect_x_sources, warn about keychain prompts, then run connect_x with confirm:true without a separate permission turn.")
                     : projects.every((p) => p.ready)
-                        ? (x.connected
+                        ? (xConnected
                             ? "All configured projects are ready and X is connected. SCHEDULE THE AUTOPILOT: (1) call queue_setup and create each returned task with create_scheduled_task (prompt verbatim; 'already exists' is fine); (2) the autopilot then runs on its own (launchd kicker + queue worker). Call the `dashboard` tool to confirm the schedule is firing (schedule_state 'ok') — that is the terminal step; do NOT wait for or verify a draft card. Do NOT pause to ask the user to review drafts."
                             : "All configured projects are ready, but X is NOT connected — posting needs a logged-in " +
                                 "x.com session. Detect sources and run project_config action:'connect_x', confirm:true; do not ask whether to proceed.")
                         : "Some projects are missing required fields (see each project's missing_required). Derive them from config, context, profile_scan, and website research, then call project_config again. Ask only if a required field is genuinely unknowable." +
-                            (x.connected ? "" : " X is also not connected yet; detect sources and run connect_x with confirm:true."),
+                            (xConnected ? "" : " X is also not connected yet; detect sources and run connect_x with confirm:true."),
         });
     }
     // Apply mode (incremental): merge whatever fields were supplied onto the
@@ -2964,22 +2952,38 @@ function ensureCoworkMcpRegistered() {
         console.error(`[cowork-mcp] ensureCoworkMcpRegistered error: ${e?.message || e}`);
     }
 }
-// ---- launchd kicker: run the REAL pipeline in DRAFT_ONLY + queue mode --------
+// ---- launchd kicker: run the REAL pipeline in queue mode ---------------------
 // Reinstates com.m13v.social-twitter-cycle as the customer-box kicker. It runs
-// run-twitter-cycle.sh straight through (scan -> score -> draft -> link-gen) but
-// STOPS before posting (DRAFT_ONLY=1), writing the plan to the review-queue the
-// approval cards read. Its `claude -p` steps route through the job queue
-// (S4L_CLAUDE_PROVIDER=queue) for the scheduled-task workers to service.
-// link_tail is skipped for now (TWITTER_TAIL_LINK_RATE=0); the short link is
-// still baked by twitter_gen_links.py (pure Python).
-const QUEUE_KICKER_INTERVAL_SECS = 300; // a fresh draft cycle every 5 min
+// run-twitter-cycle.sh straight through (scan -> score -> draft -> link-gen); its
+// `claude -p` steps route through the job queue (S4L_CLAUDE_PROVIDER=queue) for
+// the scheduled-task workers to service. The per-cycle DRAFT_ONLY value is NOT
+// baked here anymore: run-draft-and-publish.sh decides it from mode.json
+// (draft-only flag, 2026-07-06) — while draft-only is ON (default) cycles stop
+// before posting and merge into review cards; with draft-only OFF (operator
+// opt-out) promotion cycles post autonomously behind the virality bar. The DRAFT_ONLY=1 below is only the safe baseline an OLD wrapper (which
+// never overrides it) inherits.
+// 60s tick (2026-07-06): parity with the retired claude -p twitter-cycle plist.
+// The preflight slot gate (max-1) makes this safe — a tick that fires while a
+// cycle is still running skips in milliseconds — so the effective cadence is
+// back-to-back ~10-min cycles with ≤1 min idle, not one cycle per minute.
+const QUEUE_KICKER_INTERVAL_SECS = 60;
 function kickerEnv() {
     return {
         DRAFT_ONLY: "1",
         S4L_CLAUDE_PROVIDER: "queue",
         S4L_STATE_DIR: sapsStateDir(),
-        TWITTER_TAIL_LINK_RATE: "0",
         TWITTER_PAGE_GEN_RATE: "0",
+        // Thread-media context for the drafter (2026-07-06): parity with the
+        // retired CLI twitter-cycle plist. Without it the prep step drafts blind to
+        // images in the candidate threads.
+        S4L_TWITTER_CAPTURE_MEDIA: "1",
+        // NOTE: TWITTER_TAIL_LINK_RATE is deliberately NOT set here (2026-07-06).
+        // The persona lane exports =0 per cycle via s4l_mode.py env (link-free
+        // organic replies); promotion cycles keep the script's own default so
+        // draft-only-OFF posts carry the project link per the A/B gate, and card posts
+        // still force =1.0 inside post_drafts.
+        // Virality bar percentile is NOT set here: it is hardcoded to 0.90 in
+        // skill/run-twitter-cycle.sh (single source of truth, no env dependency).
     };
 }
 async function ensureQueueKickerInstalled() {
@@ -3428,6 +3432,29 @@ async function buildSnapshot() {
         completeOnboardingMilestone("project_ready", { missing_count: 0 });
     if (snap.schedule_state === "ok")
         completeOnboardingMilestone("tasks_scheduled");
+    // mode_chosen completes when the user explicitly picked a mode (mode.json
+    // exists) OR this is a legacy install already past setup (a ready project),
+    // so adding this step never regresses an already-onboarded box. (Moved here
+    // from project_config's status branch so ALL milestone truth lives in one
+    // place next to the snapshot.)
+    if (modeChosen() || (snap.projects_ready || 0) > 0) {
+        completeOnboardingMilestone("mode_chosen", {
+            source: modeChosen() ? "chosen" : "backfilled_legacy",
+        });
+    }
+    // profile_scanned has no file signal of its own, but a provisioned persona
+    // project can only come from the scan+dictation flow — treat its presence as
+    // the completed scan so old installs can't stick at "profile pending".
+    if ((Array.isArray(snap.projects) ? snap.projects : []).some((p) => p?.persona)) {
+        completeOnboardingMilestone("profile_scanned", { backfill: true });
+    }
+    // topics_seeded has no cheap live signal (it's a DB fact, not a file fact), so
+    // installs that finished setup before the persona-path completion landed stay
+    // stuck at 7/8 forever. Heal by re-running the idempotent seed for the ready
+    // project(s) and completing the milestone on success. Fire-and-forget: the
+    // ledger flip shows on the next snapshot.
+    if ((snap.projects_ready || 0) > 0)
+        void healTopicsSeeded(snap);
     // Persist this snapshot so the menu bar can answer "set up?" the SAME way when
     // the loopback server is unreachable (Claude Desktop closed or mid-restart)
     // instead of falling back to a divergent local rule. Refreshed on every
@@ -3436,6 +3463,37 @@ async function buildSnapshot() {
     persistStatusSummary(snap);
     return snap;
 }
+// One attempt per process: a failed seed (offline DB) retries on the next MCP
+// launch, not on every dashboard poll.
+let topicsSeedHealAttempted = false;
+async function healTopicsSeeded(snap) {
+    if (topicsSeedHealAttempted)
+        return;
+    topicsSeedHealAttempted = true;
+    try {
+        const ledger = onboardingLedger();
+        if (ledger?.milestones?.topics_seeded?.status === "complete")
+            return;
+        const ready = (Array.isArray(snap.projects) ? snap.projects : []).filter((p) => p && p.ready && typeof p.name === "string");
+        for (const p of ready) {
+            const seed = await runPython("scripts/seed_search_topics.py", ["--project", p.name], {
+                timeoutMs: 60_000,
+            });
+            if (seed.code === 0) {
+                const m = /planned=(\d+)\s+inserted=(\d+)\s+updated=(\d+)/.exec(seed.stdout);
+                completeOnboardingMilestone("topics_seeded", {
+                    project: p.name,
+                    topic_count: m ? Number(m[1]) : 0,
+                    backfill: true,
+                });
+                return;
+            }
+        }
+    }
+    catch (e) {
+        console.error("[snapshot] topics_seeded heal failed:", e?.message || e);
+    }
+}
 // ---- dashboard localhost fallback -----------------------------------------
 // When the connected host doesn't support MCP Apps UI (Claude Code / Cowork
 // today), serve the SAME dist/panel.html from a loopback HTTP server. The page
@@ -3580,7 +3638,7 @@ function sapsStateDir() {
 }
 // Has the user explicitly chosen an engagement mode? mode.json is written by the
 // engagement_mode tool (setup) and the menu-bar toggle. Used to complete the
-// mode_chosen onboarding milestone. (Source of truth: scripts/saps_mode.py.)
+// mode_chosen onboarding milestone. (Source of truth: scripts/s4l_mode.py.)
 function modeChosen() {
     try {
         return fs.existsSync(path.join(sapsStateDir(), "mode.json"));
@@ -3590,8 +3648,8 @@ function modeChosen() {
     }
 }
 // The current engagement lane flags, surfaced in the snapshot so the dashboard
-// AND menu bar read them from ONE place (mode.json, the same file saps_mode.py
-// writes). Mirrors saps_mode.py get_flags(): explicit flag keys win; else map a
+// AND menu bar read them from ONE place (mode.json, the same file s4l_mode.py
+// writes). Mirrors s4l_mode.py get_flags(): explicit flag keys win; else map a
 // legacy {"mode": ...} string; else default personal ON / promotion OFF.
 function currentFlags() {
     try {