@m1212e/rumble 0.12.13 → 0.12.14

package/README.md

@@ -129,10 +129,10 @@ rumble({
 ## Helpers
 Rumble offers various helpers to make it easy and fast to implement your api. Ofcourse you can write your api by hand using the provided `schemaBuilder` from the rumble initiator, but since this might get repetitive, the provided helpers automate a lot of this work for you while also automatically applying the concepts of rumble directly into your api.
 
-### arg
-`arg` is a helper to implement query arguments for filtering the results of a query for certain results. In many cases you would implement arguments for a query with something as `matchUsername: t.arg.string()` which is supposed to restrict the query to users which have that username. The arg helper implements such a filter tailored to the specific entity which you then can directly pass on to the database query.
+### whereArg
+`whereArg` is a helper to implement query arguments for filtering the results of a query for certain results. In many cases you would implement arguments for a query with something as `matchUsername: t.arg.string()` which is supposed to restrict the query to users which have that username. The whereArg helper implements such a filter tailored to the specific entity which you then can directly pass on to the database query.
 ```ts
-const WhereArgs = arg({
+const WhereArgs = whereArg({
  table: "posts",
 });
 
@@ -210,6 +210,9 @@ const enumRef = enum_({
 ```
 > The enum parameter allows other fields to be used to reference an enum. This is largely due to how this is used internally. Because of the way how drizzle handles enums, we are not able to provide type safety with enums. In case you actually need to use it, the above way is the recommended approach.
 
+### and more...
+See [the example file](./example/src/main.ts) or clone it and let intellisense guide you. Rumble offers various other helpers which might become handy!
+
 ## Running the server
 In case you directly want to run a server from your rumble instance, you can do so by using the `createYoga` function. It returns a graphql `yoga` instance which can be used to provide a graphql api in [a multitude of ways](https://the-guild.dev/graphql/yoga-server/docs/integrations/z-other-environments).
 ```ts
@@ -242,7 +245,9 @@ await clientCreator({
   // to point to your custom client
 });
 ```
-> The client uses [urql](https://nearform.com/open-source/urql/docs/basics/core/) under the hood. If you would like more info on how the internals work, please see the docs.
+> The client uses [urql](https://nearform.com/open-source/urql/docs/basics/core/) under the hood. If you would like more info on how the internals work, please see their docs.
+
+This way of generating code is especially helpful in monorepos, where it is convenient to output client code when running the server during development. If you do not use a monorepo and want to decouple the generation process, see below.
 
 An example usage might look like this:
 ```ts
@@ -272,7 +277,7 @@ users.subscribe((s) => s?.at(0));
 // you can directly access the values of an awaited result
 console.log(users.firstName)
 ```
-### Alternative
+### Alternative decoupled client generation
 As an alternative to use the client generator with a fully instanciated rumble instance, you can also import the `generateFromSchema` function from rumble and pass it a standard `GraphQLSchema` object to generate the client:
 ```ts
 import { generateFromSchema } from "@m1212e/rumble";

package/out/index.cjs

@@ -244,25 +244,21 @@ function makeGraphQLQuery({ queryName, input, client, enableSubscription = false
 	const argsString = stringifyArgumentObjectToGraphqlList(input[argsKey] ?? {});
 	const operationString = (operationVerb) => `${operationVerb} ${otwQueryName} { ${queryName}${argsString} { ${stringifySelection(input)} }}`;
 	let awaitedReturnValueReference;
-	const response = (0, wonka.pipe)((0, wonka.merge)([client.query(operationString("query"), {}), enableSubscription ? client.subscription(operationString("subscription"), {}) : wonka.empty]), (0, wonka.map)((v) => {
+	const observable = (0, wonka.pipe)((0, wonka.merge)([client.query(operationString("query"), {}), enableSubscription ? client.subscription(operationString("subscription"), {}) : wonka.empty]), (0, wonka.map)((v) => {
 		const data = v.data?.[queryName];
 		if (!data && v.error) throw v.error;
 		return data;
 	}), (0, wonka.onPush)((data) => {
 		if (awaitedReturnValueReference) Object.assign(awaitedReturnValueReference, data);
-	}));
+	}), wonka.toObservable);
 	const promise = new Promise((resolve) => {
-		const unsub = (0, wonka.toObservable)(response).subscribe((v) => {
+		const unsub = observable.subscribe((v) => {
 			unsub();
-			const newObservableWithAwaitedValue = (0, wonka.pipe)((0, wonka.merge)([response, (0, wonka.fromValue)(v)]), wonka.toObservable);
-			awaitedReturnValueReference = {
-				...v,
-				...newObservableWithAwaitedValue
-			};
+			awaitedReturnValueReference = Object.assign(v, observable);
 			resolve(awaitedReturnValueReference);
 		}).unsubscribe;
 	});
-	Object.assign(promise, (0, wonka.toObservable)(response));
+	Object.assign(promise, observable);
 	return promise;
 }
 function makeGraphQLMutation({ mutationName, input, client }) {
@@ -1091,6 +1087,16 @@ const createContextFunction = ({ context: makeUserContext, abilityBuilder }) =>
 	};
 };
 
+//#endregion
+//#region lib/helpers/protoMapper.ts
+function deepSetProto(obj, proto = Object.prototype, seen = /* @__PURE__ */ new WeakSet()) {
+	if (obj === null || typeof obj !== "object") return;
+	if (seen.has(obj)) return;
+	seen.add(obj);
+	Object.setPrototypeOf(obj, proto);
+	for (const key of Object.keys(obj)) deepSetProto(obj[key], proto, seen);
+}
+
 //#endregion
 //#region lib/countQuery.ts
 const createCountQueryImplementer = ({ db, schemaBuilder, whereArgImplementer, makePubSubInstance }) => {
@@ -1123,7 +1129,7 @@ const createCountQueryImplementer = ({ db, schemaBuilder, whereArgImplementer, m
 				}) },
 				resolve: async (root, args, ctx, info) => {
 					if (isAllowed && !await isAllowed(ctx)) throw new RumbleErrorSafe("Not allowed to perform this action");
-					Object.setPrototypeOf(args, Object.prototype);
+					deepSetProto(args);
 					return db.select({ count: (0, drizzle_orm.count)() }).from(tableSchema.fullSchema).where(ctx.abilities[table].filter(listAction).merge(mapNullFieldsToUndefined(args)).sql.where).then(assertFirstEntryExists).then((r) => r.count);
 				}
 			}) };
@@ -1579,7 +1585,7 @@ const createQueryImplementer = ({ db, schemaBuilder, search, whereArgImplementer
 					},
 					args: manyArgs,
 					resolve: (query, _root, args, ctx, _info) => {
-						Object.setPrototypeOf(args, Object.prototype);
+						deepSetProto(args);
 						adjustQueryArgsForSearch({
 							search,
 							args,
@@ -1602,7 +1608,7 @@ const createQueryImplementer = ({ db, schemaBuilder, search, whereArgImplementer
 					description: `Get a single ${pluralize.default.singular(table.toString())} by ID`,
 					args: { id: t.arg.id({ required: true }) },
 					resolve: (query, _root, args, ctx, _info) => {
-						Object.setPrototypeOf(args, Object.prototype);
+						deepSetProto(args);
 						const filter = ctx.abilities[table].filter(readAction).merge({ where: { [primaryKeyField.name]: args.id } }).query.single;
 						const q = query(filter);
 						if (filter.columns) q.columns = filter.columns;