@lythos/cold-pool 0.11.2 → 0.12.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lythos/cold-pool",
-  "version": "0.11.2",
+  "version": "0.12.0",
   "description": "Cold pool service layer — dedicated resource holder for skill repositories with intent/plan/execute primitives. Single owner of git side-effects; consumed by deck/curator/arena.",
   "keywords": [
     "ai-agent",
@@ -42,7 +42,7 @@
   },
   "homepage": "https://github.com/lythos-labs/lythoskill/tree/main/packages/lythoskill-cold-pool#readme",
   "dependencies": {
-    "@lythos/infra": "^0.11.2",
+    "@lythos/infra": "^0.12.0",
     "simple-git": "^3.36.0"
   },
   "engines": {

package/src/mirror.test.ts

@@ -3,15 +3,23 @@ import { probeConnectivity } from './mirror.js'
 
 describe('probeConnectivity', () => {
   let originalFetch: typeof fetch
+  let originalEnv: string | undefined
   let fetchCalls: Array<{ url: string; options: RequestInit }>
 
   beforeEach(() => {
     originalFetch = globalThis.fetch
+    originalEnv = process.env.LYTHOSKILL_GH_MIRROR
+    delete process.env.LYTHOSKILL_GH_MIRROR
     fetchCalls = []
   })
 
   afterEach(() => {
     globalThis.fetch = originalFetch
+    if (originalEnv !== undefined) {
+      process.env.LYTHOSKILL_GH_MIRROR = originalEnv
+    } else {
+      delete process.env.LYTHOSKILL_GH_MIRROR
+    }
   })
 
   function mockFetch(
@@ -50,11 +58,12 @@ describe('probeConnectivity', () => {
   })
 
   // ── Vertical Slice 2 ──
-  test('direct fails, mirror ok → returns mirror path', async () => {
+  test('direct fails, user mirror ok → returns mirror path', async () => {
+    process.env.LYTHOSKILL_GH_MIRROR = 'https://my-mirror.example.com'
     mockFetch(
       new Map([
         ['https://example.com/skill', new Response(null, { status: 500 })],
-        ['https://ghfast.top/https://example.com/skill', new Response(null, { status: 200 })],
+        ['https://my-mirror.example.com/https://example.com/skill', new Response(null, { status: 200 })],
       ]),
     )
 
@@ -62,7 +71,7 @@ describe('probeConnectivity', () => {
 
     expect(result).toMatchObject({
       path: 'mirror',
-      url: 'https://ghfast.top/https://example.com/skill',
+      url: 'https://my-mirror.example.com/https://example.com/skill',
       latencyMs: expect.any(Number),
     })
   })
@@ -91,14 +100,13 @@ describe('probeConnectivity', () => {
 
   // ── Vertical Slice 5: Racing behavior ──
   test('probes race concurrently, not sequentially', async () => {
+    process.env.LYTHOSKILL_GH_MIRROR = 'https://my-mirror.example.com'
     const start = performance.now()
 
     mockFetch(
       new Map([
         ['https://example.com/skill', new Response(null, { status: 500 })],
-        ['https://ghfast.top/https://example.com/skill', new Response(null, { status: 200 })],
-        ['https://ghproxy.com/https://example.com/skill', new Response(null, { status: 200 })],
-        ['https://mirror.ghproxy.com/https://example.com/skill', new Response(null, { status: 200 })],
+        ['https://my-mirror.example.com/https://example.com/skill', new Response(null, { status: 200 })],
       ]),
       50, // each mock fetch takes 50ms
     )
@@ -108,11 +116,26 @@ describe('probeConnectivity', () => {
     const elapsed = performance.now() - start
 
     expect(result?.path).toBe('mirror')
-    // Sequential would take ~200ms (4 × 50ms). Racing should be ~50-100ms.
+    // Sequential would take ~100ms (2 × 50ms). Racing should be ~50-100ms.
     expect(elapsed).toBeLessThan(150)
   })
 
-  // ── Vertical Slice 6: Timeout honored ──
+  // ── Vertical Slice 6: No user mirror set → only probes direct ──
+  test('without user mirror, only probes direct', async () => {
+    mockFetch(
+      new Map([
+        ['https://example.com/skill', new Response(null, { status: 200 })],
+      ]),
+    )
+
+    const result = await probeConnectivity('https://example.com/skill')
+
+    expect(result?.path).toBe('direct')
+    expect(fetchCalls.length).toBe(1)
+    expect(fetchCalls[0].url).toBe('https://example.com/skill')
+  })
+
+  // ── Vertical Slice 7: Timeout honored ──
   test('timeout aborts slow probes', async () => {
     globalThis.fetch = async (_input, init?) => {
       return new Promise((_, reject) => {

package/src/mirror.ts

@@ -1,24 +1,15 @@
 /**
  * Mirror URL rewriting for restricted networks.
  *
- * Three layers, checked in order:
- *   1. LYTHOSKILL_GH_MIRROR env var (explicit user choice)
- *   2. HTTPS_PROXY / HTTP_PROXY (standard — Bun fetch and git respect these natively)
- *   3. Known public mirrors (auto-fallback when GitHub is unreachable)
+ * Two layers only — the tool never decides which third party to trust:
+ *   1. LYTHOSKILL_GH_MIRROR env var (explicit user choice, user bears trust)
+ *   2. LYTHOS_SOCKS_PROXY / HTTPS_PROXY / HTTP_PROXY (standard, user's own infra)
  *
- * Per ADR-20260512191438745.
+ * No hard-coded mirror list. Auto-fallback to "known" third-party mirrors was
+ * removed: the tool must not silently delegate trust to an external service
+ * that can return tampered skill files (see ADR-202605130...).
  */
 
-// ── Known public mirrors (tried in order when GitHub is unreachable) ──
-
-const KNOWN_MIRRORS = [
-  'https://ghfast.top',            // commonly used in CN
-  'https://ghproxy.com',           // commonly used in CN
-  'https://mirror.ghproxy.com',    // ghproxy alternative domain
-]
-
-// ── Explicit user mirror ──────────────────────────────────────────────
-
 export function getMirror(): string | undefined {
   const v = process.env.LYTHOSKILL_GH_MIRROR?.trim()
   if (!v) return undefined
@@ -28,18 +19,14 @@ export function getMirror(): string | undefined {
   return `https://${v.replace(/\/+$/, '')}`
 }
 
-// ── URL rewriting ─────────────────────────────────────────────────────
-
 export function rewriteUrl(url: string, mirror?: string): string {
   if (!mirror) return url
   return `${mirror}/${url}`
 }
 
 export function mirrorUrls(url: string): string[] {
-  const mirrors = [...KNOWN_MIRRORS]
   const explicit = getMirror()
-  if (explicit) mirrors.unshift(explicit)
-  return mirrors.map(m => rewriteUrl(url, m))
+  return explicit ? [rewriteUrl(url, explicit)] : []
 }
 
 export function isLikelyGitHubBlock(err: unknown): boolean {
@@ -61,7 +48,7 @@ export interface ProbeFailure {
 }
 
 /**
- * Quick connectivity probe: race direct + all mirrors concurrently.
+ * Quick connectivity probe: race direct + user mirror (if set) concurrently.
  * Uses short timeout (default 3s) to fail fast instead of waiting for
  * the full git clone / fetch timeout.
  *