@lynx-js/runtime-wrapper-webpack-plugin 0.1.0 → 0.1.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @lynx-js/runtime-wrapper-webpack-plugin
 
+## 0.1.2
+
+### Patch Changes
+
+- Wrap with IIFE when `output.iife: false` to avoid naming conflict. ([#1176](https://github.com/lynx-family/lynx-stack/pull/1176))
+
+## 0.1.1
+
+### Patch Changes
+
+- Fix `requestAnimationFrame` is not working. ([#1021](https://github.com/lynx-family/lynx-stack/pull/1021))
+
 ## 0.1.0
 
 ### Minor Changes

package/lib/RuntimeWrapperWebpackPlugin.js

@@ -37,7 +37,6 @@ const defaultInjectVars = [
     'webkit',
     'Reporter',
     'print',
-    '__Function__', // We should allow using `Function`
     'global',
     // Lynx API
     'requestAnimationFrame',
@@ -90,6 +89,7 @@ class RuntimeWrapperWebpackPluginImpl {
         if (typeof options.injectVars === 'function') {
             injectStr = options.injectVars(defaultInjectVars).join(',');
         }
+        const iife = compiler.options.output.iife ?? true;
         // banner
         new BannerPlugin({
             test: test,
@@ -105,6 +105,7 @@ class RuntimeWrapperWebpackPluginImpl {
                         overrideRuntimePromise: true,
                         moduleId: '[name].js',
                         targetSdkVersion,
+                        iife,
                     })
                     // In standalone lazy bundle mode, the lazy bundle will
                     // also has chunk.id "main", it will be conflict with the
@@ -125,7 +126,7 @@ class RuntimeWrapperWebpackPluginImpl {
                 const footer = this.#getBannerType(filename) === 'script'
                     ? loadScriptFooter
                     : loadBundleFooter;
-                return amdFooter('[name].js') + footer;
+                return amdFooter('[name].js', iife) + footer;
             },
         }).apply(compiler);
     }
@@ -174,7 +175,10 @@ const loadBundleBanner = (strictMode = true) => `(function(){
   function initBundle(lynxCoreInject) {
     var tt = lynxCoreInject.tt;
 `;
-const amdBanner = ({ injectStr, moduleId, overrideRuntimePromise, targetSdkVersion, }) => {
+const amdBanner = ({ injectStr, moduleId, overrideRuntimePromise, targetSdkVersion, iife, }) => {
+    const iifeWrapper = iife ? '' : `
+// This needs to be wrapped in an IIFE because it needs to be isolated against Lynx injected variables.
+(() => {`;
     return (`
     tt.define("${moduleId}", function(require, module, exports, ${injectStr}) {
 lynx = lynx || {};
@@ -183,9 +187,11 @@ ${overrideRuntimePromise ? `var Promise = lynx.Promise;` : ''}
 fetch = fetch || lynx.fetch;
 requestAnimationFrame = requestAnimationFrame || lynx.requestAnimationFrame;
 cancelAnimationFrame = cancelAnimationFrame || lynx.cancelAnimationFrame;
+${iifeWrapper}
 `);
 };
-const amdFooter = (moduleId) => `
+const amdFooter = (moduleId, iife) => `
+${iife ? '' : '})();'}
     });
     return tt.require("${moduleId}");`;
 // footer for app-service.js chunk

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lynx-js/runtime-wrapper-webpack-plugin",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "Use runtime wrapper which allow JavaScript to be load by Lynx.",
   "keywords": [
     "webpack",
@@ -36,7 +36,7 @@
   },
   "devDependencies": {
     "@microsoft/api-extractor": "7.52.8",
-    "webpack": "^5.99.8",
+    "webpack": "^5.99.9",
     "@lynx-js/test-tools": "0.0.0"
   },
   "engines": {