@lwc/synthetic-shadow 6.3.3 → 6.4.0

package/dist/index.js

@@ -208,7 +208,7 @@ const KEY__LEGACY_SHADOW_TOKEN_PRIVATE = '$$LegacyShadowTokenKey$$';
 const KEY__SYNTHETIC_MODE = '$$lwc-synthetic-mode';
 const KEY__NATIVE_GET_ELEMENT_BY_ID = '$nativeGetElementById$';
 const KEY__NATIVE_QUERY_SELECTOR_ALL = '$nativeQuerySelectorAll$';
-/** version: 6.3.3 */
+/** version: 6.4.0 */
 
 /**
  * Copyright (c) 2024 Salesforce, Inc.
@@ -216,7 +216,7 @@ const KEY__NATIVE_QUERY_SELECTOR_ALL = '$nativeQuerySelectorAll$';
 if (!globalThis.lwcRuntimeFlags) {
     Object.defineProperty(globalThis, 'lwcRuntimeFlags', { value: create(null) });
 }
-/** version: 6.3.3 */
+/** version: 6.4.0 */
 
 /*
  * Copyright (c) 2018, salesforce.com, inc.
@@ -239,6 +239,7 @@ const ownerDocumentGetter = getOwnPropertyDescriptor(nodePrototype, 'ownerDocume
 const parentElementGetter = getOwnPropertyDescriptor(nodePrototype, 'parentElement').get;
 const textContextSetter = getOwnPropertyDescriptor(nodePrototype, 'textContent').set;
 const childNodesGetter = getOwnPropertyDescriptor(nodePrototype, 'childNodes').get;
+const nextSiblingGetter = getOwnPropertyDescriptor(nodePrototype, 'nextSibling').get;
 const isConnected = hasOwnProperty.call(nodePrototype, 'isConnected')
     ? getOwnPropertyDescriptor(nodePrototype, 'isConnected').get
     : function () {
@@ -425,6 +426,8 @@ function getNodeNearestOwnerKey(node) {
             return hostKey;
         }
         host = parentNodeGetter.call(host);
+        // Elements slotted from top level light DOM into synthetic shadow
+        // reach the slot tag from the shadow element first
         if (!isNull(host) && isSyntheticSlotElement(host)) {
             return undefined;
         }
@@ -1225,7 +1228,11 @@ function cloneNodePatched(deep) {
 function childNodesGetterPatched() {
     if (isSyntheticShadowHost(this)) {
         const owner = getNodeOwner(this);
-        const childNodes = isNull(owner) ? [] : getAllMatches(owner, getFilteredChildNodes(this));
+        const filteredChildNodes = getFilteredChildNodes(this);
+        // No need to filter by owner for non-shadowed nodes
+        const childNodes = isNull(owner)
+            ? filteredChildNodes
+            : getAllMatches(owner, filteredChildNodes);
         return createStaticNodeList(childNodes);
     }
     // nothing to do here since this does not have a synthetic shadow attached to it
@@ -3354,7 +3361,11 @@ function shadowRootGetterPatched() {
 }
 function childrenGetterPatched() {
     const owner = getNodeOwner(this);
-    const childNodes = isNull(owner) ? [] : getAllMatches(owner, getFilteredChildNodes(this));
+    const filteredChildNodes = getFilteredChildNodes(this);
+    // No need to filter by owner for non-shadowed nodes
+    const childNodes = isNull(owner)
+        ? filteredChildNodes
+        : getAllMatches(owner, filteredChildNodes);
     return createStaticHTMLCollection(ArrayFilter.call(childNodes, (node) => node instanceof Element));
 }
 function childElementCountGetterPatched() {
@@ -4190,9 +4201,13 @@ defineProperty(Element.prototype, KEY__SHADOW_TOKEN, {
 });
 function recursivelySetShadowResolver(node, fn) {
     node[KEY__SHADOW_RESOLVER] = fn;
-    const childNodes = childNodesGetter.call(node);
-    for (let i = 0, n = childNodes.length; i < n; i++) {
-        recursivelySetShadowResolver(childNodes[i], fn);
+    // Recurse using firstChild/nextSibling because browsers use a linked list under the hood to
+    // represent the DOM, so childNodes/children would cause an unnecessary array allocation.
+    // https://viethung.space/blog/2020/09/01/Browser-from-Scratch-DOM-API/#Choosing-DOM-tree-data-structure
+    let child = firstChildGetter.call(node);
+    while (!isNull(child)) {
+        recursivelySetShadowResolver(child, fn);
+        child = nextSiblingGetter.call(child);
     }
 }
 defineProperty(Element.prototype, KEY__SHADOW_STATIC, {
@@ -4361,6 +4376,6 @@ defineProperty(Element.prototype, '$domManual$', {
     },
     configurable: true,
 });
-/** version: 6.3.3 */
+/** version: 6.4.0 */
 }
 //# sourceMappingURL=index.js.map