@lwc/engine-core 8.3.0 → 8.5.0

package/dist/framework/base-lightning-element.d.ts

@@ -10,7 +10,7 @@ import { AccessibleElementProperties } from '@lwc/shared';
 import { ShadowSupportMode } from './vm';
 import { Template } from './template';
 import { HTMLElementConstructor } from './base-bridge-element';
-import { Stylesheets } from './stylesheet';
+import type { Stylesheets } from '@lwc/shared';
 export interface LightningElementConstructor {
     new (): LightningElement;
     readonly prototype: LightningElement;

package/dist/framework/check-version-mismatch.d.ts

@@ -1,6 +1,6 @@
 import { Template } from './template';
-import { Stylesheet } from './stylesheet';
 import { LightningElementConstructor } from './base-lightning-element';
+import type { Stylesheet } from '@lwc/shared';
 /**
  * Validate a template, stylesheet, or component to make sure that its compiled version matches
  * the version used by the LWC engine at runtime. Note that this only works in dev mode because

package/dist/framework/hot-swaps.d.ts

@@ -1,7 +1,7 @@
 import { VM } from './vm';
 import { LightningElementConstructor } from './base-lightning-element';
 import { Template } from './template';
-import { Stylesheet } from './stylesheet';
+import type { Stylesheet } from '@lwc/shared';
 export declare function getTemplateOrSwappedTemplate(tpl: Template): Template;
 export declare function getComponentOrSwappedComponent(Ctor: LightningElementConstructor): LightningElementConstructor;
 export declare function getStyleOrSwappedStyle(style: Stylesheet): Stylesheet;

package/dist/framework/main.d.ts

@@ -18,7 +18,6 @@ export { getComponentAPIVersion } from './component';
 export { shouldBeFormAssociated } from './utils';
 export { getComponentConstructor } from './get-component-constructor';
 export type { RendererAPI, LifecycleCallback } from './renderer';
-export type { Stylesheets } from './stylesheet';
 export type { Template } from './template';
 export type { ConfigValue as WireConfigValue, ContextConsumer as WireContextConsumer, ContextProvider as WireContextProvider, ContextValue as WireContextValue, DataCallback as WireDataCallback, WireAdapter, WireAdapterConstructor, WireAdapterSchemaValue, WireContextSubscriptionPayload, WireContextSubscriptionCallback, } from './wiring';
 export type { FormRestoreState, FormRestoreReason } from './vm';
@@ -29,3 +28,4 @@ export { default as wire } from './decorators/wire';
 export { readonly } from './readonly';
 export { setFeatureFlag, setFeatureFlagForTest } from '@lwc/features';
 export { setTrustedSignalSet } from '@lwc/shared';
+export type { Stylesheet, Stylesheets } from '@lwc/shared';

package/dist/framework/stylesheet.d.ts

@@ -1,16 +1,7 @@
 import { VM } from './vm';
 import { Template } from './template';
 import { VCustomElement, VNode } from './vnodes';
-/**
- * Function producing style based on a host and a shadow selector. This function is invoked by
- * the engine with different values depending on the mode that the component is running on.
- */
-export type Stylesheet = (stylesheetToken: string | undefined, useActualHostSelector: boolean, useNativeDirPseudoclass: boolean) => string;
-/**
- * The list of stylesheets associated with a template. Each entry is either a `Stylesheet` or
- * an array of stylesheets that a given stylesheet depends on via CSS `@import` declarations.
- */
-export type Stylesheets = Array<Stylesheet | Stylesheets>;
+import type { Stylesheet } from '@lwc/shared';
 export declare function updateStylesheetToken(vm: VM, template: Template, legacy: boolean): void;
 export declare function getStylesheetsContent(vm: VM, template: Template): ReadonlyArray<string>;
 /**

package/dist/framework/template.d.ts

@@ -1,7 +1,7 @@
 import { RenderAPI } from './api';
 import { SlotSet, TemplateCache, VM } from './vm';
-import { Stylesheets } from './stylesheet';
 import { VNodes } from './vnodes';
+import type { Stylesheets } from '@lwc/shared';
 export interface Template {
     (api: RenderAPI, cmp: object, slotSet: SlotSet, cache: TemplateCache): VNodes;
     /** The list of slot names used in the template. */

package/dist/framework/utils.d.ts

@@ -1,4 +1,3 @@
-import { Stylesheet, Stylesheets } from './stylesheet';
 import { LightningElementConstructor } from './base-lightning-element';
 type Callback = () => void;
 export declare const SPACE_CHAR = 32;
@@ -11,7 +10,6 @@ export declare function cloneAndOmitKey(object: {
 }, keyToOmit: string): {
     [key: string]: any;
 };
-export declare function flattenStylesheets(stylesheets: Stylesheets): Stylesheet[];
 export declare function assertNotProd(): void;
 export declare function shouldBeFormAssociated(Ctor: LightningElementConstructor): boolean;
 export {};

package/dist/framework/vm.d.ts

@@ -5,7 +5,7 @@ import { ComponentDef } from './def';
 import { LightningElement, LightningElementConstructor, LightningElementShadowRoot } from './base-lightning-element';
 import { ReactiveObserver } from './mutation-tracker';
 import { VNodes, VCustomElement, VNode, VBaseElement, VStaticPartElement } from './vnodes';
-import { Stylesheets } from './stylesheet';
+import type { Stylesheets } from '@lwc/shared';
 type ShadowRootMode = 'open' | 'closed';
 export interface TemplateCache {
     [key: string]: any;

package/dist/index.cjs.js

@@ -231,18 +231,6 @@ function cloneAndOmitKey(object, keyToOmit) {
     }
     return result;
 }
-function flattenStylesheets(stylesheets) {
-    const list = [];
-    for (const stylesheet of stylesheets) {
-        if (!shared.isArray(stylesheet)) {
-            list.push(stylesheet);
-        }
-        else {
-            list.push(...flattenStylesheets(stylesheet));
-        }
-    }
-    return list;
-}
 // Throw an error if we're running in prod mode. Ensures code is truly removed from prod mode.
 function assertNotProd() {
     /* istanbul ignore if */
@@ -296,6 +284,16 @@ function toPrettyMemberNotation(parent, child) {
         return `${shared.toString(parent)}[${JSON.stringify(child)}]`;
     }
 }
+function safelyCallGetter(target, key) {
+    // Arbitrary getters can throw. We don't want to throw an error just due to dev-mode-only mutation tracking
+    // (which is only used for performance debugging) so ignore errors here.
+    try {
+        return target[key];
+    }
+    catch (_err) {
+        /* ignore */
+    }
+}
 /**
  * Flush all the logs we've written so far and return the current logs.
  */
@@ -364,7 +362,7 @@ function trackTargetForMutationLogging(key, target) {
         // Deeply traverse arrays and objects to track every object within
         if (shared.isArray(target)) {
             for (let i = 0; i < target.length; i++) {
-                trackTargetForMutationLogging(toPrettyMemberNotation(key, i), target[i]);
+                trackTargetForMutationLogging(toPrettyMemberNotation(key, i), safelyCallGetter(target, i));
             }
         }
         else {
@@ -373,10 +371,10 @@ function trackTargetForMutationLogging(key, target) {
             // https://github.com/salesforce/observable-membrane/blob/b85417f/src/base-handler.ts#L142-L143
             // Note this code path is very hot, hence doing two separate for-loops rather than creating a new array.
             for (const prop of shared.getOwnPropertyNames(target)) {
-                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), target[prop]);
+                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), safelyCallGetter(target, prop));
             }
             for (const prop of shared.getOwnPropertySymbols(target)) {
-                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), target[prop]);
+                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), safelyCallGetter(target, prop));
             }
         }
     }
@@ -669,8 +667,9 @@ for (const [propName, attrName] of shared.entries(shared.AriaPropNameToAttrNameM
                 return this.getAttribute(attrName);
             },
             set(newValue) {
-                // TODO [#3284]: there is disagreement between browsers and the spec on how to treat undefined
-                // Our historical behavior is to only treat null as removing the attribute
+                // TODO [#3284]: According to the spec, IDL nullable type values
+                // (null and undefined) should remove the attribute; however, we
+                // only do so in the case of null for historical reasons.
                 // See also https://github.com/w3c/aria/issues/1858
                 if (shared.isNull(newValue)) {
                     this.removeAttribute(attrName);
@@ -3569,7 +3568,7 @@ function addActiveStylesheets(stylesheets, vm) {
         // Ignore non-existent stylesheets
         return;
     }
-    for (const stylesheet of flattenStylesheets(stylesheets)) {
+    for (const stylesheet of shared.flattenStylesheets(stylesheets)) {
         // this is necessary because we don't hold the list of styles
         // in the vm, we only hold the selected (already swapped template)
         // but the styles attached to the template might not be the actual
@@ -6885,7 +6884,7 @@ function computeStylesheets(vm, ctor) {
     if (!shared.isUndefined(stylesheets)) {
         const valid = validateComponentStylesheets(vm, stylesheets);
         if (valid) {
-            return flattenStylesheets(stylesheets);
+            return shared.flattenStylesheets(stylesheets);
         }
         else if (process.env.NODE_ENV !== 'production') {
             logError(`static stylesheets must be an array of CSS stylesheets. Found invalid stylesheets on <${vm.tagName}>`, vm);
@@ -8008,7 +8007,10 @@ function validateClassAttr(vnode, elm, data, renderer) {
     let nodesAreCompatible = true;
     let readableVnodeClassname;
     const elmClassName = getAttribute(elm, 'class');
-    if (!shared.isUndefined(className) && String(className) !== elmClassName) {
+    if (!shared.isUndefined(className) &&
+        String(className) !== elmClassName &&
+        // No mismatch if SSR `class` attribute is missing and CSR `class` is the empty string
+        !(className === '' && shared.isNull(elmClassName))) {
         // className is used when class is bound to an expr.
         nodesAreCompatible = false;
         // stringify for pretty-printing
@@ -8493,5 +8495,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 8.3.0 */
+/** version: 8.5.0 */
 //# sourceMappingURL=index.cjs.js.map