@lwc/engine-core 8.3.0 → 8.4.0

package/dist/index.cjs.js

@@ -296,6 +296,16 @@ function toPrettyMemberNotation(parent, child) {
         return `${shared.toString(parent)}[${JSON.stringify(child)}]`;
     }
 }
+function safelyCallGetter(target, key) {
+    // Arbitrary getters can throw. We don't want to throw an error just due to dev-mode-only mutation tracking
+    // (which is only used for performance debugging) so ignore errors here.
+    try {
+        return target[key];
+    }
+    catch (_err) {
+        /* ignore */
+    }
+}
 /**
  * Flush all the logs we've written so far and return the current logs.
  */
@@ -364,7 +374,7 @@ function trackTargetForMutationLogging(key, target) {
         // Deeply traverse arrays and objects to track every object within
         if (shared.isArray(target)) {
             for (let i = 0; i < target.length; i++) {
-                trackTargetForMutationLogging(toPrettyMemberNotation(key, i), target[i]);
+                trackTargetForMutationLogging(toPrettyMemberNotation(key, i), safelyCallGetter(target, i));
             }
         }
         else {
@@ -373,10 +383,10 @@ function trackTargetForMutationLogging(key, target) {
             // https://github.com/salesforce/observable-membrane/blob/b85417f/src/base-handler.ts#L142-L143
             // Note this code path is very hot, hence doing two separate for-loops rather than creating a new array.
             for (const prop of shared.getOwnPropertyNames(target)) {
-                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), target[prop]);
+                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), safelyCallGetter(target, prop));
             }
             for (const prop of shared.getOwnPropertySymbols(target)) {
-                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), target[prop]);
+                trackTargetForMutationLogging(toPrettyMemberNotation(key, prop), safelyCallGetter(target, prop));
             }
         }
     }
@@ -669,8 +679,9 @@ for (const [propName, attrName] of shared.entries(shared.AriaPropNameToAttrNameM
                 return this.getAttribute(attrName);
             },
             set(newValue) {
-                // TODO [#3284]: there is disagreement between browsers and the spec on how to treat undefined
-                // Our historical behavior is to only treat null as removing the attribute
+                // TODO [#3284]: According to the spec, IDL nullable type values
+                // (null and undefined) should remove the attribute; however, we
+                // only do so in the case of null for historical reasons.
                 // See also https://github.com/w3c/aria/issues/1858
                 if (shared.isNull(newValue)) {
                     this.removeAttribute(attrName);
@@ -8008,7 +8019,10 @@ function validateClassAttr(vnode, elm, data, renderer) {
     let nodesAreCompatible = true;
     let readableVnodeClassname;
     const elmClassName = getAttribute(elm, 'class');
-    if (!shared.isUndefined(className) && String(className) !== elmClassName) {
+    if (!shared.isUndefined(className) &&
+        String(className) !== elmClassName &&
+        // No mismatch if SSR `class` attribute is missing and CSR `class` is the empty string
+        !(className === '' && shared.isNull(elmClassName))) {
         // className is used when class is bound to an expr.
         nodesAreCompatible = false;
         // stringify for pretty-printing
@@ -8493,5 +8507,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 8.3.0 */
+/** version: 8.4.0 */
 //# sourceMappingURL=index.cjs.js.map