@lwc/engine-core 8.28.2 → 8.28.3-0

package/dist/framework/weak-multimap.d.ts

@@ -3,21 +3,11 @@
  * The goal is to avoid leaking the values, which is what would happen with a WeakMap<K, Set<V>>.
  *
  * Note that this is currently only intended to be used in dev/PRODDEBUG environments.
- * It leaks in legacy browsers, which may be undesired.
+ *
+ * This implementation relies on WeakRefs and FinalizationRegistry.
+ * For some background, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef
  */
-export interface WeakMultiMap<T extends object, V extends object> {
-    get(key: T): ReadonlySet<V>;
-    add(key: T, vm: V): void;
-    delete(key: T): void;
-}
-declare class LegacyWeakMultiMap<K extends object, V extends object> implements WeakMultiMap<K, V> {
-    private _map;
-    private _getValues;
-    get(key: K): ReadonlySet<V>;
-    add(key: K, vm: V): void;
-    delete(key: K): void;
-}
-declare class ModernWeakMultiMap<K extends object, V extends object> implements WeakMultiMap<K, V> {
+export declare class WeakMultiMap<K extends object, V extends object> {
     private _map;
     private _registry;
     private _getWeakRefs;
@@ -25,6 +15,4 @@ declare class ModernWeakMultiMap<K extends object, V extends object> implements
     add(key: K, value: V): void;
     delete(key: K): void;
 }
-export declare const WeakMultiMap: typeof LegacyWeakMultiMap | typeof ModernWeakMultiMap;
-export {};
 //# sourceMappingURL=weak-multimap.d.ts.map

package/dist/index.cjs.js

@@ -3442,34 +3442,16 @@ function isValidScopeToken(token) {
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-const supportsWeakRefs = typeof WeakRef === 'function' && typeof FinalizationRegistry === 'function';
-// In browsers that doesn't support WeakRefs, the values will still leak, but at least the keys won't
-class LegacyWeakMultiMap {
-    constructor() {
-        this._map = new WeakMap();
-    }
-    _getValues(key) {
-        let values = this._map.get(key);
-        if (shared.isUndefined(values)) {
-            values = new Set();
-            this._map.set(key, values);
-        }
-        return values;
-    }
-    get(key) {
-        return this._getValues(key);
-    }
-    add(key, vm) {
-        const set = this._getValues(key);
-        set.add(vm);
-    }
-    delete(key) {
-        this._map.delete(key);
-    }
-}
-// This implementation relies on the WeakRef/FinalizationRegistry proposal.
-// For some background, see: https://github.com/tc39/proposal-weakrefs
-class ModernWeakMultiMap {
+/**
+ * A map where the keys are weakly held and the values are a Set that are also each weakly held.
+ * The goal is to avoid leaking the values, which is what would happen with a WeakMap<K, Set<V>>.
+ *
+ * Note that this is currently only intended to be used in dev/PRODDEBUG environments.
+ *
+ * This implementation relies on WeakRefs and FinalizationRegistry.
+ * For some background, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef
+ */
+class WeakMultiMap {
     constructor() {
         this._map = new WeakMap();
         this._registry = new FinalizationRegistry((weakRefs) => {
@@ -3505,8 +3487,12 @@ class ModernWeakMultiMap {
     }
     add(key, value) {
         const weakRefs = this._getWeakRefs(key);
-        // We could check for duplicate values here, but it doesn't seem worth it.
-        // We transform the output into a Set anyway
+        // Skip adding if already present
+        for (const weakRef of weakRefs) {
+            if (weakRef.deref() === value) {
+                return;
+            }
+        }
         shared.ArrayPush.call(weakRefs, new WeakRef(value));
         // It's important here not to leak the second argument, which is the "held value." The FinalizationRegistry
         // effectively creates a strong reference between the first argument (the "target") and the held value. When
@@ -3521,7 +3507,6 @@ class ModernWeakMultiMap {
         this._map.delete(key);
     }
 }
-const WeakMultiMap = supportsWeakRefs ? ModernWeakMultiMap : LegacyWeakMultiMap;
 
 /*
  * Copyright (c) 2020, salesforce.com, inc.
@@ -8843,5 +8828,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 8.28.2 */
+/** version: 8.28.3-0 */
 //# sourceMappingURL=index.cjs.js.map

package/dist/index.js

@@ -3439,34 +3439,16 @@ function isValidScopeToken(token) {
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-const supportsWeakRefs = typeof WeakRef === 'function' && typeof FinalizationRegistry === 'function';
-// In browsers that doesn't support WeakRefs, the values will still leak, but at least the keys won't
-class LegacyWeakMultiMap {
-    constructor() {
-        this._map = new WeakMap();
-    }
-    _getValues(key) {
-        let values = this._map.get(key);
-        if (isUndefined$1(values)) {
-            values = new Set();
-            this._map.set(key, values);
-        }
-        return values;
-    }
-    get(key) {
-        return this._getValues(key);
-    }
-    add(key, vm) {
-        const set = this._getValues(key);
-        set.add(vm);
-    }
-    delete(key) {
-        this._map.delete(key);
-    }
-}
-// This implementation relies on the WeakRef/FinalizationRegistry proposal.
-// For some background, see: https://github.com/tc39/proposal-weakrefs
-class ModernWeakMultiMap {
+/**
+ * A map where the keys are weakly held and the values are a Set that are also each weakly held.
+ * The goal is to avoid leaking the values, which is what would happen with a WeakMap<K, Set<V>>.
+ *
+ * Note that this is currently only intended to be used in dev/PRODDEBUG environments.
+ *
+ * This implementation relies on WeakRefs and FinalizationRegistry.
+ * For some background, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef
+ */
+class WeakMultiMap {
     constructor() {
         this._map = new WeakMap();
         this._registry = new FinalizationRegistry((weakRefs) => {
@@ -3502,8 +3484,12 @@ class ModernWeakMultiMap {
     }
     add(key, value) {
         const weakRefs = this._getWeakRefs(key);
-        // We could check for duplicate values here, but it doesn't seem worth it.
-        // We transform the output into a Set anyway
+        // Skip adding if already present
+        for (const weakRef of weakRefs) {
+            if (weakRef.deref() === value) {
+                return;
+            }
+        }
         ArrayPush$1.call(weakRefs, new WeakRef(value));
         // It's important here not to leak the second argument, which is the "held value." The FinalizationRegistry
         // effectively creates a strong reference between the first argument (the "target") and the held value. When
@@ -3518,7 +3504,6 @@ class ModernWeakMultiMap {
         this._map.delete(key);
     }
 }
-const WeakMultiMap = supportsWeakRefs ? ModernWeakMultiMap : LegacyWeakMultiMap;
 
 /*
  * Copyright (c) 2020, salesforce.com, inc.
@@ -8769,5 +8754,5 @@ function readonly(obj) {
 }
 
 export { BaseBridgeElement, LightningElement, profilerControl as __unstable__ProfilerControl, reportingControl as __unstable__ReportingControl, api$1 as api, computeShadowAndRenderMode, connectRootElement, createContextProviderWithRegister, createVM, disconnectRootElement, freezeTemplate, getAssociatedVMIfPresent, getComponentAPIVersion, getComponentConstructor, getComponentDef, getComponentHtmlPrototype, hydrateRoot, isComponentConstructor, parseFragment, parseSVGFragment, readonly, registerComponent, registerDecorators, registerTemplate, runFormAssociatedCallback, runFormDisabledCallback, runFormResetCallback, runFormStateRestoreCallback, sanitizeAttribute, shouldBeFormAssociated, swapComponent, swapStyle, swapTemplate, track, unwrap, wire };
-/** version: 8.28.2 */
+/** version: 8.28.3-0 */
 //# sourceMappingURL=index.js.map

package/package.json

@@ -4,7 +4,7 @@
         "You can safely modify dependencies, devDependencies, keywords, etc., but other props will be overwritten."
     ],
     "name": "@lwc/engine-core",
-    "version": "8.28.2",
+    "version": "8.28.3-0",
     "description": "Core LWC engine APIs.",
     "keywords": [
         "lwc"
@@ -46,9 +46,9 @@
         }
     },
     "dependencies": {
-        "@lwc/features": "8.28.2",
-        "@lwc/shared": "8.28.2",
-        "@lwc/signals": "8.28.2"
+        "@lwc/features": "8.28.3-0",
+        "@lwc/shared": "8.28.3-0",
+        "@lwc/signals": "8.28.3-0"
     },
     "devDependencies": {
         "observable-membrane": "2.0.0"