@lwc/engine-core 8.17.0 → 8.18.0

package/dist/framework/invoker.d.ts

@@ -1,4 +1,4 @@
-import type { LightningElement } from './base-lightning-element';
+import { LightningElement } from './base-lightning-element';
 import type { VM } from './vm';
 import type { LightningElementConstructor } from './base-lightning-element';
 import type { VNodes } from './vnodes';

package/dist/index.cjs.js

@@ -896,8 +896,11 @@ function logMissingPortalWarn(name, type) {
 function patchElementWithRestrictions(elm, options) {
     assertNotProd(); // this method should never leak to prod
     const originalOuterHTMLDescriptor = shared.getPropertyDescriptor(elm, 'outerHTML');
-    const descriptors = {
-        outerHTML: generateAccessorDescriptor({
+    const descriptors = {};
+    // For consistency between dev/prod modes, only patch `outerHTML` if it exists
+    // (i.e. patch it in engine-dom, not in engine-server)
+    if (originalOuterHTMLDescriptor) {
+        descriptors.outerHTML = generateAccessorDescriptor({
             get() {
                 return originalOuterHTMLDescriptor.get.call(this);
             },
@@ -905,8 +908,8 @@ function patchElementWithRestrictions(elm, options) {
                 logError(`Invalid attempt to set outerHTML on Element.`);
                 return originalOuterHTMLDescriptor.set.call(this, value);
             },
-        }),
-    };
+        });
+    }
     // Apply extra restriction related to DOM manipulation if the element is not a portal.
     if (!options.isLight && options.isSynthetic && !options.isPortal) {
         const { appendChild, insertBefore, removeChild, replaceChild } = elm;
@@ -2736,7 +2739,7 @@ function registerDecorators(Ctor, meta) {
                     validateMethodDecoratedWithWire(Ctor, fieldOrMethodName, descriptor);
                 }
                 if (shared.isUndefined(descriptor)) {
-                    throw new Error();
+                    throw new Error(`Missing descriptor for wired method "${fieldOrMethodName}".`);
                 }
                 wiredMethods[fieldOrMethodName] = descriptor;
                 storeWiredMethodMeta(descriptor, adapter, configCallback, dynamic);
@@ -6508,15 +6511,16 @@ function invokeComponentConstructor(vm, Ctor) {
     try {
         // job
         const result = new Ctor();
-        // Check indirectly if the constructor result is an instance of LightningElement. Using
-        // the "instanceof" operator would not work here since Locker Service provides its own
-        // implementation of LightningElement, so we indirectly check if the base constructor is
-        // invoked by accessing the component on the vm.
-        // TODO [W-17769475]: Restore this fix when we can reliably detect Locker enabled
-        // const isInvalidConstructor = lwcRuntimeFlags.LEGACY_LOCKER_ENABLED
-        //     ? vmBeingConstructed.component !== result
-        //     : !(result instanceof LightningElement);
-        const isInvalidConstructor = vmBeingConstructed.component !== result;
+        // Check indirectly if the constructor result is an instance of LightningElement.
+        // When Locker is enabled, the "instanceof" operator would not work since Locker Service
+        // provides its own implementation of LightningElement, so we indirectly check
+        // if the base constructor is invoked by accessing the component on the vm.
+        // When the ENABLE_LOCKER_VALIDATION gate is true and LEGACY_LOCKER_ENABLED is false,
+        // then the instanceof LightningElement can be used.
+        const useLegacyConstructorCheck = lwcRuntimeFlags.ENABLE_LEGACY_VALIDATION || lwcRuntimeFlags.LEGACY_LOCKER_ENABLED;
+        const isInvalidConstructor = useLegacyConstructorCheck
+            ? vmBeingConstructed.component !== result
+            : !(result instanceof LightningElement);
         if (isInvalidConstructor) {
             throw new TypeError('Invalid component constructor, the class should extend LightningElement.');
         }
@@ -8525,5 +8529,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 8.17.0 */
+/** version: 8.18.0 */
 //# sourceMappingURL=index.cjs.js.map

package/dist/index.js

@@ -893,8 +893,11 @@ function logMissingPortalWarn(name, type) {
 function patchElementWithRestrictions(elm, options) {
     assertNotProd(); // this method should never leak to prod
     const originalOuterHTMLDescriptor = getPropertyDescriptor(elm, 'outerHTML');
-    const descriptors = {
-        outerHTML: generateAccessorDescriptor({
+    const descriptors = {};
+    // For consistency between dev/prod modes, only patch `outerHTML` if it exists
+    // (i.e. patch it in engine-dom, not in engine-server)
+    if (originalOuterHTMLDescriptor) {
+        descriptors.outerHTML = generateAccessorDescriptor({
             get() {
                 return originalOuterHTMLDescriptor.get.call(this);
             },
@@ -902,8 +905,8 @@ function patchElementWithRestrictions(elm, options) {
                 logError(`Invalid attempt to set outerHTML on Element.`);
                 return originalOuterHTMLDescriptor.set.call(this, value);
             },
-        }),
-    };
+        });
+    }
     // Apply extra restriction related to DOM manipulation if the element is not a portal.
     if (!options.isLight && options.isSynthetic && !options.isPortal) {
         const { appendChild, insertBefore, removeChild, replaceChild } = elm;
@@ -2733,7 +2736,7 @@ function registerDecorators(Ctor, meta) {
                     validateMethodDecoratedWithWire(Ctor, fieldOrMethodName, descriptor);
                 }
                 if (isUndefined$1(descriptor)) {
-                    throw new Error();
+                    throw new Error(`Missing descriptor for wired method "${fieldOrMethodName}".`);
                 }
                 wiredMethods[fieldOrMethodName] = descriptor;
                 storeWiredMethodMeta(descriptor, adapter, configCallback, dynamic);
@@ -6505,15 +6508,16 @@ function invokeComponentConstructor(vm, Ctor) {
     try {
         // job
         const result = new Ctor();
-        // Check indirectly if the constructor result is an instance of LightningElement. Using
-        // the "instanceof" operator would not work here since Locker Service provides its own
-        // implementation of LightningElement, so we indirectly check if the base constructor is
-        // invoked by accessing the component on the vm.
-        // TODO [W-17769475]: Restore this fix when we can reliably detect Locker enabled
-        // const isInvalidConstructor = lwcRuntimeFlags.LEGACY_LOCKER_ENABLED
-        //     ? vmBeingConstructed.component !== result
-        //     : !(result instanceof LightningElement);
-        const isInvalidConstructor = vmBeingConstructed.component !== result;
+        // Check indirectly if the constructor result is an instance of LightningElement.
+        // When Locker is enabled, the "instanceof" operator would not work since Locker Service
+        // provides its own implementation of LightningElement, so we indirectly check
+        // if the base constructor is invoked by accessing the component on the vm.
+        // When the ENABLE_LOCKER_VALIDATION gate is true and LEGACY_LOCKER_ENABLED is false,
+        // then the instanceof LightningElement can be used.
+        const useLegacyConstructorCheck = lwcRuntimeFlags.ENABLE_LEGACY_VALIDATION || lwcRuntimeFlags.LEGACY_LOCKER_ENABLED;
+        const isInvalidConstructor = useLegacyConstructorCheck
+            ? vmBeingConstructed.component !== result
+            : !(result instanceof LightningElement);
         if (isInvalidConstructor) {
             throw new TypeError('Invalid component constructor, the class should extend LightningElement.');
         }
@@ -8471,5 +8475,5 @@ function readonly(obj) {
 }
 
 export { BaseBridgeElement, LightningElement, profilerControl as __unstable__ProfilerControl, reportingControl as __unstable__ReportingControl, api$1 as api, computeShadowAndRenderMode, connectRootElement, createContextProviderWithRegister, createVM, disconnectRootElement, freezeTemplate, getAssociatedVMIfPresent, getComponentAPIVersion, getComponentConstructor, getComponentDef, getComponentHtmlPrototype, hydrateRoot, isComponentConstructor, parseFragment, parseSVGFragment, readonly, registerComponent, registerDecorators, registerTemplate, runFormAssociatedCallback, runFormDisabledCallback, runFormResetCallback, runFormStateRestoreCallback, sanitizeAttribute, shouldBeFormAssociated, swapComponent, swapStyle, swapTemplate, track, unwrap, wire };
-/** version: 8.17.0 */
+/** version: 8.18.0 */
 //# sourceMappingURL=index.js.map

package/package.json

@@ -4,7 +4,7 @@
         "You can safely modify dependencies, devDependencies, keywords, etc., but other props will be overwritten."
     ],
     "name": "@lwc/engine-core",
-    "version": "8.17.0",
+    "version": "8.18.0",
     "description": "Core LWC engine APIs.",
     "keywords": [
         "lwc"
@@ -46,9 +46,9 @@
         }
     },
     "dependencies": {
-        "@lwc/features": "8.17.0",
-        "@lwc/shared": "8.17.0",
-        "@lwc/signals": "8.17.0"
+        "@lwc/features": "8.18.0",
+        "@lwc/shared": "8.18.0",
+        "@lwc/signals": "8.18.0"
     },
     "devDependencies": {
         "observable-membrane": "2.0.0"