@lwc/engine-core 8.1.0-alpha.2 → 8.1.0-alpha.4

package/dist/index.cjs.js

@@ -367,6 +367,10 @@ function associateReactiveObserverWithVM(reactiveObserver, vm) {
  */
 function trackTargetForMutationLogging(key, target) {
     assertNotProd();
+    if (targetsToPropertyKeys.has(target)) {
+        // Guard against recursive objects - don't traverse forever
+        return;
+    }
     if (shared.isObject(target) && !shared.isNull(target)) {
         // only track non-primitives; others are invalid as WeakMap keys
         targetsToPropertyKeys.set(target, key);
@@ -380,10 +384,13 @@ function trackTargetForMutationLogging(key, target) {
             // Track only own property names and symbols (including non-enumerated)
             // This is consistent with what observable-membrane does:
             // https://github.com/salesforce/observable-membrane/blob/b85417f/src/base-handler.ts#L142-L143
-            const props = [...shared.getOwnPropertyNames(target), ...shared.getOwnPropertySymbols(target)];
-            for (const prop of props) {
+            // Note this code path is very hot, hence doing two separate for-loops rather than creating a new array.
+            for (const prop of shared.getOwnPropertyNames(target)) {
                 trackTargetForMutationLogging(`${shared.toString(key)}.${shared.toString(prop)}`, target[prop]);
             }
+            for (const prop of shared.getOwnPropertySymbols(target)) {
+                trackTargetForMutationLogging(`${shared.toString(key)}[${shared.toString(prop)}]`, target[prop]);
+            }
         }
     }
 }
@@ -5933,7 +5940,7 @@ function getMutationProperties(mutationLogs) {
     const usePlural = tagNames.length > 1 || tagNamesToIdsAndProps.get(tagNames[0]).ids.size > 1;
     const result = [
         [
-            `Re-rendered Component${usePlural ? 's' : ''}`,
+            `Component${usePlural ? 's' : ''}`,
             shared.ArrayJoin.call(shared.ArrayMap.call(tagNames, (_) => tagNamesToDisplayTagNames.get(_)), ', '),
         ],
     ];
@@ -6017,8 +6024,7 @@ function logGlobalOperationEnd(opId, mutationLogs) {
         const opName = getOperationName(opId);
         const markName = opName;
         end(opName, markName, {
-            // not really an error, but we want to draw attention to re-renders since folks may want to debug it
-            color: 'error',
+            color: 'tertiary',
             tooltipText: getTooltipText(opName, opId),
             properties: getMutationProperties(mutationLogs),
         });
@@ -8390,5 +8396,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 8.1.0-alpha.2 */
+/** version: 8.1.0-alpha.4 */
 //# sourceMappingURL=index.cjs.js.map