@lwc/engine-core 7.0.3-alpha.0 → 7.0.4

package/dist/framework/utils.d.ts

@@ -6,7 +6,6 @@ export declare const EmptyObject: any;
 export declare const EmptyArray: never[];
 export declare function addCallbackToNextTick(callback: Callback): void;
 export declare function guid(): string;
-export declare function shouldUseNativeCustomElementLifecycle(ctor: LightningElementConstructor): boolean;
 export declare function parseStyleText(cssText: string): {
     [name: string]: string;
 };

package/dist/index.cjs.js

@@ -449,14 +449,6 @@ function guid() {
     }
     return s4() + s4() + '-' + s4() + '-' + s4() + '-' + s4() + '-' + s4() + s4() + s4();
 }
-function shouldUseNativeCustomElementLifecycle(ctor) {
-    if (lwcRuntimeFlags.DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE) {
-        // temporary "kill switch"
-        return false;
-    }
-    const apiVersion = getComponentAPIVersion(ctor);
-    return shared.isAPIFeatureEnabled(7 /* APIFeature.ENABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE */, apiVersion);
-}
 // Borrowed from Vue template compiler.
 // https://github.com/vuejs/vue/blob/531371b818b0e31a989a06df43789728f23dc4e8/src/platforms/web/util/style.js#L5-L16
 const DECLARATION_DELIMITER = /;(?![^(]*\))/g;
@@ -507,7 +499,7 @@ function assertNotProd() {
 function shouldBeFormAssociated(Ctor) {
     const ctorFormAssociated = Boolean(Ctor.formAssociated);
     const apiVersion = getComponentAPIVersion(Ctor);
-    const apiFeatureEnabled = shared.isAPIFeatureEnabled(8 /* APIFeature.ENABLE_ELEMENT_INTERNALS_AND_FACE */, apiVersion);
+    const apiFeatureEnabled = shared.isAPIFeatureEnabled(7 /* APIFeature.ENABLE_ELEMENT_INTERNALS_AND_FACE */, apiVersion);
     if (process.env.NODE_ENV !== 'production' && ctorFormAssociated && !apiFeatureEnabled) {
         const tagName = getComponentRegisteredName(Ctor);
         logWarnOnce(`Component <${tagName}> set static formAssociated to true, but form ` +
@@ -1750,7 +1742,7 @@ LightningElement.prototype = {
     attachInternals() {
         const vm = getAssociatedVM(this);
         const { elm, apiVersion, renderer: { attachInternals }, } = vm;
-        if (!shared.isAPIFeatureEnabled(8 /* APIFeature.ENABLE_ELEMENT_INTERNALS_AND_FACE */, apiVersion)) {
+        if (!shared.isAPIFeatureEnabled(7 /* APIFeature.ENABLE_ELEMENT_INTERNALS_AND_FACE */, apiVersion)) {
             throw new Error(`The attachInternals API is only supported in API version 61 and above. ` +
                 `The current version is ${apiVersion}. ` +
                 `To use this API, update the LWC component API version. https://lwc.dev/guide/versioning`);
@@ -1790,7 +1782,7 @@ LightningElement.prototype = {
             shared.assert.fail('this.hostElement is not supported in this environment');
         }
         const apiVersion = getComponentAPIVersion(vm.def.ctor);
-        if (!shared.isAPIFeatureEnabled(9 /* APIFeature.ENABLE_THIS_DOT_HOST_ELEMENT */, apiVersion)) {
+        if (!shared.isAPIFeatureEnabled(8 /* APIFeature.ENABLE_THIS_DOT_HOST_ELEMENT */, apiVersion)) {
             if (process.env.NODE_ENV !== 'production') {
                 logWarnOnce('The `this.hostElement` API within LightningElement is ' +
                     'only supported in API version 62 and above. Increase the API version to use it.');
@@ -1932,7 +1924,7 @@ LightningElement.prototype = {
     get style() {
         const { elm, renderer, def } = getAssociatedVM(this);
         const apiVersion = getComponentAPIVersion(def.ctor);
-        if (!shared.isAPIFeatureEnabled(10 /* APIFeature.ENABLE_THIS_DOT_STYLE */, apiVersion)) {
+        if (!shared.isAPIFeatureEnabled(9 /* APIFeature.ENABLE_THIS_DOT_STYLE */, apiVersion)) {
             if (process.env.NODE_ENV !== 'production') {
                 logWarnOnce('The `this.style` API within LightningElement returning the CSSStyleDeclaration is ' +
                     'only supported in API version 62 and above. Increase the API version to use it.');
@@ -4504,7 +4496,7 @@ function mountCustomElement(vnode, parent, anchor, renderer) {
     // compiler may generate tagnames with uppercase letters so - for backwards
     // compatibility, we lower case the tagname here.
     const normalizedTagname = sel.toLowerCase();
-    const useNativeLifecycle = shouldUseNativeCustomElementLifecycle(ctor);
+    const useNativeLifecycle = !lwcRuntimeFlags.DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE;
     const isFormAssociated = shouldBeFormAssociated(ctor);
     const elm = createCustomElement(normalizedTagname, upgradeCallback, useNativeLifecycle, isFormAssociated);
     vnode.elm = elm;
@@ -5651,8 +5643,11 @@ function ncls(value) {
             }
         }
     }
-    else if (shared.isObject(value)) {
-        for (const key in value) {
+    else if (shared.isObject(value) && !shared.isNull(value)) {
+        // Iterate own enumerable keys of the object
+        const keys = shared.keys(value);
+        for (let i = 0; i < keys.length; i += 1) {
+            const key = keys[i];
             if (value[key]) {
                 res += key + ' ';
             }
@@ -5875,6 +5870,7 @@ function buildSerializeExpressionFn(parts) {
         // 4. For non-attributes everything from index 1 to the string length is the partId.
         // Ex, attribute: a0:data-name, a = an attribute, 0 = partId, data-name = attribute name.
         // Ex, style: s0, s = a style attribute, 0 = partId.
+        // Note some attributes contain a `:`, e.g. `xlink:href` may be encoded as `a0:xlink:href`.
         const type = shared.StringCharAt.call(partToken, 0);
         let delimiterIndex = partToken.length;
         let attrName = '';
@@ -6381,7 +6377,7 @@ function resetComponentStateWhenRemoved(vm) {
 // old vnode.children is removed from the DOM.
 function removeVM(vm) {
     if (process.env.NODE_ENV !== 'production') {
-        if (!shouldUseNativeCustomElementLifecycle(vm.component.constructor)) {
+        if (lwcRuntimeFlags.DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE) {
             // With native lifecycle, we cannot be certain that connectedCallback was called before a component
             // was removed from the VDOM. If the component is disconnected, then connectedCallback will not fire
             // in native mode, although it will fire in synthetic mode due to appendChild triggering it.
@@ -6705,7 +6701,7 @@ function runConnectedCallback(vm) {
     // This test only makes sense in the browser, with synthetic lifecycle, and when reporting is enabled or
     // we're in dev mode. This is to detect a particular issue with synthetic lifecycle.
     if (process.env.IS_BROWSER &&
-        !shouldUseNativeCustomElementLifecycle(vm.component.constructor) &&
+        lwcRuntimeFlags.DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE &&
         (process.env.NODE_ENV !== 'production' || isReportingEnabled())) {
         if (!vm.renderer.isConnected(vm.elm)) {
             if (process.env.NODE_ENV !== 'production') {
@@ -8076,5 +8072,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 7.0.0 */
+/** version: 7.0.4 */
 //# sourceMappingURL=index.cjs.js.map