@lwc/engine-core 6.6.0 → 6.6.1

package/dist/framework/renderer.d.ts

@@ -15,6 +15,7 @@ export interface RendererAPI {
     createComment: (content: string) => N;
     nextSibling: (node: N) => N | null;
     previousSibling: (node: N) => N | null;
+    getParentNode: (node: N) => N | null;
     attachShadow: (element: E, options: ShadowRootInit) => N;
     getProperty: (node: N, key: string) => any;
     setProperty: (node: N, key: string, value: any) => void;

package/dist/index.cjs.js

@@ -4075,7 +4075,7 @@ function updateTextContent$1(vnode, renderer) {
 }
 
 /*
- * Copyright (c) 2023, salesforce.com, inc.
+ * Copyright (c) 2024, Salesforce, Inc.
  * All rights reserved.
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
@@ -4101,31 +4101,56 @@ function traverseAndSetElements(root, parts, renderer) {
     for (const staticPart of parts) {
         partIdsToParts.set(staticPart.partId, staticPart);
     }
+    // Note that we traverse using `*Child`/`*Sibling` rather than `children` because the browser uses a linked
+    // list under the hood to represent the DOM tree, so it's faster to do this than to create an underlying array
+    // by calling `children`.
+    const { nextSibling, getFirstChild, getParentNode } = renderer;
     let numFoundParts = 0;
-    const { previousSibling, getLastChild } = renderer;
-    const stack = [root];
     let partId = -1;
+    // We should never traverse up to the root. We should exit early due to numFoundParts === numParts.
+    // This is just a sanity check, in case the static parts generated by @lwc/template-compiler are wrong.
+    function assertNotRoot(node) {
+        if (process.env.NODE_ENV !== 'production') {
+            shared.assert.isFalse(node === root, `Reached the root without finding all parts. Found ${numFoundParts}, needed ${numParts}.`);
+        }
+    }
     // Depth-first traversal. We assign a partId to each element, which is an integer based on traversal order.
-    while (stack.length > 0) {
-        const elm = shared.ArrayShift.call(stack);
+    // This function is very hot, which is why it's micro-optimized. Note we don't use a stack at all; we traverse
+    // using an algorithm that relies on the parentNode getter: https://stackoverflow.com/a/5285417
+    // This is very slightly faster than a TreeWalker (~0.5% on js-framework-benchmark create-10k), but basically
+    // the same idea.
+    let node = root;
+    while (!shared.isNull(node)) {
+        // visit node
         partId++;
         const part = partIdsToParts.get(partId);
         if (!shared.isUndefined(part)) {
-            part.elm = elm;
-            if (++numFoundParts === numParts) {
+            part.elm = node;
+            numFoundParts++;
+            if (numFoundParts === numParts) {
                 return; // perf optimization - stop traversing once we've found everything we need
             }
         }
-        // For depth-first traversal, prepend to the stack in reverse order
-        // Note that we traverse using `*Child`/`*Sibling` rather than `children` because the browser uses a linked
-        // list under the hood to represent the DOM tree, so it's faster to do this than to create an underlying array
-        // by calling `children`.
-        let child = getLastChild(elm);
-        while (!shared.isNull(child)) {
-            shared.ArrayUnshift.call(stack, child);
-            child = previousSibling(child);
+        const child = getFirstChild(node);
+        if (!shared.isNull(child)) {
+            // walk down
+            node = child;
+        }
+        else {
+            let sibling;
+            while (shared.isNull((sibling = nextSibling(node)))) {
+                // we never want to walk up from the root
+                assertNotRoot(node);
+                // walk up
+                node = getParentNode(node);
+            }
+            // we never want to walk right from the root
+            assertNotRoot(node);
+            // walk right
+            node = sibling;
         }
     }
+    /* istanbul ignore next */
     if (process.env.NODE_ENV !== 'production') {
         shared.assert.isTrue(numFoundParts === numParts, `Should have found all parts by now. Found ${numFoundParts}, needed ${numParts}.`);
     }
@@ -7940,5 +7965,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 6.6.0 */
+/** version: 6.6.1 */
 //# sourceMappingURL=index.cjs.js.map